[{"id":29021,"web_url":"https://patchwork.libcamera.org/comment/29021/","msgid":"","date":"2024-03-21T09:31:56","subject":"Re: [PATCH v3 01/16] libcamera: lc-compliance: Add controls param to\n\tstart() function","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan,\n\nOn Tue, Mar 19, 2024 at 01:05:02PM +0100, Stefan Klug wrote:\n> This is needed for tests that need to pass controls to\n> Camera::start().\n>\n> Signed-off-by: Stefan Klug \n\nYou forgot to collect tags maybe\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/apps/lc-compliance/simple_capture.cpp | 4 ++--\n> src/apps/lc-compliance/simple_capture.h | 2 +-\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\n> index cf4d7cf3..56680a83 100644\n> --- a/src/apps/lc-compliance/simple_capture.cpp\n> +++ b/src/apps/lc-compliance/simple_capture.cpp\n> @@ -42,7 +42,7 @@ void SimpleCapture::configure(StreamRole role)\n> \t}\n> }\n>\n> -void SimpleCapture::start()\n> +void SimpleCapture::start(const ControlList *controls)\n> {\n> \tStream *stream = config_->at(0).stream();\n> \tint count = allocator_->allocate(stream);\n> @@ -52,7 +52,7 @@ void SimpleCapture::start()\n>\n> \tcamera_->requestCompleted.connect(this, &SimpleCapture::requestComplete);\n>\n> -\tASSERT_EQ(camera_->start(), 0) << \"Failed to start camera\";\n> +\tASSERT_EQ(camera_->start(controls), 0) << \"Failed to start camera\";\n> }\n>\n> void SimpleCapture::stop()\n> diff --git a/src/apps/lc-compliance/simple_capture.h b/src/apps/lc-compliance/simple_capture.h\n> index 2911d601..54b1d54b 100644\n> --- a/src/apps/lc-compliance/simple_capture.h\n> +++ b/src/apps/lc-compliance/simple_capture.h\n> @@ -22,7 +22,7 @@ protected:\n> \tSimpleCapture(std::shared_ptr camera);\n> \tvirtual ~SimpleCapture();\n>\n> -\tvoid start();\n> +\tvoid start(const libcamera::ControlList *controls = nullptr);\n> \tvoid stop();\n>\n> \tvirtual void requestComplete(libcamera::Request *request) = 0;\n> --\n> 2.40.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA27FC3272\n\tfor ;\n\tThu, 21 Mar 2024 09:32:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C924A6305E;\n\tThu, 21 Mar 2024 10:32:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3816163036\n\tfor ;\n\tThu, 21 Mar 2024 10:31:59 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0627A7E9;\n\tThu, 21 Mar 2024 10:31:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fQnZcTVP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711013491;\n\tbh=v08IQV1Mg2A9MZmG10uT/LbTZpbZWUkURRREinW7MsE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fQnZcTVPd2ECxzIdhXTKvsDtSb29J9jxPzHb0fp4Y6Zidx5DofXiUMdoj+qjOk8kb\n\t0341WQObHy21serT8ahrWZRR1Jkz47O4S6PBA86D9apsebrON+/p2+LVDYGScwnKuP\n\t6vCO6aDlSuhrMf9zBQ8M6QVIPD/oh2P1/RNH0kkE=","Date":"Thu, 21 Mar 2024 10:31:56 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 01/16] libcamera: lc-compliance: Add controls param to\n\tstart() function","Message-ID":"","References":"<20240319120517.362082-1-stefan.klug@ideasonboard.com>\n\t<20240319120517.362082-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240319120517.362082-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29022,"web_url":"https://patchwork.libcamera.org/comment/29022/","msgid":"<20240321094110.muqjkfllqle6z2cp@jasper>","date":"2024-03-21T09:41:10","subject":"Re: [PATCH v3 01/16] libcamera: lc-compliance: Add controls param to\n\tstart() function","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Thu, Mar 21, 2024 at 10:31:56AM +0100, Jacopo Mondi wrote:\n> Hi Stefan,\n> \n> On Tue, Mar 19, 2024 at 01:05:02PM +0100, Stefan Klug wrote:\n> > This is needed for tests that need to pass controls to\n> > Camera::start().\n> >\n> > Signed-off-by: Stefan Klug \n> \n> You forgot to collect tags maybe\n> Reviewed-by: Jacopo Mondi \n\nSorry for that. Kieran already noticed. It's fixed in v4\n\nStefan\n\n> \n> > ---\n> > src/apps/lc-compliance/simple_capture.cpp | 4 ++--\n> > src/apps/lc-compliance/simple_capture.h | 2 +-\n> > 2 files changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\n> > index cf4d7cf3..56680a83 100644\n> > --- a/src/apps/lc-compliance/simple_capture.cpp\n> > +++ b/src/apps/lc-compliance/simple_capture.cpp\n> > @@ -42,7 +42,7 @@ void SimpleCapture::configure(StreamRole role)\n> > \t}\n> > }\n> >\n> > -void SimpleCapture::start()\n> > +void SimpleCapture::start(const ControlList *controls)\n> > {\n> > \tStream *stream = config_->at(0).stream();\n> > \tint count = allocator_->allocate(stream);\n> > @@ -52,7 +52,7 @@ void SimpleCapture::start()\n> >\n> > \tcamera_->requestCompleted.connect(this, &SimpleCapture::requestComplete);\n> >\n> > -\tASSERT_EQ(camera_->start(), 0) << \"Failed to start camera\";\n> > +\tASSERT_EQ(camera_->start(controls), 0) << \"Failed to start camera\";\n> > }\n> >\n> > void SimpleCapture::stop()\n> > diff --git a/src/apps/lc-compliance/simple_capture.h b/src/apps/lc-compliance/simple_capture.h\n> > index 2911d601..54b1d54b 100644\n> > --- a/src/apps/lc-compliance/simple_capture.h\n> > +++ b/src/apps/lc-compliance/simple_capture.h\n> > @@ -22,7 +22,7 @@ protected:\n> > \tSimpleCapture(std::shared_ptr camera);\n> > \tvirtual ~SimpleCapture();\n> >\n> > -\tvoid start();\n> > +\tvoid start(const libcamera::ControlList *controls = nullptr);\n> > \tvoid stop();\n> >\n> > \tvirtual void requestComplete(libcamera::Request *request) = 0;\n> > --\n> > 2.40.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DA6CBD160\n\tfor ;\n\tThu, 21 Mar 2024 09:41:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42F2963055;\n\tThu, 21 Mar 2024 10:41:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A33A61C59\n\tfor ;\n\tThu, 21 Mar 2024 10:41:14 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1bc6:8c62:a44e:3d82])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A22C7E9;\n\tThu, 21 Mar 2024 10:40:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XaDAZqR7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711014046;\n\tbh=ulm9zTM6R3mN+tfH4dPYPoYquFvdaEqAQ8nWNiu4tS4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XaDAZqR7DPsfDlQijPfD1c0hLhNMHY7jbkDMpUzd2VlXeIzfWViV/z3hePaX+XITN\n\tw/Z5nm8NlWCKL9AVY7e0dO8dXhb+F/WCCu264+FI3Eyva78S4f3on8De4O9yz33rx8\n\tLtvPun4ZENjdtf1h/3VJwhbA/vWf6ncMu39CCffU=","Date":"Thu, 21 Mar 2024 10:41:10 +0100","From":"Stefan Klug ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 01/16] libcamera: lc-compliance: Add controls param to\n\tstart() function","Message-ID":"<20240321094110.muqjkfllqle6z2cp@jasper>","References":"<20240319120517.362082-1-stefan.klug@ideasonboard.com>\n\t<20240319120517.362082-2-stefan.klug@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]