[{"id":28968,"web_url":"https://patchwork.libcamera.org/comment/28968/","msgid":"<171046260841.1913896.4267282233807769995@ping.linuxembedded.co.uk>","date":"2024-03-15T00:30:08","subject":"Re: [PATCH v2 02/14] libcamera: v4l2_subdevice: Add code member to\n\tMediaBusFormatInfo","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-03-15 00:16:01)\n> To prepare for exposing the MediaBusFormatInfo structure as an internal\n> API, add a code member to the structure to store the media bus code.\n> This makes MediaBusFormatInfo usable standalone, without having to\n> externally associate the code related to the info.\n> \n> The entries in the mediaBusFormatInfo map are becoming too long, so\n> split them on multiple lines.\n> \n> While at it, swap the order of the members to match the PixelFormatInfo\n> class for consistency.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThat's a big change. But probably worthwhile.\nI've tried to scan through and everything I've checked is consistent so:\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n> Changes since combined RFC:\n> \n> - Rebase on addition oa 14-bit bayer formats\n> ---\n>  src/libcamera/v4l2_subdevice.cpp | 582 ++++++++++++++++++++++++++-----\n>  1 file changed, 497 insertions(+), 85 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index b6a25e25230b..1286e7c385c4 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -41,13 +41,15 @@ namespace {\n>  /*\n>   * \\struct MediaBusFormatInfo\n>   * \\brief Information about media bus formats\n> - * \\param bitsPerPixel Bits per pixel\n>   * \\param name Name of MBUS format\n> + * \\param code The media bus format code\n> + * \\param bitsPerPixel Bits per pixel\n>   * \\param colourEncoding Type of colour encoding\n>   */\n>  struct MediaBusFormatInfo {\n> -       unsigned int bitsPerPixel;\n>         const char *name;\n> +       uint32_t code;\n> +       unsigned int bitsPerPixel;\n>         PixelFormatInfo::ColourEncoding colourEncoding;\n>  };\n>  \n> @@ -56,91 +58,501 @@ struct MediaBusFormatInfo {\n>   * \\brief A map that associates MediaBusFormatInfo struct to V4L2 media\n>   * bus codes\n>   */\n> -const std::map<uint32_t, MediaBusFormatInfo> mediaBusFormatInfo = {\n> +const std::map<uint32_t, MediaBusFormatInfo> mediaBusFormatInfo{\n>         /* This table is sorted to match the order in linux/media-bus-format.h */\n> -       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE, { 16, \"RGB555_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE, { 16, \"RGB555_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB565_1X16, { 16, \"RGB565_1X16\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_BGR565_2X8_BE, { 16, \"BGR565_2X8_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_BGR565_2X8_LE, { 16, \"BGR565_2X8_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB565_2X8_BE, { 16, \"RGB565_2X8_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_BGR888_1X24, { 24, \"BGR888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_Y8_1X8, { 8, \"Y8_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UV8_1X8, { 8, \"UV8_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UYVY8_1_5X8, { 12, \"UYVY8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_VYUY8_1_5X8, { 12, \"VYUY8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUYV8_1_5X8, { 12, \"YUYV8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YVYU8_1_5X8, { 12, \"YVYU8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UYVY8_2X8, { 16, \"UYVY8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_VYUY8_2X8, { 16, \"VYUY8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUYV8_2X8, { 16, \"YUYV8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YVYU8_2X8, { 16, \"YVYU8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_Y10_1X10, { 10, \"Y10_1X10\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UYVY10_2X10, { 20, \"UYVY10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_VYUY10_2X10, { 20, \"VYUY10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_Y12_1X12, { 12, \"Y12_1X12\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_Y16_1X16, { 16, \"Y16_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YVYU8_1X16, { 16, \"YVYU8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YDYUYDYV8_1X16, { 16, \"YDYUYDYV8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UYVY10_1X20, { 20, \"UYVY10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_VYUY10_1X20, { 20, \"VYUY10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUYV10_1X20, { 20, \"YUYV10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YVYU10_1X20, { 20, \"YVYU10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUV8_1X24, { 24, \"YUV8_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUV10_1X30, { 30, \"YUV10_1X30\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_AYUV8_1X32, { 32, \"AYUV8_1X32\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UYVY12_2X12, { 24, \"UYVY12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_VYUY12_2X12, { 24, \"VYUY12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUYV12_2X12, { 24, \"YUYV12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YVYU12_2X12, { 24, \"YVYU12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_UYVY12_1X24, { 24, \"UYVY12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_VYUY12_1X24, { 24, \"VYUY12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YUYV12_1X24, { 24, \"YUYV12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_YVYU12_1X24, { 24, \"YVYU12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> -       { MEDIA_BUS_FMT_SBGGR8_1X8, { 8, \"SBGGR8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGBRG8_1X8, { 8, \"SGBRG8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGRBG8_1X8, { 8, \"SGRBG8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SRGGB8_1X8, { 8, \"SRGGB8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8, { 8, \"SBGGR10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8, { 8, \"SGBRG10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8, { 8, \"SGRBG10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8, { 8, \"SRGGB10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8, { 8, \"SBGGR10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8, { 8, \"SGBRG10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8, { 8, \"SGRBG10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8, { 8, \"SRGGB10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE, { 16, \"SBGGR10_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE, { 16, \"SBGGR10_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE, { 16, \"SBGGR10_2X8_PADLO_BE\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE, { 16, \"SBGGR10_2X8_PADLO_LE\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR10_1X10, { 10, \"SBGGR10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGBRG10_1X10, { 10, \"SGBRG10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGRBG10_1X10, { 10, \"SGRBG10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SRGGB10_1X10, { 10, \"SRGGB10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR12_1X12, { 12, \"SBGGR12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SBGGR14_1X14, { 14, \"SBGGR14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGBRG14_1X14, { 14, \"SGBRG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SGRBG14_1X14, { 14, \"SGRBG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> -       { MEDIA_BUS_FMT_SRGGB14_1X14, { 14, \"SRGGB14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> +       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE, {\n> +               .name = \"RGB444_2X8_PADHI_BE\",\n> +               .code = MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE, {\n> +               .name = \"RGB444_2X8_PADHI_LE\",\n> +               .code = MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE, {\n> +               .name = \"RGB555_2X8_PADHI_BE\",\n> +               .code = MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE, {\n> +               .name = \"RGB555_2X8_PADHI_LE\",\n> +               .code = MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB565_1X16, {\n> +               .name = \"RGB565_1X16\",\n> +               .code = MEDIA_BUS_FMT_RGB565_1X16,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_BGR565_2X8_BE, {\n> +               .name = \"BGR565_2X8_BE\",\n> +               .code = MEDIA_BUS_FMT_BGR565_2X8_BE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_BGR565_2X8_LE, {\n> +               .name = \"BGR565_2X8_LE\",\n> +               .code = MEDIA_BUS_FMT_BGR565_2X8_LE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB565_2X8_BE, {\n> +               .name = \"RGB565_2X8_BE\",\n> +               .code = MEDIA_BUS_FMT_RGB565_2X8_BE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB565_2X8_LE, {\n> +               .name = \"RGB565_2X8_LE\",\n> +               .code = MEDIA_BUS_FMT_RGB565_2X8_LE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB666_1X18, {\n> +               .name = \"RGB666_1X18\",\n> +               .code = MEDIA_BUS_FMT_RGB666_1X18,\n> +               .bitsPerPixel = 18,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_BGR888_1X24, {\n> +               .name = \"BGR888_1X24\",\n> +               .code = MEDIA_BUS_FMT_BGR888_1X24,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB888_1X24, {\n> +               .name = \"RGB888_1X24\",\n> +               .code = MEDIA_BUS_FMT_RGB888_1X24,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB888_2X12_BE, {\n> +               .name = \"RGB888_2X12_BE\",\n> +               .code = MEDIA_BUS_FMT_RGB888_2X12_BE,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_RGB888_2X12_LE, {\n> +               .name = \"RGB888_2X12_LE\",\n> +               .code = MEDIA_BUS_FMT_RGB888_2X12_LE,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_ARGB8888_1X32, {\n> +               .name = \"ARGB8888_1X32\",\n> +               .code = MEDIA_BUS_FMT_ARGB8888_1X32,\n> +               .bitsPerPixel = 32,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_Y8_1X8, {\n> +               .name = \"Y8_1X8\",\n> +               .code = MEDIA_BUS_FMT_Y8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UV8_1X8, {\n> +               .name = \"UV8_1X8\",\n> +               .code = MEDIA_BUS_FMT_UV8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UYVY8_1_5X8, {\n> +               .name = \"UYVY8_1_5X8\",\n> +               .code = MEDIA_BUS_FMT_UYVY8_1_5X8,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_VYUY8_1_5X8, {\n> +               .name = \"VYUY8_1_5X8\",\n> +               .code = MEDIA_BUS_FMT_VYUY8_1_5X8,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUYV8_1_5X8, {\n> +               .name = \"YUYV8_1_5X8\",\n> +               .code = MEDIA_BUS_FMT_YUYV8_1_5X8,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YVYU8_1_5X8, {\n> +               .name = \"YVYU8_1_5X8\",\n> +               .code = MEDIA_BUS_FMT_YVYU8_1_5X8,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UYVY8_2X8, {\n> +               .name = \"UYVY8_2X8\",\n> +               .code = MEDIA_BUS_FMT_UYVY8_2X8,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_VYUY8_2X8, {\n> +               .name = \"VYUY8_2X8\",\n> +               .code = MEDIA_BUS_FMT_VYUY8_2X8,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUYV8_2X8, {\n> +               .name = \"YUYV8_2X8\",\n> +               .code = MEDIA_BUS_FMT_YUYV8_2X8,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YVYU8_2X8, {\n> +               .name = \"YVYU8_2X8\",\n> +               .code = MEDIA_BUS_FMT_YVYU8_2X8,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_Y10_1X10, {\n> +               .name = \"Y10_1X10\",\n> +               .code = MEDIA_BUS_FMT_Y10_1X10,\n> +               .bitsPerPixel = 10,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UYVY10_2X10, {\n> +               .name = \"UYVY10_2X10\",\n> +               .code = MEDIA_BUS_FMT_UYVY10_2X10,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_VYUY10_2X10, {\n> +               .name = \"VYUY10_2X10\",\n> +               .code = MEDIA_BUS_FMT_VYUY10_2X10,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUYV10_2X10, {\n> +               .name = \"YUYV10_2X10\",\n> +               .code = MEDIA_BUS_FMT_YUYV10_2X10,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YVYU10_2X10, {\n> +               .name = \"YVYU10_2X10\",\n> +               .code = MEDIA_BUS_FMT_YVYU10_2X10,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_Y12_1X12, {\n> +               .name = \"Y12_1X12\",\n> +               .code = MEDIA_BUS_FMT_Y12_1X12,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_Y16_1X16, {\n> +               .name = \"Y16_1X16\",\n> +               .code = MEDIA_BUS_FMT_Y16_1X16,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UYVY8_1X16, {\n> +               .name = \"UYVY8_1X16\",\n> +               .code = MEDIA_BUS_FMT_UYVY8_1X16,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_VYUY8_1X16, {\n> +               .name = \"VYUY8_1X16\",\n> +               .code = MEDIA_BUS_FMT_VYUY8_1X16,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUYV8_1X16, {\n> +               .name = \"YUYV8_1X16\",\n> +               .code = MEDIA_BUS_FMT_YUYV8_1X16,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YVYU8_1X16, {\n> +               .name = \"YVYU8_1X16\",\n> +               .code = MEDIA_BUS_FMT_YVYU8_1X16,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YDYUYDYV8_1X16, {\n> +               .name = \"YDYUYDYV8_1X16\",\n> +               .code = MEDIA_BUS_FMT_YDYUYDYV8_1X16,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UYVY10_1X20, {\n> +               .name = \"UYVY10_1X20\",\n> +               .code = MEDIA_BUS_FMT_UYVY10_1X20,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_VYUY10_1X20, {\n> +               .name = \"VYUY10_1X20\",\n> +               .code = MEDIA_BUS_FMT_VYUY10_1X20,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUYV10_1X20, {\n> +               .name = \"YUYV10_1X20\",\n> +               .code = MEDIA_BUS_FMT_YUYV10_1X20,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YVYU10_1X20, {\n> +               .name = \"YVYU10_1X20\",\n> +               .code = MEDIA_BUS_FMT_YVYU10_1X20,\n> +               .bitsPerPixel = 20,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUV8_1X24, {\n> +               .name = \"YUV8_1X24\",\n> +               .code = MEDIA_BUS_FMT_YUV8_1X24,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUV10_1X30, {\n> +               .name = \"YUV10_1X30\",\n> +               .code = MEDIA_BUS_FMT_YUV10_1X30,\n> +               .bitsPerPixel = 30,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_AYUV8_1X32, {\n> +               .name = \"AYUV8_1X32\",\n> +               .code = MEDIA_BUS_FMT_AYUV8_1X32,\n> +               .bitsPerPixel = 32,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UYVY12_2X12, {\n> +               .name = \"UYVY12_2X12\",\n> +               .code = MEDIA_BUS_FMT_UYVY12_2X12,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_VYUY12_2X12, {\n> +               .name = \"VYUY12_2X12\",\n> +               .code = MEDIA_BUS_FMT_VYUY12_2X12,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUYV12_2X12, {\n> +               .name = \"YUYV12_2X12\",\n> +               .code = MEDIA_BUS_FMT_YUYV12_2X12,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YVYU12_2X12, {\n> +               .name = \"YVYU12_2X12\",\n> +               .code = MEDIA_BUS_FMT_YVYU12_2X12,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_UYVY12_1X24, {\n> +               .name = \"UYVY12_1X24\",\n> +               .code = MEDIA_BUS_FMT_UYVY12_1X24,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_VYUY12_1X24, {\n> +               .name = \"VYUY12_1X24\",\n> +               .code = MEDIA_BUS_FMT_VYUY12_1X24,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YUYV12_1X24, {\n> +               .name = \"YUYV12_1X24\",\n> +               .code = MEDIA_BUS_FMT_YUYV12_1X24,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_YVYU12_1X24, {\n> +               .name = \"YVYU12_1X24\",\n> +               .code = MEDIA_BUS_FMT_YVYU12_1X24,\n> +               .bitsPerPixel = 24,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR8_1X8, {\n> +               .name = \"SBGGR8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SBGGR8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGBRG8_1X8, {\n> +               .name = \"SGBRG8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SGBRG8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGRBG8_1X8, {\n> +               .name = \"SGRBG8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SGRBG8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SRGGB8_1X8, {\n> +               .name = \"SRGGB8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SRGGB8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8, {\n> +               .name = \"SBGGR10_ALAW8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8, {\n> +               .name = \"SGBRG10_ALAW8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8, {\n> +               .name = \"SGRBG10_ALAW8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8, {\n> +               .name = \"SRGGB10_ALAW8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8, {\n> +               .name = \"SBGGR10_DPCM8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8, {\n> +               .name = \"SGBRG10_DPCM8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8, {\n> +               .name = \"SGRBG10_DPCM8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8, {\n> +               .name = \"SRGGB10_DPCM8_1X8\",\n> +               .code = MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE, {\n> +               .name = \"SBGGR10_2X8_PADHI_BE\",\n> +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE, {\n> +               .name = \"SBGGR10_2X8_PADHI_LE\",\n> +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE, {\n> +               .name = \"SBGGR10_2X8_PADLO_BE\",\n> +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE, {\n> +               .name = \"SBGGR10_2X8_PADLO_LE\",\n> +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE,\n> +               .bitsPerPixel = 16,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR10_1X10, {\n> +               .name = \"SBGGR10_1X10\",\n> +               .code = MEDIA_BUS_FMT_SBGGR10_1X10,\n> +               .bitsPerPixel = 10,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGBRG10_1X10, {\n> +               .name = \"SGBRG10_1X10\",\n> +               .code = MEDIA_BUS_FMT_SGBRG10_1X10,\n> +               .bitsPerPixel = 10,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGRBG10_1X10, {\n> +               .name = \"SGRBG10_1X10\",\n> +               .code = MEDIA_BUS_FMT_SGRBG10_1X10,\n> +               .bitsPerPixel = 10,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SRGGB10_1X10, {\n> +               .name = \"SRGGB10_1X10\",\n> +               .code = MEDIA_BUS_FMT_SRGGB10_1X10,\n> +               .bitsPerPixel = 10,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR12_1X12, {\n> +               .name = \"SBGGR12_1X12\",\n> +               .code = MEDIA_BUS_FMT_SBGGR12_1X12,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGBRG12_1X12, {\n> +               .name = \"SGBRG12_1X12\",\n> +               .code = MEDIA_BUS_FMT_SGBRG12_1X12,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGRBG12_1X12, {\n> +               .name = \"SGRBG12_1X12\",\n> +               .code = MEDIA_BUS_FMT_SGRBG12_1X12,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SRGGB12_1X12, {\n> +               .name = \"SRGGB12_1X12\",\n> +               .code = MEDIA_BUS_FMT_SRGGB12_1X12,\n> +               .bitsPerPixel = 12,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SBGGR14_1X14, {\n> +               .name = \"SBGGR14_1X14\",\n> +               .code = MEDIA_BUS_FMT_SBGGR14_1X14,\n> +               .bitsPerPixel = 14,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGBRG14_1X14, {\n> +               .name = \"SGBRG14_1X14\",\n> +               .code = MEDIA_BUS_FMT_SGBRG14_1X14,\n> +               .bitsPerPixel = 14,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SGRBG14_1X14, {\n> +               .name = \"SGRBG14_1X14\",\n> +               .code = MEDIA_BUS_FMT_SGRBG14_1X14,\n> +               .bitsPerPixel = 14,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n> +       { MEDIA_BUS_FMT_SRGGB14_1X14, {\n> +               .name = \"SRGGB14_1X14\",\n> +               .code = MEDIA_BUS_FMT_SRGGB14_1X14,\n> +               .bitsPerPixel = 14,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +       } },\n>         /* \\todo Clarify colour encoding for HSV formats */\n> -       { MEDIA_BUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> -       { MEDIA_BUS_FMT_JPEG_1X8, { 8, \"JPEG_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> +       { MEDIA_BUS_FMT_AHSV8888_1X32, {\n> +               .name = \"AHSV8888_1X32\",\n> +               .code = MEDIA_BUS_FMT_AHSV8888_1X32,\n> +               .bitsPerPixel = 32,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +       } },\n> +       { MEDIA_BUS_FMT_JPEG_1X8, {\n> +               .name = \"JPEG_1X8\",\n> +               .code = MEDIA_BUS_FMT_JPEG_1X8,\n> +               .bitsPerPixel = 8,\n> +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +       } },\n>  };\n>  \n>  } /* namespace */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7769BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Mar 2024 00:30:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0109A62C93;\n\tFri, 15 Mar 2024 01:30:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6D9162C8F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Mar 2024 01:30:11 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B89B4667;\n\tFri, 15 Mar 2024 01:29:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r8vJ5BJ3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710462587;\n\tbh=fdZTYWfX11rSrjX0Bghx4s7hQAzfRMVDvr31Z4+TWQg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=r8vJ5BJ30N6XpVxB1T/NGcDGY00wCQvmgsBMpKYfWXE433Vnd5BgXfozDCQPbDUT4\n\t53BWYf24M7RzdgM8a3D50iTv5FruYN9sSrzh2UvG9dTFvmDP7zsGdiCqAGb5OYMLC6\n\twpOt+7SLr2mTOtG6dndZ550oNbLdMgAIEDaaksvw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240315001613.2033-3-laurent.pinchart@ideasonboard.com>","References":"<20240315001613.2033-1-laurent.pinchart@ideasonboard.com>\n\t<20240315001613.2033-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v2 02/14] libcamera: v4l2_subdevice: Add code member to\n\tMediaBusFormatInfo","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 15 Mar 2024 00:30:08 +0000","Message-ID":"<171046260841.1913896.4267282233807769995@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28969,"web_url":"https://patchwork.libcamera.org/comment/28969/","msgid":"<20240315003125.GE2441@pendragon.ideasonboard.com>","date":"2024-03-15T00:31:25","subject":"Re: [PATCH v2 02/14] libcamera: v4l2_subdevice: Add code member to\n\tMediaBusFormatInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Mar 15, 2024 at 12:30:08AM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2024-03-15 00:16:01)\n> > To prepare for exposing the MediaBusFormatInfo structure as an internal\n> > API, add a code member to the structure to store the media bus code.\n> > This makes MediaBusFormatInfo usable standalone, without having to\n> > externally associate the code related to the info.\n> > \n> > The entries in the mediaBusFormatInfo map are becoming too long, so\n> > split them on multiple lines.\n> > \n> > While at it, swap the order of the members to match the PixelFormatInfo\n> > class for consistency.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> \n> That's a big change. But probably worthwhile.\n> I've tried to scan through and everything I've checked is consistent so:\n\nI've automated it with a vim regex, so it should be safe :-)\n\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > ---\n> > Changes since combined RFC:\n> > \n> > - Rebase on addition oa 14-bit bayer formats\n> > ---\n> >  src/libcamera/v4l2_subdevice.cpp | 582 ++++++++++++++++++++++++++-----\n> >  1 file changed, 497 insertions(+), 85 deletions(-)\n> > \n> > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> > index b6a25e25230b..1286e7c385c4 100644\n> > --- a/src/libcamera/v4l2_subdevice.cpp\n> > +++ b/src/libcamera/v4l2_subdevice.cpp\n> > @@ -41,13 +41,15 @@ namespace {\n> >  /*\n> >   * \\struct MediaBusFormatInfo\n> >   * \\brief Information about media bus formats\n> > - * \\param bitsPerPixel Bits per pixel\n> >   * \\param name Name of MBUS format\n> > + * \\param code The media bus format code\n> > + * \\param bitsPerPixel Bits per pixel\n> >   * \\param colourEncoding Type of colour encoding\n> >   */\n> >  struct MediaBusFormatInfo {\n> > -       unsigned int bitsPerPixel;\n> >         const char *name;\n> > +       uint32_t code;\n> > +       unsigned int bitsPerPixel;\n> >         PixelFormatInfo::ColourEncoding colourEncoding;\n> >  };\n> >  \n> > @@ -56,91 +58,501 @@ struct MediaBusFormatInfo {\n> >   * \\brief A map that associates MediaBusFormatInfo struct to V4L2 media\n> >   * bus codes\n> >   */\n> > -const std::map<uint32_t, MediaBusFormatInfo> mediaBusFormatInfo = {\n> > +const std::map<uint32_t, MediaBusFormatInfo> mediaBusFormatInfo{\n> >         /* This table is sorted to match the order in linux/media-bus-format.h */\n> > -       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE, { 16, \"RGB555_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE, { 16, \"RGB555_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB565_1X16, { 16, \"RGB565_1X16\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_BGR565_2X8_BE, { 16, \"BGR565_2X8_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_BGR565_2X8_LE, { 16, \"BGR565_2X8_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB565_2X8_BE, { 16, \"RGB565_2X8_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_BGR888_1X24, { 24, \"BGR888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_Y8_1X8, { 8, \"Y8_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UV8_1X8, { 8, \"UV8_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UYVY8_1_5X8, { 12, \"UYVY8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_VYUY8_1_5X8, { 12, \"VYUY8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUYV8_1_5X8, { 12, \"YUYV8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YVYU8_1_5X8, { 12, \"YVYU8_1_5X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UYVY8_2X8, { 16, \"UYVY8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_VYUY8_2X8, { 16, \"VYUY8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUYV8_2X8, { 16, \"YUYV8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YVYU8_2X8, { 16, \"YVYU8_2X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_Y10_1X10, { 10, \"Y10_1X10\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UYVY10_2X10, { 20, \"UYVY10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_VYUY10_2X10, { 20, \"VYUY10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_Y12_1X12, { 12, \"Y12_1X12\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_Y16_1X16, { 16, \"Y16_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YVYU8_1X16, { 16, \"YVYU8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YDYUYDYV8_1X16, { 16, \"YDYUYDYV8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UYVY10_1X20, { 20, \"UYVY10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_VYUY10_1X20, { 20, \"VYUY10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUYV10_1X20, { 20, \"YUYV10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YVYU10_1X20, { 20, \"YVYU10_1X20\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUV8_1X24, { 24, \"YUV8_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUV10_1X30, { 30, \"YUV10_1X30\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_AYUV8_1X32, { 32, \"AYUV8_1X32\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UYVY12_2X12, { 24, \"UYVY12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_VYUY12_2X12, { 24, \"VYUY12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUYV12_2X12, { 24, \"YUYV12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YVYU12_2X12, { 24, \"YVYU12_2X12\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_UYVY12_1X24, { 24, \"UYVY12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_VYUY12_1X24, { 24, \"VYUY12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YUYV12_1X24, { 24, \"YUYV12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_YVYU12_1X24, { 24, \"YVYU12_1X24\", PixelFormatInfo::ColourEncodingYUV } },\n> > -       { MEDIA_BUS_FMT_SBGGR8_1X8, { 8, \"SBGGR8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGBRG8_1X8, { 8, \"SGBRG8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGRBG8_1X8, { 8, \"SGRBG8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SRGGB8_1X8, { 8, \"SRGGB8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8, { 8, \"SBGGR10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8, { 8, \"SGBRG10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8, { 8, \"SGRBG10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8, { 8, \"SRGGB10_ALAW8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8, { 8, \"SBGGR10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8, { 8, \"SGBRG10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8, { 8, \"SGRBG10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8, { 8, \"SRGGB10_DPCM8_1X8\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE, { 16, \"SBGGR10_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE, { 16, \"SBGGR10_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE, { 16, \"SBGGR10_2X8_PADLO_BE\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE, { 16, \"SBGGR10_2X8_PADLO_LE\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR10_1X10, { 10, \"SBGGR10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGBRG10_1X10, { 10, \"SGBRG10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGRBG10_1X10, { 10, \"SGRBG10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SRGGB10_1X10, { 10, \"SRGGB10_1X10\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR12_1X12, { 12, \"SBGGR12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SBGGR14_1X14, { 14, \"SBGGR14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGBRG14_1X14, { 14, \"SGBRG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SGRBG14_1X14, { 14, \"SGRBG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> > -       { MEDIA_BUS_FMT_SRGGB14_1X14, { 14, \"SRGGB14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> > +       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE, {\n> > +               .name = \"RGB444_2X8_PADHI_BE\",\n> > +               .code = MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE, {\n> > +               .name = \"RGB444_2X8_PADHI_LE\",\n> > +               .code = MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE, {\n> > +               .name = \"RGB555_2X8_PADHI_BE\",\n> > +               .code = MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE, {\n> > +               .name = \"RGB555_2X8_PADHI_LE\",\n> > +               .code = MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB565_1X16, {\n> > +               .name = \"RGB565_1X16\",\n> > +               .code = MEDIA_BUS_FMT_RGB565_1X16,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_BGR565_2X8_BE, {\n> > +               .name = \"BGR565_2X8_BE\",\n> > +               .code = MEDIA_BUS_FMT_BGR565_2X8_BE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_BGR565_2X8_LE, {\n> > +               .name = \"BGR565_2X8_LE\",\n> > +               .code = MEDIA_BUS_FMT_BGR565_2X8_LE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB565_2X8_BE, {\n> > +               .name = \"RGB565_2X8_BE\",\n> > +               .code = MEDIA_BUS_FMT_RGB565_2X8_BE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB565_2X8_LE, {\n> > +               .name = \"RGB565_2X8_LE\",\n> > +               .code = MEDIA_BUS_FMT_RGB565_2X8_LE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB666_1X18, {\n> > +               .name = \"RGB666_1X18\",\n> > +               .code = MEDIA_BUS_FMT_RGB666_1X18,\n> > +               .bitsPerPixel = 18,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_BGR888_1X24, {\n> > +               .name = \"BGR888_1X24\",\n> > +               .code = MEDIA_BUS_FMT_BGR888_1X24,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB888_1X24, {\n> > +               .name = \"RGB888_1X24\",\n> > +               .code = MEDIA_BUS_FMT_RGB888_1X24,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB888_2X12_BE, {\n> > +               .name = \"RGB888_2X12_BE\",\n> > +               .code = MEDIA_BUS_FMT_RGB888_2X12_BE,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_RGB888_2X12_LE, {\n> > +               .name = \"RGB888_2X12_LE\",\n> > +               .code = MEDIA_BUS_FMT_RGB888_2X12_LE,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_ARGB8888_1X32, {\n> > +               .name = \"ARGB8888_1X32\",\n> > +               .code = MEDIA_BUS_FMT_ARGB8888_1X32,\n> > +               .bitsPerPixel = 32,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_Y8_1X8, {\n> > +               .name = \"Y8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_Y8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UV8_1X8, {\n> > +               .name = \"UV8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_UV8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UYVY8_1_5X8, {\n> > +               .name = \"UYVY8_1_5X8\",\n> > +               .code = MEDIA_BUS_FMT_UYVY8_1_5X8,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_VYUY8_1_5X8, {\n> > +               .name = \"VYUY8_1_5X8\",\n> > +               .code = MEDIA_BUS_FMT_VYUY8_1_5X8,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUYV8_1_5X8, {\n> > +               .name = \"YUYV8_1_5X8\",\n> > +               .code = MEDIA_BUS_FMT_YUYV8_1_5X8,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YVYU8_1_5X8, {\n> > +               .name = \"YVYU8_1_5X8\",\n> > +               .code = MEDIA_BUS_FMT_YVYU8_1_5X8,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UYVY8_2X8, {\n> > +               .name = \"UYVY8_2X8\",\n> > +               .code = MEDIA_BUS_FMT_UYVY8_2X8,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_VYUY8_2X8, {\n> > +               .name = \"VYUY8_2X8\",\n> > +               .code = MEDIA_BUS_FMT_VYUY8_2X8,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUYV8_2X8, {\n> > +               .name = \"YUYV8_2X8\",\n> > +               .code = MEDIA_BUS_FMT_YUYV8_2X8,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YVYU8_2X8, {\n> > +               .name = \"YVYU8_2X8\",\n> > +               .code = MEDIA_BUS_FMT_YVYU8_2X8,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_Y10_1X10, {\n> > +               .name = \"Y10_1X10\",\n> > +               .code = MEDIA_BUS_FMT_Y10_1X10,\n> > +               .bitsPerPixel = 10,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UYVY10_2X10, {\n> > +               .name = \"UYVY10_2X10\",\n> > +               .code = MEDIA_BUS_FMT_UYVY10_2X10,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_VYUY10_2X10, {\n> > +               .name = \"VYUY10_2X10\",\n> > +               .code = MEDIA_BUS_FMT_VYUY10_2X10,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUYV10_2X10, {\n> > +               .name = \"YUYV10_2X10\",\n> > +               .code = MEDIA_BUS_FMT_YUYV10_2X10,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YVYU10_2X10, {\n> > +               .name = \"YVYU10_2X10\",\n> > +               .code = MEDIA_BUS_FMT_YVYU10_2X10,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_Y12_1X12, {\n> > +               .name = \"Y12_1X12\",\n> > +               .code = MEDIA_BUS_FMT_Y12_1X12,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_Y16_1X16, {\n> > +               .name = \"Y16_1X16\",\n> > +               .code = MEDIA_BUS_FMT_Y16_1X16,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UYVY8_1X16, {\n> > +               .name = \"UYVY8_1X16\",\n> > +               .code = MEDIA_BUS_FMT_UYVY8_1X16,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_VYUY8_1X16, {\n> > +               .name = \"VYUY8_1X16\",\n> > +               .code = MEDIA_BUS_FMT_VYUY8_1X16,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUYV8_1X16, {\n> > +               .name = \"YUYV8_1X16\",\n> > +               .code = MEDIA_BUS_FMT_YUYV8_1X16,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YVYU8_1X16, {\n> > +               .name = \"YVYU8_1X16\",\n> > +               .code = MEDIA_BUS_FMT_YVYU8_1X16,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YDYUYDYV8_1X16, {\n> > +               .name = \"YDYUYDYV8_1X16\",\n> > +               .code = MEDIA_BUS_FMT_YDYUYDYV8_1X16,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UYVY10_1X20, {\n> > +               .name = \"UYVY10_1X20\",\n> > +               .code = MEDIA_BUS_FMT_UYVY10_1X20,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_VYUY10_1X20, {\n> > +               .name = \"VYUY10_1X20\",\n> > +               .code = MEDIA_BUS_FMT_VYUY10_1X20,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUYV10_1X20, {\n> > +               .name = \"YUYV10_1X20\",\n> > +               .code = MEDIA_BUS_FMT_YUYV10_1X20,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YVYU10_1X20, {\n> > +               .name = \"YVYU10_1X20\",\n> > +               .code = MEDIA_BUS_FMT_YVYU10_1X20,\n> > +               .bitsPerPixel = 20,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUV8_1X24, {\n> > +               .name = \"YUV8_1X24\",\n> > +               .code = MEDIA_BUS_FMT_YUV8_1X24,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUV10_1X30, {\n> > +               .name = \"YUV10_1X30\",\n> > +               .code = MEDIA_BUS_FMT_YUV10_1X30,\n> > +               .bitsPerPixel = 30,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_AYUV8_1X32, {\n> > +               .name = \"AYUV8_1X32\",\n> > +               .code = MEDIA_BUS_FMT_AYUV8_1X32,\n> > +               .bitsPerPixel = 32,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UYVY12_2X12, {\n> > +               .name = \"UYVY12_2X12\",\n> > +               .code = MEDIA_BUS_FMT_UYVY12_2X12,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_VYUY12_2X12, {\n> > +               .name = \"VYUY12_2X12\",\n> > +               .code = MEDIA_BUS_FMT_VYUY12_2X12,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUYV12_2X12, {\n> > +               .name = \"YUYV12_2X12\",\n> > +               .code = MEDIA_BUS_FMT_YUYV12_2X12,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YVYU12_2X12, {\n> > +               .name = \"YVYU12_2X12\",\n> > +               .code = MEDIA_BUS_FMT_YVYU12_2X12,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_UYVY12_1X24, {\n> > +               .name = \"UYVY12_1X24\",\n> > +               .code = MEDIA_BUS_FMT_UYVY12_1X24,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_VYUY12_1X24, {\n> > +               .name = \"VYUY12_1X24\",\n> > +               .code = MEDIA_BUS_FMT_VYUY12_1X24,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YUYV12_1X24, {\n> > +               .name = \"YUYV12_1X24\",\n> > +               .code = MEDIA_BUS_FMT_YUYV12_1X24,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_YVYU12_1X24, {\n> > +               .name = \"YVYU12_1X24\",\n> > +               .code = MEDIA_BUS_FMT_YVYU12_1X24,\n> > +               .bitsPerPixel = 24,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR8_1X8, {\n> > +               .name = \"SBGGR8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGBRG8_1X8, {\n> > +               .name = \"SGBRG8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SGBRG8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGRBG8_1X8, {\n> > +               .name = \"SGRBG8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SGRBG8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SRGGB8_1X8, {\n> > +               .name = \"SRGGB8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SRGGB8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8, {\n> > +               .name = \"SBGGR10_ALAW8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR10_ALAW8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8, {\n> > +               .name = \"SGBRG10_ALAW8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SGBRG10_ALAW8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8, {\n> > +               .name = \"SGRBG10_ALAW8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SGRBG10_ALAW8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8, {\n> > +               .name = \"SRGGB10_ALAW8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SRGGB10_ALAW8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8, {\n> > +               .name = \"SBGGR10_DPCM8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8, {\n> > +               .name = \"SGBRG10_DPCM8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8, {\n> > +               .name = \"SGRBG10_DPCM8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8, {\n> > +               .name = \"SRGGB10_DPCM8_1X8\",\n> > +               .code = MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE, {\n> > +               .name = \"SBGGR10_2X8_PADHI_BE\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE, {\n> > +               .name = \"SBGGR10_2X8_PADHI_LE\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE, {\n> > +               .name = \"SBGGR10_2X8_PADLO_BE\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_BE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE, {\n> > +               .name = \"SBGGR10_2X8_PADLO_LE\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADLO_LE,\n> > +               .bitsPerPixel = 16,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR10_1X10, {\n> > +               .name = \"SBGGR10_1X10\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR10_1X10,\n> > +               .bitsPerPixel = 10,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGBRG10_1X10, {\n> > +               .name = \"SGBRG10_1X10\",\n> > +               .code = MEDIA_BUS_FMT_SGBRG10_1X10,\n> > +               .bitsPerPixel = 10,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGRBG10_1X10, {\n> > +               .name = \"SGRBG10_1X10\",\n> > +               .code = MEDIA_BUS_FMT_SGRBG10_1X10,\n> > +               .bitsPerPixel = 10,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SRGGB10_1X10, {\n> > +               .name = \"SRGGB10_1X10\",\n> > +               .code = MEDIA_BUS_FMT_SRGGB10_1X10,\n> > +               .bitsPerPixel = 10,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR12_1X12, {\n> > +               .name = \"SBGGR12_1X12\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR12_1X12,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGBRG12_1X12, {\n> > +               .name = \"SGBRG12_1X12\",\n> > +               .code = MEDIA_BUS_FMT_SGBRG12_1X12,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGRBG12_1X12, {\n> > +               .name = \"SGRBG12_1X12\",\n> > +               .code = MEDIA_BUS_FMT_SGRBG12_1X12,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SRGGB12_1X12, {\n> > +               .name = \"SRGGB12_1X12\",\n> > +               .code = MEDIA_BUS_FMT_SRGGB12_1X12,\n> > +               .bitsPerPixel = 12,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SBGGR14_1X14, {\n> > +               .name = \"SBGGR14_1X14\",\n> > +               .code = MEDIA_BUS_FMT_SBGGR14_1X14,\n> > +               .bitsPerPixel = 14,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGBRG14_1X14, {\n> > +               .name = \"SGBRG14_1X14\",\n> > +               .code = MEDIA_BUS_FMT_SGBRG14_1X14,\n> > +               .bitsPerPixel = 14,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SGRBG14_1X14, {\n> > +               .name = \"SGRBG14_1X14\",\n> > +               .code = MEDIA_BUS_FMT_SGRBG14_1X14,\n> > +               .bitsPerPixel = 14,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_SRGGB14_1X14, {\n> > +               .name = \"SRGGB14_1X14\",\n> > +               .code = MEDIA_BUS_FMT_SRGGB14_1X14,\n> > +               .bitsPerPixel = 14,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> > +       } },\n> >         /* \\todo Clarify colour encoding for HSV formats */\n> > -       { MEDIA_BUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> > -       { MEDIA_BUS_FMT_JPEG_1X8, { 8, \"JPEG_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> > +       { MEDIA_BUS_FMT_AHSV8888_1X32, {\n> > +               .name = \"AHSV8888_1X32\",\n> > +               .code = MEDIA_BUS_FMT_AHSV8888_1X32,\n> > +               .bitsPerPixel = 32,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +       } },\n> > +       { MEDIA_BUS_FMT_JPEG_1X8, {\n> > +               .name = \"JPEG_1X8\",\n> > +               .code = MEDIA_BUS_FMT_JPEG_1X8,\n> > +               .bitsPerPixel = 8,\n> > +               .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> > +       } },\n> >  };\n> >  \n> >  } /* namespace */","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07B06BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Mar 2024 00:31:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6DAE62C93;\n\tFri, 15 Mar 2024 01:31:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB65362C8F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Mar 2024 01:31:27 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DFB55A9A;\n\tFri, 15 Mar 2024 01:31:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EO/5EtRp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710462664;\n\tbh=gH8sxvdwzmi6oylsyFyMKEYLJpy4QUjvAMItrFcoAg8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EO/5EtRpg3BTrg21KZCCb+l5TxcD53T5ZsObbXezoECOgFfoqf6uDH1bueALyWmZU\n\tM72vwNDf6aGF7ax8+9hf/r8I5Mjl9OFo3cut1uYKK1wmfRj75+BRdA3CRHPWClasPg\n\tThnk9JbkZfAKQYwcCcF2nQnJJ05tGd8TgvVCVTS0=","Date":"Fri, 15 Mar 2024 02:31:25 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v2 02/14] libcamera: v4l2_subdevice: Add code member to\n\tMediaBusFormatInfo","Message-ID":"<20240315003125.GE2441@pendragon.ideasonboard.com>","References":"<20240315001613.2033-1-laurent.pinchart@ideasonboard.com>\n\t<20240315001613.2033-3-laurent.pinchart@ideasonboard.com>\n\t<171046260841.1913896.4267282233807769995@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171046260841.1913896.4267282233807769995@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]