[{"id":2661,"web_url":"https://patchwork.libcamera.org/comment/2661/","msgid":"<20190915123821.wnweozuqpdtaauke@uno.localdomain>","date":"2019-09-15T12:38:21","subject":"Re: [libcamera-devel] [PATCH] libcamera: proxy: linux: Initialise\n\tpointer members at construction time","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Sep 15, 2019 at 02:18:20PM +0300, Laurent Pinchart wrote:\n> If the IPAProxyLinux constructor fails to locate the proxy worker, the\n> socket_ and proc_ member pointers will be left uninitialised, leading\n> the a crash in the destructor. Initialise them both to nullptr.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n   j\n> ---\n>  src/libcamera/proxy/ipa_proxy_linux.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index 2a3872fdd52a..553714886f62 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -38,6 +38,7 @@ private:\n>  };\n>\n>  IPAProxyLinux::IPAProxyLinux(IPAModule *ipam)\n> +\t: proc_(nullptr), socket_(nullptr)\n>  {\n>  \tLOG(IPAProxy, Debug)\n>  \t\t<< \"initializing dummy proxy: loading IPA from \"\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF87A60BED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Sep 2019 14:41:04 +0200 (CEST)","from uno.localdomain (bl7-67-185.dsl.telepac.pt [85.240.67.185])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 3CD65100007;\n\tSun, 15 Sep 2019 12:41:04 +0000 (UTC)"],"Date":"Sun, 15 Sep 2019 14:38:21 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190915123821.wnweozuqpdtaauke@uno.localdomain>","References":"<20190915111820.11762-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"wfcxwvbtpoi7lcnf\"","Content-Disposition":"inline","In-Reply-To":"<20190915111820.11762-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: proxy: linux: Initialise\n\tpointer members at construction time","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 15 Sep 2019 12:41:05 -0000"}}]