{"id":1972,"url":"https://patchwork.libcamera.org/api/patches/1972/?format=json","web_url":"https://patchwork.libcamera.org/patch/1972/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190915111820.11762-1-laurent.pinchart@ideasonboard.com>","date":"2019-09-15T11:18:20","name":"[libcamera-devel] libcamera: proxy: linux: Initialise pointer members at construction time","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"09e7282da2856e9b8d330c4b4ca7329ce1c106e1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1972/mbox/","series":[{"id":494,"url":"https://patchwork.libcamera.org/api/series/494/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=494","date":"2019-09-15T11:18:20","name":"[libcamera-devel] libcamera: proxy: linux: Initialise pointer members at construction time","version":1,"mbox":"https://patchwork.libcamera.org/series/494/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1972/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1972/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC71B60BB0\n\tfor ;\n\tSun, 15 Sep 2019 13:18:37 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-97-146-nat.elisa-mobile.fi\n\t[85.76.97.146])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D41ED23F\n\tfor ;\n\tSun, 15 Sep 2019 13:18:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568546317;\n\tbh=AgM3I3ybZw18ypiwlNLCjEByWAIJczrFDO/CbeFZ1M8=;\n\th=From:To:Subject:Date:From;\n\tb=IiIp8hAA6KT6/3NT/vsd2l62vCZr8OUBv0ULyyLlO5XCaUp0/3Yfo6p+CwajQOamU\n\tP8++L2eg8JYSFj1LP80QPfbbKGXuxSS89ZW8LuMampGpzXBbX+y58aHxuiwyJslFRW\n\tTw3K2jUWz75BEi2otsUF/sx6WA7BDMAXQWLkKH34=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 15 Sep 2019 14:18:20 +0300","Message-Id":"<20190915111820.11762-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: proxy: linux: Initialise\n\tpointer members at construction time","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 15 Sep 2019 11:18:38 -0000"},"content":"If the IPAProxyLinux constructor fails to locate the proxy worker, the\nsocket_ and proc_ member pointers will be left uninitialised, leading\nthe a crash in the destructor. Initialise them both to nullptr.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/proxy/ipa_proxy_linux.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\nindex 2a3872fdd52a..553714886f62 100644\n--- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n+++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n@@ -38,6 +38,7 @@ private:\n };\n \n IPAProxyLinux::IPAProxyLinux(IPAModule *ipam)\n+\t: proc_(nullptr), socket_(nullptr)\n {\n \tLOG(IPAProxy, Debug)\n \t\t<< \"initializing dummy proxy: loading IPA from \"\n","prefixes":["libcamera-devel"]}