[{"id":28980,"web_url":"https://patchwork.libcamera.org/comment/28980/","msgid":"","date":"2024-03-15T11:12:04","subject":"Re: [PATCH v2 01/12] libcamera: lc-compliance: Add controls param to\n\tstart() function","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Wed, Mar 13, 2024 at 01:12:12PM +0100, Stefan Klug wrote:\n> This is needed for tests that need to pass controls to\n> Camera::start().\n>\n> Signed-off-by: Stefan Klug \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/lc-compliance/simple_capture.cpp | 4 ++--\n> src/apps/lc-compliance/simple_capture.h | 2 +-\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\n> index cf4d7cf3..56680a83 100644\n> --- a/src/apps/lc-compliance/simple_capture.cpp\n> +++ b/src/apps/lc-compliance/simple_capture.cpp\n> @@ -42,7 +42,7 @@ void SimpleCapture::configure(StreamRole role)\n> \t}\n> }\n>\n> -void SimpleCapture::start()\n> +void SimpleCapture::start(const ControlList *controls)\n> {\n> \tStream *stream = config_->at(0).stream();\n> \tint count = allocator_->allocate(stream);\n> @@ -52,7 +52,7 @@ void SimpleCapture::start()\n>\n> \tcamera_->requestCompleted.connect(this, &SimpleCapture::requestComplete);\n>\n> -\tASSERT_EQ(camera_->start(), 0) << \"Failed to start camera\";\n> +\tASSERT_EQ(camera_->start(controls), 0) << \"Failed to start camera\";\n> }\n>\n> void SimpleCapture::stop()\n> diff --git a/src/apps/lc-compliance/simple_capture.h b/src/apps/lc-compliance/simple_capture.h\n> index 2911d601..54b1d54b 100644\n> --- a/src/apps/lc-compliance/simple_capture.h\n> +++ b/src/apps/lc-compliance/simple_capture.h\n> @@ -22,7 +22,7 @@ protected:\n> \tSimpleCapture(std::shared_ptr camera);\n> \tvirtual ~SimpleCapture();\n>\n> -\tvoid start();\n> +\tvoid start(const libcamera::ControlList *controls = nullptr);\n> \tvoid stop();\n>\n> \tvirtual void requestComplete(libcamera::Request *request) = 0;\n> --\n> 2.40.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9D58BD808\n\tfor ;\n\tFri, 15 Mar 2024 11:12:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B0E162C8C;\n\tFri, 15 Mar 2024 12:12:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 572FC61C65\n\tfor ;\n\tFri, 15 Mar 2024 12:12:07 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DD47E4;\n\tFri, 15 Mar 2024 12:11:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YAodk7cq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710501103;\n\tbh=yoyy03qmxk5qPlFGvuApSywi20qJGa9G27Zc5PTr8dc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YAodk7cqXlggPh4nJ5N8tAn5iUsL/vukbLstJcMoDwMwN1ZIkVIpwCnB6+7I7wBze\n\tWqfimqRZ+e5Kb20RG9jb0ZJ/XhgSTxpYSesNJcdmr/dkngQQ/XzKb5WrEguk4m0nHN\n\teiXYwEiiFqXQ4a0C0XRXXeJIjAF3NqROKEiuUhRY=","Date":"Fri, 15 Mar 2024 12:12:04 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Subject":"Re: [PATCH v2 01/12] libcamera: lc-compliance: Add controls param to\n\tstart() function","Message-ID":"","References":"<20240313121223.138150-1-stefan.klug@ideasonboard.com>\n\t<20240313121223.138150-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240313121223.138150-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28983,"web_url":"https://patchwork.libcamera.org/comment/28983/","msgid":"<171050754765.252503.2745654998894638288@ping.linuxembedded.co.uk>","date":"2024-03-15T12:59:07","subject":"Re: [PATCH v2 01/12] libcamera: lc-compliance: Add controls param to\n\tstart() function","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-03-13 12:12:12)\n> This is needed for tests that need to pass controls to\n> Camera::start().\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/apps/lc-compliance/simple_capture.cpp | 4 ++--\n> src/apps/lc-compliance/simple_capture.h | 2 +-\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\n> index cf4d7cf3..56680a83 100644\n> --- a/src/apps/lc-compliance/simple_capture.cpp\n> +++ b/src/apps/lc-compliance/simple_capture.cpp\n> @@ -42,7 +42,7 @@ void SimpleCapture::configure(StreamRole role)\n> }\n> }\n> \n> -void SimpleCapture::start()\n> +void SimpleCapture::start(const ControlList *controls)\n> {\n> Stream *stream = config_->at(0).stream();\n> int count = allocator_->allocate(stream);\n> @@ -52,7 +52,7 @@ void SimpleCapture::start()\n> \n> camera_->requestCompleted.connect(this, &SimpleCapture::requestComplete);\n> \n> - ASSERT_EQ(camera_->start(), 0) << \"Failed to start camera\";\n> + ASSERT_EQ(camera_->start(controls), 0) << \"Failed to start camera\";\n> }\n> \n> void SimpleCapture::stop()\n> diff --git a/src/apps/lc-compliance/simple_capture.h b/src/apps/lc-compliance/simple_capture.h\n> index 2911d601..54b1d54b 100644\n> --- a/src/apps/lc-compliance/simple_capture.h\n> +++ b/src/apps/lc-compliance/simple_capture.h\n> @@ -22,7 +22,7 @@ protected:\n> SimpleCapture(std::shared_ptr camera);\n> virtual ~SimpleCapture();\n> \n> - void start();\n> + void start(const libcamera::ControlList *controls = nullptr);\n> void stop();\n> \n> virtual void requestComplete(libcamera::Request *request) = 0;\n> -- \n> 2.40.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3350BD808\n\tfor ;\n\tFri, 15 Mar 2024 12:59:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C70D162C8D;\n\tFri, 15 Mar 2024 13:59:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9329C6294A\n\tfor ;\n\tFri, 15 Mar 2024 13:59:10 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8EB5BE4;\n\tFri, 15 Mar 2024 13:58:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EiLC+kC5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710507526;\n\tbh=CUoHyqnz+8L0UR1EbFVPJLTVAagY4LlLmRFl0XQwdwY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=EiLC+kC5oB3s7eoSDPoaL2dB9CSmgSrvpXQeSUULz6PAq7wYYPL8O/0aU1Su4R2nZ\n\tWYlAvxvIorZZ0vUCQlocvERrOzW/NlApkWDjO1OdLsahIHPicQQiIh0Ob1zSHKAVt8\n\tcHJF8V7kFkKSbeieYd8XcJ92iu/DFNWqp9M6fNQc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240313121223.138150-2-stefan.klug@ideasonboard.com>","References":"<20240313121223.138150-1-stefan.klug@ideasonboard.com>\n\t<20240313121223.138150-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 01/12] libcamera: lc-compliance: Add controls param to\n\tstart() function","From":"Kieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 15 Mar 2024 12:59:07 +0000","Message-ID":"<171050754765.252503.2745654998894638288@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Klug ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]