[{"id":2659,"web_url":"https://patchwork.libcamera.org/comment/2659/","msgid":"<20190915084028.cshdnr4uotvcfq5i@uno.localdomain>","date":"2019-09-15T08:40:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: Move list of private\n\theaders to src/libcamera/include/meson.build","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Sep 15, 2019 at 03:39:24AM +0300, Laurent Pinchart wrote:\n> The libcamera private headers are listed in src/libcamera/meson.build,\n> while they are located in src/libcamera/include/. The lack of a\n> meson.build in src/libcamera/include/ increases the risk of forgetting\n> to add new headers to the libcamera_headers array. Fix it by moving it\n> to src/libcamera/include/meson.build, and add the missing\n> v4l2_controls.h entry.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n> ---\n>  src/libcamera/include/meson.build | 24 ++++++++++++++++++++++++\n>  src/libcamera/meson.build         | 24 +-----------------------\n>  2 files changed, 25 insertions(+), 23 deletions(-)\n>  create mode 100644 src/libcamera/include/meson.build\n>\n> diff --git a/src/libcamera/include/meson.build b/src/libcamera/include/meson.build\n> new file mode 100644\n> index 000000000000..933be8543a8d\n> --- /dev/null\n> +++ b/src/libcamera/include/meson.build\n> @@ -0,0 +1,24 @@\n> +libcamera_headers = files([\n> +    'camera_sensor.h',\n> +    'device_enumerator.h',\n> +    'device_enumerator_sysfs.h',\n> +    'device_enumerator_udev.h',\n> +    'event_dispatcher_poll.h',\n> +    'formats.h',\n> +    'ipa_manager.h',\n> +    'ipa_module.h',\n> +    'ipa_proxy.h',\n> +    'ipc_unixsocket.h',\n> +    'log.h',\n> +    'media_device.h',\n> +    'media_object.h',\n> +    'message.h',\n> +    'pipeline_handler.h',\n> +    'process.h',\n> +    'thread.h',\n> +    'utils.h',\n> +    'v4l2_controls.h',\n> +    'v4l2_device.h',\n> +    'v4l2_subdevice.h',\n> +    'v4l2_videodevice.h',\n> +])\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 0916bc411360..755149c55c7b 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -36,29 +36,7 @@ libcamera_sources = files([\n>      'v4l2_videodevice.cpp',\n>  ])\n>\n> -libcamera_headers = files([\n> -    'include/camera_sensor.h',\n> -    'include/device_enumerator.h',\n> -    'include/device_enumerator_sysfs.h',\n> -    'include/device_enumerator_udev.h',\n> -    'include/event_dispatcher_poll.h',\n> -    'include/formats.h',\n> -    'include/ipa_manager.h',\n> -    'include/ipa_module.h',\n> -    'include/ipa_proxy.h',\n> -    'include/ipc_unixsocket.h',\n> -    'include/log.h',\n> -    'include/media_device.h',\n> -    'include/media_object.h',\n> -    'include/message.h',\n> -    'include/pipeline_handler.h',\n> -    'include/process.h',\n> -    'include/thread.h',\n> -    'include/utils.h',\n> -    'include/v4l2_device.h',\n> -    'include/v4l2_subdevice.h',\n> -    'include/v4l2_videodevice.h',\n> -])\n> +subdir('include')\n>\n>  libcamera_internal_includes =  include_directories('include')\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD6B060BD9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Sep 2019 10:38:52 +0200 (CEST)","from uno.localdomain (bl10-204-24.dsl.telepac.pt [85.243.204.24])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 39B95240005;\n\tSun, 15 Sep 2019 08:38:52 +0000 (UTC)"],"Date":"Sun, 15 Sep 2019 10:40:28 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190915084028.cshdnr4uotvcfq5i@uno.localdomain>","References":"<20190915003924.9803-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ngmc5fnfa5gu7upj\"","Content-Disposition":"inline","In-Reply-To":"<20190915003924.9803-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Move list of private\n\theaders to src/libcamera/include/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 15 Sep 2019 08:38:53 -0000"}}]