{"id":1970,"url":"https://patchwork.libcamera.org/api/patches/1970/?format=json","web_url":"https://patchwork.libcamera.org/patch/1970/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190915003924.9803-1-laurent.pinchart@ideasonboard.com>","date":"2019-09-15T00:39:24","name":"[libcamera-devel] libcamera: Move list of private headers to src/libcamera/include/meson.build","commit_ref":"ba44276dd1393fb7583ac7253667c836a175158e","pull_url":null,"state":"accepted","archived":false,"hash":"3421bb9b26ad784f33017497b00bd7675f8736fb","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1970/mbox/","series":[{"id":492,"url":"https://patchwork.libcamera.org/api/series/492/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=492","date":"2019-09-15T00:39:24","name":"[libcamera-devel] libcamera: Move list of private headers to src/libcamera/include/meson.build","version":1,"mbox":"https://patchwork.libcamera.org/series/492/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1970/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1970/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0010A60C11\n\tfor ;\n\tSun, 15 Sep 2019 02:39:36 +0200 (CEST)","from pendragon.lan (unknown\n\t[IPv6:2001:8a0:6be4:9301:a728:6099:33:a27c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1155723F\n\tfor ;\n\tSun, 15 Sep 2019 02:39:35 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568507976;\n\tbh=9uUE55pd5tojM8glKSdmbSSZdVcl45L6Ckv3J2PTkXo=;\n\th=From:To:Subject:Date:From;\n\tb=B4c4eyi4h40o7QiIN9cNpb78joJCuDKqpA5TczCsVSNUecUOUGMMSMMU3wfGs2LDl\n\tjCEB7Tn+5P0ZOkKZ1XHDbDrQcjlAIrYox4w6pnlPRYRuvj7feXCmkGLf4RwnW9Qj22\n\tGVwOuMZtXKOXnaI550ynMrp9yeRbXdkVoA4WlVjg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 15 Sep 2019 03:39:24 +0300","Message-Id":"<20190915003924.9803-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Move list of private headers\n\tto src/libcamera/include/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 15 Sep 2019 00:39:37 -0000"},"content":"The libcamera private headers are listed in src/libcamera/meson.build,\nwhile they are located in src/libcamera/include/. The lack of a\nmeson.build in src/libcamera/include/ increases the risk of forgetting\nto add new headers to the libcamera_headers array. Fix it by moving it\nto src/libcamera/include/meson.build, and add the missing\nv4l2_controls.h entry.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/include/meson.build | 24 ++++++++++++++++++++++++\n src/libcamera/meson.build | 24 +-----------------------\n 2 files changed, 25 insertions(+), 23 deletions(-)\n create mode 100644 src/libcamera/include/meson.build","diff":"diff --git a/src/libcamera/include/meson.build b/src/libcamera/include/meson.build\nnew file mode 100644\nindex 000000000000..933be8543a8d\n--- /dev/null\n+++ b/src/libcamera/include/meson.build\n@@ -0,0 +1,24 @@\n+libcamera_headers = files([\n+ 'camera_sensor.h',\n+ 'device_enumerator.h',\n+ 'device_enumerator_sysfs.h',\n+ 'device_enumerator_udev.h',\n+ 'event_dispatcher_poll.h',\n+ 'formats.h',\n+ 'ipa_manager.h',\n+ 'ipa_module.h',\n+ 'ipa_proxy.h',\n+ 'ipc_unixsocket.h',\n+ 'log.h',\n+ 'media_device.h',\n+ 'media_object.h',\n+ 'message.h',\n+ 'pipeline_handler.h',\n+ 'process.h',\n+ 'thread.h',\n+ 'utils.h',\n+ 'v4l2_controls.h',\n+ 'v4l2_device.h',\n+ 'v4l2_subdevice.h',\n+ 'v4l2_videodevice.h',\n+])\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 0916bc411360..755149c55c7b 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -36,29 +36,7 @@ libcamera_sources = files([\n 'v4l2_videodevice.cpp',\n ])\n \n-libcamera_headers = files([\n- 'include/camera_sensor.h',\n- 'include/device_enumerator.h',\n- 'include/device_enumerator_sysfs.h',\n- 'include/device_enumerator_udev.h',\n- 'include/event_dispatcher_poll.h',\n- 'include/formats.h',\n- 'include/ipa_manager.h',\n- 'include/ipa_module.h',\n- 'include/ipa_proxy.h',\n- 'include/ipc_unixsocket.h',\n- 'include/log.h',\n- 'include/media_device.h',\n- 'include/media_object.h',\n- 'include/message.h',\n- 'include/pipeline_handler.h',\n- 'include/process.h',\n- 'include/thread.h',\n- 'include/utils.h',\n- 'include/v4l2_device.h',\n- 'include/v4l2_subdevice.h',\n- 'include/v4l2_videodevice.h',\n-])\n+subdir('include')\n \n libcamera_internal_includes = include_directories('include')\n \n","prefixes":["libcamera-devel"]}