{"id":19689,"url":"https://patchwork.libcamera.org/api/patches/19689/?format=json","web_url":"https://patchwork.libcamera.org/patch/19689/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240313105645.120317-2-stefan.klug@ideasonboard.com>","date":"2024-03-13T10:56:33","name":"[01/12] libcamera: lc-compliance: Add controls param to start() function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c15b9a6e9c0a11af497d0e7e549fc6511f1ce7a1","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19689/mbox/","series":[{"id":4219,"url":"https://patchwork.libcamera.org/api/series/4219/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4219","date":"2024-03-13T10:56:32","name":"Preparation for per-frame-controls and initial tests","version":1,"mbox":"https://patchwork.libcamera.org/series/4219/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19689/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19689/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54F3FBD1F1\n\tfor ;\n\tWed, 13 Mar 2024 10:57:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EABB62C92;\n\tWed, 13 Mar 2024 11:56:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB6AA62973\n\tfor ;\n\tWed, 13 Mar 2024 11:56:52 +0100 (CET)","from jasper.fritz.box (unknown\n\t[IPv6:2a00:6020:448c:6c00:9b07:31b5:38e1:e957])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44AABA8F;\n\tWed, 13 Mar 2024 11:56:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AHD3ERE6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710327390;\n\tbh=XqL+6G8l6sAh3t0/iCiSp/QB+GBR3E9zSf2oNX9yT4E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AHD3ERE6U4oqRW0HaZNgvI9GcXE/FfQ3bx4NuOo/MCRcWEPezIbwlYyobu6kTmore\n\t3s1op3dF7kqrIu/8oko4KnhYLE3Fo7x2xnOVxbv7CaPvbK/quXzw2Cp+ok0XInnHJ4\n\tVQJahULy5JQSuYxTr72/V9tm6QlRcwKq3aNLoGss=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 01/12] libcamera: lc-compliance: Add controls param to\n\tstart() function","Date":"Wed, 13 Mar 2024 11:56:33 +0100","Message-Id":"<20240313105645.120317-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20240313105645.120317-1-stefan.klug@ideasonboard.com>","References":"<20240313105645.120317-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This is needed for tests that need to pass controls to\nCamera::start().\n\nSigned-off-by: Stefan Klug \n---\n src/apps/lc-compliance/simple_capture.cpp | 4 ++--\n src/apps/lc-compliance/simple_capture.h | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\nindex cf4d7cf3..56680a83 100644\n--- a/src/apps/lc-compliance/simple_capture.cpp\n+++ b/src/apps/lc-compliance/simple_capture.cpp\n@@ -42,7 +42,7 @@ void SimpleCapture::configure(StreamRole role)\n \t}\n }\n \n-void SimpleCapture::start()\n+void SimpleCapture::start(const ControlList *controls)\n {\n \tStream *stream = config_->at(0).stream();\n \tint count = allocator_->allocate(stream);\n@@ -52,7 +52,7 @@ void SimpleCapture::start()\n \n \tcamera_->requestCompleted.connect(this, &SimpleCapture::requestComplete);\n \n-\tASSERT_EQ(camera_->start(), 0) << \"Failed to start camera\";\n+\tASSERT_EQ(camera_->start(controls), 0) << \"Failed to start camera\";\n }\n \n void SimpleCapture::stop()\ndiff --git a/src/apps/lc-compliance/simple_capture.h b/src/apps/lc-compliance/simple_capture.h\nindex 2911d601..54b1d54b 100644\n--- a/src/apps/lc-compliance/simple_capture.h\n+++ b/src/apps/lc-compliance/simple_capture.h\n@@ -22,7 +22,7 @@ protected:\n \tSimpleCapture(std::shared_ptr camera);\n \tvirtual ~SimpleCapture();\n \n-\tvoid start();\n+\tvoid start(const libcamera::ControlList *controls = nullptr);\n \tvoid stop();\n \n \tvirtual void requestComplete(libcamera::Request *request) = 0;\n","prefixes":["01/12"]}