[{"id":28917,"web_url":"https://patchwork.libcamera.org/comment/28917/","msgid":"<634e45d0-3063-4d87-8f7c-57b0e1b926a1@redhat.com>","date":"2024-03-11T14:27:13","subject":"Re: [PATCH v2] utils: checkstyle.py: Fix known_trailers sort order","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/people/102/","name":"Hans de Goede","email":"hdegoede@redhat.com"},"content":"Hi,\n\nOn 3/11/24 3:26 PM, Kieran Bingham wrote:\n> From: Hans de Goede \n> \n> An unruly libcamera maintainer merged the wrong patch adding the\n> Co-developed-by: tag to the known_trailers.\n> \n> Fix the sort order alphabetically to match the version which should have\n> been merged.\n> \n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Hans de Goede \n> Signed-off-by: Kieran Bingham \n> ---\n> Keeping Hans' authorship on the commit to reflect that /he/ got the\n> final code state right. But I keep getting things wrong ;-)\n> \n> v2:\n> - move the line rather than duplicate it!\n\nThanks, this looks good to me.\n\nRegards,\n\nHans\n\n\n\n\n\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 52cf770c9da3..db5a550d518f 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -471,6 +471,7 @@ class TrailersChecker(CommitChecker):\n> known_trailers = {\n> 'Acked-by': email_regex,\n> 'Bug': link_regex,\n> + 'Co-developed-by': email_regex,\n> 'Fixes': commit_regex,\n> 'Link': link_regex,\n> 'Reported-by': validate_reported_by,\n> @@ -478,7 +479,6 @@ class TrailersChecker(CommitChecker):\n> 'Signed-off-by': email_regex,\n> 'Suggested-by': email_regex,\n> 'Tested-by': email_regex,\n> - 'Co-developed-by': email_regex,\n> }\n> \n> trailer_regex = re.compile(r'([A-Z][a-zA-Z-]*)\\s*:\\s*(.*)')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6FDCBD1F1\n\tfor ;\n\tMon, 11 Mar 2024 14:27:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 874A162C8C;\n\tMon, 11 Mar 2024 15:27:28 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0531862C8B\n\tfor ;\n\tMon, 11 Mar 2024 15:27:25 +0100 (CET)","from mail-ej1-f71.google.com (mail-ej1-f71.google.com\n\t[209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-88-8t_bKUSWOSOYhRxIvm25Cw-1; Mon, 11 Mar 2024 10:27:16 -0400","by mail-ej1-f71.google.com with SMTP id\n\ta640c23a62f3a-a4636af135aso33149166b.1\n\tfor ;\n\tMon, 11 Mar 2024 07:27:16 -0700 (PDT)","from [10.40.98.142] ([78.108.130.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tld1-20020a170906f94100b00a461c74bbbfsm1645516ejb.91.2024.03.11.07.27.14\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 11 Mar 2024 07:27:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"LYBYq2UI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1710167245;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=BqoQcM587i2IjIBvrkMUYvq9DvNFT7NSvef1OicUPm8=;\n\tb=LYBYq2UIKdApOODNBxO9td3UD5a2cvIcMzd0yLevOMl0hgkMCmd+2P8n2Fkp/tjN6fAzQX\n\t9UV9YRHf5veSAchDTWLRR0eP9uEFj41F8fab2P2YuIlj+7jvLa/Pzt2Wz1lG/w3Vi4V0/l\n\tADmz0CcW+tDl+hSk++40UnV/bGM3P/o=","X-MC-Unique":"8t_bKUSWOSOYhRxIvm25Cw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1710167235; x=1710772035;\n\th=content-transfer-encoding:in-reply-to:from:references:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=BqoQcM587i2IjIBvrkMUYvq9DvNFT7NSvef1OicUPm8=;\n\tb=sFmQJONywweK/82GRxa10+aGd0S5h2QkZpeA/rBIxeCyL9RtRQm0vrA+yLWADn0vYy\n\tzZcf3fOj4hXusabeIX9WQ6yUPfgXbz3SLYWNygfZyFA41074qRBSOmCbg3taQnVibu9n\n\tWoY+fmQWP4g/i278+uFaCbBh4EYzkf9hdeVMjnAHWRjL1GF5ptw9cy5qQewHReNsIfPT\n\t7qATNdkreJZa2WYJOas9Ft4/6wGECHI5inqb+psRUw0Pj8L+Jn8LVhaBuK7Uv9os/8X8\n\tT+Cv65otyVtH/aOxcpeof7fyG7gN5coAlpwZcNIVhnAl+YesrPeyQY8Xn0H4LD9LqBji\n\tC2Dg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWm+OxquZ76JBNXVd72Rb8Kgy6igR3JLPE60+MvX8sCtOZZKo9nyLO4x1+UldN7RTifXk1/e9VTa1Hk21Yg5QoxbWjR6BMI6ZzqcjMWjsF/EmbDKA==","X-Gm-Message-State":"AOJu0Yw3ZccWSWmjmhjcA0hM+U/pB/UPl1bQc4k0alYd2qydierAi4Sl\n\thkTgmVdMynEMZsn29evrKXwS9Yiz2glDwRkRChnktghEg0UaUjuThCX9VGS2mdOD3Jf1IRyi4sq\n\tq/rj5yTbRTp8/mxqVhv/vSq48zsMj88SsSBzGsvN6Gjqeh3plO+rIcDTGfLjBUAeYLY56hn7OSO\n\tJE108=","X-Received":["by 2002:a17:906:48ce:b0:a46:3785:40d7 with SMTP id\n\td14-20020a17090648ce00b00a46378540d7mr623910ejt.49.1710167235288; \n\tMon, 11 Mar 2024 07:27:15 -0700 (PDT)","by 2002:a17:906:48ce:b0:a46:3785:40d7 with SMTP id\n\td14-20020a17090648ce00b00a46378540d7mr623900ejt.49.1710167234941; \n\tMon, 11 Mar 2024 07:27:14 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEHu73/bGD9siDSXQBH+60U6Yo9pf82vJmhzbhMlwZHfrRGYK6XTYOtWEafGq3FOwTui4UvRA==","Message-ID":"<634e45d0-3063-4d87-8f7c-57b0e1b926a1@redhat.com>","Date":"Mon, 11 Mar 2024 15:27:13 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] utils: checkstyle.py: Fix known_trailers sort order","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20240311142604.326356-1-kieran.bingham@ideasonboard.com>","From":"Hans de Goede ","In-Reply-To":"<20240311142604.326356-1-kieran.bingham@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28918,"web_url":"https://patchwork.libcamera.org/comment/28918/","msgid":"<171016773106.252503.4493516525961380295@ping.linuxembedded.co.uk>","date":"2024-03-11T14:35:31","subject":"Re: [PATCH v2] utils: checkstyle.py: Fix known_trailers sort order","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Hans de Goede (2024-03-11 14:27:13)\n> Hi,\n> \n> On 3/11/24 3:26 PM, Kieran Bingham wrote:\n> > From: Hans de Goede \n> > \n> > An unruly libcamera maintainer merged the wrong patch adding the\n> > Co-developed-by: tag to the known_trailers.\n> > \n> > Fix the sort order alphabetically to match the version which should have\n> > been merged.\n> > \n> > Reviewed-by: Kieran Bingham \n> > Signed-off-by: Hans de Goede \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > Keeping Hans' authorship on the commit to reflect that /he/ got the\n> > final code state right. But I keep getting things wrong ;-)\n> > \n> > v2:\n> > - move the line rather than duplicate it!\n> \n> Thanks, this looks good to me.\n\nThanks, tree 'corrected' now.\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49B1EBD160\n\tfor ;\n\tMon, 11 Mar 2024 14:35:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9653862C84;\n\tMon, 11 Mar 2024 15:35:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A710C62868\n\tfor ;\n\tMon, 11 Mar 2024 15:35:33 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CD39F0A;\n\tMon, 11 Mar 2024 15:35:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kv3wiSFq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710167712;\n\tbh=MIO79ex/uWALeqzaapW0GHCHfye9leHY7aQzJVw8pRI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Kv3wiSFqSeYk1zT+QU5oeic0U5pYynt0C1g+3sl6S3WwogjYPWno1aCmRp7nMma3e\n\tDNaE6KzUJHfOs5aWy/AtdnNlfVT7khR7tEIKbcepqkYd/Szv1UQ4OKjWqaQG0MzDCR\n\tSaBdMNzGgNwEg0ZzDW/DPZpq38GIs89W1Ftf/TCU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<634e45d0-3063-4d87-8f7c-57b0e1b926a1@redhat.com>","References":"<20240311142604.326356-1-kieran.bingham@ideasonboard.com>\n\t<634e45d0-3063-4d87-8f7c-57b0e1b926a1@redhat.com>","Subject":"Re: [PATCH v2] utils: checkstyle.py: Fix known_trailers sort order","From":"Kieran Bingham ","To":"Hans de Goede ,\n\tlibcamera devel ","Date":"Mon, 11 Mar 2024 14:35:31 +0000","Message-ID":"<171016773106.252503.4493516525961380295@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]