[{"id":28916,"web_url":"https://patchwork.libcamera.org/comment/28916/","msgid":"<171016703914.252503.4420885992278050243@ping.linuxembedded.co.uk>","date":"2024-03-11T14:23:59","subject":"Re: [PATCH] utils: checkstyle.py: Fix known_trailers sort order","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2024-03-11 13:24:51)\n> From: Hans de Goede \n> \n> An unruly libcamera maintainer merged the wrong patch adding the\n> Co-developed-by: tag to the known_trailers.\n> \n> Fix the sort order alphabetically to match the version which should have\n> been merged.\n> \n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Hans de Goede \n> Signed-off-by: Kieran Bingham \n> ---\n> utils/checkstyle.py | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 52cf770c9da3..c0a8bdfe10d5 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -471,6 +471,7 @@ class TrailersChecker(CommitChecker):\n> known_trailers = {\n> 'Acked-by': email_regex,\n> 'Bug': link_regex,\n> + 'Co-developed-by': email_regex,\n> 'Fixes': commit_regex,\n> 'Link': link_regex,\n> 'Reported-by': validate_reported_by,\n\nThat same unruly maintainer can't create a fixup correctly either!\n\nHe failed to add the removal of the incorrect line :-(\n\n--\nKieran\n\n\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D0E7BD160\n\tfor ;\n\tMon, 11 Mar 2024 14:24:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C8DC62C8C;\n\tMon, 11 Mar 2024 15:24:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 845EF61C7C\n\tfor ;\n\tMon, 11 Mar 2024 15:24:01 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A4AAF0A;\n\tMon, 11 Mar 2024 15:23:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CLnCDjMn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710167020;\n\tbh=JI/iLQaCY+1yXQjqgd4vk/3OLRdpYLjI/QHralTQ98M=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CLnCDjMn3hrschfGNuvBz3f0R0/yHvX9s0JpIovSJAwYKBu1VfWZNN9JqSjyez0/4\n\tZbSOEktSHbKB1UXZ3MNHniS0ybg8gB+uaAVShvNvRXJuoJCNvXThUPnoHagysPOKWp\n\tpgd4Z0LqyoKv3fNM+paD1ZK+MSOJg3Spctc9wnFY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240311132451.182317-1-kieran.bingham@ideasonboard.com>","References":"<20240311132451.182317-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH] utils: checkstyle.py: Fix known_trailers sort order","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Mon, 11 Mar 2024 14:23:59 +0000","Message-ID":"<171016703914.252503.4420885992278050243@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]