[{"id":28909,"web_url":"https://patchwork.libcamera.org/comment/28909/","msgid":"<171015883649.252503.14521591759631918459@ping.linuxembedded.co.uk>","date":"2024-03-11T12:07:16","subject":"Re: [PATCH] utils: checkstyle.py: Add Co-developed-by to\n\tknown_trailers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Hans de Goede (2024-03-11 12:01:02)\n> Add Co-developed-by to known_trailers to silence false positive\n> \"Invalid commit trailer key 'Co-developed-by'\" warnings.\n\nAha, I was intending to do the same. Thanks for beating me to it!\n\nMatches\nhttps://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by\nso\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Hans de Goede \n> ---\n> utils/checkstyle.py | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index fb03dc34..52cf770c 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -478,6 +478,7 @@ class TrailersChecker(CommitChecker):\n> 'Signed-off-by': email_regex,\n> 'Suggested-by': email_regex,\n> 'Tested-by': email_regex,\n> + 'Co-developed-by': email_regex,\n> }\n> \n> trailer_regex = re.compile(r'([A-Z][a-zA-Z-]*)\\s*:\\s*(.*)')\n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56972BD1F1\n\tfor ;\n\tMon, 11 Mar 2024 12:07:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B00162C80;\n\tMon, 11 Mar 2024 13:07:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 351DC61C7C\n\tfor ;\n\tMon, 11 Mar 2024 13:07:19 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1495D6BE;\n\tMon, 11 Mar 2024 13:06:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"inVecSPh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710158818;\n\tbh=hNe55EfY9xP4kWfnNyKL5Gzo4PyU5CNvVp+d8cS5pZU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=inVecSPhkIa6po2BJPXiAgZlqSRYU3fFd+rIsDXFmdKOxd8TaMPrmtA92L55mjqFp\n\tzoHyq2sL4COO5Y1ZVLQM5wQn0Z0HS10p2mbcarxm1zAFvskXNKVxlY5jQIUtojI4RK\n\t9k0ZvZW7E3ro7o7Cvm+Ya+bE5vObEoNtbJPobn6E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240311120102.13235-1-hdegoede@redhat.com>","References":"<20240311120102.13235-1-hdegoede@redhat.com>","Subject":"Re: [PATCH] utils: checkstyle.py: Add Co-developed-by to\n\tknown_trailers","From":"Kieran Bingham ","To":"Hans de Goede , libcamera-devel@lists.libcamera.org","Date":"Mon, 11 Mar 2024 12:07:16 +0000","Message-ID":"<171015883649.252503.14521591759631918459@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28910,"web_url":"https://patchwork.libcamera.org/comment/28910/","msgid":"","date":"2024-03-11T12:34:06","subject":"Re: [PATCH] utils: checkstyle.py: Add Co-developed-by to\n\tknown_trailers","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"On Mon, Mar 11, 2024 at 01:01:02PM +0100, Hans de Goede wrote:\n> Add Co-developed-by to known_trailers to silence false positive\n> \"Invalid commit trailer key 'Co-developed-by'\" warnings.\n>\n> Signed-off-by: Hans de Goede \n> ---\n> utils/checkstyle.py | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index fb03dc34..52cf770c 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -478,6 +478,7 @@ class TrailersChecker(CommitChecker):\n> 'Signed-off-by': email_regex,\n> 'Suggested-by': email_regex,\n> 'Tested-by': email_regex,\n> + 'Co-developed-by': email_regex,\n\nMaybe keep this alphabetically sorted ?\n\nThis apart\nReviewed-by: Jacopo Mondi \n> }\n>\n> trailer_regex = re.compile(r'([A-Z][a-zA-Z-]*)\\s*:\\s*(.*)')\n> --\n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1243BD1F1\n\tfor ;\n\tMon, 11 Mar 2024 12:34:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 809BE62C80;\n\tMon, 11 Mar 2024 13:34:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5ABAF62868\n\tfor ;\n\tMon, 11 Mar 2024 13:34:10 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E1CAC85;\n\tMon, 11 Mar 2024 13:33:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FlVg3JNq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710160429;\n\tbh=3YGY6wvk43OwCZ08p79hQk+F2GQGkE1GpZG4xbibckY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FlVg3JNqT5D6YmJK0mP4mS66bW09HMAU4XDYvpLKl1cneZ1JqUQITdTdDCyx0zynZ\n\tbtEwkrg2JZdd5Ok9EtIeYYFlw7LMC4low3zYKrG7SxBjnPbs/m8uuEI//jmkPLINjC\n\t9EKk6AhrXn3MYQNMptM8ox6AM+6V7n/P0BIY60Ww=","Date":"Mon, 11 Mar 2024 13:34:06 +0100","From":"Jacopo Mondi ","To":"Hans de Goede ","Subject":"Re: [PATCH] utils: checkstyle.py: Add Co-developed-by to\n\tknown_trailers","Message-ID":"","References":"<20240311120102.13235-1-hdegoede@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240311120102.13235-1-hdegoede@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28912,"web_url":"https://patchwork.libcamera.org/comment/28912/","msgid":"<05f0ce08-565e-4fbc-9180-f1a59e7ea9cc@redhat.com>","date":"2024-03-11T12:54:58","subject":"Re: [PATCH] utils: checkstyle.py: Add Co-developed-by to\n\tknown_trailers","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/people/102/","name":"Hans de Goede","email":"hdegoede@redhat.com"},"content":"Hi,\n\nOn 3/11/24 1:34 PM, Jacopo Mondi wrote:\n> On Mon, Mar 11, 2024 at 01:01:02PM +0100, Hans de Goede wrote:\n>> Add Co-developed-by to known_trailers to silence false positive\n>> \"Invalid commit trailer key 'Co-developed-by'\" warnings.\n>>\n>> Signed-off-by: Hans de Goede \n>> ---\n>> utils/checkstyle.py | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n>> index fb03dc34..52cf770c 100755\n>> --- a/utils/checkstyle.py\n>> +++ b/utils/checkstyle.py\n>> @@ -478,6 +478,7 @@ class TrailersChecker(CommitChecker):\n>> 'Signed-off-by': email_regex,\n>> 'Suggested-by': email_regex,\n>> 'Tested-by': email_regex,\n>> + 'Co-developed-by': email_regex,\n> \n> Maybe keep this alphabetically sorted ?\n\nAh I did not realize this was alphabetically sorted.\n\nI'll do a v2 keeping things sorted.\n\n> \n> This apart\n> Reviewed-by: Jacopo Mondi \n\nThank you for the review.\n\nRegards,\n\nHans\n\n\n\n\n\n>> }\n>>\n>> trailer_regex = re.compile(r'([A-Z][a-zA-Z-]*)\\s*:\\s*(.*)')\n>> --\n>> 2.44.0\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C09BABD1F1\n\tfor ;\n\tMon, 11 Mar 2024 12:55:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12D5662C80;\n\tMon, 11 Mar 2024 13:55:05 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 695EF61C7C\n\tfor ;\n\tMon, 11 Mar 2024 13:55:03 +0100 (CET)","from mail-ed1-f71.google.com (mail-ed1-f71.google.com\n\t[209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-588-g459DfttN8GG4Xw99YhDhQ-1; Mon, 11 Mar 2024 08:55:00 -0400","by mail-ed1-f71.google.com with SMTP id\n\t4fb4d7f45d1cf-5684b839aafso1111049a12.2\n\tfor ;\n\tMon, 11 Mar 2024 05:55:00 -0700 (PDT)","from [10.40.98.142] ([78.108.130.194])\n\tby smtp.gmail.com with ESMTPSA id\n\ta3-20020a50e703000000b005661badcccesm2896999edn.87.2024.03.11.05.54.58\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 11 Mar 2024 05:54:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"AtGCg/OJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1710161702;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=hgKLV5psunN64pYqL107wlxIReX0q/RV3IZzcfPHB2Q=;\n\tb=AtGCg/OJpi7HJvyWDnGaxCu5GnMWk2lGCvWTIfd4Zyh14PzS1kxBNoeYDb1hi4FZ1Gmfs2\n\tmscy9lRt/9ng5qbm81IDGsrm3JOuWGZldlSbPSKwa/MDjjaPG1fnMh1qrPQdfUWzGfzder\n\tGvTk7RNngcvVps0nHrpMeNOotNgR1cY=","X-MC-Unique":"g459DfttN8GG4Xw99YhDhQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1710161699; x=1710766499;\n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=hgKLV5psunN64pYqL107wlxIReX0q/RV3IZzcfPHB2Q=;\n\tb=vYltdd2ZTdIwND792jgyVlVOU3fInTYr3izfwAaVZGRHMcWsvplFWvBKtCVb/6XSaJ\n\tcEZesOU9ykig9VQqqyTKJZ8JZnj2lhvR6s2clNX10F93Z2+a/z5HnsdchOfgS4u4LR07\n\tWjmWo+CJURQVJ8NKj9tQbDKN+Tg0tO3DkgmxxD6blmX01kXxd6GRK0udYSAUe8hvuox0\n\ttJc6PoJuJ+IGVPnjCLPvzQerLrgEFSCfnhnR6Z9pXP/XwOl/C5hD9+Xw4ijiz+N/DFxO\n\t6gZUyqBNEXWDyAkwhExGfsNsEsCb2W8STAZUd+iqYsAGoAkIGPjqfO5YQyHoOAQf6j0c\n\t2d5g==","X-Gm-Message-State":"AOJu0Yx9U49md2UONxzxxg+36Y/UePVxlzJmkrAPohAcTk2Ev28lYuaf\n\tIebnxOFHzEfc6DwmaA3+TP6KNZLpeilKjx7jzEajZlitwNX/SsjpmxUJOJaAZNDIqr+PWJ8XNd/\n\tfjKO+nWqR43eSd5+aRUUgBdHnKls1cfzgd1awJivhq9800fbYYqRZFgWWnqTM85czUwZK2Y315z\n\tYfuDI=","X-Received":["by 2002:a50:9e81:0:b0:568:1988:f699 with SMTP id\n\ta1-20020a509e81000000b005681988f699mr4253695edf.30.1710161699542; \n\tMon, 11 Mar 2024 05:54:59 -0700 (PDT)","by 2002:a50:9e81:0:b0:568:1988:f699 with SMTP id\n\ta1-20020a509e81000000b005681988f699mr4253683edf.30.1710161699118; \n\tMon, 11 Mar 2024 05:54:59 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHh3RMOrYuAKC2HeoixXZBy/fn0BSgZh4Zi23IguITLpSBFs4BdQswZi9vJwxtSZkci2jb14Q==","Message-ID":"<05f0ce08-565e-4fbc-9180-f1a59e7ea9cc@redhat.com>","Date":"Mon, 11 Mar 2024 13:54:58 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] utils: checkstyle.py: Add Co-developed-by to\n\tknown_trailers","To":"Jacopo Mondi ","References":"<20240311120102.13235-1-hdegoede@redhat.com>\n\t","From":"Hans de Goede ","In-Reply-To":"","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]