[{"id":28914,"web_url":"https://patchwork.libcamera.org/comment/28914/","msgid":"<171016650183.252503.12062646148481793143@ping.linuxembedded.co.uk>","date":"2024-03-11T14:15:01","subject":"Re: [PATCH v2 2/3] libcamera: framebuffer_allocator: Use default\n\tdestructor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2024-03-10 14:30:38)\n> The compiler generated destructor works fine, so use that.\n> \n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/framebuffer_allocator.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\n> index 8cf45ab2..fc19a33a 100644\n> --- a/src/libcamera/framebuffer_allocator.cpp\n> +++ b/src/libcamera/framebuffer_allocator.cpp\n> @@ -63,10 +63,7 @@ FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr camera)\n> {\n> }\n> \n> -FrameBufferAllocator::~FrameBufferAllocator()\n> -{\n> - buffers_.clear();\n> -}\n> +FrameBufferAllocator::~FrameBufferAllocator() = default;\n> \n> /**\n> * \\brief Allocate buffers for a configured stream\n> -- \n> 2.44.0\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1FF2BD160\n\tfor ;\n\tMon, 11 Mar 2024 14:15:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D09162C85;\n\tMon, 11 Mar 2024 15:15:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56E9C61C7C\n\tfor ;\n\tMon, 11 Mar 2024 15:15:04 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B30EF0A;\n\tMon, 11 Mar 2024 15:14:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r7l5DnIU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710166483;\n\tbh=2LJBNIsjs9xxXzSnPSxZXLqZmO3V1FflsyPNYVrLw4w=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=r7l5DnIUmrQCG6Avf4CqZC33Bl8HrZKgphuPgkT5OxAPwTAKDcXYfcmjFli9F7msk\n\tqIZlMcHGSBedKVLQlc06S2qZVfs63hF0GiYYya3l2GjFL2/NkU4gSm5ShRbacLN7Lp\n\t9jzUp1mZ4j97kZIlZtgnhEOfDZUJDl87WmsdkF5E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240310143023.752559-3-pobrn@protonmail.com>","References":"<20240310143023.752559-1-pobrn@protonmail.com>\n\t<20240310143023.752559-3-pobrn@protonmail.com>","Subject":"Re: [PATCH v2 2/3] libcamera: framebuffer_allocator: Use default\n\tdestructor","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 11 Mar 2024 14:15:01 +0000","Message-ID":"<171016650183.252503.12062646148481793143@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28921,"web_url":"https://patchwork.libcamera.org/comment/28921/","msgid":"","date":"2024-03-11T17:01:40","subject":"Re: [PATCH v2 2/3] libcamera: framebuffer_allocator: Use default\n\tdestructor","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Sun, Mar 10, 2024 at 02:30:38PM +0000, Barnabás Pőcze wrote:\n> The compiler generated destructor works fine, so use that.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/libcamera/framebuffer_allocator.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\n> index 8cf45ab2..fc19a33a 100644\n> --- a/src/libcamera/framebuffer_allocator.cpp\n> +++ b/src/libcamera/framebuffer_allocator.cpp\n> @@ -63,10 +63,7 @@ FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr camera)\n> {\n> }\n>\n> -FrameBufferAllocator::~FrameBufferAllocator()\n> -{\n> -\tbuffers_.clear();\n> -}\n> +FrameBufferAllocator::~FrameBufferAllocator() = default;\n>\n> /**\n> * \\brief Allocate buffers for a configured stream\n> --\n> 2.44.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56532BD1F1\n\tfor ;\n\tMon, 11 Mar 2024 17:01:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2C6A62C85;\n\tMon, 11 Mar 2024 18:01:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AEC7C61C7C\n\tfor ;\n\tMon, 11 Mar 2024 18:01:43 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 777906BE;\n\tMon, 11 Mar 2024 18:01:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L5e0mJCP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710176482;\n\tbh=9TaXR/EiAYTjAWVHCTU+kMiGdzpHu592ss6IDmZXCxM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=L5e0mJCPbKuLr7rluVJrV6/VJOEO/jI+7adL0Qp+dXx3uC28OlX/hraX+6s3YNmwD\n\tiKBWG+jNz1HcKJGp1d7bgExu/sQDB4l0Ru/mXJMcoZaZ4Qt+akzSswUM+jfg86Y2Rj\n\ttqSgeLQE4pnaNFvpk3AtUWpJObT0u9VbfUkjoezg=","Date":"Mon, 11 Mar 2024 18:01:40 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"Re: [PATCH v2 2/3] libcamera: framebuffer_allocator: Use default\n\tdestructor","Message-ID":"","References":"<20240310143023.752559-1-pobrn@protonmail.com>\n\t<20240310143023.752559-3-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20240310143023.752559-3-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]