[{"id":28898,"web_url":"https://patchwork.libcamera.org/comment/28898/","msgid":"<170985083479.304827.1556967034055990771@ping.linuxembedded.co.uk>","date":"2024-03-07T22:33:54","subject":"Re: [PATCH v1 3/5] qemu: Print error logs on unit test failure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Nicolas Dufresne (2024-03-07 22:18:08)\n> From: Nicolas Dufresne \n> \n> The error logs very often holds the information needed to fix the\n> failure, don't hide it.\n> \n\nSounds good to me.\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Nicolas Dufresne \n> ---\n> .gitlab-ci/test-libcamera-qemu.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/.gitlab-ci/test-libcamera-qemu.sh b/.gitlab-ci/test-libcamera-qemu.sh\n> index 068f2ff..f9de5ab 100755\n> --- a/.gitlab-ci/test-libcamera-qemu.sh\n> +++ b/.gitlab-ci/test-libcamera-qemu.sh\n> @@ -26,7 +26,7 @@ libcamera_unit_test() {\n> virtme-ng --verbose --skip-modules --force-9p \\\n> --rwdir \"$PWD/build\" \\\n> --run /opt/linux/bzImage \\\n> - --exec \"meson test -C build --no-rebuild ; echo \\\\\\$? > build/.test-status\"\n> + --exec \"meson test -C build --no-rebuild --print-errorlogs; echo \\\\\\$? > build/.test-status\"\n> \n> local status=$(cat build/.test-status)\n> echo \"Test result exit state: $status\"\n> -- \n> 2.43.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E39E9C0F2A\n\tfor ;\n\tThu, 7 Mar 2024 22:33:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C1CA62865;\n\tThu, 7 Mar 2024 23:33:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB3DA62865\n\tfor ;\n\tThu, 7 Mar 2024 23:33:57 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62290DC9;\n\tThu, 7 Mar 2024 23:33:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qwl+W5e/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709850819;\n\tbh=mkd32SbaE/mN3XyEKdJG8bVkBymRTX1Wx+BCcnAS8Ws=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Qwl+W5e/cWEPu0rOV0Mpx0+L1yO6Hgm5s84v4gbzzAflwy1wBmL+9l9ll4V6s/SIv\n\tc036+b7LbzObni7u6e5LGN1dCpySc8rmUU1Pnw/LMt0fd0me0KA4YI5HLbyMIbMnlf\n\tFIGgI1ZXwlmd/uwr9FglkvpPOAGD8G6a0ltRB9eA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240307221810.2109348-4-nicolas@ndufresne.ca>","References":"<20240307221810.2109348-1-nicolas@ndufresne.ca>\n\t<20240307221810.2109348-4-nicolas@ndufresne.ca>","Subject":"Re: [PATCH v1 3/5] qemu: Print error logs on unit test failure","From":"Kieran Bingham ","To":"Nicolas Dufresne ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 07 Mar 2024 22:33:54 +0000","Message-ID":"<170985083479.304827.1556967034055990771@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Nicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]