[{"id":28871,"web_url":"https://patchwork.libcamera.org/comment/28871/","msgid":"<20240305152628.GH12482@pendragon.ideasonboard.com>","date":"2024-03-05T15:26:28","subject":"Re: [PATCH 1/2] libcamera: v4l2_subdevice: Add 14-bit Bayer formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nick,\n\nThank you for the patch.\n\nOn Tue, Mar 05, 2024 at 11:01:35AM +0000, Nick Hollinghurst wrote:\n> Add MEDIA_BUS_FMT_SBGGR14_1X14 etc to formatInfoMap.\n> Not adding any Y14 for now.\n\nNice to see the gap being filled :-)\n\n> Signed-off-by: Nick Hollinghurst \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index aea90aba..dfe46fa7 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -134,6 +134,10 @@ const std::map formatInfoMap = {\n> \t{ MEDIA_BUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> \t{ MEDIA_BUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> \t{ MEDIA_BUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> +\t{ MEDIA_BUS_FMT_SBGGR14_1X14, { 14, \"SBGGR14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> +\t{ MEDIA_BUS_FMT_SGBRG14_1X14, { 14, \"SGBRG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> +\t{ MEDIA_BUS_FMT_SGRBG14_1X14, { 14, \"SGRBG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> +\t{ MEDIA_BUS_FMT_SRGGB14_1X14, { 14, \"SRGGB14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> \t{ MEDIA_BUS_FMT_SBGGR16_1X16, { 16, \"SBGGR16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n> \t{ MEDIA_BUS_FMT_SGBRG16_1X16, { 16, \"SGBRG16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n> \t{ MEDIA_BUS_FMT_SGRBG16_1X16, { 16, \"SGRBG16_1x16\", PixelFormatInfo::ColourEncodingRAW } },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFA74C0F2A\n\tfor ;\n\tTue, 5 Mar 2024 15:26:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AAF961C92;\n\tTue, 5 Mar 2024 16:26:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16B3E61C8D\n\tfor ;\n\tTue, 5 Mar 2024 16:26:26 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E6A2B8D0;\n\tTue, 5 Mar 2024 16:26:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mDxd9pD3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709652369;\n\tbh=hZBxhzj5bJDxDCUoeQPC3ngyoisEQpqkDTmW5Ip+4bw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mDxd9pD3/2tpz0mVnACPMGorE/0Jf8C/gKMgobWWJxiJ8DzIDsNvqC7GEdOVYyXit\n\tBEZKkQVWqO5zEtnK59AoMPL71Nc5HLkPiwpDFAj2oaMc6aq1mdgJs4nv0wGBs9SSLY\n\t2w0jHG2ptls4S+g4E/9g8Xq+7jKJSt4F0bJH8t0s=","Date":"Tue, 5 Mar 2024 17:26:28 +0200","From":"Laurent Pinchart ","To":"Nick Hollinghurst ","Subject":"Re: [PATCH 1/2] libcamera: v4l2_subdevice: Add 14-bit Bayer formats","Message-ID":"<20240305152628.GH12482@pendragon.ideasonboard.com>","References":"<20240305110136.3624-1-nick.hollinghurst@raspberrypi.com>\n\t<20240305110136.3624-2-nick.hollinghurst@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240305110136.3624-2-nick.hollinghurst@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28876,"web_url":"https://patchwork.libcamera.org/comment/28876/","msgid":"","date":"2024-03-06T12:41:20","subject":"Re: [PATCH 1/2] libcamera: v4l2_subdevice: Add 14-bit Bayer formats","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Nick,\n\nOn Tue, 5 Mar 2024 at 11:01, Nick Hollinghurst\n wrote:\n>\n> Add MEDIA_BUS_FMT_SBGGR14_1X14 etc to formatInfoMap.\n> Not adding any Y14 for now.\n>\n> Signed-off-by: Nick Hollinghurst \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index aea90aba..dfe46fa7 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -134,6 +134,10 @@ const std::map formatInfoMap = {\n> { MEDIA_BUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> { MEDIA_BUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> { MEDIA_BUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> + { MEDIA_BUS_FMT_SBGGR14_1X14, { 14, \"SBGGR14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> + { MEDIA_BUS_FMT_SGBRG14_1X14, { 14, \"SGBRG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> + { MEDIA_BUS_FMT_SGRBG14_1X14, { 14, \"SGRBG14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> + { MEDIA_BUS_FMT_SRGGB14_1X14, { 14, \"SRGGB14_1X14\", PixelFormatInfo::ColourEncodingRAW } },\n> { MEDIA_BUS_FMT_SBGGR16_1X16, { 16, \"SBGGR16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n> { MEDIA_BUS_FMT_SGBRG16_1X16, { 16, \"SGBRG16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n> { MEDIA_BUS_FMT_SGRBG16_1X16, { 16, \"SGRBG16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A326BD160\n\tfor ;\n\tWed, 6 Mar 2024 12:42:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 654B36286F;\n\tWed, 6 Mar 2024 13:41:59 +0100 (CET)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6A2C61C8F\n\tfor ;\n\tWed, 6 Mar 2024 13:41:57 +0100 (CET)","by mail-ed1-x534.google.com with SMTP id\n\t4fb4d7f45d1cf-5640fef9fa6so8344645a12.0\n\tfor ;\n\tWed, 06 Mar 2024 04:41:57 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"PLeI6t06\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1709728917; x=1710333717;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=vbMPDM/Bx6iqxSllNqJYHlplYs/b+G9WCKoyFTtuMp4=;\n\tb=PLeI6t06B9S9O2N9oyMcwBhCQseBw6bbvHotKBXvdvxS/hsvRDuC1l3K3N36pj6YQn\n\tghkMOU/X7mtkUtbLj+0F5CGClGT0ZsVZEjcDfr9piMwYs54NpUEhe7kWShTUtVTAdchM\n\tq5Wsksd7q4GPdmMin7JQsXt0lObT8rtGL3PbN44BIrKXrX37lg/lN2diQL5MHb+hPMT7\n\tDMJwSqNxSxtUqDw6dC34S+PgnfUSOZIIePT9wm/mWAw+uQ8oy3X/Nh6Cd5TLirc8GEQD\n\tnglAJ1l2aa661aYBrd3X4Hoc1f/A711Z3tdO8g5C/HTl4lM6wATNc8yGVkqFTBRbI0y1\n\tInSg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1709728917; x=1710333717;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=vbMPDM/Bx6iqxSllNqJYHlplYs/b+G9WCKoyFTtuMp4=;\n\tb=FNyFWJOQ62//kdguyW9hty7tEWnKSCkeHvCBkkc6ek7Ugz73Cq2jblmhSpM5o55va7\n\twGt09z4b+3vauoScEZrgTXBwrFZel/HZ4tLD7n4RYM7ZL4cfksTOjyPKLOTD8o+YEaDQ\n\tftuLegM3xFejb21uUsFopjeMM7HhB8DwkEHaFH+JZQ/KuWdBGG7qjowok8RU10fMFnG/\n\t+RQfv3GWsqCZWyH2z1aGg6M1+4r20DsIxTAsJzHiXsthlPzKGATgzGLpaV8vnY/wHJhO\n\tDQQLqH1uxuJDhShp0eWCRIUPeS/5bTd3xAIdJcAXu9uWUdesuN+4oabM7GF7O6f0pbkQ\n\tEQUA==","X-Gm-Message-State":"AOJu0Yy6wIBKZUdPYZR/cxpBr5tpLGTwZ0BogCkQu8rjTQwBCRyEnSix\n\tkymAIPbFbCfLy+Z/qFZCb1ss4BHs9mY+4l77OLkbJmZaGLp+ZINLOR2q/85TMd8dvBMTjZ3nng3\n\tICRw5bQ9JO2gHJKJ+O3PZWhjLYC5POj0j3donwg==","X-Google-Smtp-Source":"AGHT+IHL0OXLMD25j/+dQZWRoL3pBOPHavmA+j1zjixV1hDc6tgS6M/fB6GhH0mt73GtdgwrqGTBDS8jYyQZh7zJqSg=","X-Received":"by 2002:a05:6402:1e87:b0:566:4047:7106 with SMTP id\n\tf7-20020a0564021e8700b0056640477106mr11254914edf.25.1709728917160;\n\tWed, 06 Mar 2024 04:41:57 -0800 (PST)","MIME-Version":"1.0","References":"<20240305110136.3624-1-nick.hollinghurst@raspberrypi.com>\n\t<20240305110136.3624-2-nick.hollinghurst@raspberrypi.com>","In-Reply-To":"<20240305110136.3624-2-nick.hollinghurst@raspberrypi.com>","From":"Naushir Patuck ","Date":"Wed, 6 Mar 2024 12:41:20 +0000","Message-ID":"","Subject":"Re: [PATCH 1/2] libcamera: v4l2_subdevice: Add 14-bit Bayer formats","To":"Nick Hollinghurst ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]