{"id":19616,"url":"https://patchwork.libcamera.org/api/patches/19616/?format=json","web_url":"https://patchwork.libcamera.org/patch/19616/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240301212121.9072-26-laurent.pinchart@ideasonboard.com>","date":"2024-03-01T21:21:14","name":"[PATCH/RFC,25/32] pipeline: raspberrypi: vc4: Use operator<<(V4L2VideoFormat)","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"37417e1306faea2ae38d2f178e32e5838c295c1a","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19616/mbox/","series":[{"id":4197,"url":"https://patchwork.libcamera.org/api/series/4197/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4197","date":"2024-03-01T21:20:49","name":"libcamera: Support the upstream Unicam driver","version":1,"mbox":"https://patchwork.libcamera.org/series/4197/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19616/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19616/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E64A4BD160\n\tfor ;\n\tFri, 1 Mar 2024 21:21:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6B1962875;\n\tFri, 1 Mar 2024 22:21:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F8E262875\n\tfor ;\n\tFri, 1 Mar 2024 22:21:56 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D4793370;\n\tFri, 1 Mar 2024 22:21:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ys8fUx8G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709328102;\n\tbh=9SLYmxbv0qs2VrZvv3mTlIeQUVcGPAV5LswD1uuZUdA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ys8fUx8GVlPAETWe4yBckz2g7PBbpY2dBVIhsW8Q9gKGRp1u7AXYCT5G3vxrWRDOm\n\tYs1vIuXvL0F70CBOWHHBEm4INFEk/DJ2FmHHhCcFVHl1QPro14mifkhx/hrwJUClaF\n\tfRvS96QOo6ZVxVSwcWtrVfz/x4AfOZhd6fWxjur0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH/RFC 25/32] pipeline: raspberrypi: vc4: Use\n\toperator<<(V4L2VideoFormat)","Date":"Fri, 1 Mar 2024 23:21:14 +0200","Message-ID":"<20240301212121.9072-26-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>","References":"<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sakari Ailus ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the stream formatting operator for V4L2VideoFormat instead of\ncalling .toString() manually. As the .toString() member function is a\nwrapper around the stream formatting operator, this makes the code\nslightly more efficient.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\nindex ad7dddde59f1..4b0eb93745cf 100644\n--- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n+++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n@@ -690,7 +690,7 @@ int Vc4CameraData::platformConfigure(const RPi::RPiCameraConfiguration *rpiConfi\n \t\tformat.fourcc = V4L2PixelFormat(V4L2_META_FMT_SENSOR_DATA);\n \t\tformat.planes[0].size = embeddedFormat.size.width * embeddedFormat.size.height;\n \n-\t\tLOG(RPI, Debug) << \"Setting embedded data format \" << format.toString();\n+\t\tLOG(RPI, Debug) << \"Setting embedded data format \" << format;\n \t\tret = unicam_[Unicam::Embedded].dev()->setFormat(&format);\n \t\tif (ret) {\n \t\t\tLOG(RPI, Error) << \"Failed to set format on Unicam embedded: \"\n","prefixes":["PATCH/RFC","25/32"]}