[{"id":28847,"web_url":"https://patchwork.libcamera.org/comment/28847/","msgid":"","date":"2024-03-05T08:19:08","subject":"Re: [PATCH/RFC 14/32] libcamera: camera_sensor: Move related classes\n\tto subdirectory","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Fri, Mar 01, 2024 at 11:21:03PM +0200, Laurent Pinchart wrote:\n> In preparation for adding alternative implementations of the\n> CameraSensor class, move the code to a subdirectory to avoid cluttering\n> the main src/libcamera/ directory.\n>\n> Signed-off-by: Laurent Pinchart \n\nI think you can fast-track patches 14 to 18!\n\nReviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/meson.build | 3 +--\n> src/libcamera/{ => sensor}/camera_sensor.cpp | 0\n> src/libcamera/{ => sensor}/camera_sensor_properties.cpp | 0\n> src/libcamera/sensor/meson.build | 6 ++++++\n> 4 files changed, 7 insertions(+), 2 deletions(-)\n> rename src/libcamera/{ => sensor}/camera_sensor.cpp (100%)\n> rename src/libcamera/{ => sensor}/camera_sensor_properties.cpp (100%)\n> create mode 100644 src/libcamera/sensor/meson.build\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 45f63e932e4f..2e7b0c77e63c 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -7,8 +7,6 @@ libcamera_sources = files([\n> 'camera_controls.cpp',\n> 'camera_lens.cpp',\n> 'camera_manager.cpp',\n> - 'camera_sensor.cpp',\n> - 'camera_sensor_properties.cpp',\n> 'color_space.cpp',\n> 'controls.cpp',\n> 'control_serializer.cpp',\n> @@ -69,6 +67,7 @@ subdir('converter')\n> subdir('ipa')\n> subdir('pipeline')\n> subdir('proxy')\n> +subdir('sensor')\n>\n> null_dep = dependency('', required : false)\n>\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\n> similarity index 100%\n> rename from src/libcamera/camera_sensor.cpp\n> rename to src/libcamera/sensor/camera_sensor.cpp\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> similarity index 100%\n> rename from src/libcamera/camera_sensor_properties.cpp\n> rename to src/libcamera/sensor/camera_sensor_properties.cpp\n> diff --git a/src/libcamera/sensor/meson.build b/src/libcamera/sensor/meson.build\n> new file mode 100644\n> index 000000000000..bf4b131a94b1\n> --- /dev/null\n> +++ b/src/libcamera/sensor/meson.build\n> @@ -0,0 +1,6 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +libcamera_sources += files([\n> + 'camera_sensor.cpp',\n> + 'camera_sensor_properties.cpp',\n> +])\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81494C326B\n\tfor ;\n\tTue, 5 Mar 2024 08:19:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEE1962871;\n\tTue, 5 Mar 2024 09:19:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBD1F62865\n\tfor ;\n\tTue, 5 Mar 2024 09:19:11 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DEDDCC8;\n\tTue, 5 Mar 2024 09:18:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EsrehXM7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709626735;\n\tbh=cjzw3OEznVJMWL/VyQ4Cisfgf9f99IoSLFXntpfS1xg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EsrehXM7gzDjCxQzSQ9YxTcbwTzZ5DM1RPp8q8vvdrHrO4n31Em3gUW1Z6bazSqSQ\n\t1K7pggXFx+fbJAdOJr9y+9qliOxnICOO725zNL7P8ja5Mxbp98RnI9wYaeXfCnMkJ8\n\tH8pJxng5PFWdZj3AHRKoZgyIsfTD8HIMk0rKvsWM=","Date":"Tue, 5 Mar 2024 09:19:08 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Subject":"Re: [PATCH/RFC 14/32] libcamera: camera_sensor: Move related classes\n\tto subdirectory","Message-ID":"","References":"<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>\n\t<20240301212121.9072-15-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240301212121.9072-15-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, Sakari Ailus ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28884,"web_url":"https://patchwork.libcamera.org/comment/28884/","msgid":"<20240306160605.mtdzwiyvzet4545o@jasper>","date":"2024-03-06T16:06:05","subject":"Re: [PATCH/RFC 14/32] libcamera: camera_sensor: Move related classes\n\tto subdirectory","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Fri, Mar 01, 2024 at 11:21:03PM +0200, Laurent Pinchart wrote:\n> In preparation for adding alternative implementations of the\n> CameraSensor class, move the code to a subdirectory to avoid cluttering\n> the main src/libcamera/ directory.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/libcamera/meson.build | 3 +--\n> src/libcamera/{ => sensor}/camera_sensor.cpp | 0\n> src/libcamera/{ => sensor}/camera_sensor_properties.cpp | 0\n> src/libcamera/sensor/meson.build | 6 ++++++\n> 4 files changed, 7 insertions(+), 2 deletions(-)\n> rename src/libcamera/{ => sensor}/camera_sensor.cpp (100%)\n> rename src/libcamera/{ => sensor}/camera_sensor_properties.cpp (100%)\n> create mode 100644 src/libcamera/sensor/meson.build\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 45f63e932e4f..2e7b0c77e63c 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -7,8 +7,6 @@ libcamera_sources = files([\n> 'camera_controls.cpp',\n> 'camera_lens.cpp',\n> 'camera_manager.cpp',\n> - 'camera_sensor.cpp',\n> - 'camera_sensor_properties.cpp',\n> 'color_space.cpp',\n> 'controls.cpp',\n> 'control_serializer.cpp',\n> @@ -69,6 +67,7 @@ subdir('converter')\n> subdir('ipa')\n> subdir('pipeline')\n> subdir('proxy')\n> +subdir('sensor')\n> \n> null_dep = dependency('', required : false)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\n> similarity index 100%\n> rename from src/libcamera/camera_sensor.cpp\n> rename to src/libcamera/sensor/camera_sensor.cpp\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> similarity index 100%\n> rename from src/libcamera/camera_sensor_properties.cpp\n> rename to src/libcamera/sensor/camera_sensor_properties.cpp\n> diff --git a/src/libcamera/sensor/meson.build b/src/libcamera/sensor/meson.build\n> new file mode 100644\n> index 000000000000..bf4b131a94b1\n> --- /dev/null\n> +++ b/src/libcamera/sensor/meson.build\n> @@ -0,0 +1,6 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +libcamera_sources += files([\n> + 'camera_sensor.cpp',\n> + 'camera_sensor_properties.cpp',\n> +])\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDF25BD160\n\tfor ;\n\tWed, 6 Mar 2024 16:06:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A2EA62871;\n\tWed, 6 Mar 2024 17:06:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD87362867\n\tfor ;\n\tWed, 6 Mar 2024 17:06:08 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:dd65:a3ea:5f4d:989a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA40DBD1;\n\tWed, 6 Mar 2024 17:05:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rGt7quSe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709741151;\n\tbh=s1htXI+KvauuCijnO2kzUkicVOAfHZmCwBuMkRtbUOY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rGt7quSeLlL3gGItOmZV0JE7zjpvXyxvz9z2ZjgWWOyIzy/UW6QzIETxFNqIEUmqj\n\tr32kQi3Fdo42lgyY2IbXmdeiiKOJ43UGGK1TtymXfai9NXg4Qzv560YCKGYe8ci0b3\n\tfG2ovVEUqkyHqjDkotsm/bJ4gHPTr9wePwuqsf1Y=","Date":"Wed, 6 Mar 2024 17:06:05 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Subject":"Re: [PATCH/RFC 14/32] libcamera: camera_sensor: Move related classes\n\tto subdirectory","Message-ID":"<20240306160605.mtdzwiyvzet4545o@jasper>","References":"<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>\n\t<20240301212121.9072-15-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240301212121.9072-15-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, Sakari Ailus ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]