{"id":19596,"url":"https://patchwork.libcamera.org/api/patches/19596/?format=json","web_url":"https://patchwork.libcamera.org/patch/19596/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240301212121.9072-6-laurent.pinchart@ideasonboard.com>","date":"2024-03-01T21:20:54","name":"[PATCH/RFC,05/32] libcamera: v4l2_subdevice: Drop V4L2SubdeviceFormat::bitsPerPixel()","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"940535e55bfad49cca98f3ab2c5dbbf6334b5cc0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19596/mbox/","series":[{"id":4197,"url":"https://patchwork.libcamera.org/api/series/4197/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4197","date":"2024-03-01T21:20:49","name":"libcamera: Support the upstream Unicam driver","version":1,"mbox":"https://patchwork.libcamera.org/series/4197/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19596/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19596/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E13EC32C3\n\tfor ;\n\tFri, 1 Mar 2024 21:21:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3404628AC;\n\tFri, 1 Mar 2024 22:21:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5053662871\n\tfor ;\n\tFri, 1 Mar 2024 22:21:27 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46CA1A9A;\n\tFri, 1 Mar 2024 22:21:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HDEkulrM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709328073;\n\tbh=iSk4SkBmskR3lKQlyR7vJ379H0m7K2JrlgNEBsrqmIU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HDEkulrMVhnrb0sfpVPvg1IamBZ1LIVVvZ3+DGM8HI3ne/5av/FCKTr00ACY7J2ds\n\t3GLEMCGKedDtU1ke4x3YqvkUgQ3h3M++03GJpgeI8Fn7zkeNXIlpvSBqmwAP6Xi+Sk\n\tO+GA24+rFRKrzK/WPoYIRCwn7Z9VRZKtMwEAH1iM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH/RFC 05/32] libcamera: v4l2_subdevice: Drop\n\tV4L2SubdeviceFormat::bitsPerPixel()","Date":"Fri, 1 Mar 2024 23:20:54 +0200","Message-ID":"<20240301212121.9072-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>","References":"<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sakari Ailus ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The V4L2SubdeviceFormat::bitsPerPixel() function is just a wrapper\naround a MediaBusFormatInfo lookup. It made sense when the\nMediaBusFormatInfo class was not exposed outside of the compilation\nunit, but is now redundant. Drop it and use MediaBusFormatInfo in the\nonly caller.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n---\n include/libcamera/internal/v4l2_subdevice.h | 1 -\n src/libcamera/camera_sensor.cpp | 3 ++-\n src/libcamera/v4l2_subdevice.cpp | 10 ----------\n 3 files changed, 2 insertions(+), 12 deletions(-)","diff":"diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex c9aa90e00ec8..a87981341d75 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -66,7 +66,6 @@ struct V4L2SubdeviceFormat {\n \tstd::optional colorSpace;\n \n \tconst std::string toString() const;\n-\tuint8_t bitsPerPixel() const;\n };\n \n std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f);\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 0ef78d9c8b0a..55c9c74b10c2 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -1060,7 +1060,8 @@ int CameraSensor::sensorInfo(IPACameraSensorInfo *info) const\n \tret = subdev_->getFormat(pad_, &format);\n \tif (ret)\n \t\treturn ret;\n-\tinfo->bitsPerPixel = format.bitsPerPixel();\n+\n+\tinfo->bitsPerPixel = MediaBusFormatInfo::info(format.mbus_code).bitsPerPixel;\n \tinfo->outputSize = format.size;\n \n \tstd::optional cfa = properties_.get(properties::draft::ColorFilterArrangement);\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 4dce8a81a97d..e896977121d2 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -765,16 +765,6 @@ const std::string V4L2SubdeviceFormat::toString() const\n \treturn ss.str();\n }\n \n-/**\n- * \\brief Retrieve the number of bits per pixel for the V4L2 subdevice format\n- * \\return The number of bits per pixel for the format, or 0 if the format is\n- * not supported\n- */\n-uint8_t V4L2SubdeviceFormat::bitsPerPixel() const\n-{\n-\treturn MediaBusFormatInfo::info(mbus_code).bitsPerPixel;\n-}\n-\n /**\n * \\brief Insert a text representation of a V4L2SubdeviceFormat into an output\n * stream\n","prefixes":["PATCH/RFC","05/32"]}