[{"id":28809,"web_url":"https://patchwork.libcamera.org/comment/28809/","msgid":"","date":"2024-03-01T10:39:37","subject":"Re: [PATCH] guides: pipeline-handler: Fix controlInfo_\n\tinitialization","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch\n\nOn 01/03/24 3:41 pm, Jacopo Mondi wrote:\n> Since commit b48db3c489d3 (\"libcamera: controls: Create ControlInfoMap\n> with ControlIdMap\"), instances of the ControlInfoMap class need to be\n> created with an instance of an unordered_map of ControlId to ControlInfo\n> and with a ControlIdMap instance.\n>\n> The pipeline handler developer guide was never updated to reflect the\n> change. Fix it.\n>\n> Signed-off-by: Jacopo Mondi \n\nLGTM,\n\nReviewed-by: Umang Jain \n\n> ---\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 10b9c75c2a7f..5396eb6d0c56 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -651,7 +651,7 @@ inline in our VividCameraData init:\n> ctrls.emplace(id, info);\n> }\n> \n> - controlInfo_ = std::move(ctrls);\n> + controlInfo_ = ControlInfoMap(std::move(ctrls), controls::controls);\n> \n> The ``properties_`` field is a list of ``ControlId`` instances\n> associated with immutable values, which represent static characteristics that can","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E31DBD160\n\tfor ;\n\tFri, 1 Mar 2024 10:39:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52D2F6286C;\n\tFri, 1 Mar 2024 11:39:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3821E61C8D\n\tfor ;\n\tFri, 1 Mar 2024 11:39:45 +0100 (CET)","from [192.168.1.102] (unknown [103.251.226.76])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E482F22A;\n\tFri, 1 Mar 2024 11:39:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h3KxjA53\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709289571;\n\tbh=NTWa55qWBPzFDZkpkWUuSHwR4cIoOJz/toqMxMAxMQ4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=h3KxjA53xVRT5purDt2xsLJyxHD+kJKG2XVXSyQbhV9v8uI5ZW4bwZqDxyJPSxpmX\n\twWWY1jajbUYCppmRsh850annHS6LwQTH7qut8DtIIGt4tiMiF62ZZj+UMAvHhD9rXc\n\tidOj/4eNKz43o4xewjXqlzjWHLUAnnR68w4dgBRs=","Message-ID":"","Date":"Fri, 1 Mar 2024 16:09:37 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] guides: pipeline-handler: Fix controlInfo_\n\tinitialization","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240301101135.18822-1-jacopo.mondi@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240301101135.18822-1-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28811,"web_url":"https://patchwork.libcamera.org/comment/28811/","msgid":"<20240301104855.GE30104@pendragon.ideasonboard.com>","date":"2024-03-01T10:48:55","subject":"Re: [PATCH] guides: pipeline-handler: Fix controlInfo_\n\tinitialization","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Mar 01, 2024 at 11:11:35AM +0100, Jacopo Mondi wrote:\n> Since commit b48db3c489d3 (\"libcamera: controls: Create ControlInfoMap\n> with ControlIdMap\"), instances of the ControlInfoMap class need to be\n> created with an instance of an unordered_map of ControlId to ControlInfo\n> and with a ControlIdMap instance.\n> \n> The pipeline handler developer guide was never updated to reflect the\n> change. Fix it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 10b9c75c2a7f..5396eb6d0c56 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -651,7 +651,7 @@ inline in our VividCameraData init:\n> ctrls.emplace(id, info);\n> }\n> \n> - controlInfo_ = std::move(ctrls);\n> + controlInfo_ = ControlInfoMap(std::move(ctrls), controls::controls);\n> \n> The ``properties_`` field is a list of ``ControlId`` instances\n> associated with immutable values, which represent static characteristics that can","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF98FBE080\n\tfor ;\n\tFri, 1 Mar 2024 10:48:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8652862873;\n\tFri, 1 Mar 2024 11:48:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6C2162806\n\tfor ;\n\tFri, 1 Mar 2024 11:48:53 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8ACE2673;\n\tFri, 1 Mar 2024 11:48:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YgMzF9up\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709290119;\n\tbh=oUcBf7H2SGSjb2xGL74wvEBChy3KRqmGJCoX1GgYUjI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YgMzF9upAKD6HXVnvE6z0KJjoA+XJh0qOv+vaiaB389rOinmU21hI1PwIngcHVe1y\n\tEdHNqH/X2YpVFj7RaCk5JacFagdl/oTFVCrJibnqjl4llSpzCG9+Ag0XbYC14iY4QO\n\tT/BjGXx2q5sI96MMjERgsAjt1DEydMUYoPAAYCtA=","Date":"Fri, 1 Mar 2024 12:48:55 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Subject":"Re: [PATCH] guides: pipeline-handler: Fix controlInfo_\n\tinitialization","Message-ID":"<20240301104855.GE30104@pendragon.ideasonboard.com>","References":"<20240301101135.18822-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240301101135.18822-1-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]