[{"id":28822,"web_url":"https://patchwork.libcamera.org/comment/28822/","msgid":"<87h6hmauiw.fsf@redhat.com>","date":"2024-03-04T15:25:43","subject":"Re: [PATCH v4 07/18] libcamera: software_isp: Add Debayer base class","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hans de Goede writes:\n\n> Add a base class for debayer implementations. This is intended to be\n> suitable for both GPU (or otherwise) accelerated debayer implementations\n> as well as CPU based debayering.\n>\n> Doxygen documentation by Dennis Bonke.\n>\n> Tested-by: Bryan O'Donoghue # sc8280xp Lenovo x13s\n> Tested-by: Pavel Machek \n> Reviewed-by: Pavel Machek \n> Co-developed-by: Dennis Bonke \n> Signed-off-by: Dennis Bonke \n> Co-developed-by: Andrey Konovalov \n> Signed-off-by: Andrey Konovalov \n> Signed-off-by: Hans de Goede \n\nWith one change below:\n\nReviewed-by: Milan Zamazal \n\n> ---\n> Changes in v3:\n> - Move debayer.h to src/libcamera/software_isp/\n> - Move class documentation (only a brief for now) to .cpp file\n> ---\n> .../internal/software_isp/debayer_params.h | 48 ++++++++\n> .../internal/software_isp/meson.build | 1 +\n> src/libcamera/software_isp/debayer.cpp | 29 +++++\n> src/libcamera/software_isp/debayer.h | 104 ++++++++++++++++++\n> src/libcamera/software_isp/meson.build | 1 +\n> 5 files changed, 183 insertions(+)\n> create mode 100644 include/libcamera/internal/software_isp/debayer_params.h\n> create mode 100644 src/libcamera/software_isp/debayer.cpp\n> create mode 100644 src/libcamera/software_isp/debayer.h\n>\n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> new file mode 100644\n> index 00000000..98e7fc92\n> --- /dev/null\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -0,0 +1,48 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2023, Red Hat Inc.\n> + *\n> + * Authors:\n> + * Hans de Goede \n> + *\n> + * swstats.h - software statistics base class\n\nForgotten update of a copy from a different file.\n\n[...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21D66C326B\n\tfor ;\n\tMon, 4 Mar 2024 15:25:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71D12627FC;\n\tMon, 4 Mar 2024 16:25:51 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58A8C627FC\n\tfor ;\n\tMon, 4 Mar 2024 16:25:49 +0100 (CET)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-116-X4ZTQGUnNVaLQWO0pO-fDg-1; Mon, 04 Mar 2024 10:25:46 -0500","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-412b4744e9dso28243365e9.3\n\tfor ;\n\tMon, 04 Mar 2024 07:25:46 -0800 (PST)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tay12-20020a05600c1e0c00b00412e9162f19sm652363wmb.20.2024.03.04.07.25.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 04 Mar 2024 07:25:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Vm04CyVc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1709565947;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=upCGM51kJvEMOwkq0UtOogOSa38Pgj5nd3F0AH6Wv9s=;\n\tb=Vm04CyVc2R1biD4NKAmUhGhFyOhoG4MUhsti4pyANYkdEHw1akb6gAv757Jt+IakX/5PS2\n\tCQjQNpQCtBzKRxSEdj0WpCnIFJTQGjYfg1IaDZCpM43afpM/a0Ev8LX6ZnjpIDRsQ/Mgq1\n\tXI0PA1+6/3XQ6WmWIotD1Tq4C8OF1wc=","X-MC-Unique":"X4ZTQGUnNVaLQWO0pO-fDg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1709565945; x=1710170745;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=upCGM51kJvEMOwkq0UtOogOSa38Pgj5nd3F0AH6Wv9s=;\n\tb=LXAccVT/BvEeqeJ9VaCBLFOxMOxU7bmEgAKX2brjP6eiXyzRIQddP0HP50nBB7kNzu\n\tAHAcQTBCRDUUCer40eiHVim+wozu/dSKIsEckZtOIHbQ7dSe0pXBTvpYfl3F+WUMDYb7\n\tojWplGgC4GuC094ECmHMBvWuCz/WyFrouJGkuhp7LZmVAEEzD14TzuWdjhS0h5VU5N+G\n\tPZQolVm8phny+b9QoQ9yWgOcuAUMm/wjOfd1MqUjb1pjCOJqvGpQeSltYch7wBA+Y1wo\n\t88OaEVhwMsZaK1f0Qx+zxWn1ywhK0Tf930KkUDrhp4PdIZ3cv0v/z9+8ubRma/QsNzyI\n\t9OEw==","X-Gm-Message-State":"AOJu0YykGpdPGgjwh2D6zYHhf3cGixmuldYKOAXBWxPMwJ0IiHciJZOO\n\thqVMNyhKzLuYfSa0qtqQXh+BKcu/X0pRvjozq1DLeR5JXhFqihYPBlr4JU7i/U1ZgSpJ4wgwXVf\n\t9NE2Fdd1tkLQiGZ0bDjqwX7pg2rx+m56LHvBl7LtW5rer4JkVmD63TA8mS5Iq+9KtEkRbzDU=","X-Received":["by 2002:a05:600c:458f:b0:412:bfa1:2139 with SMTP id\n\tr15-20020a05600c458f00b00412bfa12139mr6731634wmo.37.1709565945187; \n\tMon, 04 Mar 2024 07:25:45 -0800 (PST)","by 2002:a05:600c:458f:b0:412:bfa1:2139 with SMTP id\n\tr15-20020a05600c458f00b00412bfa12139mr6731620wmo.37.1709565944889; \n\tMon, 04 Mar 2024 07:25:44 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGJOdMwZ33W2kxLEw8gkftwzbIXLaVK+W92cLH0ILdFoNGg0Qxx+5Nuph6DFB2svdXLBzAe2Q==","From":"Milan Zamazal ","To":"Hans de Goede ","Subject":"Re: [PATCH v4 07/18] libcamera: software_isp: Add Debayer base class","In-Reply-To":"<20240229183654.7206-8-hdegoede@redhat.com> (Hans de Goede's\n\tmessage of \"Thu, 29 Feb 2024 19:36:18 +0100\")","References":"<20240229183654.7206-1-hdegoede@redhat.com>\n\t<20240229183654.7206-8-hdegoede@redhat.com>","Date":"Mon, 04 Mar 2024 16:25:43 +0100","Message-ID":"<87h6hmauiw.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Maxime Ripard , libcamera-devel@lists.libcamera.org, \n\tPavel Machek ,\n\tBryan O'Donoghue , \n\tDennis Bonke ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]