[{"id":28797,"web_url":"https://patchwork.libcamera.org/comment/28797/","msgid":"<20240228173352.GB1659@pendragon.ideasonboard.com>","date":"2024-02-28T17:33:52","subject":"Re: [PATCH] libcamera: controls: Fix typo on thermal","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Feb 28, 2024 at 05:27:15PM +0000, Kieran Bingham wrote:\n> The documentation for the SensorTemperature control has a spelling\n> mistake for thermal.\n> \n> Fix it.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/control_ids_core.yaml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index f2f783342a1b..7c0576d82be8 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -449,7 +449,7 @@ controls:\n> range of reported temperatures is device dependent.\n> \n> The SensorTemperature control will only be returned in metadata if a\n> - themal sensor is present.\n> + thermal sensor is present.\n> \n> - SensorTimestamp:\n> type: int64_t","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB161BE080\n\tfor ;\n\tWed, 28 Feb 2024 17:33:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E54962868;\n\tWed, 28 Feb 2024 18:33:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF05061C94\n\tfor ;\n\tWed, 28 Feb 2024 18:33:50 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1ACC6B3;\n\tWed, 28 Feb 2024 18:33:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EjcTe7Iq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709141618;\n\tbh=JIaX8tun4oa2WPO0HEr7fQ5HgjIm9//TJ74wzp4rtGk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EjcTe7IqYXQaPGCPGUneWE8S7plNnIZEWw8Pq7mifrFZCIV5s7uKOR6rq0PCW9sFL\n\tGEUM+6wulRG0QCewMSpeNQlz+x4IkK7WnscMaEX/W9HQZuddzFpCb8YJGZSOUPoSdO\n\t91igwevTfYXH938aWQF5pF4OmMLU99WUleWaVcbo=","Date":"Wed, 28 Feb 2024 19:33:52 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Subject":"Re: [PATCH] libcamera: controls: Fix typo on thermal","Message-ID":"<20240228173352.GB1659@pendragon.ideasonboard.com>","References":"<20240228172715.3766315-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240228172715.3766315-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28803,"web_url":"https://patchwork.libcamera.org/comment/28803/","msgid":"","date":"2024-02-29T14:02:16","subject":"Re: [PATCH] libcamera: controls: Fix typo on thermal","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn 28/02/24 10:57 pm, Kieran Bingham wrote:\n> The documentation for the SensorTemperature control has a spelling\n> mistake for thermal.\n>\n> Fix it.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/control_ids_core.yaml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index f2f783342a1b..7c0576d82be8 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -449,7 +449,7 @@ controls:\n> range of reported temperatures is device dependent.\n> \n> The SensorTemperature control will only be returned in metadata if a\n> - themal sensor is present.\n> + thermal sensor is present.\n> \n> - SensorTimestamp:\n> type: int64_t","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D9A2BE080\n\tfor ;\n\tThu, 29 Feb 2024 14:02:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D79286286C;\n\tThu, 29 Feb 2024 15:02:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 950ED61C96\n\tfor ;\n\tThu, 29 Feb 2024 15:02:24 +0100 (CET)","from [192.168.1.102] (unknown [103.251.226.76])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13385673;\n\tThu, 29 Feb 2024 15:02:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wfWx16oi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709215331;\n\tbh=nGg9GOvM7Kt3e8RWjhivVJpL2dhGm0crZwd6EgFGlRg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=wfWx16oi3OCFAoXbh3UG5MjWdRNGxOMv7f0ldVSV4HnKzydQiWa2i06cZjDKpqbhU\n\tS5kxR1FyK9VINJzOtBEJyrnzR5AYBaNmzUEbxHKGQzAA+70F9HTgc68QrOrxgJyDN/\n\tcDPBkuSZ3pOQyTgsPG5RJz3YPPgps7hgIoIRxytg=","Message-ID":"","Date":"Thu, 29 Feb 2024 19:32:16 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: controls: Fix typo on thermal","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20240228172715.3766315-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240228172715.3766315-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]