[{"id":2633,"web_url":"https://patchwork.libcamera.org/comment/2633/","msgid":"<20190910094418.GD4799@pendragon.ideasonboard.com>","date":"2019-09-10T09:44:18","subject":"Re: [libcamera-devel] [PATCH 2/3] test: process: Initialise member\n\tvariables","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Sep 10, 2019 at 10:04:17AM +0100, Kieran Bingham wrote:\n> The ProcessTest() declares member variables but leaves them unitialised.\n> Set them appropriately from the constructor.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  test/process/process_test.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\n> index 701f156b5053..f3cabe0a36c7 100644\n> --- a/test/process/process_test.cpp\n> +++ b/test/process/process_test.cpp\n> @@ -35,6 +35,7 @@ class ProcessTest : public Test\n>  {\n>  public:\n>  \tProcessTest()\n> +\t\t: exitStatus_(Process::NotExited), exitCode_(-1)\n>  \t{\n>  \t}\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CAD760BCF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Sep 2019 11:44:24 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [148.69.85.38])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0F9C2F9;\n\tTue, 10 Sep 2019 11:44:23 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568108664;\n\tbh=LsqMACvbxyJMginuYELSIi1U1UFf9wJuD/Ie863sSMo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KYYm9mTNOa7uhzYOdphfkFt/2IIUflVbAzYvm1lDbFtkbwuCnkNBOlsD08Ia1mNUr\n\t+kJJ2WndfbFFcik2Tn2Rshs72/QS5+8HTJve3bQoDzUvwoBbW5XauDUpcpkxr4jIun\n\tQTi28Y4rBnpHejCqWnCH5qdZegq6xdsAOrUhd1L4=","Date":"Tue, 10 Sep 2019 12:44:18 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190910094418.GD4799@pendragon.ideasonboard.com>","References":"<20190910090418.30502-1-kieran.bingham@ideasonboard.com>\n\t<20190910090418.30502-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190910090418.30502-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/3] test: process: Initialise member\n\tvariables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 10 Sep 2019 09:44:24 -0000"}}]