[{"id":28775,"web_url":"https://patchwork.libcamera.org/comment/28775/","msgid":"<2i42u4daitvef3ckad6bwixrokkx2mmujcwfwsz43dh6tbwsuz@z5pcdjlxbd7j>","date":"2024-02-28T08:20:02","subject":"Re: [PATCH 1/9] libcamera: v4l2_subdevice: Rename\n\tV4L2SubdeviceFormatInfo","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Tue, Feb 27, 2024 at 04:09:45PM +0200, Laurent Pinchart wrote:\n> The V4L2SubdeviceFormatInfo structure contains information about a media\n> bus format, not a V4L2 subdevice format. Rename it to MediaBusFormatInfo\n> to clarify its purpose. Rename the formatInfoMap map accordingly.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 22 +++++++++++-----------\n> 1 file changed, 11 insertions(+), 11 deletions(-)\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 6d0785b7b484..6c1df7812f07 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -39,24 +39,24 @@ LOG_DECLARE_CATEGORY(V4L2)\n> namespace {\n>\n> /*\n> - * \\struct V4L2SubdeviceFormatInfo\n> + * \\struct MediaBusFormatInfo\n> * \\brief Information about media bus formats\n> * \\param bitsPerPixel Bits per pixel\n> * \\param name Name of MBUS format\n> * \\param colourEncoding Type of colour encoding\n> */\n> -struct V4L2SubdeviceFormatInfo {\n> +struct MediaBusFormatInfo {\n> \tunsigned int bitsPerPixel;\n> \tconst char *name;\n> \tPixelFormatInfo::ColourEncoding colourEncoding;\n> };\n>\n> /*\n> - * \\var formatInfoMap\n> - * \\brief A map that associates V4L2SubdeviceFormatInfo struct to V4L2 media\n> + * \\var mediaBusFormatInfo\n> + * \\brief A map that associates MediaBusFormatInfo struct to V4L2 media\n> * bus codes\n> */\n> -const std::map formatInfoMap = {\n> +const std::map mediaBusFormatInfo = {\n> \t/* This table is sorted to match the order in linux/media-bus-format.h */\n> \t{ MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> @@ -237,8 +237,8 @@ const std::string V4L2SubdeviceFormat::toString() const\n> */\n> uint8_t V4L2SubdeviceFormat::bitsPerPixel() const\n> {\n> -\tconst auto it = formatInfoMap.find(mbus_code);\n> -\tif (it == formatInfoMap.end()) {\n> +\tconst auto it = mediaBusFormatInfo.find(mbus_code);\n> +\tif (it == mediaBusFormatInfo.end()) {\n> \t\tLOG(V4L2, Error) << \"No information available for format '\"\n> \t\t\t\t << *this << \"'\";\n> \t\treturn 0;\n> @@ -258,9 +258,9 @@ std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f)\n> {\n> \tout << f.size << \"-\";\n>\n> -\tconst auto it = formatInfoMap.find(f.mbus_code);\n> +\tconst auto it = mediaBusFormatInfo.find(f.mbus_code);\n>\n> -\tif (it == formatInfoMap.end())\n> +\tif (it == mediaBusFormatInfo.end())\n> \t\tout << utils::hex(f.mbus_code, 4);\n> \telse\n> \t\tout << it->second.name;\n> @@ -511,8 +511,8 @@ std::optional V4L2Subdevice::toColorSpace(const v4l2_mbus_framefmt &\n> \t\treturn std::nullopt;\n>\n> \tPixelFormatInfo::ColourEncoding colourEncoding;\n> -\tauto iter = formatInfoMap.find(format.code);\n> -\tif (iter != formatInfoMap.end()) {\n> +\tauto iter = mediaBusFormatInfo.find(format.code);\n> +\tif (iter != mediaBusFormatInfo.end()) {\n> \t\tcolourEncoding = iter->second.colourEncoding;\n> \t} else {\n> \t\tLOG(V4L2, Warning)\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4126FBD80A\n\tfor ;\n\tWed, 28 Feb 2024 08:20:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C90062868;\n\tWed, 28 Feb 2024 09:20:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79E81627F9\n\tfor ;\n\tWed, 28 Feb 2024 09:20:06 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1E6B672;\n\tWed, 28 Feb 2024 09:19:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BQok0WnD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709108393;\n\tbh=90BkyH6/++9WLMGSDlp1MPcPll1s9qvlk76PSUVsG0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BQok0WnDra2sf02JFC71p9tIKLJY73r7AeaOb08EEmx/y1/NtgSQ+zTRBKlUnpCi0\n\t9ivdrcRauWpHSXkHZwLmJJXqaHAI1pmcpXlfpsLXbOaVI8dL30mw66gwN61qUMA7ol\n\tYC9nywZNb+Di5J+vRrJl36zq6ERW1Hc+UBunqd1k=","Date":"Wed, 28 Feb 2024 09:20:02 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Subject":"Re: [PATCH 1/9] libcamera: v4l2_subdevice: Rename\n\tV4L2SubdeviceFormatInfo","Message-ID":"<2i42u4daitvef3ckad6bwixrokkx2mmujcwfwsz43dh6tbwsuz@z5pcdjlxbd7j>","References":"<20240227140953.26093-1-laurent.pinchart@ideasonboard.com>\n\t<20240227140953.26093-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240227140953.26093-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]