[{"id":28751,"web_url":"https://patchwork.libcamera.org/comment/28751/","msgid":"<20240227122943.GB3419@pendragon.ideasonboard.com>","date":"2024-02-27T12:29:43","subject":"Re: [PATCH 2/2] utils: checkstyle.py: Update LogCategoryChecker\n\tregexp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Tue, Feb 27, 2024 at 01:14:47PM +0100, Milan Zamazal wrote:\n> The regexp uses obsolete form, update it to mute the warning emitted by Python\n> 3.12:\n> \n> SyntaxWarning: invalid escape sequence '\\('\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index af553cfd..fb03dc34 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -588,7 +588,7 @@ class IncludeChecker(StyleChecker):\n> \n> \n> class LogCategoryChecker(StyleChecker):\n> - log_regex = re.compile('\\\\bLOG\\((Debug|Info|Warning|Error|Fatal)\\)')\n> + log_regex = re.compile(r'\\bLOG\\((Debug|Info|Warning|Error|Fatal)\\)')\n> patterns = ('*.cpp',)\n> \n> def __init__(self, content):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95D52BD80A\n\tfor ;\n\tTue, 27 Feb 2024 12:29:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F77D62868;\n\tTue, 27 Feb 2024 13:29:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18D5562806\n\tfor ;\n\tTue, 27 Feb 2024 13:29:41 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ECFBA8C;\n\tTue, 27 Feb 2024 13:29:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UE2PFtZb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709036969;\n\tbh=hvFbJE7ViVUnPwXsYcBABwSHedMNI208hup9iFvRZA4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UE2PFtZbsXJ03teONJbXdDVMEevLZiTvNZmNQec6j+z0qGhEqYho0VdbsvaXXlIn9\n\tpnYVkYQt+2FNY/yGOARO5HEwxIYmcQpjSYExbqv0cYFB6zIZlhYeiSvMpwhH9RzJ4k\n\tYjDS5HBUUeEz6DpSz2ytgbITooTPm/F6STD2a6Qw=","Date":"Tue, 27 Feb 2024 14:29:43 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Subject":"Re: [PATCH 2/2] utils: checkstyle.py: Update LogCategoryChecker\n\tregexp","Message-ID":"<20240227122943.GB3419@pendragon.ideasonboard.com>","References":"<20240227121448.656200-1-mzamazal@redhat.com>\n\t<20240227121448.656200-3-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240227121448.656200-3-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28756,"web_url":"https://patchwork.libcamera.org/comment/28756/","msgid":"<170903946610.1011926.1567747299696181425@ping.linuxembedded.co.uk>","date":"2024-02-27T13:11:06","subject":"Re: [PATCH 2/2] utils: checkstyle.py: Update LogCategoryChecker\n\tregexp","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-02-27 12:14:47)\n> The regexp uses obsolete form, update it to mute the warning emitted by Python\n> 3.12:\n> \n> SyntaxWarning: invalid escape sequence '\\('\n> \n> Signed-off-by: Milan Zamazal \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index af553cfd..fb03dc34 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -588,7 +588,7 @@ class IncludeChecker(StyleChecker):\n> \n> \n> class LogCategoryChecker(StyleChecker):\n> - log_regex = re.compile('\\\\bLOG\\((Debug|Info|Warning|Error|Fatal)\\)')\n> + log_regex = re.compile(r'\\bLOG\\((Debug|Info|Warning|Error|Fatal)\\)')\n> patterns = ('*.cpp',)\n> \n> def __init__(self, content):\n> -- \n> 2.42.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29317BD80A\n\tfor ;\n\tTue, 27 Feb 2024 13:11:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EF76627FC;\n\tTue, 27 Feb 2024 14:11:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3A00627FC\n\tfor ;\n\tTue, 27 Feb 2024 14:11:08 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B39EA8D4;\n\tTue, 27 Feb 2024 14:10:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gxo8CSHM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709039456;\n\tbh=BGqePvMM0grT1EnE62TWnZZkCpgcbkq89VjZCnaKC0Y=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=gxo8CSHM/42QtrSIJnviS1Hg66OOMdRkib+5SgrfmJimthVJYBdxMjDWtCuUZuQKF\n\tHVTRyBigtDwvSTazYiPs2bAl/z6R6wrpWho5uq6eXLePSdJ772z01klBYxrmtH/Dfm\n\tAMKYZR2c7JCeGcOLAfDIZIgRWq1LGamqo1+KpRDI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240227121448.656200-3-mzamazal@redhat.com>","References":"<20240227121448.656200-1-mzamazal@redhat.com>\n\t<20240227121448.656200-3-mzamazal@redhat.com>","Subject":"Re: [PATCH 2/2] utils: checkstyle.py: Update LogCategoryChecker\n\tregexp","From":"Kieran Bingham ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Tue, 27 Feb 2024 13:11:06 +0000","Message-ID":"<170903946610.1011926.1567747299696181425@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]