[{"id":28750,"web_url":"https://patchwork.libcamera.org/comment/28750/","msgid":"<20240227122826.GA3419@pendragon.ideasonboard.com>","date":"2024-02-27T12:28:26","subject":"Re: [PATCH 1/2] utils: checkstyle.py: Don't presume python3 location","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Tue, Feb 27, 2024 at 01:14:46PM +0100, Milan Zamazal wrote:\n> python3 binary may be present in a location other than /usr/bin/.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 836ea80f..af553cfd 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -1,4 +1,4 @@\n> -#!/usr/bin/python3\n> +#!/usr/bin/env python3\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Copyright (C) 2018, Google Inc.\n> #","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4793CBD80A\n\tfor ;\n\tTue, 27 Feb 2024 12:28:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB53E62864;\n\tTue, 27 Feb 2024 13:28:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 429AA62806\n\tfor ;\n\tTue, 27 Feb 2024 13:28:24 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF00B8C;\n\tTue, 27 Feb 2024 13:28:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hAHlECYy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709036892;\n\tbh=O+i6yrQEY3i6dk6FSoq97/7HGjnFSOdayefDs9y6FdA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hAHlECYyd/3znqQhhCuRm8xB92YEtonqWyOcaqO9zeGtsS26EhbJ0YylfQjvGvmqZ\n\tACiQNONa/360k9SlQdFPyXA1ScS4fur87j1vpYbdYBEfMcAYuz1NB+00MO2kDmySkF\n\tCj7gAuCj70hj0buxSq/1R+Pj7kMzCN6MTPbX3JFQ=","Date":"Tue, 27 Feb 2024 14:28:26 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Subject":"Re: [PATCH 1/2] utils: checkstyle.py: Don't presume python3 location","Message-ID":"<20240227122826.GA3419@pendragon.ideasonboard.com>","References":"<20240227121448.656200-1-mzamazal@redhat.com>\n\t<20240227121448.656200-2-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240227121448.656200-2-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28755,"web_url":"https://patchwork.libcamera.org/comment/28755/","msgid":"<170903944852.1011926.17841937441481488338@ping.linuxembedded.co.uk>","date":"2024-02-27T13:10:48","subject":"Re: [PATCH 1/2] utils: checkstyle.py: Don't presume python3 location","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-02-27 12:14:46)\n> python3 binary may be present in a location other than /usr/bin/.\n> \n> Signed-off-by: Milan Zamazal \nReviewed-by: Kieran Bingham \n\n> ---\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 836ea80f..af553cfd 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -1,4 +1,4 @@\n> -#!/usr/bin/python3\n> +#!/usr/bin/env python3\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Copyright (C) 2018, Google Inc.\n> #\n> -- \n> 2.42.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29C2EBD80A\n\tfor ;\n\tTue, 27 Feb 2024 13:10:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E998162864;\n\tTue, 27 Feb 2024 14:10:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 869B5627FC\n\tfor ;\n\tTue, 27 Feb 2024 14:10:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81B3D8D4;\n\tTue, 27 Feb 2024 14:10:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lZOZBOaF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709039439;\n\tbh=1yIGPZqclkGkhPUrK9miVtA6iGlqJqhZx7eRb9Gs9/0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=lZOZBOaF2U1P4GS+x6+HZQfr1LKW67adx6m4iec/XybgxucJtfwftl/sJV/To4k6N\n\t3iCopw9+p7au5p61dg183pf7A+xh1cDOjf2RTU15m+V39qdoytH9d28UFqoJtzlLvG\n\tlYOwIGTJBULnq4Z9sj42lM0DmWFqY4WeWA3RbN8g=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240227121448.656200-2-mzamazal@redhat.com>","References":"<20240227121448.656200-1-mzamazal@redhat.com>\n\t<20240227121448.656200-2-mzamazal@redhat.com>","Subject":"Re: [PATCH 1/2] utils: checkstyle.py: Don't presume python3 location","From":"Kieran Bingham ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Tue, 27 Feb 2024 13:10:48 +0000","Message-ID":"<170903944852.1011926.17841937441481488338@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]