[{"id":28748,"web_url":"https://patchwork.libcamera.org/comment/28748/","msgid":"<3dl4tjjzezujrar7dzqzkzg4dx6pj5y7yzsuvjq3qk6fgez4ao@eajx3zxxljdm>","date":"2024-02-27T10:16:02","subject":"Re: [PATCH] libcamera: formats: Fix typos in PixelFormatInfo\n\tdocumentation","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Tue, Feb 27, 2024 at 12:10:22PM +0200, Laurent Pinchart wrote:\n> The PixelFormatInfo documentation has typo. Fix two of them.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/formats.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 8a606a7c37f1..6a3b89a38cc0 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -33,7 +33,7 @@ LOG_DEFINE_CATEGORY(Formats)\n> * used in pipeline handlers.\n> *\n> * \\var PixelFormatInfo::name\n> - * \\brief The format name as a human-readable string, used as the test\n> + * \\brief The format name as a human-readable string, used as the text\n> * representation of the PixelFormat\n> *\n> * \\var PixelFormatInfo::format\n> @@ -49,9 +49,9 @@ LOG_DEFINE_CATEGORY(Formats)\n> * \\var PixelFormatInfo::bitsPerPixel\n> * \\brief The average number of bits per pixel\n> *\n> - * The number per pixel averages the total number of bits for all colour\n> - * components over the whole image, excluding any padding bits or padding\n> - * pixels.\n> + * The number of bits per pixel averages the total number of bits for all\n> + * colour components over the whole image, excluding any padding bits or\n> + * padding pixels.\n> *\n> * For formats that store pixels with bit padding within words, only the\n> * effective bits are taken into account. For instance, 12-bit Bayer data\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F8A8BD80A\n\tfor ;\n\tTue, 27 Feb 2024 10:16:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C7B362806;\n\tTue, 27 Feb 2024 11:16:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C688F627FA\n\tfor ;\n\tTue, 27 Feb 2024 11:16:06 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1F978C;\n\tTue, 27 Feb 2024 11:15:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rXPBZZrd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709028954;\n\tbh=akSaakdxOsjWnNce1E4nUrLKycIIYapao9NaR1HULTM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rXPBZZrdMrRwl2b58VosLzJhCRuOAoNTI2JPDltUgDPLfSutMPZKLiW8fvJMLUGz0\n\tftQvpDpgU06uZ2Ngvxo4ETHOM4nH6mmqDQvl0p91SjkzVZ9ty36PAmSoK4L56rDPHK\n\tihecgUZhge4+f0ATpoW3z4YQhyLRrVid/nqlWMb4=","Date":"Tue, 27 Feb 2024 11:16:02 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Subject":"Re: [PATCH] libcamera: formats: Fix typos in PixelFormatInfo\n\tdocumentation","Message-ID":"<3dl4tjjzezujrar7dzqzkzg4dx6pj5y7yzsuvjq3qk6fgez4ao@eajx3zxxljdm>","References":"<20240227101022.4795-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240227101022.4795-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28879,"web_url":"https://patchwork.libcamera.org/comment/28879/","msgid":"<20240306144510.x3ol5zc2zhddhyj2@jasper>","date":"2024-03-06T14:45:10","subject":"Re: [PATCH] libcamera: formats: Fix typos in PixelFormatInfo\n\tdocumentation","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Feb 27, 2024 at 12:10:22PM +0200, Laurent Pinchart wrote:\n> The PixelFormatInfo documentation has typo. Fix two of them.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug\n\nCheers,\nStefan\n\n> ---\n> src/libcamera/formats.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 8a606a7c37f1..6a3b89a38cc0 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -33,7 +33,7 @@ LOG_DEFINE_CATEGORY(Formats)\n> * used in pipeline handlers.\n> *\n> * \\var PixelFormatInfo::name\n> - * \\brief The format name as a human-readable string, used as the test\n> + * \\brief The format name as a human-readable string, used as the text\n> * representation of the PixelFormat\n> *\n> * \\var PixelFormatInfo::format\n> @@ -49,9 +49,9 @@ LOG_DEFINE_CATEGORY(Formats)\n> * \\var PixelFormatInfo::bitsPerPixel\n> * \\brief The average number of bits per pixel\n> *\n> - * The number per pixel averages the total number of bits for all colour\n> - * components over the whole image, excluding any padding bits or padding\n> - * pixels.\n> + * The number of bits per pixel averages the total number of bits for all\n> + * colour components over the whole image, excluding any padding bits or\n> + * padding pixels.\n> *\n> * For formats that store pixels with bit padding within words, only the\n> * effective bits are taken into account. For instance, 12-bit Bayer data\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7444C0F2A\n\tfor ;\n\tWed, 6 Mar 2024 14:45:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2605262867;\n\tWed, 6 Mar 2024 15:45:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C890961C8F\n\tfor ;\n\tWed, 6 Mar 2024 15:45:12 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:dd65:a3ea:5f4d:989a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AB7122A;\n\tWed, 6 Mar 2024 15:44:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t7zCYoiE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709736295;\n\tbh=b53dWyibOe6t+0OhgQtR1QRpEqOY0e3dLVbKMQ7xi4s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t7zCYoiE5glIivgQe7F+mjdiJhmiWiFwAQ/1foYLB5w+SdeaBQZZHwa6NL4ViyV+J\n\tKVJnxuPdjxZlY7MNeWdyyC6Q0ccYZ83rsvYrJvnaeYePjHgoBkl1R0Us0yseA0QWeM\n\tkfTlL7RvpQpM6cbUAKqyvyJV2ZKzdnfHmk7bJXbA=","Date":"Wed, 6 Mar 2024 15:45:10 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Subject":"Re: [PATCH] libcamera: formats: Fix typos in PixelFormatInfo\n\tdocumentation","Message-ID":"<20240306144510.x3ol5zc2zhddhyj2@jasper>","References":"<20240227101022.4795-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240227101022.4795-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]