[{"id":28744,"web_url":"https://patchwork.libcamera.org/comment/28744/","msgid":"","date":"2024-02-27T07:34:19","subject":"Re: [PATCH] android: camera_device: Save capture settings\n\tunconditionally","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi,\n\nOn Tue, Feb 27, 2024 at 10:13:20AM +0800, Fang Hui wrote:\n> If not, it will be deferred to the next frame,\n\nI proposed an extended commit message in the previous review. If\nignored on purpose, could you suggest me how it could be improved.\nJust this one line is too short and not explicative imo\n\n> as there's a bug assigned to this issue\n> https://bugs.libcamera.org/show_bug.cgi?id=210\n\nWhat I meant was to add:\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=210\n>\n> Signed-off-by: Fang Hui \n\nBefore the Signed-off-by tag\n\n> ---\n> src/android/camera_device.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 25cedd44..d45ed1a5 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \t */\n> \tif (camera3Request->settings)\n> \t\tlastSettings_ = camera3Request->settings;\n> -\telse\n> -\t\tdescriptor->settings_ = lastSettings_;\n> +\n> +\tdescriptor->settings_ = lastSettings_;\n\nI still think you should re-initialize lastSettings_ as I proposed in\nthe review of the previous version. Was it left out intentionally\nbecause you think it's not needed ? Could you explain why ?\n\nAs I've said, with your ack, I could have made the changes I proposed\nbefore applying the patch, but as you sent a new version I deduce you\ndisagree with the proposed changes ?\n\n>\n> \tLOG(HAL, Debug) << \"Queueing request \" << descriptor->request_->cookie()\n> \t\t\t<< \" with \" << descriptor->buffers_.size() << \" streams\";\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D624EBD80A\n\tfor ;\n\tTue, 27 Feb 2024 07:34:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 363E4627F9;\n\tTue, 27 Feb 2024 08:34:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6944961C94\n\tfor ;\n\tTue, 27 Feb 2024 08:34:22 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DC798C;\n\tTue, 27 Feb 2024 08:34:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CI3riTgS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709019250;\n\tbh=SlMkBh4WG0hRCqwpUkoqD80WbET9xPeX94YjXIyBTL0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CI3riTgS3UC3/5oct4rXYKvKlQJKWASCknrgKef9PARP3rGflyTAEAB8++CGMC14P\n\toqCqNi1BpH6vee/AX/4uLerxi13NRrM/uFlf3EFtUhjYML2MLqcDJd8BuzuK/wzAR2\n\tm8A2s1QcqUd9MbNT5oyKNMGY3QqxTLHpz++FPvCA=","Date":"Tue, 27 Feb 2024 08:34:19 +0100","From":"Jacopo Mondi ","To":"Fang Hui ","Subject":"Re: [PATCH] android: camera_device: Save capture settings\n\tunconditionally","Message-ID":"","References":"<20240227021320.3443016-1-hui.fang@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240227021320.3443016-1-hui.fang@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, biomifang118@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28773,"web_url":"https://patchwork.libcamera.org/comment/28773/","msgid":"","date":"2024-02-28T05:37:06","subject":"Re: [EXT] Re: [PATCH] android: camera_device: Save capture settings\n\tunconditionally","submitter":{"id":186,"url":"https://patchwork.libcamera.org/api/people/186/","name":"Fang Hui","email":"hui.fang@nxp.com"},"content":"Hi, Jacopo\n\nSorry for inconvenience. I just updated patches in the previous email \"[PATCH] android: camera_device: The first valid settings should be saved\".\nLet's go back to this one.\n\nYesterday, after I refined patch, I still used \"git send-email\", so miss generated this email.\n\nBRs,\nFang Hui","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60EDEBD80A\n\tfor ;\n\tWed, 28 Feb 2024 05:37:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E41D62867;\n\tWed, 28 Feb 2024 06:37:10 +0100 (CET)","from EUR04-VI1-obe.outbound.protection.outlook.com\n\t(mail-vi1eur04on20600.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2611::600])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D01B61C92\n\tfor ;\n\tWed, 28 Feb 2024 06:37:08 +0100 (CET)","from DB9PR04MB9284.eurprd04.prod.outlook.com (2603:10a6:10:36c::8)\n\tby AM9PR04MB8954.eurprd04.prod.outlook.com (2603:10a6:20b:409::7)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.31;\n\tWed, 28 Feb 2024 05:37:06 +0000","from DB9PR04MB9284.eurprd04.prod.outlook.com\n\t([fe80::7d9b:76bb:b6c6:7f69]) by\n\tDB9PR04MB9284.eurprd04.prod.outlook.com\n\t([fe80::7d9b:76bb:b6c6:7f69%6]) with mapi id 15.20.7316.035;\n\tWed, 28 Feb 2024 05:37:06 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QqPgFCEP\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=YSWUFWLwYQ2ifspMn7xybEgNEEtLhpr/nxztQRscOTdlKVu2hI52m3uED5G6v0/2Hfsh1AyRC2ojwl3nZjmKGg2CeRYDANQWfptZBZ0WnQlWAgUZFRqp4gMEAfIyZV3R7ppcRZxDxfmPEiXN9T1GMO2ejuy69AFNT0Rzt018wnxx69zn67Y4TRhtQEhJqtUgoLYGQDLG+9ehxFH+0wPgk55KL96WRhuaLS+2Zow9b7FbCAOhyysEJvrHCEGb6UjBgg/L8VqUdxDmEjJwp0CocUnjhNIsoQwhIMP69oX5N+2jONsB9HhM3ZCHN9cjCmQc3FUwaN/nJBq1QVCnr/Q2vA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=jMY08EtHL6YftzW/WXy/2gydALibWhoDKWYoO1VwkS8=;\n\tb=LkIoQS88O6d8TiSRHDIvRrhJ4rzDzLlFU6Lp0IovKnbiV2EyrifsrlxH/tXxvjAE50AMZgb0i/44ltcAr4jzyAnQK56tRk6A2aslZW00oOLF/bh1HMadke0Lqhwbr8fxyxA80Wx9ryswxFuTwFiMwBMKjH57SuAenjcJdY0B0+g5LX+m3OqYa/46U6Sk/iHVAJsvgzeIirj0t6eGcIkiGb2D49AHwrWJOJ6iXDcaupeUGbFFlw4xLcI9NDhUEqWiVhNl/mcYJYXmZCd4ydRnlqm/mrfw/bNMMOcP5WjJMVBhZIjphnam8+VPHEB1IEjf7reHQNCvL7ebTAIuFFE2yA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=jMY08EtHL6YftzW/WXy/2gydALibWhoDKWYoO1VwkS8=;\n\tb=QqPgFCEPV/RK6xoCLt3bMwECFhshrSbtA5GpMRTqtSbyqyRBfW5JESKayS0QKoP3jnj9YPyZTklq/wxnZrKn02QKqxlLN2Mbt0q0J5AcKRoqscQ9SVm5Q6xmlOuZhZ2RD7Q4APMqRQLdGEDtkojTvvGGt7zdoNNio0pAyKjd/44=","From":"Hui Fang ","To":"Jacopo Mondi ","Subject":"Re: [EXT] Re: [PATCH] android: camera_device: Save capture settings\n\tunconditionally","Thread-Topic":"[EXT] Re: [PATCH] android: camera_device: Save capture settings\n\tunconditionally","Thread-Index":"AQHaaScDlYuEFzQirEmCUH31FhQ2BbEdzHGAgAFv4As=","Date":"Wed, 28 Feb 2024 05:37:06 +0000","Message-ID":"","References":"<20240227021320.3443016-1-hui.fang@nxp.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","msip_labels":"","authentication-results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QqPgFCEP\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"DB9PR04MB9284:EE_|AM9PR04MB8954:EE_","x-ms-office365-filtering-correlation-id":"206bd660-d9f2-467b-518f-08dc381f4ce4","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;","x-microsoft-antispam-message-info":"wcX9+zkwkalbVeco7BUPZaLZUEZ9ocSwK9/TuQifF1Dij80aNZRuuNOMSnY1anDjU4lz+ZczBxcxylzOhwt4mae3eM84dFPjN0XOivjqgqrJ7lDiamvtopadILP8CfO9eIL5hOOwy9JPfm/n3rp9tipiWLdugoLMygR9y+6H1ITBavvzXJI7GUJ+wQJgL8BOyOqqmw3WTt5/8DzaqzaDFFsxB6eu/SQ+qRCZYqbFBprVVE9sVmEJ9LCCldlPAh1xsDtWRszbjUpknwILpD+KRJ5GsSXvX8iuUnsY3i1bGdoopXS5pvW/4H1lCpOFC4iwUukpYfxyklMPP0XNPQmseLIo7dcDrOZxs3w5d44Z1Jdxxwxn2mX1dKkosloPsOi4fcwJjweIE4TWumLepIOeckpd2zSTISii7OL054wJSlnV8dc6FapzIIwJ7kE3HzI7dHngM39dwt5401D7Wqrzf5k8sY33FtwC5YgOC47Ue6GrI4cDvgk71s929X+YLOAtusCXmTwcxG07EBmGO+8wZfoUopSNcfQKw68beGsI5QeMFHxjzeos5M01cVwPZQATWl/ZpNtunZYs7GsVpM18AN7TonFltLy3dFXrK1wBWQpBDUQ4UxsnEbfUehJ3ZZ+BNu4i34GHdC9b3Vfa4+7sugVaYwYAu57dUN9g8JfiQ3b9oA8lnez4cwP8hN1/2tXmHNpEPRwNolFToUfElDy5iA==","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DB9PR04MB9284.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230031)(230273577357003)(38070700009); DIR:OUT; SFP:1101; ","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"U3MKV0TzQSxuhEDVfKw8SCarIt4oGCmP/VVUIGq+4Poxg6/V23/DxI2RzPTdruXbScFRaTnzznXuM8fjps4WulXiFaMwkfiiXGmaMQEn1PliWjOwcsh1D6LRD3CExcaZl41s5+xDjIzcNuoMYvQw1MTaBIM8ykAImHnB8thOdeueD5hBnhnRJpq9uOMgV29I9Ck4Vu73Z5agwmqrgYfX/apJ+aPZGBFgy84XGDpK3pVePaicaty994Oy6zUQAh3Qa1A8rWjDtSBChwBwDBl5PRil2wnAO7qs3Wb7/tA0ZZBV2HQCBZjD6LCpYKa/MDjtMEVGYcDrD5dV8Z2gucoXQ5/XEK0MaSO5SndUBOb1XcpO88lSGkz1fCO5QmsswYb7JZOfZrSWQV0z1fyy/R6ucS8q2vgf5hjKjpoLdNfZbZA7AVvfwHiaVeCS3ZSZKL3MD/BJ/8tkvqhkZfIEmIClmOLoPPFvYLJy4+5rZoqxIBnakDgX2E3ciPE1y6LCs1z2LguPYggN7qIpx8YFQddRqhBosd4CJUCLsT9iULk5udcNLCe6ahulxWOhmrJxe/O+34R+e32YuEV856eC9a7567sIz8q5lmTFF8l4BJ85Xrr/ujHqE0MK+vqdGMsyGQmQpA/DXpGd/Y/Ufy00XE/lAlNG3bDznzu8vH3LObcYGGf37m6rwjNUH5M310xcFYXAuvIGQHIyizJ79dbOGWPcAx2DLoCtGOTOKRPnNg5+G7sljna1YbF9ne5zPEwoOG5JkH1ety8H8sHTYmo9NusfCZnT/QnyVmcfUE6vdChJjsmhze5YtiLv+G9Ke1QVS27uZJZMNFWBtIU2CfbkvuZ6ua3pNqFgVHhEEuIXBMIx1Hfc+JMLzLwcZxVOo3usxXWyJaQ7HFgBKOMzhRJ5k+vA9aPrrUIlLsJWpeB2keRXEl3qpKayDJStTBWnXufpqwXxoo/K/k1d/rHoczEKH8+3TQIeIgMdSoNwh6pHd3ITiyDN9h3lCK3uanT5mMRZbs2b+Zvbap1ZGt1TgFBHbBMoTFvjJ8BeBwfX8h4o2W+PhAJSHFFAFg9YiCjd1pg96tcayJc5C7gzep/vJb3f7skxJQj5pjeTP0VVopBBiSDmaRoHbruLZpzv5IZWScTKO5E8cZDFTfWjPKCltb5Vy5Fld3UrcYH1/0uFIalf4ZNVqJ1yfPPHGkOKs6vJ7/RHSovOdQizxPhFtQ8vlPlNt4QsbszStDH6NxD4e7IxvC6Ea06m0h5GuvfXILoXQp2GjDW0PSnBbSPLmn7hlmbEQJbE6PQmb0zQZ8x8vonmdJvy97MYIZ+Vir+hABHE4DJA2IssDegHtUvx2OwV+HFkEAh5UfWIN5GdNLX5kVYLdxzEABlRtHLNc3ACQqqJu/DRcxkMOPCB0e/Bu5o2bGVbpjQz4G0SZnSRqXRjqL9Gax7ayXqQJxFlnRgaRU9qdlT7u3ZCyPKiRoYMEW4wIGDDRijcI3IBRh0IF2FKMG+l33syTXHfvoqGNmARXoVZzDJYub3tMiLAL9YHKnQ2AYwa5Cc7Tu2Vc5gdkCgEAf3j95jyTuQ=","Content-Type":"multipart/alternative;\n\tboundary=\"_000_DB9PR04MB9284EF27607B2F32DC80D10187582DB9PR04MB9284eurp_\"","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"DB9PR04MB9284.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"206bd660-d9f2-467b-518f-08dc381f4ce4","X-MS-Exchange-CrossTenant-originalarrivaltime":"28 Feb 2024 05:37:06.4519\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"s+xgXtVlfHD3KnPJ6qbvCaBmWCP6xBDZOi03gp8wSA+k84LHKUhmMG/1ll4OQR6hgT5JUV3NhJ75N2pTCx+bCA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM9PR04MB8954","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"libcamera-devel@lists.libcamera.org\"\n\t,\n\t\"biomifang118@gmail.com\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]