[{"id":28808,"web_url":"https://patchwork.libcamera.org/comment/28808/","msgid":"","date":"2024-03-01T09:38:51","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jacopo,\n\nThank you for this patch.\n\nOn Mon, 26 Feb 2024 at 13:26, Jacopo Mondi\n wrote:\n>\n> Add FourCC definitions for the 48-bit RGB/BGR formats to the\n> DRM/KMS uapi.\n>\n> The format will be used by the Raspberry Pi PiSP Back End,\n> supported by a V4L2 driver in kernel space and by libcamera in\n> userspace, which uses the DRM FourCC identifiers.\n>\n> Signed-off-by: Jacopo Mondi \n\nAll the fields look reasonable to me, so:\n\nReviewed-by: Naushir Patuck \n\n> ---\n> drivers/gpu/drm/drm_fourcc.c | 8 ++++++++\n> include/uapi/drm/drm_fourcc.h | 4 ++++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c\n> index 193cf8ed7912..908f20b96fd5 100644\n> --- a/drivers/gpu/drm/drm_fourcc.c\n> +++ b/drivers/gpu/drm/drm_fourcc.c\n> @@ -210,6 +210,14 @@ const struct drm_format_info *__drm_format_info(u32 format)\n> { .format = DRM_FORMAT_ABGR2101010, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_RGBA1010102, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_BGRA1010102, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> + { .format = DRM_FORMAT_RGB161616, .depth = 0,\n> + .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> + .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> + .hsub = 1, .vsub = 1, .has_alpha = false },\n> + { .format = DRM_FORMAT_BGR161616, .depth = 0,\n> + .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> + .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> + .hsub = 1, .vsub = 1, .has_alpha = false },\n> { .format = DRM_FORMAT_ARGB8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_ABGR8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_RGBA8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h\n> index 84d502e42961..00db00083175 100644\n> --- a/include/uapi/drm/drm_fourcc.h\n> +++ b/include/uapi/drm/drm_fourcc.h\n> @@ -210,6 +210,10 @@ extern \"C\" {\n> #define DRM_FORMAT_RGBA1010102 fourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */\n> #define DRM_FORMAT_BGRA1010102 fourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */\n>\n> +/* 48 bpp RGB */\n> +#define DRM_FORMAT_RGB161616 fourcc_code('R', 'G', '4', '8') /* [47:0] R:G:B 16:16:16 little endian */\n> +#define DRM_FORMAT_BGR161616 fourcc_code('B', 'G', '4', '8') /* [47:0] B:G:R 16:16:16 little endian */\n> +\n> /* 64 bpp RGB */\n> #define DRM_FORMAT_XRGB16161616 fourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */\n> #define DRM_FORMAT_XBGR16161616 fourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9B8EBD160\n\tfor ;\n\tFri, 1 Mar 2024 09:39:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAC1C6286C;\n\tFri, 1 Mar 2024 10:39:29 +0100 (CET)","from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com\n\t[IPv6:2607:f8b0:4864:20::112e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E79861C8D\n\tfor ;\n\tFri, 1 Mar 2024 10:39:28 +0100 (CET)","by mail-yw1-x112e.google.com with SMTP id\n\t00721157ae682-6096ff3e4abso14635377b3.0\n\tfor ;\n\tFri, 01 Mar 2024 01:39:28 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cM99ahel\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1709285967; x=1709890767;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=T4FReK8go5B+QNMImpm5GNB78mbfotA8iWW7uG0MwSU=;\n\tb=cM99ahelm6doLpGJCJIMXPFZMiYlO8hWxtqRwmr/rzxEGxAjGbiZwvGYIGm0CdTL6H\n\t4enBMji6g+94En8fnQtSPR6T/wrraw7bB5/hqa3wDm/R+vQbFsyFAEjwTwOsnaX6rZ99\n\t4bL4ua3RPnffalGeQuAj4D4ZVb1tezxgsvWpELmTkYEf3OZgryAu0gyTPV2S5rY6nQUX\n\t0TbhudZBE0dK4LOzLAH40WDVIiKXODGE8n621tTnG+p4sM0+3JomoBHGOAjhiqEBZILd\n\tkFBHxjKsT7uhY61cEqQIvej7rQrd8V2bC+BhRYzXEPMEkkg1HCA9Ux4UTcWUIiqnAYIy\n\tJJ9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1709285967; x=1709890767;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=T4FReK8go5B+QNMImpm5GNB78mbfotA8iWW7uG0MwSU=;\n\tb=Dq7tNZpQnhuzk+KI6t/k5THE7JakENAcJ2/VErzxkXeTmUoZwqWO5g8BrbBgqbJqJo\n\tav7zH6oe7BPL1/tBuDsVIK2J4YrIWjt4tvGDLtCjUXMPkSTanqbQudsR4/ZCdpeGYaMH\n\tJ8yJfbOoRAjJWCFoPl8qBTDO4yiFCpGqGV6ssfdnPTJgCZxWPPSNrCEFRsPeCIH87wcr\n\tYJTGuhq14TFJk5egFfhjEH/0vudTa/RVq8M9MvtaM56mHPomvAOCoNLn72MQZjnBjXlT\n\tu5TKJ26QgqFapPXyZSUMqme+lZEXehsHUbXzJRzto/caYWs8CS9+j6gje59bhmXWLMc1\n\tNNKQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCX72xVBqq4jkQz1R1qINhir0GmIyJZLIpTWht2MiKtP01fPU3vE+pll1XaJfKrXm64e0g3VNk7/Dc15RE/R8hCKlBoJl+2jIpG6y+JZ6DE+OeJEGA==","X-Gm-Message-State":"AOJu0YyZIo9s3Pt0Q2ZQuoVfiIUzy/aBGwXJRyQ9XR78HkKANG4VyDuG\n\tVDBgicGIV4y1XhTsjFcNGGT8v8SGFw/+0RVxMwYr4T3HvDQDkY3PNWeB4js8BfJGqXxgqlUVD5m\n\t0Ky0CwfCONbABgHiBcCXOAaOlcN+AIDhgtRU2jw==","X-Google-Smtp-Source":"AGHT+IHBJlVslNQf72z5nYstBMHq1r6NEyZlI3Q+57WJ6N+cTDUWeKdD7ZbOQA3tq8oZz2pmh/Zc/ze9767bOaC8j2U=","X-Received":"by 2002:a81:4c44:0:b0:607:cb4e:eb41 with SMTP id\n\tz65-20020a814c44000000b00607cb4eeb41mr1042777ywa.35.1709285967144;\n\tFri, 01 Mar 2024 01:39:27 -0800 (PST)","MIME-Version":"1.0","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","In-Reply-To":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 1 Mar 2024 09:38:51 +0000","Message-ID":"","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Zimmermann ,\n\tMaarten Lankhorst ,\n\tdri-devel@lists.freedesktop.org, libcamera-devel@lists.libcamera.org, \n\tMaxime Ripard , Daniel Vetter , \n\tDavid Airlie ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28817,"web_url":"https://patchwork.libcamera.org/comment/28817/","msgid":"","date":"2024-03-03T14:31:58","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":188,"url":"https://patchwork.libcamera.org/api/people/188/","name":"Simon Ser","email":"contact@emersion.fr"},"content":"Reviewed-by: Simon Ser ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C66DBD160\n\tfor ;\n\tSun, 3 Mar 2024 14:40:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51DD06286F;\n\tSun, 3 Mar 2024 15:39:59 +0100 (CET)","from mail-4022.proton.ch (mail-4022.proton.ch [185.70.40.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6E7662868\n\tfor ;\n\tSun, 3 Mar 2024 15:32:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=emersion.fr header.i=@emersion.fr\n\theader.b=\"jcN4spbR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr;\n\ts=protonmail3; t=1709476325; x=1709735525;\n\tbh=zRwWsMDd5Kf2yQpedEA3Ka2dLpgNvYvwuOL0uYq4mxY=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=jcN4spbRPMS/t2O67DdnJLPirs86fSoTJAUvPE+mo1IBPV0euCEgrh+H6nZ33KV0n\n\tg/BX244S/6ljDNVUV2krKixjo26gf+zzzBmDFJJ0CphZAhb2BxDqJUhtbm827eJUSW\n\tq1GCpYOskzTqxQ9p77lsKWDlwrA50bSrJ1ViCJgDdx9J/pkc9oRCOJGAiBwvk4AZ+f\n\tPvf1Nlbr+46M0VpEEG6L5CYDLui2H5ONVobyeT7AfO2cClMynTN2IOBLTqQ/lUE/TK\n\tAH988DOCRNDv91hrjEq5mAs2zMdymHAlTwCk7Fs6ki7kfcLh1yfxkjHN+7Q+8g6RyJ\n\tBYWhUckRYlnuw==","Date":"Sun, 03 Mar 2024 14:31:58 +0000","To":"Jacopo Mondi ","From":"Simon Ser ","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","Message-ID":"","In-Reply-To":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","Feedback-ID":"1358184:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Mailman-Approved-At":"Sun, 03 Mar 2024 15:39:58 +0100","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Zimmermann ,\n\tMaarten Lankhorst ,\n\tMaxime Ripard , libcamera-devel@lists.libcamera.org, \n\tdri-devel@lists.freedesktop.org, Daniel Vetter ,\n\tDavid Airlie ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29379,"web_url":"https://patchwork.libcamera.org/comment/29379/","msgid":"","date":"2024-05-02T09:02:27","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hello\n which tree should this patch be collected from now that it has\nbeen reviewed ?\n\nOn Mon, Feb 26, 2024 at 02:25:43PM GMT, Jacopo Mondi wrote:\n> Add FourCC definitions for the 48-bit RGB/BGR formats to the\n> DRM/KMS uapi.\n>\n> The format will be used by the Raspberry Pi PiSP Back End,\n> supported by a V4L2 driver in kernel space and by libcamera in\n> userspace, which uses the DRM FourCC identifiers.\n>\n> Signed-off-by: Jacopo Mondi \n> ---\n> drivers/gpu/drm/drm_fourcc.c | 8 ++++++++\n> include/uapi/drm/drm_fourcc.h | 4 ++++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c\n> index 193cf8ed7912..908f20b96fd5 100644\n> --- a/drivers/gpu/drm/drm_fourcc.c\n> +++ b/drivers/gpu/drm/drm_fourcc.c\n> @@ -210,6 +210,14 @@ const struct drm_format_info *__drm_format_info(u32 format)\n> \t\t{ .format = DRM_FORMAT_ABGR2101010,\t.depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> \t\t{ .format = DRM_FORMAT_RGBA1010102,\t.depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> \t\t{ .format = DRM_FORMAT_BGRA1010102,\t.depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> +\t\t{ .format = DRM_FORMAT_RGB161616,\t.depth = 0,\n> +\t\t .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> +\t\t .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> +\t\t .hsub = 1, .vsub = 1, .has_alpha = false },\n> +\t\t{ .format = DRM_FORMAT_BGR161616,\t.depth = 0,\n> +\t\t .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> +\t\t .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> +\t\t .hsub = 1, .vsub = 1, .has_alpha = false },\n> \t\t{ .format = DRM_FORMAT_ARGB8888,\t.depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> \t\t{ .format = DRM_FORMAT_ABGR8888,\t.depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> \t\t{ .format = DRM_FORMAT_RGBA8888,\t.depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h\n> index 84d502e42961..00db00083175 100644\n> --- a/include/uapi/drm/drm_fourcc.h\n> +++ b/include/uapi/drm/drm_fourcc.h\n> @@ -210,6 +210,10 @@ extern \"C\" {\n> #define DRM_FORMAT_RGBA1010102\tfourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */\n> #define DRM_FORMAT_BGRA1010102\tfourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */\n>\n> +/* 48 bpp RGB */\n> +#define DRM_FORMAT_RGB161616 fourcc_code('R', 'G', '4', '8') /* [47:0] R:G:B 16:16:16 little endian */\n> +#define DRM_FORMAT_BGR161616 fourcc_code('B', 'G', '4', '8') /* [47:0] B:G:R 16:16:16 little endian */\n> +\n> /* 64 bpp RGB */\n> #define DRM_FORMAT_XRGB16161616\tfourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */\n> #define DRM_FORMAT_XBGR16161616\tfourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33AEEBDE6B\n\tfor ;\n\tThu, 2 May 2024 09:02:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CEA163418;\n\tThu, 2 May 2024 11:02:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B82361A89\n\tfor ;\n\tThu, 2 May 2024 11:02:31 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77DEFBC8;\n\tThu, 2 May 2024 11:01:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sz9ixFx1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714640493;\n\tbh=ss707vsEvpxLJxwi3bQDGTrjp0VfVeydeR2e0E1DgfA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sz9ixFx1HRr1ylVGujEHDMgBzBPnDkBgtefJDXDTuKYXNnfhetAbPzWdRls41S2Ua\n\tij5cbiW/Rrh4uCy2sVr3MAaaJjqe0JvfvyX0Z9EezmDggICIU+V0E36nkgobQZlRfV\n\thXEX0y+QfYUgcDU1BrShqFVU3WRDAfpItbDhemIM=","Date":"Thu, 2 May 2024 11:02:27 +0200","From":"Jacopo Mondi ","To":"Jacopo Mondi ","Cc":"David Airlie , Daniel Vetter , \n\tMaarten Lankhorst ,\n\tMaxime Ripard , \n\tThomas Zimmermann ,\n\tNaushir Patuck , \n\tdri-devel@lists.freedesktop.org, libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","Message-ID":"","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29399,"web_url":"https://patchwork.libcamera.org/comment/29399/","msgid":"<20240502235409.GH4959@pendragon.ideasonboard.com>","date":"2024-05-02T23:54:09","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Thu, May 02, 2024 at 11:02:27AM +0200, Jacopo Mondi wrote:\n> Hello\n> which tree should this patch be collected from now that it has\n> been reviewed ?\n\nI think this can go through drm-misc. I'm not sure what the rule is for\npatches that touch core code like these, can then be pushed by anyone\nwith commit access, or do they need to be collected by a drm-misc\nmaintainer ?\n\n> On Mon, Feb 26, 2024 at 02:25:43PM GMT, Jacopo Mondi wrote:\n> > Add FourCC definitions for the 48-bit RGB/BGR formats to the\n> > DRM/KMS uapi.\n> >\n> > The format will be used by the Raspberry Pi PiSP Back End,\n> > supported by a V4L2 driver in kernel space and by libcamera in\n> > userspace, which uses the DRM FourCC identifiers.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > drivers/gpu/drm/drm_fourcc.c | 8 ++++++++\n> > include/uapi/drm/drm_fourcc.h | 4 ++++\n> > 2 files changed, 12 insertions(+)\n> >\n> > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c\n> > index 193cf8ed7912..908f20b96fd5 100644\n> > --- a/drivers/gpu/drm/drm_fourcc.c\n> > +++ b/drivers/gpu/drm/drm_fourcc.c\n> > @@ -210,6 +210,14 @@ const struct drm_format_info *__drm_format_info(u32 format)\n> > \t\t{ .format = DRM_FORMAT_ABGR2101010,\t.depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > \t\t{ .format = DRM_FORMAT_RGBA1010102,\t.depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > \t\t{ .format = DRM_FORMAT_BGRA1010102,\t.depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > +\t\t{ .format = DRM_FORMAT_RGB161616,\t.depth = 0,\n> > +\t\t .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> > +\t\t .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> > +\t\t .hsub = 1, .vsub = 1, .has_alpha = false },\n> > +\t\t{ .format = DRM_FORMAT_BGR161616,\t.depth = 0,\n> > +\t\t .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> > +\t\t .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> > +\t\t .hsub = 1, .vsub = 1, .has_alpha = false },\n> > \t\t{ .format = DRM_FORMAT_ARGB8888,\t.depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > \t\t{ .format = DRM_FORMAT_ABGR8888,\t.depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > \t\t{ .format = DRM_FORMAT_RGBA8888,\t.depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h\n> > index 84d502e42961..00db00083175 100644\n> > --- a/include/uapi/drm/drm_fourcc.h\n> > +++ b/include/uapi/drm/drm_fourcc.h\n> > @@ -210,6 +210,10 @@ extern \"C\" {\n> > #define DRM_FORMAT_RGBA1010102\tfourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */\n> > #define DRM_FORMAT_BGRA1010102\tfourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */\n> >\n> > +/* 48 bpp RGB */\n> > +#define DRM_FORMAT_RGB161616 fourcc_code('R', 'G', '4', '8') /* [47:0] R:G:B 16:16:16 little endian */\n> > +#define DRM_FORMAT_BGR161616 fourcc_code('B', 'G', '4', '8') /* [47:0] B:G:R 16:16:16 little endian */\n> > +\n> > /* 64 bpp RGB */\n> > #define DRM_FORMAT_XRGB16161616\tfourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */\n> > #define DRM_FORMAT_XBGR16161616\tfourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D3B9C3220\n\tfor ;\n\tThu, 2 May 2024 23:54:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F34863418;\n\tFri, 3 May 2024 01:54:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 320CC62C9F\n\tfor ;\n\tFri, 3 May 2024 01:54:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA10A593;\n\tFri, 3 May 2024 01:53:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FRGEwMZI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714693998;\n\tbh=HRe5ljL+DRh/cLziQZQnHnErjG7fAwPUbblbiOOjz10=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FRGEwMZIp8bwwSkOb//OCCGNgD5GveHlaLhmZHRxlSeVgXLcl01HKvAYosVSpyqz6\n\tB4WgmiShlNWFu5HeZp2Nv1TarfhZxMImvJj359KKEqlbAXzpCvCmkz8C5jUBRq+NgO\n\t1ybdm7fICZczzjlTOPiVgL0Mn7IqJl9LEOjmZwgE=","Date":"Fri, 3 May 2024 02:54:09 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"David Airlie , Daniel Vetter ,\n\tMaarten Lankhorst ,\n\tMaxime Ripard ,\n\tThomas Zimmermann ,\n\tNaushir Patuck , dri-devel@lists.freedesktop.org, \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","Message-ID":"<20240502235409.GH4959@pendragon.ideasonboard.com>","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34706,"web_url":"https://patchwork.libcamera.org/comment/34706/","msgid":"","date":"2025-06-27T16:39:37","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":234,"url":"https://patchwork.libcamera.org/api/people/234/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi\n wrote:\n>\n> Add FourCC definitions for the 48-bit RGB/BGR formats to the\n> DRM/KMS uapi.\n>\n> The format will be used by the Raspberry Pi PiSP Back End,\n> supported by a V4L2 driver in kernel space and by libcamera in\n> userspace, which uses the DRM FourCC identifiers.\n>\n> Signed-off-by: Jacopo Mondi \n\nResurrecting this, as it appears to have not ever landed upstream\n\nReviewed-by: Rob Clark \n\n> ---\n> drivers/gpu/drm/drm_fourcc.c | 8 ++++++++\n> include/uapi/drm/drm_fourcc.h | 4 ++++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c\n> index 193cf8ed7912..908f20b96fd5 100644\n> --- a/drivers/gpu/drm/drm_fourcc.c\n> +++ b/drivers/gpu/drm/drm_fourcc.c\n> @@ -210,6 +210,14 @@ const struct drm_format_info *__drm_format_info(u32 format)\n> { .format = DRM_FORMAT_ABGR2101010, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_RGBA1010102, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_BGRA1010102, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> + { .format = DRM_FORMAT_RGB161616, .depth = 0,\n> + .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> + .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> + .hsub = 1, .vsub = 1, .has_alpha = false },\n> + { .format = DRM_FORMAT_BGR161616, .depth = 0,\n> + .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> + .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> + .hsub = 1, .vsub = 1, .has_alpha = false },\n> { .format = DRM_FORMAT_ARGB8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_ABGR8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> { .format = DRM_FORMAT_RGBA8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h\n> index 84d502e42961..00db00083175 100644\n> --- a/include/uapi/drm/drm_fourcc.h\n> +++ b/include/uapi/drm/drm_fourcc.h\n> @@ -210,6 +210,10 @@ extern \"C\" {\n> #define DRM_FORMAT_RGBA1010102 fourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */\n> #define DRM_FORMAT_BGRA1010102 fourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */\n>\n> +/* 48 bpp RGB */\n> +#define DRM_FORMAT_RGB161616 fourcc_code('R', 'G', '4', '8') /* [47:0] R:G:B 16:16:16 little endian */\n> +#define DRM_FORMAT_BGR161616 fourcc_code('B', 'G', '4', '8') /* [47:0] B:G:R 16:16:16 little endian */\n> +\n> /* 64 bpp RGB */\n> #define DRM_FORMAT_XRGB16161616 fourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */\n> #define DRM_FORMAT_XBGR16161616 fourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1590BDCBF\n\tfor ;\n\tFri, 27 Jun 2025 17:04:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 845AB68DE5;\n\tFri, 27 Jun 2025 19:04:13 +0200 (CEST)","from mail-il1-x130.google.com (mail-il1-x130.google.com\n\t[IPv6:2607:f8b0:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 377B768DE5\n\tfor ;\n\tFri, 27 Jun 2025 18:39:51 +0200 (CEST)","by mail-il1-x130.google.com with SMTP id\n\te9e14a558f8ab-3ddd2710d14so518575ab.2\n\tfor ;\n\tFri, 27 Jun 2025 09:39:51 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"j4SHPMHM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1751042390; x=1751647190;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=sSwQlatYo2hfWz4yZlz2QlGPM20UYuQK38iob7ZA/l4=;\n\tb=j4SHPMHMD6M/QnRBH/2QPC9zvsqBDiqBTq0FigxRMJlz4J/eeOLsvUSC0hU+xxl6BB\n\t2s4u6/uPAEsUoUNUUrTuqwP2Uq/FQnWOFaHiteQuLeYfivb2ihlDF1PlCpWBfg7n5nIS\n\tYcgdlhMOAyvEM4bHqXpxoTqbFX5K2lNGNnq92owlBmKQF92IS0pWrbf0iUxzQQV5ivEH\n\tR8FIVnWZOwTatU5wJt97tXnEKJOiFdD+mHnrkRdYQ9RWLkLYO4Kxs1wmXD5BvXxr0t+7\n\tS/RI7jyY5BxWyaEsvOxFpLsAtVLhjTjiPFhe0lkMl3jMbjfWnE/usITI0tIo62ggvPSy\n\tvhfg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1751042390; x=1751647190;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=sSwQlatYo2hfWz4yZlz2QlGPM20UYuQK38iob7ZA/l4=;\n\tb=CuHLQJ1ivRZpeXaZNso2EzEcnmcM6+0WaXRDXU5bzwwWkkvMjrORL0XqU1OcoeBubi\n\tL5teZcOkWSW8KpKGpowdkwYEP8Zp5dLAKBm/+bXmMWADynNAwsK5QvFppTB7F3LlYmy8\n\tYnxT0NCW7Jikw3pAWWtktwsYAlTtKbbJpNe5kV4DqQnPJDyGd6Ta2Uq8Y/Jqkjm7UIfi\n\tUdvRsCTKsjyeHceXmu0h2UXjkHWk5bOmxAIORpSHR2vV9QhI5Rr3TWsJNB6eQv4byZh4\n\tRcGGixcU1PiGNlLDnoc7FCpPV6Yd5CPZX4hK+tmcJGd3AiRMtFqmjh5kd4R7urMArcSV\n\tbgiw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCV82tmPCSbsMfAlmZDiPFcEs0a0JHzxTT+uRaGoGDlUva9X1nCwWf1meBbtPqSj6jRhKl7anh76tisL01S/WyY=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yxunn0T9p7vD1AJnhJUPkaxYE1z42S4YVnMYI7SULa8OiKwsN0S\n\tKZgJoMqutpRHaWzcimJDGRJI88yDpLJabJnU+qznBqtl4myo/6gosd6A4lnIUZIhbU5YDmH8gkZ\n\tHQyN+q+c9gJe84kUQaj8S+T6kEwKRz64=","X-Gm-Gg":"ASbGncsC3Dj7BSXcvjOOM4OoJDstMNzkkXatd1I2IRNSewubjIrz03M60TfuWKrlc20\n\tGdBSD+mV/wGI6wSJEmlMvUaQ60PDYemrXyUFM3fhjgmDttJPIAcvkCZEA8qoNEu3GCTWQQfRrxo\n\tALR5cxeiSFb6nKp2mUDd2+i8RgFDd9mPdcHTYFRKLhnteeNfMzgUrY7Uajx9iSiChWQHP7vFQPz\n\tjr7Q6W7rHQoDg==","X-Google-Smtp-Source":"AGHT+IE+EQJINO2hqvKdeq50nVAmw4xPSXVM3N9Np89oAO2+jjaTnQXXEEePMfd+k6JVFTPXRjeWMGtc9KqvK2DKFT4=","X-Received":"by 2002:a05:6e02:3708:b0:3da:71c7:5c7f with SMTP id\n\te9e14a558f8ab-3df4ab9bd2bmr56840715ab.15.1751042389877;\n\tFri, 27 Jun 2025 09:39:49 -0700 (PDT)","MIME-Version":"1.0","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","In-Reply-To":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>","From":"Rob Clark ","Date":"Fri, 27 Jun 2025 09:39:37 -0700","X-Gm-Features":"Ac12FXwhljaBE40PrupTpRd1f6sZbUiAEPUkOhAArAoICLRBlhYXmUUMciYGwDA","Message-ID":"","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","To":"Jacopo Mondi ","Cc":"David Airlie , Daniel Vetter , \n\tMaarten Lankhorst ,\n\tMaxime Ripard , \n\tThomas Zimmermann ,\n\tNaushir Patuck , \n\tdri-devel@lists.freedesktop.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Mailman-Approved-At":"Fri, 27 Jun 2025 19:04:12 +0200","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34709,"web_url":"https://patchwork.libcamera.org/comment/34709/","msgid":"<20250627180454.GD24912@pendragon.ideasonboard.com>","date":"2025-06-27T18:04:54","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jun 27, 2025 at 09:39:37AM -0700, Rob Clark wrote:\n> On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi wrote:\n> >\n> > Add FourCC definitions for the 48-bit RGB/BGR formats to the\n> > DRM/KMS uapi.\n> >\n> > The format will be used by the Raspberry Pi PiSP Back End,\n> > supported by a V4L2 driver in kernel space and by libcamera in\n> > userspace, which uses the DRM FourCC identifiers.\n> >\n> > Signed-off-by: Jacopo Mondi \n> \n> Resurrecting this, as it appears to have not ever landed upstream\n\nWhat are the rule is for patches that touch core code like this one, can\nthey be pushed to drm-misc by anyone with commit access, or do they need\nto be collected by a drm-misc maintainer ?\n\n> Reviewed-by: Rob Clark \n> \n> > ---\n> > drivers/gpu/drm/drm_fourcc.c | 8 ++++++++\n> > include/uapi/drm/drm_fourcc.h | 4 ++++\n> > 2 files changed, 12 insertions(+)\n> >\n> > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c\n> > index 193cf8ed7912..908f20b96fd5 100644\n> > --- a/drivers/gpu/drm/drm_fourcc.c\n> > +++ b/drivers/gpu/drm/drm_fourcc.c\n> > @@ -210,6 +210,14 @@ const struct drm_format_info *__drm_format_info(u32 format)\n> > { .format = DRM_FORMAT_ABGR2101010, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > { .format = DRM_FORMAT_RGBA1010102, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > { .format = DRM_FORMAT_BGRA1010102, .depth = 30, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > + { .format = DRM_FORMAT_RGB161616, .depth = 0,\n> > + .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> > + .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> > + .hsub = 1, .vsub = 1, .has_alpha = false },\n> > + { .format = DRM_FORMAT_BGR161616, .depth = 0,\n> > + .num_planes = 1, .char_per_block = { 6, 0, 0 },\n> > + .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 },\n> > + .hsub = 1, .vsub = 1, .has_alpha = false },\n> > { .format = DRM_FORMAT_ARGB8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > { .format = DRM_FORMAT_ABGR8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > { .format = DRM_FORMAT_RGBA8888, .depth = 32, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },\n> > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h\n> > index 84d502e42961..00db00083175 100644\n> > --- a/include/uapi/drm/drm_fourcc.h\n> > +++ b/include/uapi/drm/drm_fourcc.h\n> > @@ -210,6 +210,10 @@ extern \"C\" {\n> > #define DRM_FORMAT_RGBA1010102 fourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */\n> > #define DRM_FORMAT_BGRA1010102 fourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */\n> >\n> > +/* 48 bpp RGB */\n> > +#define DRM_FORMAT_RGB161616 fourcc_code('R', 'G', '4', '8') /* [47:0] R:G:B 16:16:16 little endian */\n> > +#define DRM_FORMAT_BGR161616 fourcc_code('B', 'G', '4', '8') /* [47:0] B:G:R 16:16:16 little endian */\n> > +\n> > /* 64 bpp RGB */\n> > #define DRM_FORMAT_XRGB16161616 fourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */\n> > #define DRM_FORMAT_XBGR16161616 fourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59251C3237\n\tfor ;\n\tFri, 27 Jun 2025 18:05:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 192E768E04;\n\tFri, 27 Jun 2025 20:05:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E0F868DE5\n\tfor ;\n\tFri, 27 Jun 2025 20:05:18 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D4FC07E1;\n\tFri, 27 Jun 2025 20:04:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CHNpQ+aV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751047498;\n\tbh=2p+3T+jX3u1dt4arf1dj1Ca9BY88qtk4/dhlHJij/bk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CHNpQ+aV9HocvQHE45HahhiYwPMAFaSFU4nZODtXIS6GC+x+ObAhDAP0YEgYXqhu4\n\tQvMyH4gItXIWufrbxkS9SRAdhAmZTvBrukqEJjG1ohu+Mbbqk7QLt6hKYsQ+8d/lgO\n\tn93M6GV4n6VgsqkjgIsuBk5uYJqHN89Xp35RLYJA=","Date":"Fri, 27 Jun 2025 21:04:54 +0300","From":"Laurent Pinchart ","To":"Rob Clark ","Cc":"Jacopo Mondi ,\n\tDavid Airlie , Daniel Vetter ,\n\tMaarten Lankhorst ,\n\tMaxime Ripard ,\n\tThomas Zimmermann ,\n\tNaushir Patuck , dri-devel@lists.freedesktop.org, \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","Message-ID":"<20250627180454.GD24912@pendragon.ideasonboard.com>","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34712,"web_url":"https://patchwork.libcamera.org/comment/34712/","msgid":"<877c0xatmb.fsf@minerva.mail-host-address-is-not-set>","date":"2025-06-27T19:10:04","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":95,"url":"https://patchwork.libcamera.org/api/people/95/","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"content":"Laurent Pinchart writes:\n\n> On Fri, Jun 27, 2025 at 09:39:37AM -0700, Rob Clark wrote:\n>> On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi wrote:\n>> >\n>> > Add FourCC definitions for the 48-bit RGB/BGR formats to the\n>> > DRM/KMS uapi.\n>> >\n>> > The format will be used by the Raspberry Pi PiSP Back End,\n>> > supported by a V4L2 driver in kernel space and by libcamera in\n>> > userspace, which uses the DRM FourCC identifiers.\n>> >\n>> > Signed-off-by: Jacopo Mondi \n>> \n>> Resurrecting this, as it appears to have not ever landed upstream\n>\n> What are the rule is for patches that touch core code like this one, can\n> they be pushed to drm-misc by anyone with commit access, or do they need\n> to be collected by a drm-misc maintainer ?\n>\n\nAccording to [0] I would say that you could just push it through drm-misc\nsince there are already a few review-by tags collected.\n\n[0]: https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html#merge-criteria","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5DC6BDCBF\n\tfor ;\n\tFri, 27 Jun 2025 19:10:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1AAE68E04;\n\tFri, 27 Jun 2025 21:10:11 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EFB068DE5\n\tfor ;\n\tFri, 27 Jun 2025 21:10:10 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-687-5QAGLYsnOLukTxE9-O6Gvg-1; Fri, 27 Jun 2025 15:10:08 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-3a5058f9ef4so1165850f8f.2\n\tfor ;\n\tFri, 27 Jun 2025 12:10:08 -0700 (PDT)","from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4538a421434sm59447325e9.37.2025.06.27.12.10.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Jun 2025 12:10:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"QXf8f2Mj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1751051409;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=8dhUCmQVBVc3ggbPxSqO6DltDZ+HKdR/dQ/Hvgc9d5M=;\n\tb=QXf8f2MjRMv8tCfU5RBjjy4aysaqG0EJFcx1R48jWL5B9pgz+p/QMR/G4H/cy+V2kRVotk\n\tVSDCyq9is9tFB6hcMbm/1uTKqgO/hHoPdU/GNZl5/qymR4Wf7k67oDT7gzIXMxYq7fKJIF\n\tLVbebSaLVdPil80FtC7IEtaWVmElmJU=","X-MC-Unique":"5QAGLYsnOLukTxE9-O6Gvg-1","X-Mimecast-MFC-AGG-ID":"5QAGLYsnOLukTxE9-O6Gvg_1751051407","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1751051406; x=1751656206;\n\th=content-transfer-encoding:mime-version:message-id:date:references\n\t:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=8dhUCmQVBVc3ggbPxSqO6DltDZ+HKdR/dQ/Hvgc9d5M=;\n\tb=p4yKy6DOwi0j1uqs3+M5tSfnNtK2ULZ+bsd2nyMd5EZiKKDxYQKV/8I4TknH3Mkmc9\n\t4iWErMDh4kWaG7rxGBSVeVQ+SEZYdY/yUArzbS3nq5kvwdW/moyhK9MQ8xDymGECNiN2\n\tTTkkBAPf0p4/fsoyrQqzXy2igROrzn66zd5xTVyRLif13qrWE3AF8Ki8nVxfFMvwkg+u\n\tX/u56T4LYSetzOQeBcbO3n9Rftbgk25T9x9PBMirkM4GAquAD5X19XP0WJoOqLjdCLmQ\n\treqngxnTDiYwIRciWhJL7PycjMHk5940p77v4eZacWv1Fv0mzHYK8R9gEr5zz/B13lbM\n\tJskQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVS+Hm7uEVztvMqFl+cTyBzXLsNLAtWIjNNRvW0N3KrXqClHmkziV7sJTxX66QDsotlX2v8h7YxD7t55D/HZYY=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxzXcWHYpEDnweqVStMJ9hRWtvvymgmOYWTnw3W7twRHyjVq3u7\n\tNT25EWNwpW8sZ7fv9YHnpDWMOR7V2p1kWxR+SuyJinTuhV1XyLQ1iD+SM6gj0vEIkrsA3uAi2bM\n\troS+h0rZA7gAKP6BLAsOXaDSjn3qhbNnFruYY4erR6z6/Nm0YWQDhm2OpjWSqI8v/qFMoyPZmoc\n\tdodIJrbyE=","X-Gm-Gg":"ASbGncu8GrATOhZi2HMigBLnDDxwui2txKOWYpMmhRgX0M8Xz/YrdrrlIUy6jngpqaF\n\tt5/2DXowlGjAcDMp6Y7OfsZR/MGXtLyrKIEiMhir73hpe+j8z72nJpD5SEZnjiLPt/uRE6yV3eH\n\tY88PZrgEcM9FqV1xeF8EjtuZYrmiSrkIghVBzDoS82wxQ3UGlxGzk5BhT/TPM0vS/8Rxex9Ikle\n\tK2EqlT9kB32gxCDehvLsLBFpVyHuPnf1ziVx7+8RPvq9FXzhZ312x4EjFrHt+9SzT8/3sERr0xT\n\tdfszEq5qy7ojZjpRjZS3G4VCeVEC66btUuRFX+bHQYoE7CjTwooFkNj8X4VjUQj1kfN+kZMM3rG\n\tHetWj","X-Received":["by 2002:a05:600c:6214:b0:43c:f81d:34 with SMTP id\n\t5b1f17b1804b1-4538ee59e00mr48894155e9.9.1751051406203; \n\tFri, 27 Jun 2025 12:10:06 -0700 (PDT)","by 2002:a05:600c:6214:b0:43c:f81d:34 with SMTP id\n\t5b1f17b1804b1-4538ee59e00mr48893895e9.9.1751051405736; \n\tFri, 27 Jun 2025 12:10:05 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IG+dlVQhSspA5PwToMnM0ThWWPH9JNUOFrS62C1jlwna+ewSRl206auR0M8OY+YVTp2hsPtgg==","From":"Javier Martinez Canillas ","To":"Laurent Pinchart , Rob Clark\n\t","Cc":"Jacopo Mondi , David Airlie\n\t, Daniel Vetter , Maarten Lankhorst\n\t, Maxime Ripard , \n\tThomas Zimmermann , Naushir Patuck\n\t, dri-devel@lists.freedesktop.org,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","In-Reply-To":"<20250627180454.GD24912@pendragon.ideasonboard.com>","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>\n\t\n\t<20250627180454.GD24912@pendragon.ideasonboard.com>","Date":"Fri, 27 Jun 2025 21:10:04 +0200","Message-ID":"<877c0xatmb.fsf@minerva.mail-host-address-is-not-set>","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"_3I03rb9yuVnep-2jiX5eWEJxmHVikQenFUN-TNYqNU_1751051407","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34720,"web_url":"https://patchwork.libcamera.org/comment/34720/","msgid":"<874iw0b9bq.fsf@minerva.mail-host-address-is-not-set>","date":"2025-06-28T07:43:05","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":95,"url":"https://patchwork.libcamera.org/api/people/95/","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"content":"Rob Clark writes:\n\n> On Fri, Jun 27, 2025 at 12:10 PM Javier Martinez Canillas\n> wrote:\n>>\n>> Laurent Pinchart writes:\n>>\n>> > On Fri, Jun 27, 2025 at 09:39:37AM -0700, Rob Clark wrote:\n>> >> On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi wrote:\n>> >> >\n>> >> > Add FourCC definitions for the 48-bit RGB/BGR formats to the\n>> >> > DRM/KMS uapi.\n>> >> >\n>> >> > The format will be used by the Raspberry Pi PiSP Back End,\n>> >> > supported by a V4L2 driver in kernel space and by libcamera in\n>> >> > userspace, which uses the DRM FourCC identifiers.\n>> >> >\n>> >> > Signed-off-by: Jacopo Mondi \n>> >>\n>> >> Resurrecting this, as it appears to have not ever landed upstream\n>> >\n>> > What are the rule is for patches that touch core code like this one, can\n>> > they be pushed to drm-misc by anyone with commit access, or do they need\n>> > to be collected by a drm-misc maintainer ?\n>> >\n>>\n>> According to [0] I would say that you could just push it through drm-misc\n>> since there are already a few review-by tags collected.\n>>\n>> [0]: https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html#merge-criteria\n>\n> yeah, should be fine to push to drm-misc since it has r-b's (not to\n> mention no negative comments for a _long_ time)\n>\n\nPushed to drm-misc (drm-misc-next). Thanks!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C3F5BDCBF\n\tfor ;\n\tSat, 28 Jun 2025 07:43:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BFDA68E05;\n\tSat, 28 Jun 2025 09:43:14 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DED536152B\n\tfor ;\n\tSat, 28 Jun 2025 09:43:12 +0200 (CEST)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-638--3XeHKCoPom7eeMwXxnZDQ-1; Sat, 28 Jun 2025 03:43:09 -0400","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-451dda846a0so3882485e9.2\n\tfor ;\n\tSat, 28 Jun 2025 00:43:09 -0700 (PDT)","from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-453823ad20bsm102446295e9.20.2025.06.28.00.43.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 28 Jun 2025 00:43:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"XoaNXn6Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1751096591;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=U/zR+tRhdJvIMo++94eInuug2KHQSKfRczI4CreLh0Q=;\n\tb=XoaNXn6ZVwMMp7Vtn9mEUJV7eNp2ZBqLsPz+yjgoOy4dNDvx5ZSso/4GMSty39xCTwMKED\n\thLIq2ipgCGFFCGmWa4z8dNo6AvSxH/g+gONvcpJqU+BVawrltAfAkZC7P2KohiQkqlET7Y\n\t/WYxu6EjpZnTA7zSqovkhstJwxBjC64=","X-MC-Unique":"-3XeHKCoPom7eeMwXxnZDQ-1","X-Mimecast-MFC-AGG-ID":"-3XeHKCoPom7eeMwXxnZDQ_1751096588","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1751096588; x=1751701388;\n\th=content-transfer-encoding:mime-version:message-id:date:references\n\t:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=qmbjM2vUohQXnsREL9VLb8Q7wKmlAUxLknQWn0cbM3Y=;\n\tb=Pcb7x0UvAUS6cTh+kuu4Dg34VZgimbDWVZIZpeT/XIW8yPNEdpxLc4TQ+/j31PSmb1\n\tO17i3KE2CGQdUchIh8o4r6eo6NkOaO38cZs/1bsLAk55ezr4LLm/gEnNXe9ekbK/e3bK\n\t5u2zXqk9baSeGQlsjc1xNJau1RXAuvot8ZDTKUKax/XIKFrsJmsvd7oEfQ2LTFgKNJiW\n\t/sl+hQEprZgGdkEbLpDYipK5tIoLX+1/hnc+quIu9G5xBI4ZLs9EdIGIdTCkqw3Wy97b\n\trpNpA3xF7pTlOGbCIxKF4gNetHbWZ2TQL5InjX4QjFoX7Jmj4LZ5zHdg6IAo4BGIoujI\n\tR6Mw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXB+vy1aWcelaDkUgbYyTXhTSgqIlPCM+GaviJETkh11BT8KOFdsv7D4IusYbsgXOOrrZY+8IL4ly1Po4qY80Y=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YydaH8xiD+UR1zkPYi+jBudolENGPpYHMkBG5XQOpeCm99MOjVo\n\tYicXF6Ya+/y5mAEf4Nl2p59FoT0JUWlaQFPkZDr40QS79MJi7D1F3YIGUVxNuvQmjjZxFl1MCOv\n\tvyrjEGVrlrALSXDlr79I39+uB3AD/eHzSFiT6o54qKRjpwsDv3u6tYAVYgNszc6vfzK5h0C7ZfI\n\tg=","X-Gm-Gg":"ASbGnctW86quyl1l1G+TMjZiD7w4+mZUzJ53lw0IiqUOhnJQrUCw4awLocdzI0l0J1/\n\trCQGy3C/x8mm6V1nc1ub81hJdwCahFzjWVKTpP0SrHeFCCmvcWNKR839JVXgo/Dl0tA54o2OLOx\n\tcK99garwuqZaK2Mhm1pbcQurEsqVCBxYBvYvrn43r9jqxbKx+2T7IrzEe21bFUdiZqknlQTxg+G\n\tfQVWdXjQwu0vG4QBYiejkglQ+JtCnfZnf4T1NsA3YpfWDDeWc7eBJEm1GCwYwFpv/PU83zh0NmI\n\tfhtdmazE7qh9KphcyorFqLVyWj1KUGqPHmDiVqVKblhm+xZSeUH5AQTjghdMBiYWuRbVFpw6Vst\n\tcURo8","X-Received":["by 2002:a05:600c:4594:b0:43d:47b7:b32d with SMTP id\n\t5b1f17b1804b1-4538ee8c45emr59014465e9.25.1751096588252; \n\tSat, 28 Jun 2025 00:43:08 -0700 (PDT)","by 2002:a05:600c:4594:b0:43d:47b7:b32d with SMTP id\n\t5b1f17b1804b1-4538ee8c45emr59014205e9.25.1751096587847; \n\tSat, 28 Jun 2025 00:43:07 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IF9JsCzvfINyyhreU8rIGVzGLKJ/ZNnXhwma/38lPFC8lLrr8tx0To5Ucb+zO+RmWL+1x1o9A==","From":"Javier Martinez Canillas ","To":"rob.clark@oss.qualcomm.com","Cc":"Laurent Pinchart , Rob Clark\n\t, Jacopo Mondi ,\n\tDavid\n\tAirlie , Daniel Vetter , Maarten\n\tLankhorst , Maxime Ripard\n\t, Thomas Zimmermann , Naushir\n\tPatuck , dri-devel@lists.freedesktop.org,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","In-Reply-To":"","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>\n\t\n\t<20250627180454.GD24912@pendragon.ideasonboard.com>\n\t<877c0xatmb.fsf@minerva.mail-host-address-is-not-set>\n\t","Date":"Sat, 28 Jun 2025 09:43:05 +0200","Message-ID":"<874iw0b9bq.fsf@minerva.mail-host-address-is-not-set>","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"w0WtndNIg7HJyLRVDuM5mqdb43rh4V25Ka5_YuG2k60_1751096588","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34721,"web_url":"https://patchwork.libcamera.org/comment/34721/","msgid":"","date":"2025-06-28T03:59:47","subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","submitter":{"id":235,"url":"https://patchwork.libcamera.org/api/people/235/","name":"Rob Clark","email":"rob.clark@oss.qualcomm.com"},"content":"On Fri, Jun 27, 2025 at 12:10 PM Javier Martinez Canillas\n wrote:\n>\n> Laurent Pinchart writes:\n>\n> > On Fri, Jun 27, 2025 at 09:39:37AM -0700, Rob Clark wrote:\n> >> On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi wrote:\n> >> >\n> >> > Add FourCC definitions for the 48-bit RGB/BGR formats to the\n> >> > DRM/KMS uapi.\n> >> >\n> >> > The format will be used by the Raspberry Pi PiSP Back End,\n> >> > supported by a V4L2 driver in kernel space and by libcamera in\n> >> > userspace, which uses the DRM FourCC identifiers.\n> >> >\n> >> > Signed-off-by: Jacopo Mondi \n> >>\n> >> Resurrecting this, as it appears to have not ever landed upstream\n> >\n> > What are the rule is for patches that touch core code like this one, can\n> > they be pushed to drm-misc by anyone with commit access, or do they need\n> > to be collected by a drm-misc maintainer ?\n> >\n>\n> According to [0] I would say that you could just push it through drm-misc\n> since there are already a few review-by tags collected.\n>\n> [0]: https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html#merge-criteria\n\nyeah, should be fine to push to drm-misc since it has r-b's (not to\nmention no negative comments for a _long_ time)\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAC9AC3237\n\tfor ;\n\tSat, 28 Jun 2025 08:26:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02C4268E04;\n\tSat, 28 Jun 2025 10:26:41 +0200 (CEST)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BE6761527\n\tfor ;\n\tSat, 28 Jun 2025 06:00:01 +0200 (CEST)","from pps.filterd (m0279863.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n\t55S3Z3Ua012053 for ;\n\tSat, 28 Jun 2025 03:59:59 GMT","from mail-oa1-f69.google.com (mail-oa1-f69.google.com\n\t[209.85.160.69])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j8m600x8-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128\n\tverify=NOT) for ;\n\tSat, 28 Jun 2025 03:59:59 +0000 (GMT)","by mail-oa1-f69.google.com with SMTP id\n\t586e51a60fabf-2da802bd11eso961213fac.0\n\tfor ;\n\tFri, 27 Jun 2025 20:59:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"Vyfz+J3P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:reply-to:subject:to; s=\n\tqcppdkim1; bh=zvf9ppUj6F8YNp/HoveJCKlmtqHiQeMD/hZ+bilUb2E=; b=Vy\n\tfz+J3P8miqQ7t/+aL5MN8MroBYEmU4ql+20BC3waXYIifKmXtBAxDbE7j2CqbyXV\n\tLwiZyL+o81TDvc0WZlDOh/0CvW/Nzg7OyiGLHhWY7aXOFRUEwHu+NT0I5wCpOaig\n\t9SystzkgLX+T1tTOS/Q95un/o6GM37Pfj15ziE+koOQsC2Vv/qfV5nZ4ep3rgQZj\n\tfeWd95qfXVQGfoGzVjyyPV73qYC75BCVJ2Dov2GXqVCsdpxaxvBYFbHkHxOpht0r\n\tR8qfW3We5sM4YsOBa1kOLPFydxxRF16bb5xYzomIcjaIqI9kQ9sbibq5INaTdxpc\n\t/IK/L0emk4aYKyfLSSGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1751083198; x=1751687998;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:reply-to:in-reply-to:references:mime-version:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=zvf9ppUj6F8YNp/HoveJCKlmtqHiQeMD/hZ+bilUb2E=;\n\tb=fj4p8EIWsRCzzi/FvSRniJRLxzapSjmc4GujB5L/tKzphcw2Q3Ex3+spOWZXVW+Lx3\n\tsDRhpCHR8qSjeCB8H9/WE9yAqBD1Dm75bcdFGApqCmtRtJccO3inVK8mDapFas3gxX1c\n\tqTZ66vHfvWJPXDVlRrbvgxpvFpXOe4jwqKamxmsOBUpEprRSH0rsMOLmuUKXGJ2FDjSq\n\tyCXr9Evtrj01eWFUTHu5hhKeuu2NUB05e9EzTNRamgpmxpK5F20Stv/pLUQRop8/SWAv\n\tzg87Moh84eBE02CvaN/QC4dmL5MZk7dOGgaMbUzEbQLCYrMMByi/sEhhFVJzjcL+7vIP\n\t/USA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCW3DjSYi7yKAidiMrcU5P1qHUmAymPGxE2ygeqMUkuMnJuHXZetSmaNB7YPimgFxMmonbzXb4iAAkbHrdgoi0E=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yyxd2TXk/hGkspZ9BRnNsd4PoLTxlztOHuREmRJHsQ9CMGAsrdU\n\tuX6oYktX4NcdmQB+PhbsoB58UexaGEEsw4CLbSgaohXPGS4MRCGL7l6V5pVZv4NRe1hP51Dwkik\n\tgzQXZs2xSVBqxJ8at7FvVm19c1lqfghAf5ic1zH19Wnh081Cc6V5W56TGnhOkrn9v4UnVwLvp3l\n\t8pFSUGpEcPDqYyco0pJEkC4Vrdoa5nOdxP+KHCAoyV3+/GZdsXwX0=","X-Gm-Gg":"ASbGncvlagJSXztTj7xFOTZAuxc8sGx+iBS+4N1n6/Z1+julPAwJ643JGRxvmLkFLF/\n\tCjtpgFL54Ggn+UUOrZhp2VEMTpwJASZNLLH6PCzrAnWW0NcF1M8PVP9vDUuVYSFXHHNh+T/zZOU\n\tGIA0aILs9GRN0dz44Lg73EnRgRajvR9ztBsno=","X-Received":["by 2002:a05:6870:85d0:b0:2cc:3530:d313 with SMTP id\n\t586e51a60fabf-2efed684547mr3381060fac.25.1751083198275; \n\tFri, 27 Jun 2025 20:59:58 -0700 (PDT)","by 2002:a05:6870:85d0:b0:2cc:3530:d313 with SMTP id\n\t586e51a60fabf-2efed684547mr3381051fac.25.1751083197946;\n\tFri, 27 Jun 2025 20:59:57 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IG07UzpZ+D6JCb2jHfZNGeMQ/Kfuq7IKnRyeJs8gLL1wBON/XUk5ny9SXbXsV4Qty1jv6PI/sxO0/uvr1j/2fk=","MIME-Version":"1.0","References":"<20240226132544.82817-1-jacopo.mondi@ideasonboard.com>\n\t\n\t<20250627180454.GD24912@pendragon.ideasonboard.com>\n\t<877c0xatmb.fsf@minerva.mail-host-address-is-not-set>","In-Reply-To":"<877c0xatmb.fsf@minerva.mail-host-address-is-not-set>","From":"Rob Clark ","Date":"Fri, 27 Jun 2025 20:59:47 -0700","X-Gm-Features":"Ac12FXwmYamHcHQ72u1toAJIIz0k_SZ2IgX302BTqT0M5-TC5fb8Di5vkqP3R_Y","Message-ID":"","Subject":"Re: [PATCH] drm/fourcc: Add RGB161616 and BGR161616 formats","To":"Javier Martinez Canillas ","Cc":"Laurent Pinchart ,\n\tRob Clark ,\n\tJacopo Mondi ,\n\tDavid Airlie , Daniel Vetter ,\n\tMaarten Lankhorst ,\n\tMaxime Ripard ,\n\tThomas Zimmermann ,\n\tNaushir Patuck ,\n\tdri-devel@lists.freedesktop.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjUwNjI4MDAyOSBTYWx0ZWRfXzKRpnS5Cl+4g\n\t39fXE7KTYEpTdVzUS88FVu1cDKAGXwIqnzVKiZULREO6yPHo8QkDuYqwbn7kz1pu80X4xpqAtRZ\n\tWeLz/masDTNQDdH8T2gShn4v1eSp7EMkFBDD+cV/WaevB6icrYuEUEfwvrMsnrGFcOSDAer5fpB\n\to1CPFyQAHidHPG+mLMlu1oDGNLleKacOM7Q76t8IVckpMDikUWAe/0v6KlySE8Xe0H1HWxbJRZ4\n\t5+oQxk3H6hM1BXhCCmZn7JDkI4EIC9GgmrVHBjoru584zWjIemJEL0MuaAOP3EG5B5ls4Icab5I\n\tJNhoFNB5oEbefHbr/FzYSKeZrrzurw9o85KW4qz5eRnthrJz5JYYHrpit7u1Zd9Ot0fJDA1du+1\n\tE+SmB1zmgOAIJizDKp1dLbUm8Qfe2KMMZjA9zV8pn8N4UP7T1E7XqQuHal0zrH+lp4SJnW7s","X-Authority-Analysis":"v=2.4 cv=Fq0F/3rq c=1 sm=1 tr=0 ts=685f68bf cx=c_pps\n\ta=zPxD6eHSjdtQ/OcAcrOFGw==:117 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10\n\ta=e5mUnYsNAAAA:8 a=20KFwNOVAAAA:8 a=P1BnusSwAAAA:8\n\ta=ZjRaYm2IgVGhPE4A6A0A:9\n\ta=QEXdDO2ut3YA:10 a=P2XgnWxznO8A:10 a=y8BKWJGFn5sdPF1Y92-H:22\n\ta=Vxmtnl_E_bksehYqCbjh:22 a=D0XLA9XvdZm18NrgonBM:22","X-Proofpoint-GUID":"JuAzGeVMSqh3glEeOLrIB4bKu12PdQcx","X-Proofpoint-ORIG-GUID":"JuAzGeVMSqh3glEeOLrIB4bKu12PdQcx","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1099, Hydra:6.1.7,\n\tFMLib:17.12.80.40\n\tdefinitions=2025-06-27_05,2025-06-27_01,2025-03-28_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tphishscore=0 mlxscore=0 suspectscore=0 adultscore=0 clxscore=1011\n\tmlxlogscore=999 impostorscore=0 bulkscore=0 malwarescore=0\n\tspamscore=0\n\tpriorityscore=1501 lowpriorityscore=0 classifier=spam authscore=0\n\tauthtc=n/a\n\tauthcc= route=outbound adjust=0 reason=mlx scancount=1\n\tengine=8.19.0-2505280000 definitions=main-2506280029","X-Mailman-Approved-At":"Sat, 28 Jun 2025 10:26:40 +0200","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"rob.clark@oss.qualcomm.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]