[{"id":28732,"web_url":"https://patchwork.libcamera.org/comment/28732/","msgid":"<20240226100710.GC28701@pendragon.ideasonboard.com>","date":"2024-02-26T10:07:10","subject":"Re: [PATCH 2/2] utils: ipu3: Fix return value check on file output","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Feb 26, 2024 at 09:48:57AM +0000, Kieran Bingham wrote:\n> The data parsed by ipu3-unpack is written out using the write() c\n\ns/c$/C/\n\n> library call, but the error code is incorrectly checked which misses the\n> single erroroneous return value returned by the function.\n> \n> Fix it to explicitly check against the error code.\n> \n> Reported-by: Johan Mattsson <39247600+mjunix@users.noreply.github.com>\n\nWith this dropped,\n\nReviewed-by: Laurent Pinchart \n\n> Fixes: 23ac77dc4a09 (\"utils: ipu3: Add IPU3 raw capture unpack utility\")\n> Signed-off-by: Kieran Bingham \n> ---\n> utils/ipu3/ipu3-unpack.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/ipu3/ipu3-unpack.c b/utils/ipu3/ipu3-unpack.c\n> index 9d2c1200d932..c96fafed2435 100644\n> --- a/utils/ipu3/ipu3-unpack.c\n> +++ b/utils/ipu3/ipu3-unpack.c\n> @@ -78,7 +78,7 @@ int main(int argc, char *argv[])\n> \t\t}\n> \n> \t\tret = write(out_fd, out_data, 50);\n> -\t\tif (ret < -1) {\n> +\t\tif (ret == -1) {\n> \t\t\tfprintf(stderr, \"Failed to write output data: %s\\n\",\n> \t\t\t\tstrerror(errno));\n> \t\t\tgoto done;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A66B8BD80A\n\tfor ;\n\tMon, 26 Feb 2024 10:07:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54FE062877;\n\tMon, 26 Feb 2024 11:07:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2AD46286B\n\tfor ;\n\tMon, 26 Feb 2024 11:07:07 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87254672;\n\tMon, 26 Feb 2024 11:06:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rgYAfOyw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708942016;\n\tbh=+6hx5qZadyMOmtyir+e7raj6bP16mvldUGJigw0+BN8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rgYAfOyw+jTWKmC2of21PNWqWxqgdJdJZqWU7tA6Xn3dkjjsqkvtJG0lRwDT8p5Up\n\tfVElwrpzwFAZVtBzH/mhGaoVdQNint/A8UuL5N22Q9e0v8506nmJlGzlQlVWlSN7/A\n\tw6KaJ+BS2KfaqWlomAiYi0SqEJKNdnTx2E4p09Ms=","Date":"Mon, 26 Feb 2024 12:07:10 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Subject":"Re: [PATCH 2/2] utils: ipu3: Fix return value check on file output","Message-ID":"<20240226100710.GC28701@pendragon.ideasonboard.com>","References":"<20240226094857.2207313-1-kieran.bingham@ideasonboard.com>\n\t<20240226094857.2207313-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240226094857.2207313-3-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28745,"web_url":"https://patchwork.libcamera.org/comment/28745/","msgid":"","date":"2024-02-27T09:31:34","subject":"Re: [PATCH 2/2] utils: ipu3: Fix return value check on file output","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 26/02/24 3:37 pm, Laurent Pinchart wrote:\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Mon, Feb 26, 2024 at 09:48:57AM +0000, Kieran Bingham wrote:\n>> The data parsed by ipu3-unpack is written out using the write() c\n> s/c$/C/\n>\n>> library call, but the error code is incorrectly checked which misses the\n>> single erroroneous return value returned by the function.\n>>\n>> Fix it to explicitly check against the error code.\n>>\n>> Reported-by: Johan Mattsson <39247600+mjunix@users.noreply.github.com>\n> With this dropped,\n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n>\n>> Fixes: 23ac77dc4a09 (\"utils: ipu3: Add IPU3 raw capture unpack utility\")\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> utils/ipu3/ipu3-unpack.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/utils/ipu3/ipu3-unpack.c b/utils/ipu3/ipu3-unpack.c\n>> index 9d2c1200d932..c96fafed2435 100644\n>> --- a/utils/ipu3/ipu3-unpack.c\n>> +++ b/utils/ipu3/ipu3-unpack.c\n>> @@ -78,7 +78,7 @@ int main(int argc, char *argv[])\n>> \t\t}\n>> \n>> \t\tret = write(out_fd, out_data, 50);\n>> -\t\tif (ret < -1) {\n>> +\t\tif (ret == -1) {\n>> \t\t\tfprintf(stderr, \"Failed to write output data: %s\\n\",\n>> \t\t\t\tstrerror(errno));\n>> \t\t\tgoto done;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAA8DBD160\n\tfor ;\n\tTue, 27 Feb 2024 09:31:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 218226285F;\n\tTue, 27 Feb 2024 10:31:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E622E627FC\n\tfor ;\n\tTue, 27 Feb 2024 10:31:43 +0100 (CET)","from [192.168.1.102] (unknown [103.251.226.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 441578D4;\n\tTue, 27 Feb 2024 10:31:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gnoSQLBl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709026292;\n\tbh=eJILpMQwoO45QcfHZxJmWj317+NFmRG2yOIE64ORvZo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=gnoSQLBliH0G/+9YLhrtyPhB7VPPN2G39YSgWFpIIfvM4jzPa38NHgs0u9qOtMKU3\n\tBvuCjR+cilQOGRElonwsZDvFnUmN/qg8TvYrECmkjmNZWUlOvzn69v0vauaFEfQ1GW\n\twwjlCFVDcPm4sXnIxLI52f9EcBoQfKWtUfE7XFyc=","Message-ID":"","Date":"Tue, 27 Feb 2024 15:01:34 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/2] utils: ipu3: Fix return value check on file output","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20240226094857.2207313-1-kieran.bingham@ideasonboard.com>\n\t<20240226094857.2207313-3-kieran.bingham@ideasonboard.com>\n\t<20240226100710.GC28701@pendragon.ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240226100710.GC28701@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]