[{"id":28729,"web_url":"https://patchwork.libcamera.org/comment/28729/","msgid":"<170894140908.1011926.11274612423484142007@ping.linuxembedded.co.uk>","date":"2024-02-26T09:56:49","subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2024-02-26 09:48:56)\n> The plane validation in the stride helper incorrectly accepts the number\n> of planes as a plane index. Fix the off by one issue.\n> \n> Reported-by: Johan Mattsson <39247600+mjunix@users.noreply.github.com>\n\nAs that's a @users.noreply this bounces and I don't think I can really\nkeep this as is, even though that's what Github seems to provide.\n\nI could do:\n\nReported-by: Johan Mattsson \n\nPerhaps, or simply lose the reporter.\nOpinions anyone ?\n\n--\nKieran\n\n\n> Fixes: e83727a194b5 (\"libcamera: PixelFormatInfo: Add functions stride and frameSize\")\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/formats.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 447e623803c7..c11fbd730c8e 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -987,7 +987,7 @@ unsigned int PixelFormatInfo::stride(unsigned int width, unsigned int plane,\n> return 0;\n> }\n> \n> - if (plane > planes.size() || !planes[plane].bytesPerGroup) {\n> + if (plane >= planes.size() || !planes[plane].bytesPerGroup) {\n> LOG(Formats, Warning) << \"Invalid plane index, stride is zero\";\n> return 0;\n> }\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C8B5BD80A\n\tfor ;\n\tMon, 26 Feb 2024 09:56:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12AD462870;\n\tMon, 26 Feb 2024 10:56:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2C306286B\n\tfor ;\n\tMon, 26 Feb 2024 10:56:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 851C9673;\n\tMon, 26 Feb 2024 10:56:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iNbVoTJH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708941400;\n\tbh=OvLRd7jQseysFXVrVC0vnITjh/u0D19UoFUskEjQJsU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=iNbVoTJHHsdqpLFKfBQSimcBkpFAmVLF38QyPIKx+usN+lsMGhZvj0dh9bt05PE7h\n\tyMASEFB0bLKipCNxZURe5yTF4mtCQdRN9+gC2SWtZSeclmrPQc6x4+4Vq/hgQ2AniY\n\tvhQC0vEwff3tNc43z4eq2ZJaCN5y/kusxTL7xYuA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240226094857.2207313-2-kieran.bingham@ideasonboard.com>","References":"<20240226094857.2207313-1-kieran.bingham@ideasonboard.com>\n\t<20240226094857.2207313-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Mon, 26 Feb 2024 09:56:49 +0000","Message-ID":"<170894140908.1011926.11274612423484142007@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Johan Mattsson <39247600+mjunix@users.noreply.github.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28730,"web_url":"https://patchwork.libcamera.org/comment/28730/","msgid":"<20240226100205.GA28701@pendragon.ideasonboard.com>","date":"2024-02-26T10:02:05","subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Feb 26, 2024 at 09:56:49AM +0000, Kieran Bingham wrote:\n> Quoting Kieran Bingham (2024-02-26 09:48:56)\n> > The plane validation in the stride helper incorrectly accepts the number\n> > of planes as a plane index. Fix the off by one issue.\n> > \n> > Reported-by: Johan Mattsson <39247600+mjunix@users.noreply.github.com>\n> \n> As that's a @users.noreply this bounces and I don't think I can really\n> keep this as is, even though that's what Github seems to provide.\n> \n> I could do:\n> \n> Reported-by: Johan Mattsson \n> \n> Perhaps, or simply lose the reporter.\n> Opinions anyone ?\n\nIf there's no usable e-mail address, I'd just drop the reporter. The\nmain point of the Reported-by tag is (in my opinion) to be able to\ncontact the reporter to get more information. In this case the problem\nis trivial, so there's no big value in reporter information.\n\n> > Fixes: e83727a194b5 (\"libcamera: PixelFormatInfo: Add functions stride and frameSize\")\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/formats.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index 447e623803c7..c11fbd730c8e 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -987,7 +987,7 @@ unsigned int PixelFormatInfo::stride(unsigned int width, unsigned int plane,\n> > return 0;\n> > }\n> > \n> > - if (plane > planes.size() || !planes[plane].bytesPerGroup) {\n> > + if (plane >= planes.size() || !planes[plane].bytesPerGroup) {\n> > LOG(Formats, Warning) << \"Invalid plane index, stride is zero\";\n> > return 0;\n> > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AD41BD160\n\tfor ;\n\tMon, 26 Feb 2024 10:02:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A4DE6286E;\n\tMon, 26 Feb 2024 11:02:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0F416286B\n\tfor ;\n\tMon, 26 Feb 2024 11:02:03 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AEE1672;\n\tMon, 26 Feb 2024 11:01:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ilsWjP2Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708941712;\n\tbh=ZHlaRZbu5RfPWHbKFPZHFsjdNFWk+2jvdH0hs7jrTxY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ilsWjP2YdjjiCS3G92t0CHEQcSuQCVpZ8gTPqSdV+KdlwdZK1BLzIySwfBCLvG8SA\n\tniN76giwiKPIqAfzljmRwlode1pI2lMrvIeZDNPc8netZZLoXWh3OL6lWZWRD0QxGL\n\tmuZt0sW7d/kLCwdEiTMR+5TFa7EGBd0hFR6rdvow=","Date":"Mon, 26 Feb 2024 12:02:05 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","Message-ID":"<20240226100205.GA28701@pendragon.ideasonboard.com>","References":"<20240226094857.2207313-1-kieran.bingham@ideasonboard.com>\n\t<20240226094857.2207313-2-kieran.bingham@ideasonboard.com>\n\t<170894140908.1011926.11274612423484142007@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<170894140908.1011926.11274612423484142007@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tJohan Mattsson <39247600+mjunix@users.noreply.github.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28731,"web_url":"https://patchwork.libcamera.org/comment/28731/","msgid":"<20240226100609.GB28701@pendragon.ideasonboard.com>","date":"2024-02-26T10:06:09","subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Feb 26, 2024 at 12:02:07PM +0200, Laurent Pinchart wrote:\n> On Mon, Feb 26, 2024 at 09:56:49AM +0000, Kieran Bingham wrote:\n> > Quoting Kieran Bingham (2024-02-26 09:48:56)\n> > > The plane validation in the stride helper incorrectly accepts the number\n> > > of planes as a plane index. Fix the off by one issue.\n> > > \n> > > Reported-by: Johan Mattsson <39247600+mjunix@users.noreply.github.com>\n> > \n> > As that's a @users.noreply this bounces and I don't think I can really\n> > keep this as is, even though that's what Github seems to provide.\n> > \n> > I could do:\n> > \n> > Reported-by: Johan Mattsson \n> > \n> > Perhaps, or simply lose the reporter.\n> > Opinions anyone ?\n> \n> If there's no usable e-mail address, I'd just drop the reporter. The\n> main point of the Reported-by tag is (in my opinion) to be able to\n> contact the reporter to get more information. In this case the problem\n> is trivial, so there's no big value in reporter information.\n\nWith this fixed,\n\nReviewed-by: Laurent Pinchart \n\n> > > Fixes: e83727a194b5 (\"libcamera: PixelFormatInfo: Add functions stride and frameSize\")\n> > > Signed-off-by: Kieran Bingham \n> > > ---\n> > > src/libcamera/formats.cpp | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > > index 447e623803c7..c11fbd730c8e 100644\n> > > --- a/src/libcamera/formats.cpp\n> > > +++ b/src/libcamera/formats.cpp\n> > > @@ -987,7 +987,7 @@ unsigned int PixelFormatInfo::stride(unsigned int width, unsigned int plane,\n> > > return 0;\n> > > }\n> > > \n> > > - if (plane > planes.size() || !planes[plane].bytesPerGroup) {\n> > > + if (plane >= planes.size() || !planes[plane].bytesPerGroup) {\n> > > LOG(Formats, Warning) << \"Invalid plane index, stride is zero\";\n> > > return 0;\n> > > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62109BD80A\n\tfor ;\n\tMon, 26 Feb 2024 10:06:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7375662870;\n\tMon, 26 Feb 2024 11:06:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7E3862867\n\tfor ;\n\tMon, 26 Feb 2024 11:06:07 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 290CD672;\n\tMon, 26 Feb 2024 11:05:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M/7t0Dec\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708941956;\n\tbh=GhvNpS++miL/2WsJeIxw+lvJTvs34juYc4aQW7ngfds=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M/7t0DechtqQ2g6uZd8NMkDFqk//ekforycnArfcj6JxAHEDUuYUEGMd0aWDgB3W3\n\tCT9m2Ob2kerjIcO6dKrjuiY7q3pSQZcbjp/daose6DuAC8GLL5lpuHQAF7qQahDjAH\n\toISFbP78WGB9AE0gNfwpRu6yFe0IXJpcvSnwiq18=","Date":"Mon, 26 Feb 2024 12:06:09 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","Message-ID":"<20240226100609.GB28701@pendragon.ideasonboard.com>","References":"<20240226094857.2207313-1-kieran.bingham@ideasonboard.com>\n\t<20240226094857.2207313-2-kieran.bingham@ideasonboard.com>\n\t<170894140908.1011926.11274612423484142007@ping.linuxembedded.co.uk>\n\t<20240226100205.GA28701@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240226100205.GA28701@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tJohan Mattsson <39247600+mjunix@users.noreply.github.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28746,"web_url":"https://patchwork.libcamera.org/comment/28746/","msgid":"<9ecfcbc2-5026-4e25-bc47-0f10022bb55c@ideasonboard.com>","date":"2024-02-27T09:32:55","subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 26/02/24 3:36 pm, Laurent Pinchart wrote:\n> On Mon, Feb 26, 2024 at 12:02:07PM +0200, Laurent Pinchart wrote:\n>> On Mon, Feb 26, 2024 at 09:56:49AM +0000, Kieran Bingham wrote:\n>>> Quoting Kieran Bingham (2024-02-26 09:48:56)\n>>>> The plane validation in the stride helper incorrectly accepts the number\n>>>> of planes as a plane index. Fix the off by one issue.\n>>>>\n>>>> Reported-by: Johan Mattsson <39247600+mjunix@users.noreply.github.com>\n>>> As that's a @users.noreply this bounces and I don't think I can really\n>>> keep this as is, even though that's what Github seems to provide.\n>>>\n>>> I could do:\n>>>\n>>> Reported-by: Johan Mattsson \n>>>\n>>> Perhaps, or simply lose the reporter.\n>>> Opinions anyone ?\n>> If there's no usable e-mail address, I'd just drop the reporter. The\n>> main point of the Reported-by tag is (in my opinion) to be able to\n>> contact the reporter to get more information. In this case the problem\n>> is trivial, so there's no big value in reporter information.\n> With this fixed,\n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n>\n>>>> Fixes: e83727a194b5 (\"libcamera: PixelFormatInfo: Add functions stride and frameSize\")\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> src/libcamera/formats.cpp | 2 +-\n>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n>>>> index 447e623803c7..c11fbd730c8e 100644\n>>>> --- a/src/libcamera/formats.cpp\n>>>> +++ b/src/libcamera/formats.cpp\n>>>> @@ -987,7 +987,7 @@ unsigned int PixelFormatInfo::stride(unsigned int width, unsigned int plane,\n>>>> return 0;\n>>>> }\n>>>> \n>>>> - if (plane > planes.size() || !planes[plane].bytesPerGroup) {\n>>>> + if (plane >= planes.size() || !planes[plane].bytesPerGroup) {\n>>>> LOG(Formats, Warning) << \"Invalid plane index, stride is zero\";\n>>>> return 0;\n>>>> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40D31BD160\n\tfor ;\n\tTue, 27 Feb 2024 09:33:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6220627FE;\n\tTue, 27 Feb 2024 10:32:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C626627FC\n\tfor ;\n\tTue, 27 Feb 2024 10:32:58 +0100 (CET)","from [192.168.1.102] (unknown [103.251.226.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 676598D4;\n\tTue, 27 Feb 2024 10:32:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BVy7ecDN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709026366;\n\tbh=YV9H4vw1TBJFDz+y9nT0WALRoTrvtWB/iTjYzYYdCp8=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=BVy7ecDNHV41tn24kaj6rvcGQi/OPUSybW4HaFj0sHvSUqm5o0dVMGXOp10/uWOp6\n\tttZBNmJRaGo4tVVS9ew/al3/gO6H5RZVVgmnA6nlPg2otltTs4TxfbQH9AQCjLbZ+B\n\tHKDmbE6D4ADChXbjInqH1YRUeSqY8+drK+4Ckb+Q=","Message-ID":"<9ecfcbc2-5026-4e25-bc47-0f10022bb55c@ideasonboard.com>","Date":"Tue, 27 Feb 2024 15:02:55 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] libcamera: formats: Fix planes bounds check","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20240226094857.2207313-1-kieran.bingham@ideasonboard.com>\n\t<20240226094857.2207313-2-kieran.bingham@ideasonboard.com>\n\t<170894140908.1011926.11274612423484142007@ping.linuxembedded.co.uk>\n\t<20240226100205.GA28701@pendragon.ideasonboard.com>\n\t<20240226100609.GB28701@pendragon.ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240226100609.GB28701@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tJohan Mattsson <39247600+mjunix@users.noreply.github.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]