[{"id":28727,"web_url":"https://patchwork.libcamera.org/comment/28727/","msgid":"<170889123240.914352.5944104024838840322@ping.linuxembedded.co.uk>","date":"2024-02-25T20:00:32","subject":"Re: [PATCH 1/2] libcamera: utils: Add to_underlying() helper\n\tfunction","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-02-25 16:43:46)\n> C++23 has a std::to_underlying() helper function that converts an\n> enumeration value to its underlying type. Add a compatible\n> implementation to the libcamera::utils namespace.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/base/utils.h | 6 ++++++\n> src/libcamera/base/utils.cpp | 10 ++++++++++\n> 2 files changed, 16 insertions(+)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 37d9af609ec7..922e4dfaf9fa 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -369,6 +369,12 @@ decltype(auto) abs_diff(const T &a, const T &b)\n> \n> double strtod(const char *__restrict nptr, char **__restrict endptr);\n> \n> +template\n> +constexpr std::underlying_type_t to_underlying(Enum e) noexcept\n> +{\n> + return static_cast>(e);\n> +}\n\nLooks good compared to my understanding from:\nhttps://en.cppreference.com/w/cpp/utility/to_underlying\n\nReviewed-by: Kieran Bingham \n\n> +\n> } /* namespace utils */\n> \n> #ifndef __DOXYGEN__\n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 3b73b442260a..2f4c3177ac13 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -521,6 +521,16 @@ double strtod(const char *__restrict nptr, char **__restrict endptr)\n> #endif\n> }\n> \n> +/**\n> + * \\fn to_underlying(Enum e)\n> + * \\brief Convert an enumeration to its underlygin type\n> + * \\param[in] e Enumeration value to convert\n> + *\n> + * This function is equivalent to the C++23 std::to_underlying().\n> + *\n> + * \\return The value of e converted to its underlying type\n> + */\n> +\n> } /* namespace utils */\n> \n> #ifndef __DOXYGEN__\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1EAEBD160\n\tfor ;\n\tSun, 25 Feb 2024 20:00:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E753B62867;\n\tSun, 25 Feb 2024 21:00:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75F3761CA1\n\tfor ;\n\tSun, 25 Feb 2024 21:00:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 636F38C;\n\tSun, 25 Feb 2024 21:00:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m5I46iV8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708891224;\n\tbh=PFPke3ABHk4KRaSwSjDwIaG52F7AfkBISjXOBH0gQQQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=m5I46iV8cc+pHtKQEHG3RWYEGbiPwJI+oLKND5kkt+TPqCU1CVHfHDiA8gQBieP9B\n\tbMCy0aDpFk4U9IiPx9sFYQ2/ur85cawAuXO17Pl6GnwW9WHXANEpeON7o8YRE68mxH\n\tyOAwPIXS91j5d45V+s/W+5+puStBQoad/LTHgEvk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240225164348.10073-2-laurent.pinchart@ideasonboard.com>","References":"<20240225164348.10073-1-laurent.pinchart@ideasonboard.com>\n\t<20240225164348.10073-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 1/2] libcamera: utils: Add to_underlying() helper\n\tfunction","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 25 Feb 2024 20:00:32 +0000","Message-ID":"<170889123240.914352.5944104024838840322@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]