[{"id":28726,"web_url":"https://patchwork.libcamera.org/comment/28726/","msgid":"<20240223204215.GE1313@pendragon.ideasonboard.com>","date":"2024-02-23T20:42:15","subject":"Re: [PATCH v2 2/2] meson_options: Autodetect pycamera support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Feb 23, 2024 at 05:47:18PM +0000, Kieran Bingham wrote:\n> The pycamera was defaulted to be disabled due to a requirement\n> on a specialised branch of the pybind dependency.\n> \n> This requirement on a subproject has been removed and we can\n> now build the pycamera component provided that the distribution\n> packages pybind directly which is common.\n> \n> Enable the pycamera build option to be selected automatically\n> when both Python and pybind are detected on the system.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  meson_options.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 5fdc7be87a54..99dab96d7b21 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -53,7 +53,7 @@ option('pipelines',\n>  \n>  option('pycamera',\n>          type : 'feature',\n> -        value : 'disabled',\n> +        value : 'auto',\n>          description : 'Enable libcamera Python bindings (experimental)')\n>  \n>  option('qcam',","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE8A9BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Feb 2024 20:42:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 057FA62809;\n\tFri, 23 Feb 2024 21:42:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AACDA61CA1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Feb 2024 21:42:12 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCF40FF1;\n\tFri, 23 Feb 2024 21:42:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LZhHHxIx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708720923;\n\tbh=h1fQdoOYqqN3afZvE5GA+zRdJfsDvi07XShBcWP7xkc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LZhHHxIx0OXt8U65wwzCRQ2Qlb3QuZK5JWdSJOzyW/UBZt99BUO0WQ618PgtSx6m8\n\tHIJrBLTvOBT6HYfd81MopLD8CmnwS4LWub0iYWizJQy8nMW7j2V8i+vRQDg8+5W4xH\n\tY41HnUKYqxGxoR2w5eUfxvP4/6CDJknxY6w2OMTg=","Date":"Fri, 23 Feb 2024 22:42:15 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v2 2/2] meson_options: Autodetect pycamera support","Message-ID":"<20240223204215.GE1313@pendragon.ideasonboard.com>","References":"<20240223174718.198950-1-kieran.bingham@ideasonboard.com>\n\t<20240223174718.198950-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240223174718.198950-3-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]