[{"id":28866,"web_url":"https://patchwork.libcamera.org/comment/28866/","msgid":"<0d09501d-12aa-452b-a547-ea01bc38ad19@ideasonboard.com>","date":"2024-03-05T11:41:02","subject":"Re: [PATCH 2/5] libcamera: rkisp1: Create a request with a custom\n\tprivate class","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 21/02/2024 17:40, Jacopo Mondi wrote:\n> Signed-off-by: Jacopo Mondi \n> ---\n\nReviewed-by: Daniel Scally \n\nand\n\nTested-by: Daniel Scally \n\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 19 +++++++++++++++++++\n> 1 file changed, 19 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 586b46d64630..e981e60758f7 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -39,6 +39,7 @@\n> #include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> #include \"libcamera/internal/v4l2_subdevice.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> @@ -83,6 +84,15 @@ private:\n> \tstd::map frameInfo_;\n> };\n> \n> +class RkISP1Request : public Request::Private\n> +{\n> +public:\n> +\tRkISP1Request(Camera *camera)\n> +\t\t: Request::Private(camera)\n> +\t{\n> +\t}\n> +};\n> +\n> class RkISP1CameraData : public Camera::Private\n> {\n> public:\n> @@ -157,6 +167,8 @@ public:\n> \tint start(Camera *camera, const ControlList *controls) override;\n> \tvoid stopDevice(Camera *camera) override;\n> \n> +\tstd::unique_ptr createRequestDevice(Camera *camera,\n> +\t\t\t\t\t\t uint64_t cookie) override;\n> \tint queueRequestDevice(Camera *camera, Request *request) override;\n> \n> \tbool match(DeviceEnumerator *enumerator) override;\n> @@ -1020,6 +1032,13 @@ void PipelineHandlerRkISP1::stopDevice(Camera *camera)\n> \tactiveCamera_ = nullptr;\n> }\n> \n> +std::unique_ptr PipelineHandlerRkISP1::createRequestDevice(Camera *camera,\n> +\t\t\t\t\t\t\t\t uint64_t cookie)\n> +{\n> +\tauto request = std::make_unique(camera);\n> +\treturn Request::create(std::move(request), cookie);\n> +}\n> +\n> int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request)\n> {\n> \tRkISP1CameraData *data = cameraData(camera);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B1E5BD160\n\tfor ;\n\tTue, 5 Mar 2024 11:41:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9AB762873;\n\tTue, 5 Mar 2024 12:41:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15A3961C92\n\tfor ;\n\tTue, 5 Mar 2024 12:41:03 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B6D022A\n\tfor ;\n\tTue, 5 Mar 2024 12:40:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qjxDJpTP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709638846;\n\tbh=Y3FfNBJJ1C23U/fm9ZhLxfuwCOZLO3lYGPddo2QZPFg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=qjxDJpTP70p+5FiKWi1B3faLHxyHpf4MCFlJTir8GOwuwO6/v9WuVE3FC8389cR9J\n\tt+Csve0GX/dpyEIljzKVDRXn3Sl1wXuh5yvYf7eUJN6gtXo+cCYZdvomMX2/bbWPGi\n\t3OnIOIXvQmjNIFq7oWxu+epBcEAPYISmhnbr67A8=","Message-ID":"<0d09501d-12aa-452b-a547-ea01bc38ad19@ideasonboard.com>","Date":"Tue, 5 Mar 2024 11:41:02 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/5] libcamera: rkisp1: Create a request with a custom\n\tprivate class","Content-Language":"en-US","To":"libcamera-devel@lists.libcamera.org","References":"<20240221174015.52958-1-jacopo.mondi@ideasonboard.com>\n\t<20240221174015.52958-3-jacopo.mondi@ideasonboard.com>","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240221174015.52958-3-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28881,"web_url":"https://patchwork.libcamera.org/comment/28881/","msgid":"<20240306154348.xhxpeb4salu6smq4@jasper>","date":"2024-03-06T15:43:48","subject":"Re: [PATCH 2/5] libcamera: rkisp1: Create a request with a custom\n\tprivate class","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo,\n\nReviewed-by: Stefan Klug\n\nCheers,\nStefan\n\nOn Wed, Feb 21, 2024 at 06:40:10PM +0100, Jacopo Mondi wrote:\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 19 +++++++++++++++++++\n> 1 file changed, 19 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 586b46d64630..e981e60758f7 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -39,6 +39,7 @@\n> #include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> #include \"libcamera/internal/v4l2_subdevice.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> @@ -83,6 +84,15 @@ private:\n> \tstd::map frameInfo_;\n> };\n> \n> +class RkISP1Request : public Request::Private\n> +{\n> +public:\n> +\tRkISP1Request(Camera *camera)\n> +\t\t: Request::Private(camera)\n> +\t{\n> +\t}\n> +};\n> +\n> class RkISP1CameraData : public Camera::Private\n> {\n> public:\n> @@ -157,6 +167,8 @@ public:\n> \tint start(Camera *camera, const ControlList *controls) override;\n> \tvoid stopDevice(Camera *camera) override;\n> \n> +\tstd::unique_ptr createRequestDevice(Camera *camera,\n> +\t\t\t\t\t\t uint64_t cookie) override;\n> \tint queueRequestDevice(Camera *camera, Request *request) override;\n> \n> \tbool match(DeviceEnumerator *enumerator) override;\n> @@ -1020,6 +1032,13 @@ void PipelineHandlerRkISP1::stopDevice(Camera *camera)\n> \tactiveCamera_ = nullptr;\n> }\n> \n> +std::unique_ptr PipelineHandlerRkISP1::createRequestDevice(Camera *camera,\n> +\t\t\t\t\t\t\t\t uint64_t cookie)\n> +{\n> +\tauto request = std::make_unique(camera);\n> +\treturn Request::create(std::move(request), cookie);\n> +}\n> +\n> int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request)\n> {\n> \tRkISP1CameraData *data = cameraData(camera);\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4BE8C0F2A\n\tfor ;\n\tWed, 6 Mar 2024 15:43:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30BA76286F;\n\tWed, 6 Mar 2024 16:43:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 402CA61C8F\n\tfor ;\n\tWed, 6 Mar 2024 16:43:51 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:dd65:a3ea:5f4d:989a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6ABD9552;\n\tWed, 6 Mar 2024 16:43:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VjW5Elda\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709739813;\n\tbh=3gHwNraJWr6AnWNkEnGzNfYrunYgyatZXrJL4ML+vlQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VjW5EldanSweMQf6KcJ239cPiatAAC4ButHSZg0KrHfA2hH57kRe8WQefXdF7mcT7\n\tu/R8MGwz73T51bul8F+nuHXxjwfQDawqTxfuaIFcK+ao+mNFBv3fIbt1WAeZW6g+UT\n\tN1OSOTx1DmxGQub/zgnjxOo8wmnNwuA4D2O4aVNg=","Date":"Wed, 6 Mar 2024 16:43:48 +0100","From":"Stefan Klug ","To":"Jacopo Mondi ","Subject":"Re: [PATCH 2/5] libcamera: rkisp1: Create a request with a custom\n\tprivate class","Message-ID":"<20240306154348.xhxpeb4salu6smq4@jasper>","References":"<20240221174015.52958-1-jacopo.mondi@ideasonboard.com>\n\t<20240221174015.52958-3-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240221174015.52958-3-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]