[{"id":28708,"web_url":"https://patchwork.libcamera.org/comment/28708/","msgid":"<20240221130914.GB18146@pendragon.ideasonboard.com>","date":"2024-02-21T13:09:14","subject":"Re: [PATCH] pipeline: rpi: vc4: Use an unpacked format if no packed\n\tone is available","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Wed, Feb 21, 2024 at 12:49:19PM +0000, David Plowman wrote:\n> When validating a stream, and no valid packed pixel format can be\n> found, see if an unpacked format can be used instead.\n> \n> This is particularly helpful for 8 (and 16) bit raw formats, where\n> asking for a packed format would previously have failed. Now the\n> configuration will be adjusted to give you a format (in fact, the only\n> format) that will work.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> index a52f0e7a..ad76099b 100644\n> --- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> +++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> @@ -434,6 +434,16 @@ CameraConfiguration::Status Vc4CameraData::platformValidate(RPi::RPiCameraConfig\n> \t\t\trawBayer.packing = BayerFormat::Packing::CSI2;\n> \n> \t\tPixelFormat rawFormat = rawBayer.toPixelFormat();\n> +\n> +\t\t/*\n> +\t\t * Try for an unpacked format if a packed one wasn't available.This catches\n\ns/This/ This/\n\nI'll fix this locally.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t * 8 (and 16) bit formats which would otherwise fail.\n> +\t\t */\n> +\t\tif (!rawFormat.isValid() && rawBayer.packing != BayerFormat::Packing::None) {\n> +\t\t\trawBayer.packing = BayerFormat::Packing::None;\n> +\t\t\trawFormat = rawBayer.toPixelFormat();\n> +\t\t}\n> +\n> \t\tif (rawStream->pixelFormat != rawFormat ||\n> \t\t rawStream->size != rpiConfig->sensorFormat_.size) {\n> \t\t\trawStream->pixelFormat = rawFormat;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B4D4C0F1B\n\tfor ;\n\tWed, 21 Feb 2024 13:09:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED42162805;\n\tWed, 21 Feb 2024 14:09:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE5F361C9D\n\tfor ;\n\tWed, 21 Feb 2024 14:09:11 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E3D93F1;\n\tWed, 21 Feb 2024 14:09:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R+lzcEBE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708520943;\n\tbh=bPtoKIoDnoZQfDzysN7b1I/mKNVxvSH1/ZkViW3PSKk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R+lzcEBEMBjYbv/aYwq3C6gao1q0ct9uXXsaNSVwRGNBG1YvXRcZONBqPpbAa8sH9\n\t3WQXTxEI4KiyCvGCPDYW/uwhX3vJXMcJTjIqcowjuiCRhqyoyoJ1iYjmbZ2R2vJjGv\n\t415WSgOrHlwmGyDUkXerQzO9r7saQ7KHj27bu8L0=","Date":"Wed, 21 Feb 2024 15:09:14 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Subject":"Re: [PATCH] pipeline: rpi: vc4: Use an unpacked format if no packed\n\tone is available","Message-ID":"<20240221130914.GB18146@pendragon.ideasonboard.com>","References":"<20240221124919.2684-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240221124919.2684-1-david.plowman@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28711,"web_url":"https://patchwork.libcamera.org/comment/28711/","msgid":"","date":"2024-02-21T15:02:49","subject":"Re: [PATCH] pipeline: rpi: vc4: Use an unpacked format if no packed\n\tone is available","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nOn Wed, 21 Feb 2024 at 13:09, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> Thank you for the patch.\n>\n> On Wed, Feb 21, 2024 at 12:49:19PM +0000, David Plowman wrote:\n> > When validating a stream, and no valid packed pixel format can be\n> > found, see if an unpacked format can be used instead.\n> >\n> > This is particularly helpful for 8 (and 16) bit raw formats, where\n> > asking for a packed format would previously have failed. Now the\n> > configuration will be adjusted to give you a format (in fact, the only\n> > format) that will work.\n> >\n> > Signed-off-by: David Plowman \n> > ---\n> > src/libcamera/pipeline/rpi/vc4/vc4.cpp | 10 ++++++++++\n> > 1 file changed, 10 insertions(+)\n> >\n> > diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> > index a52f0e7a..ad76099b 100644\n> > --- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> > +++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> > @@ -434,6 +434,16 @@ CameraConfiguration::Status Vc4CameraData::platformValidate(RPi::RPiCameraConfig\n> > rawBayer.packing = BayerFormat::Packing::CSI2;\n> >\n> > PixelFormat rawFormat = rawBayer.toPixelFormat();\n> > +\n> > + /*\n> > + * Try for an unpacked format if a packed one wasn't available.This catches\n>\n> s/This/ This/\n>\n> I'll fix this locally.\n\nAh yes, thank you very much!!\n\nDavid\n\n>\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > + * 8 (and 16) bit formats which would otherwise fail.\n> > + */\n> > + if (!rawFormat.isValid() && rawBayer.packing != BayerFormat::Packing::None) {\n> > + rawBayer.packing = BayerFormat::Packing::None;\n> > + rawFormat = rawBayer.toPixelFormat();\n> > + }\n> > +\n> > if (rawStream->pixelFormat != rawFormat ||\n> > rawStream->size != rpiConfig->sensorFormat_.size) {\n> > rawStream->pixelFormat = rawFormat;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CE52BD80A\n\tfor ;\n\tWed, 21 Feb 2024 15:03:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA56C62805;\n\tWed, 21 Feb 2024 16:03:04 +0100 (CET)","from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com\n\t[IPv6:2607:f8b0:4864:20::82d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A838A61C9D\n\tfor ;\n\tWed, 21 Feb 2024 16:03:02 +0100 (CET)","by mail-qt1-x82d.google.com with SMTP id\n\td75a77b69052e-42dc86cc35dso3597791cf.1\n\tfor ;\n\tWed, 21 Feb 2024 07:03:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"C2kLu9Wd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1708527781; x=1709132581;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=DI4srP4woB8MP8Xb9R8ASGc9X3hsaIsWN8ff9ExqZ/g=;\n\tb=C2kLu9Wdy9Ug8zdt9C1AVvWEEklaC1ZuppNzxUbcyYvxuHguODMawo5FiE5HbnBIak\n\tlFimejtBu/gIt0K+1OJLq0a70oe5YWrFIDwfol3vkCToNI18R/ax5sKoa/5NoEswTotA\n\tNZjvjeM51jPQ0p2byIlY1fd1uWeGVuZuoS44H+fEqJ3m+HCFALyj1e+SiWEvdzH38720\n\tNVsLXrxChfCcMCyTQbijw742x9hIuDM1sl791gy3y3atoruqZK9lqGDd3Jb+68FcK9Va\n\tbKpQ0cj1sNWW1NVfuUt3tr6Ouwv3nGNbL1xL1vxFEFkeYmv6RrgtNheWurYgTr4pexoS\n\tFQ9g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1708527781; x=1709132581;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=DI4srP4woB8MP8Xb9R8ASGc9X3hsaIsWN8ff9ExqZ/g=;\n\tb=pSVV2yGDdY3MZ6z+Bf9IhA3NMHmouwVs229zN4lNVne/lAwZu7s2RumenWE5jJfIyR\n\tvCm/tntp38ZODAg3XPG9VvJFJmv8c4VuaJlW40gayfCjd3gHGAb2cMYEXzuQ5D2T03jb\n\tOj3Q3R2IeeuotAPSroclPM7TKlLaDocCiVi50fQnF/LN23mBQ/t6jBuzirG08bDQgxDT\n\tS7cmuX0DlDxyYtya9Z1jJaHjHujKwRNT3tku0XuKZDwb1Qb0NbMxn8erqGyqT7fEwGF+\n\tvmdDFrSHA6eSKl6rDLQwhopKK4RKCfe5Hgb6Wfm9J1ohAcbQsBH/02XjQniaxjwGAXzb\n\tBQBA==","X-Gm-Message-State":"AOJu0Yyw32aWd9HgcnMSH9nf6ydktzoINneB8Xt4/aWUx6w2fw8lwDpV\n\tGdcDHF2d+ZGj9x0my3oBkXUmsLvmRZvJq5i808wPmYp89tiTpXoRe+ak122mcIcW017NY1WsGO3\n\tdY5ojGppTU3bHZpn+aVim2R+5yrAhgYYNrIqfjc1WqeqdT5nD","X-Google-Smtp-Source":"AGHT+IENfHSJQgWUS9d40rvT42yFUcGdMyaZL4EhnEFniOwnCg/u/grZGwMvONCCGO1U9wZrs7IvLqf92IKIOsUqzl8=","X-Received":"by 2002:a05:622a:2c9:b0:42e:228b:5f6f with SMTP id\n\ta9-20020a05622a02c900b0042e228b5f6fmr8294876qtx.39.1708527781382;\n\tWed, 21 Feb 2024 07:03:01 -0800 (PST)","MIME-Version":"1.0","References":"<20240221124919.2684-1-david.plowman@raspberrypi.com>\n\t<20240221130914.GB18146@pendragon.ideasonboard.com>","In-Reply-To":"<20240221130914.GB18146@pendragon.ideasonboard.com>","From":"David Plowman ","Date":"Wed, 21 Feb 2024 15:02:49 +0000","Message-ID":"","Subject":"Re: [PATCH] pipeline: rpi: vc4: Use an unpacked format if no packed\n\tone is available","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]