[{"id":28721,"web_url":"https://patchwork.libcamera.org/comment/28721/","msgid":"","date":"2024-02-23T13:16:02","subject":"Re: [PATCH v3 5/5] ipa: rkisp1: Support the i.MX8MP ISP version","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Am 18.02.24 um 17:49 schrieb Laurent Pinchart:\n> From: Paul Elder \n> \n> Handle the RKISP1_V_IMX8MP version in the rkisp1 IPA. This enables basic\n> support of the i.MX8MP, excluding the processing blocks specific to the\n> new ISP version. Those will be supported later.\n> \n> Signed-off-by: Paul Elder \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 44401af8910d..9dc5f53cb091 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -136,6 +136,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n> \t/* \\todo Add support for other revisions */\n> \tswitch (hwRevision) {\n> \tcase RKISP1_V10:\n> +\tcase RKISP1_V_IMX8MP:\n> \t\tcontext_.hw = &ipaHwSettingsV10;\n> \t\tbreak;\n> \tcase RKISP1_V12:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7B56C0F1B\n\tfor ;\n\tFri, 23 Feb 2024 13:16:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98FB862816;\n\tFri, 23 Feb 2024 14:16:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9BAC627FD\n\tfor ;\n\tFri, 23 Feb 2024 14:16:02 +0100 (CET)","from [IPV6:2a00:6020:448c:6c00:163d:481a:d9f4:bc3d] (unknown\n\t[IPv6:2a00:6020:448c:6c00:163d:481a:d9f4:bc3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7207D2E7;\n\tFri, 23 Feb 2024 14:15:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h3sflC43\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708694153;\n\tbh=kuDlVCA8DkReCUBwJ2yuMX0rqstRjfxABzV1C6AhBLI=;\n\th=Date:Subject:To:References:Cc:From:In-Reply-To:From;\n\tb=h3sflC430ADxtF7/hsXyzkvZyPuLp1e/wfCVHZ+eGG7PpLsARJq/5E6rB7vQck4XU\n\tHnu1fvJ/OYeYhUUkKoy/Y9pSGZct58TIqxkxsmgijPfD6a6g2Rhlo2uGsl7OMXz2Pi\n\tDt7AKMYZvR3fv2du6x6KJ0OssoljqVVGQHcAbwiM=","Message-ID":"","Date":"Fri, 23 Feb 2024 14:16:02 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 5/5] ipa: rkisp1: Support the i.MX8MP ISP version","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20240218164908.15921-1-laurent.pinchart@ideasonboard.com>\n\t<20240218164908.15921-6-laurent.pinchart@ideasonboard.com>","From":"Stefan Klug ","In-Reply-To":"<20240218164908.15921-6-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]