[{"id":28699,"web_url":"https://patchwork.libcamera.org/comment/28699/","msgid":"","date":"2024-02-20T09:56:48","subject":"Re: [PATCH v3 3/5] ipa: rkisp1: Fix histogram weights configuration","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Sun, Feb 18, 2024 at 06:49:06PM +0200, Laurent Pinchart wrote:\n> The histogram weights are initialized to hardcoded 1's for each\n> histogram grid cell. The code uses the wrong variable for the grid size,\n> resulting in some weights having a 0 value. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index da705b14754c..47a6f7b26744 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -175,7 +175,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n> \t/* Set an average weighted histogram. */\n> \tSpan weights{\n> \t\tparams->meas.hst_config.hist_weight,\n> -\t\tcontext.hw->numHistogramBins\n> +\t\tcontext.hw->numHistogramWeights\n> \t};\n> \tstd::fill(weights.begin(), weights.end(), 1);\n> \t/* Step size can't be less than 3. */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 626A3C3257\n\tfor ;\n\tTue, 20 Feb 2024 09:56:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BCCF62816;\n\tTue, 20 Feb 2024 10:56:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D24462807\n\tfor ;\n\tTue, 20 Feb 2024 10:56:55 +0100 (CET)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 288481536;\n\tTue, 20 Feb 2024 10:56:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h/T5cI/w\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708423008;\n\tbh=BHVXORYB/+3jtFutZk2Xo/fNKvHYrkmPgoFnnhn7N5w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=h/T5cI/wxIz8SRsKDNEQTmHbTbiXhbp5n1bfGlDniIoUJSKaZ4ZC3/ER/wlT+o0AN\n\tzTW2+khyFkz13ti3nKDtPnbNd7rtYFo0ilhCpJ3OYqv7C1N+CRUBUINxktPa3urKO+\n\toz9tiOQNAZeq7825sJqF3+gEKAPsGbTzhmd9B2Ow=","Date":"Tue, 20 Feb 2024 18:56:48 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Subject":"Re: [PATCH v3 3/5] ipa: rkisp1: Fix histogram weights configuration","Message-ID":"","References":"<20240218164908.15921-1-laurent.pinchart@ideasonboard.com>\n\t<20240218164908.15921-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240218164908.15921-4-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28719,"web_url":"https://patchwork.libcamera.org/comment/28719/","msgid":"","date":"2024-02-23T13:07:08","subject":"Re: [PATCH v3 3/5] ipa: rkisp1: Fix histogram weights configuration","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Am 18.02.24 um 17:49 schrieb Laurent Pinchart:\n> The histogram weights are initialized to hardcoded 1's for each\n> histogram grid cell. The code uses the wrong variable for the grid size,\n> resulting in some weights having a 0 value. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index da705b14754c..47a6f7b26744 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -175,7 +175,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n> \t/* Set an average weighted histogram. */\n> \tSpan weights{\n> \t\tparams->meas.hst_config.hist_weight,\n> -\t\tcontext.hw->numHistogramBins\n> +\t\tcontext.hw->numHistogramWeights\n> \t};\n> \tstd::fill(weights.begin(), weights.end(), 1);\n> \t/* Step size can't be less than 3. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F422BD80A\n\tfor ;\n\tFri, 23 Feb 2024 13:07:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69857627FD;\n\tFri, 23 Feb 2024 14:07:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96C2C627FD\n\tfor ;\n\tFri, 23 Feb 2024 14:07:11 +0100 (CET)","from [IPV6:2a00:6020:448c:6c00:163d:481a:d9f4:bc3d] (unknown\n\t[IPv6:2a00:6020:448c:6c00:163d:481a:d9f4:bc3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BA83D52;\n\tFri, 23 Feb 2024 14:07:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cxUqr1Vt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708693622;\n\tbh=5w+x2fZhKaq0sKGet/MgAhnWYooJvuUJWLNTYBIUlgA=;\n\th=Date:Subject:To:References:Cc:From:In-Reply-To:From;\n\tb=cxUqr1VtKvjdJZcLi5EaemLR+xMESTpwQk4pdsNbDih2B8Cjc+r8IiyFtolkiHr37\n\t0LugcVRlZJ1U9aKj0d6CHRGNsiwnOaXALV2GdbvaQofiapBrHQR5DgN/rNDkUM9phZ\n\tNRG7mbydSaii13bLDz9s7E9PTeeEgDknYL8YjsK4=","Message-ID":"","Date":"Fri, 23 Feb 2024 14:07:08 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 3/5] ipa: rkisp1: Fix histogram weights configuration","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20240218164908.15921-1-laurent.pinchart@ideasonboard.com>\n\t<20240218164908.15921-4-laurent.pinchart@ideasonboard.com>","From":"Stefan Klug ","In-Reply-To":"<20240218164908.15921-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]