{"id":19504,"url":"https://patchwork.libcamera.org/api/patches/19504/?format=json","web_url":"https://patchwork.libcamera.org/patch/19504/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240216110952.3169023-1-paul.elder@ideasonboard.com>","date":"2024-02-16T11:09:52","name":"[v2] ipa: rkisp1: Add RKISP1_V_IMX8MP version","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"94e600e027d4324550b3ba43f2ee5a9134808006","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19504/mbox/","series":[{"id":4170,"url":"https://patchwork.libcamera.org/api/series/4170/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4170","date":"2024-02-16T11:09:52","name":"[v2] ipa: rkisp1: Add RKISP1_V_IMX8MP version","version":2,"mbox":"https://patchwork.libcamera.org/series/4170/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19504/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19504/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDEFBBDE17\n\tfor ;\n\tFri, 16 Feb 2024 11:10:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E72FF62805;\n\tFri, 16 Feb 2024 12:10:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E932A61CAE\n\tfor ;\n\tFri, 16 Feb 2024 12:10:04 +0100 (CET)","from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B78C5564;\n\tFri, 16 Feb 2024 12:09:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QObnB6p3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708081799;\n\tbh=POAWkcXyLW4kQtmAeJWyivUTmLwYNQcfy0R0HI0lN/Y=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QObnB6p3jSEMvwjT0GUoHkMQZGOThfFm3NFniSzvSKyHb9c9+kE9BMVQpa9PSgyOT\n\tu6DfeiX1d1K/eAPvtTW6zy6pVxmt68NAgn2qiiDh42lsIVg6RZqF71IhQYuS4PIqeH\n\t8+4kKoU4glHJII4flGODP6MhRa6agOIYy4fLHHIc=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2] ipa: rkisp1: Add RKISP1_V_IMX8MP version","Date":"Fri, 16 Feb 2024 20:09:52 +0900","Message-Id":"<20240216110952.3169023-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the version number for RKISP1_V_IMX8MP, and initialize values for\nit.\n\nSigned-off-by: Paul Elder \n---\nThis patch goes with the kernel series [1] which adds support for\ni.MX8MP.\n\n[1] https://lore.kernel.org/linux-media/20240216095458.2919694-1-paul.elder@ideasonboard.com/\n---\n include/linux/rkisp1-config.h | 8 +++++---\n src/ipa/rkisp1/rkisp1.cpp | 1 +\n 2 files changed, 6 insertions(+), 3 deletions(-)","diff":"diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h\nindex ec7cde8c..2d1c448a 100644\n--- a/include/linux/rkisp1-config.h\n+++ b/include/linux/rkisp1-config.h\n@@ -4,8 +4,8 @@\n * Copyright (C) 2017 Rockchip Electronics Co., Ltd.\n */\n \n-#ifndef _RKISP1_CONFIG_H\n-#define _RKISP1_CONFIG_H\n+#ifndef _UAPI_RKISP1_CONFIG_H\n+#define _UAPI_RKISP1_CONFIG_H\n \n #include \n \n@@ -179,12 +179,14 @@\n * @RKISP1_V11: declared in the original vendor code, but not used\n * @RKISP1_V12: used at least in rk3326 and px30\n * @RKISP1_V13: used at least in rk1808\n+ * @RKISP1_V_IMX8MP: used in at least imx8mp\n */\n enum rkisp1_cif_isp_version {\n \tRKISP1_V10 = 10,\n \tRKISP1_V11,\n \tRKISP1_V12,\n \tRKISP1_V13,\n+\tRKISP1_V_IMX8MP,\n };\n \n enum rkisp1_cif_isp_histogram_mode {\n@@ -992,4 +994,4 @@ struct rkisp1_stat_buffer {\n \tstruct rkisp1_cif_isp_stat params;\n };\n \n-#endif /* _RKISP1_CONFIG_H */\n+#endif /* _UAPI_RKISP1_CONFIG_H */\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 6544c925..11e31bf4 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -128,6 +128,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \t/* \\todo Add support for other revisions */\n \tswitch (hwRevision) {\n \tcase RKISP1_V10:\n+\tcase RKISP1_V_IMX8MP:\n \t\thwHistBinNMax_ = RKISP1_CIF_ISP_HIST_BIN_N_MAX_V10;\n \t\thwGammaOutMaxSamples_ = RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10;\n \t\thwHistogramWeightGridsSize_ = RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10;\n","prefixes":["v2"]}