[{"id":28631,"web_url":"https://patchwork.libcamera.org/comment/28631/","msgid":"<20240202092411.GA24423@pendragon.ideasonboard.com>","date":"2024-02-02T09:24:11","subject":"Re: [PATCH] doc: gstreamer: Add missing queues","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Fri, Feb 02, 2024 at 10:08:05AM +0100, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> As libcamerasrc reports some latency, a queue is needed in order to store the\n> data in case the buffers has been produced slightly ahead of our reported\n> latency.\n\nI fully trust your expertise on this :-)\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Nicolas Dufresne \n> ---\n> README.rst | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 6b764fb7..cc39cd5f 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -134,7 +134,7 @@ onto the OpenGL accelerated display element on your system.\n> \n> .. code::\n> \n> - gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n> + gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! queue ! glimagesink\n> \n> To show the first camera found you can omit the camera-name property, or you\n> can list the cameras and their capabilities using:\n> @@ -149,7 +149,7 @@ if desired with a pipeline such as:\n> .. code::\n> \n> gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \\\n> - glimagesink\n> + queue ! glimagesink\n> \n> The libcamerasrc element has two log categories, named libcamera-provider (for\n> the video device provider) and libcamerasrc (for the operation of the camera).\n> @@ -165,7 +165,7 @@ the following example could be used as a starting point:\n> \n> gst-launch-1.0 libcamerasrc ! \\\n> video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \\\n> - jpegenc ! multipartmux ! \\\n> + queue ! jpegenc ! multipartmux ! \\\n> tcpserversink host=0.0.0.0 port=5000\n> \n> Which can be received on another device over the network with:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 236D6BE173\n\tfor ;\n\tFri, 2 Feb 2024 09:24:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53DAC61D13;\n\tFri, 2 Feb 2024 10:24:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E09661D13\n\tfor ;\n\tFri, 2 Feb 2024 10:24:12 +0100 (CET)","from pendragon.ideasonboard.com (unknown [217.145.44.194])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9AB312E4;\n\tFri, 2 Feb 2024 10:22:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZlUTmcOX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706865772;\n\tbh=a33KpRVViDDVqpwEnSd6Fr3LQDu6gZf93FlWDqd6ySw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZlUTmcOX8bUHQDp1xX/wol5NjkVwhKmU4t90IDCoEM9BkItTp6JTbYj3F8pcBorXV\n\trM4qWQlHcI46QLy6l8seAK2vlwBzjbfqJUlTDtIwilxZnxXLJhMYAFIYrwynbFo0KS\n\tYDXFDuvLD8n1K/ybhaVocL1Y77mXIXLX2r/HCehM=","Date":"Fri, 2 Feb 2024 11:24:11 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Subject":"Re: [PATCH] doc: gstreamer: Add missing queues","Message-ID":"<20240202092411.GA24423@pendragon.ideasonboard.com>","References":"<20240202090805.120601-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240202090805.120601-1-nicolas@ndufresne.ca>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]