[{"id":28633,"web_url":"https://patchwork.libcamera.org/comment/28633/","msgid":"<20240202093238.GC24423@pendragon.ideasonboard.com>","date":"2024-02-02T09:32:38","subject":"Re: [PATCH 2/2] gstreamer: Map 10/12/14/16 bayer formats supports","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Fri, Feb 02, 2024 at 09:58:19AM +0100, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> These formats are now defined in upstream GStreamer main branch, so it is now\n> safe to use their names. Note that libcamera only supports little endian\n> variants of these formats.\n> \n> Signed-off-by: Nicolas Dufresne \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 48 ++++++++++++++++++++++++++++\n> 1 file changed, 48 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 2a0b77f4..469ac810 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -25,6 +25,22 @@ static struct {\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG8 },\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG8 },\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB8 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SBGGR10 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG10 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG10 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB10 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SBGGR12 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG12 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG12 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB12 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SBGGR14 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG14 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG14 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB14 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SBGGR16 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG16 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG16 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB16 },\n> \n> \t/* Monochrome */\n> \t{ GST_VIDEO_FORMAT_GRAY8, formats::R8 },\n> @@ -250,6 +266,38 @@ bayer_format_to_string(int format)\n> \t\treturn \"grbg\";\n> \tcase formats::SRGGB8:\n> \t\treturn \"rggb\";\n> +\tcase formats::SBGGR10:\n> +\t\treturn \"bggr10le\";\n> +\tcase formats::SGBRG10:\n> +\t\treturn \"gbrg10le\";\n> +\tcase formats::SGRBG10:\n> +\t\treturn \"grbg10le\";\n> +\tcase formats::SRGGB10:\n> +\t\treturn \"rggb10le\";\n> +\tcase formats::SBGGR12:\n> +\t\treturn \"bggr12le\";\n> +\tcase formats::SGBRG12:\n> +\t\treturn \"gbrg12le\";\n> +\tcase formats::SGRBG12:\n> +\t\treturn \"grbg12le\";\n> +\tcase formats::SRGGB12:\n> +\t\treturn \"rggb12le\";\n> +\tcase formats::SBGGR14:\n> +\t\treturn \"bggr14le\";\n> +\tcase formats::SGBRG14:\n> +\t\treturn \"gbrg14le\";\n> +\tcase formats::SGRBG14:\n> +\t\treturn \"grbg14le\";\n> +\tcase formats::SRGGB14:\n> +\t\treturn \"rggb14le\";\n> +\tcase formats::SBGGR16:\n> +\t\treturn \"bggr16le\";\n> +\tcase formats::SGBRG16:\n> +\t\treturn \"gbrg16le\";\n> +\tcase formats::SGRBG16:\n> +\t\treturn \"grbg16le\";\n> +\tcase formats::SRGGB16:\n> +\t\treturn \"rggb16le\";\n> \t}\n> \treturn NULL;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2930BE173\n\tfor ;\n\tFri, 2 Feb 2024 09:32:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01A9461D13;\n\tFri, 2 Feb 2024 10:32:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C969B61D13\n\tfor ;\n\tFri, 2 Feb 2024 10:32:38 +0100 (CET)","from pendragon.ideasonboard.com (unknown [217.145.44.194])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 692B712E4;\n\tFri, 2 Feb 2024 10:31:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qv9mHzai\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706866278;\n\tbh=ecidbcNvdNSxNtJsr6lRhdyXYRnz0hsxbZd2pQqmSKQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Qv9mHzaiEfIoAHenF9XIEycrDVtN4UT7c37Ltu2g8mVJivs+9ZGLev6/T5+TJObyT\n\tCY72KXDziEj1Gofd+0YyVLkW2hy4Umb0QlOWt34a1/CBxaHDxmuR7WWCsg1Ta5TLK+\n\tsC8R4ZztiNM8XtWruGVota8t7sppwGxf1aaWIcFQ=","Date":"Fri, 2 Feb 2024 11:32:38 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Subject":"Re: [PATCH 2/2] gstreamer: Map 10/12/14/16 bayer formats supports","Message-ID":"<20240202093238.GC24423@pendragon.ideasonboard.com>","References":"<20240202085819.119320-1-nicolas@ndufresne.ca>\n\t<20240202085819.119320-2-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240202085819.119320-2-nicolas@ndufresne.ca>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]