[{"id":28632,"web_url":"https://patchwork.libcamera.org/comment/28632/","msgid":"<20240202092918.GB24423@pendragon.ideasonboard.com>","date":"2024-02-02T09:29:18","subject":"Re: [PATCH 1/2] gstreamer: Map R8/R16 pixel format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Fri, Feb 02, 2024 at 09:58:18AM +0100, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> This enables monochrome support in libcamerasrc.\n> \n> Signed-off-by: Nicolas Dufresne \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 750ec351..2a0b77f4 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -26,6 +26,10 @@ static struct {\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG8 },\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB8 },\n> \n> +\t/* Monochrome */\n> +\t{ GST_VIDEO_FORMAT_GRAY8, formats::R8 },\n> +\t{ GST_VIDEO_FORMAT_GRAY16_LE, formats::R16 },\n> +\n> \t/* RGB16 */\n> \t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1BBBBDB13\n\tfor ;\n\tFri, 2 Feb 2024 09:29:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F00862805;\n\tFri, 2 Feb 2024 10:29:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DE3461D13\n\tfor ;\n\tFri, 2 Feb 2024 10:29:19 +0100 (CET)","from pendragon.ideasonboard.com (unknown [217.145.44.194])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B33712E4;\n\tFri, 2 Feb 2024 10:27:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jgdo4ojM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706866079;\n\tbh=jXwul8F6HOefazEFVAM7uNntDL/0RFUwjHSOc8328qI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Jgdo4ojMgeqTsu3wWUCKYh1OZZJNIhK3siF7UsD7p9/yG+JdaJqWxaFiApFmfBCum\n\tQ1wYnfKf2SOeRBdyqL1B9mDfC5FWt1mkRFNkz+mEylomfm89dd4jKoVXSMNNsm07RN\n\tPW3l4hTP8YPqUzAzSqwieZmSLWJ9wyptykwrA1v0=","Date":"Fri, 2 Feb 2024 11:29:18 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Subject":"Re: [PATCH 1/2] gstreamer: Map R8/R16 pixel format","Message-ID":"<20240202092918.GB24423@pendragon.ideasonboard.com>","References":"<20240202085819.119320-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240202085819.119320-1-nicolas@ndufresne.ca>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]