[{"id":28610,"web_url":"https://patchwork.libcamera.org/comment/28610/","msgid":"<20240123153046.GR10679@pendragon.ideasonboard.com>","date":"2024-01-23T15:30:46","subject":"Re: [PATCH v2 4/4] libcamera: v4l2_subdevice: Explain sort order of\n\tformatInfoMap","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 23, 2024 at 03:20:34PM +0000, Kieran Bingham wrote:\n> The sort order used in the table isn't obvious. Reference the source of\n> linux/media-bus-format.h at the top of the table for reference for\n> future updates.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> This patch replaces:\n> [PATCH v2 4/4] libcamera: v4l2subdev: Organise the formatInfoMap\n> \n> src/libcamera/v4l2_subdevice.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 265240dbd405..6d0785b7b484 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -57,6 +57,7 @@ struct V4L2SubdeviceFormatInfo {\n> * bus codes\n> */\n> const std::map formatInfoMap = {\n> +\t/* This table is sorted to match the order in linux/media-bus-format.h */\n> \t{ MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE, { 16, \"RGB555_2X8_PADHI_BE\", PixelFormatInfo::ColourEncodingRGB } },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05FB1BDC71\n\tfor ;\n\tTue, 23 Jan 2024 15:30:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56DEF62944;\n\tTue, 23 Jan 2024 16:30:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62509628E9\n\tfor ;\n\tTue, 23 Jan 2024 16:30:48 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 875981B9A;\n\tTue, 23 Jan 2024 16:29:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CnU03k1K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706023774;\n\tbh=R6RHbcWOIyH/m8bdeePJN1QitteMIzwCTPZ2YnLYrLY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CnU03k1Ko+c+xhAojdlaoofLYoWgfnncHEgQVOcoRNRkniFMm9Snq7o5XiVrBYnAl\n\t9KvMFxlff5qmye1vBE+W9rUW5fMerpi0rfT33ZhMcm8syGKmM3OchsfiF/dAMqmKy7\n\t07bgdEX07Uyne6I4BC3F3ggZl0hWy8hRD+ljjSvA=","Date":"Tue, 23 Jan 2024 17:30:46 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Subject":"Re: [PATCH v2 4/4] libcamera: v4l2_subdevice: Explain sort order of\n\tformatInfoMap","Message-ID":"<20240123153046.GR10679@pendragon.ideasonboard.com>","References":"<20240123143535.52255-1-kieran.bingham@ideasonboard.com>\n\t<20240123152034.119295-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240123152034.119295-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]