[{"id":28603,"web_url":"https://patchwork.libcamera.org/comment/28603/","msgid":"<20240123144656.GG10679@pendragon.ideasonboard.com>","date":"2024-01-23T14:46:56","subject":"Re: [PATCH v2 3/4] libcamera: bayer_format: Add Y12 to bayerToFormat","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 23, 2024 at 02:35:34PM +0000, Kieran Bingham wrote:\n> Support for Mono 12-bit formats were added to the mbusCodeToBayer table\n> without supplying the corresponding entry for converting the other way.\n> \n> Add the relevant entry to the bayerToFormat table.\n> \n> Fixes: ec6309571654 (\"libcamera: bayer_format: Add unpacked mono 12-bit format to the conversion table\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> v2: new patch\n> \n> src/libcamera/bayer_format.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\n> index 175617a0edf5..20aedfa6d925 100644\n> --- a/src/libcamera/bayer_format.cpp\n> +++ b/src/libcamera/bayer_format.cpp\n> @@ -170,6 +170,8 @@ const std::map bayerToFormat{\n> \t\t{ formats::R10, V4L2PixelFormat(V4L2_PIX_FMT_Y10) } },\n> \t{ { BayerFormat::MONO, 10, BayerFormat::Packing::CSI2 },\n> \t\t{ formats::R10_CSI2P, V4L2PixelFormat(V4L2_PIX_FMT_Y10P) } },\n> +\t{ { BayerFormat::MONO, 12, BayerFormat::Packing::None },\n> +\t\t{ formats::R12, V4L2PixelFormat(V4L2_PIX_FMT_Y12) } },\n> \t{ { BayerFormat::MONO, 16, BayerFormat::Packing::None },\n> \t\t{ formats::R16, V4L2PixelFormat(V4L2_PIX_FMT_Y16) } },\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05323BDC71\n\tfor ;\n\tTue, 23 Jan 2024 14:46:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A24C3628E9;\n\tTue, 23 Jan 2024 15:46:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 453F6628E9\n\tfor ;\n\tTue, 23 Jan 2024 15:46:58 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 845B41890;\n\tTue, 23 Jan 2024 15:45:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hYB+Lqwr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706021144;\n\tbh=pQw95nK211H9QAaP6HizYlKPWoYuvTh7+OYpW1rv/nA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hYB+LqwrAFidDzdfeNEvS1NXUK1B1f6kfy4I6P+yKnnOhjoko9aukNEMSGOqyRbnf\n\tjrawqexfO3e+wnwmDU/2PDloXMTwVtG02nCOQ3t4x9wmWIyH0WFPGYrg4fgJvX6wRf\n\tx3hfV2q7dDFWZNkclyStdeHKMgTvIKUlEMj41yCs=","Date":"Tue, 23 Jan 2024 16:46:56 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Subject":"Re: [PATCH v2 3/4] libcamera: bayer_format: Add Y12 to bayerToFormat","Message-ID":"<20240123144656.GG10679@pendragon.ideasonboard.com>","References":"<20240123143535.52255-1-kieran.bingham@ideasonboard.com>\n\t<20240123143535.52255-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240123143535.52255-4-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]