[{"id":28602,"web_url":"https://patchwork.libcamera.org/comment/28602/","msgid":"<20240123144631.GF10679@pendragon.ideasonboard.com>","date":"2024-01-23T14:46:31","subject":"Re: [PATCH v2 2/4] libcamera: formats: Fix sort ordering of\n\tR10_CSI2P","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 23, 2024 at 02:35:33PM +0000, Kieran Bingham wrote:\n> Move formats::R10_CSI2P to be grouped with the formats::R10 counterpart\n> and keep the section of format declarations sorted in increasing bit\n> depth.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> v2: new patch\n> \n> src/libcamera/formats.cpp | 20 ++++++++++----------\n> 1 file changed, 10 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 46ccd43ba63a..8a606a7c37f1 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -497,6 +497,16 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::R10_CSI2P, {\n> +\t\t.name = \"R10_CSI2P\",\n> +\t\t.format = formats::R10_CSI2P,\n> +\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_Y10P), },\n> +\t\t.bitsPerPixel = 10,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +\t\t.packed = true,\n> +\t\t.pixelsPerGroup = 4,\n> +\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \t{ formats::R12, {\n> \t\t.name = \"R12\",\n> \t\t.format = formats::R12,\n> @@ -517,16 +527,6 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> -\t{ formats::R10_CSI2P, {\n> -\t\t.name = \"R10_CSI2P\",\n> -\t\t.format = formats::R10_CSI2P,\n> -\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_Y10P), },\n> -\t\t.bitsPerPixel = 10,\n> -\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> -\t\t.packed = true,\n> -\t\t.pixelsPerGroup = 4,\n> -\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n> -\t} },\n> \n> \t/* Bayer formats. */\n> \t{ formats::SBGGR8, {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAE6FBDC71\n\tfor ;\n\tTue, 23 Jan 2024 14:46:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C2E962946;\n\tTue, 23 Jan 2024 15:46:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19A24628E9\n\tfor ;\n\tTue, 23 Jan 2024 15:46:34 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 364031890;\n\tTue, 23 Jan 2024 15:45:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wXQGMB3W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706021120;\n\tbh=sDDNXb/PCxWT5Yh4o+o3lKtEi7KYkPUliDu9myocr7Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wXQGMB3WapN6f+KkXM+0OIiHim79C9i+8lXWi78LgXRRLLLREQUHKoI1Ew9zH2lDy\n\tB+6Jh9ETH0ItYpVvOjyCugXbJIccQjPekPF1nPWLzq5l8HnPABozHhVIVHwd4UtBBP\n\tQZovY7lJxtARKmE2P6QRWO3xiDQWdTe7+WPv4t0U=","Date":"Tue, 23 Jan 2024 16:46:31 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Subject":"Re: [PATCH v2 2/4] libcamera: formats: Fix sort ordering of\n\tR10_CSI2P","Message-ID":"<20240123144631.GF10679@pendragon.ideasonboard.com>","References":"<20240123143535.52255-1-kieran.bingham@ideasonboard.com>\n\t<20240123143535.52255-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240123143535.52255-3-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]