{"id":19461,"url":"https://patchwork.libcamera.org/api/patches/19461/?format=json","web_url":"https://patchwork.libcamera.org/patch/19461/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240123133410.4130945-1-kieran.bingham@ideasonboard.com>","date":"2024-01-23T13:34:10","name":"libcamera: formats: Add 16-bit mono format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ae3d50ee1f57b749968db7f1b5b2b8b087864baf","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19461/mbox/","series":[{"id":4158,"url":"https://patchwork.libcamera.org/api/series/4158/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4158","date":"2024-01-23T13:34:10","name":"libcamera: formats: Add 16-bit mono format","version":1,"mbox":"https://patchwork.libcamera.org/series/4158/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19461/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19461/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2D24C323E\n\tfor ;\n\tTue, 23 Jan 2024 13:34:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F95462916;\n\tTue, 23 Jan 2024 14:34:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD94F628E9\n\tfor ;\n\tTue, 23 Jan 2024 14:34:14 +0100 (CET)","from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F34B31571;\n\tTue, 23 Jan 2024 14:33:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j6EF4vpb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1706016781;\n\tbh=Aobi3CiX9A7FLyxyTnAeGitxwQueJMjxYVfRP7LZ9gw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=j6EF4vpbx5KymjOJBuFBXYbn8Vhaw4pu341vXe58nXNodNeA4JeQx7OmyzyWg+2r+\n\tUiZ0QfbuB+qFBGVgMps8H16Z8MNAxl4htcCceJSGyUFwCt2Csb3MJiS+ZLLLaJuXCJ\n\t3sc9l83s8w7nWfupsTCMXhTYKkPWiP9MEjFi+eWo=","From":"Kieran Bingham ","To":"libcamera devel ","Subject":"[PATCH] libcamera: formats: Add 16-bit mono format","Date":"Tue, 23 Jan 2024 13:34:10 +0000","Message-Id":"<20240123133410.4130945-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Naushir Patuck \n\nAdd the relevant definitions for a 16-bit mono pixel and media-bus\nformat.\n\nSigned-off-by: Naushir Patuck \nSigned-off-by: Kieran Bingham \n---\n\nPatch cherry-picked from\nhttps://github.com/raspberrypi/libcamera/commit/d8c775077c33f7475c5d4828ce3e374d5769b59c\nand rebased on top of the recent df770d4b0a6d (\"include: linux: Update\nkernel headers to version v6.7\".\n\n\n src/libcamera/bayer_format.cpp | 3 +++\n src/libcamera/formats.cpp | 10 ++++++++++\n src/libcamera/formats.yaml | 2 ++\n src/libcamera/v4l2_pixelformat.cpp | 2 ++\n src/libcamera/v4l2_subdevice.cpp | 1 +\n 5 files changed, 18 insertions(+)","diff":"diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\nindex 3bf15fb48f36..2f55d33a915d 100644\n--- a/src/libcamera/bayer_format.cpp\n+++ b/src/libcamera/bayer_format.cpp\n@@ -168,8 +168,11 @@ const std::map bayerToFormat{\n \t\t{ formats::R8, V4L2PixelFormat(V4L2_PIX_FMT_GREY) } },\n \t{ { BayerFormat::MONO, 10, BayerFormat::Packing::None },\n \t\t{ formats::R10, V4L2PixelFormat(V4L2_PIX_FMT_Y10) } },\n+\t{ { BayerFormat::MONO, 16, BayerFormat::Packing::None },\n+\t\t{ formats::R16, V4L2PixelFormat(V4L2_PIX_FMT_Y16) } },\n \t{ { BayerFormat::MONO, 10, BayerFormat::Packing::CSI2 },\n \t\t{ formats::R10_CSI2P, V4L2PixelFormat(V4L2_PIX_FMT_Y10P) } },\n+\n };\n \n const std::unordered_map mbusCodeToBayer{\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 447e623803c7..46ccd43ba63a 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -507,6 +507,16 @@ const std::map pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::R16, {\n+\t\t.name = \"R16\",\n+\t\t.format = formats::R16,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_Y16), },\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::R10_CSI2P, {\n \t\t.name = \"R10_CSI2P\",\n \t\t.format = formats::R10_CSI2P,\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex 539ac0b33084..d8a379923b56 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -11,6 +11,8 @@ formats:\n fourcc: DRM_FORMAT_R10\n - R12:\n fourcc: DRM_FORMAT_R12\n+ - R16:\n+ fourcc: DRM_FORMAT_R16\n \n - RGB565:\n fourcc: DRM_FORMAT_RGB565\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 5551c62eb39b..731dc10f1d73 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -135,6 +135,8 @@ const std::map vpf2pf{\n \t\t{ formats::R10_CSI2P, \"10-bit Greyscale Packed\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_Y12),\n \t\t{ formats::R12, \"12-bit Greyscale\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_Y16),\n+\t\t{ formats::R16, \"16-bit Greyscale\" } },\n \n \t/* Bayer formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8),\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 75ad11e55272..265240dbd405 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -88,6 +88,7 @@ const std::map formatInfoMap = {\n \t{ MEDIA_BUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_Y12_1X12, { 12, \"Y12_1X12\", PixelFormatInfo::ColourEncodingYUV } },\n+\t{ MEDIA_BUS_FMT_Y16_1X16, { 16, \"Y16_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n \t{ MEDIA_BUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\", PixelFormatInfo::ColourEncodingYUV } },\n","prefixes":[]}