{"id":19449,"url":"https://patchwork.libcamera.org/api/patches/19449/?format=json","web_url":"https://patchwork.libcamera.org/patch/19449/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240123011249.22716-2-laurent.pinchart@ideasonboard.com>","date":"2024-01-23T01:12:38","name":"[v2,01/12] libcamera: object: Fix thread-bound reference in documentation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f749139245f1c713df014ee3653678b1ca8c508e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19449/mbox/","series":[{"id":4157,"url":"https://patchwork.libcamera.org/api/series/4157/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4157","date":"2024-01-23T01:12:37","name":"libcamera: Hardening against thread race conditions","version":2,"mbox":"https://patchwork.libcamera.org/series/4157/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19449/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19449/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A69FC324D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Jan 2024 01:12:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D979662944;\n\tTue, 23 Jan 2024 02:12:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 789CA61D46\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jan 2024 02:12:47 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2319F1574;\n\tTue, 23 Jan 2024 02:11:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T0HJcGJO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705972294;\n\tbh=wMpLozaP/xKqQlEJAwOaeetDCtxiB+1F5J2rq9uRqGw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=T0HJcGJO/49dHhI9p7cf6qlKRSJvNbw5WeSLn1qZkYzKZR00CKU9AuAdJEoox6iDS\n\t33iV0G+pdd5YEIeV4fuWD2e37ErYDSqya7YBrlWFVGPD8zSGhZiRZT6DicZvlNRu8+\n\te18wd37baYPmTAVRa8XLP93rGKxyTUlbCMuMHCho=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 01/12] libcamera: object: Fix thread-bound reference in\n\tdocumentation","Date":"Tue, 23 Jan 2024 03:12:38 +0200","Message-ID":"<20240123011249.22716-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240123011249.22716-1-laurent.pinchart@ideasonboard.com>","References":"<20240123011249.22716-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The Object::message() function is documented as thread-bound without\nusing the correct \\threadbound reference. Fix it to ensure it gets\nincluded in the thread safety context list.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/base/object.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/base/object.cpp b/src/libcamera/base/object.cpp\nindex 92cecd22fbe9..1fce5a2af9af 100644\n--- a/src/libcamera/base/object.cpp\n+++ b/src/libcamera/base/object.cpp\n@@ -259,7 +259,7 @@ void Object::message(Message *msg)\n  * Moving an object that has a parent is not allowed, and causes undefined\n  * behaviour.\n  *\n- * \\context This function is thread-bound.\n+ * \\context This function is \\threadbound.\n  */\n void Object::moveToThread(Thread *thread)\n {\n","prefixes":["v2","01/12"]}