[{"id":28537,"web_url":"https://patchwork.libcamera.org/comment/28537/","msgid":"<170593866091.1011926.18266619838352438497@ping.linuxembedded.co.uk>","date":"2024-01-22T15:51:00","subject":"Re: [PATCH] libcamera: Remove empty formats.c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-01-22 15:46:21)\n> Commit e0a51061bc69 (\"libcamera: formats: Add 14-bits Bayer RAW\n> formats\") added an empty formats.c file by mistake (and we failed to\n> catch it during review). Delete it.\n> \n> Fixes: e0a51061bc69 (\"libcamera: formats: Add 14-bits Bayer RAW formats\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/formats.c | 0\n> 1 file changed, 0 insertions(+), 0 deletions(-)\n\nBut ... that's /only zero/ lines deleted. Hardly any gain ;-)\n\nReviewed-by: Kieran Bingham \n\n> delete mode 100644 src/libcamera/formats.c\n> \n> diff --git a/src/libcamera/formats.c b/src/libcamera/formats.c\n> deleted file mode 100644\n> index e69de29bb2d1..000000000000\n> \n> base-commit: 0d99f2de13faccf199e6c9e806702cb21d0b6c24\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AFD2C323E\n\tfor ;\n\tMon, 22 Jan 2024 15:51:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 433DD62916;\n\tMon, 22 Jan 2024 16:51:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F8CB61D30\n\tfor ;\n\tMon, 22 Jan 2024 16:51:03 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 576018C;\n\tMon, 22 Jan 2024 16:49:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sH31bnAO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705938590;\n\tbh=O9/wkmsxVNjAbFhpjCqmEq7+TSXmLKVgoT1XjpmNAM0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sH31bnAOfdTFVDTJMw3Iv61r9s+22ojnQcKmPU0pU/fHUudgMcmi7DihLEBDFpeeG\n\tqiyYQ3lfSO2MGWHcrm5CrO7CJ/otS/D82wcAP/rpOViBVDBnzQ+EcRcDsFClolNmm8\n\tuf+TbxQJj547uFq0P8B76di+zrcI8/IcF4GGTtmw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240122154621.18543-1-laurent.pinchart@ideasonboard.com>","References":"<20240122154621.18543-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: Remove empty formats.c","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 22 Jan 2024 15:51:00 +0000","Message-ID":"<170593866091.1011926.18266619838352438497@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]