[{"id":28521,"web_url":"https://patchwork.libcamera.org/comment/28521/","msgid":"<20240122111737.GA28216@pendragon.ideasonboard.com>","date":"2024-01-22T11:17:37","subject":"Re: [PATCH] utils: ipc: extract-docs: Fix escape characters in regex","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Jan 22, 2024 at 08:01:04PM +0900, Paul Elder wrote:\n> Newer versions of python now generate a SyntaxWarning (SyntaxError in\n> the future [1]) for invalid escape sequences. Fix this, as there were\n> invalid escape sequences in the regexes:\n> \n> \"libcamera/utils/ipc/./extract-docs.py:13: SyntaxWarning: invalid escape\n> sequence '\\/'\"\n> \n> [1] https://docs.python.org/3.12/library/re.html\n> \n> Reported-by: Nicolas Dufresne \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> I'm not actually able to reproduce the warning in the first place, but\n> from my understanding this should fix the problem. Nicolas, could you\n> confirm this please?\n> ---\n> utils/ipc/extract-docs.py | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/utils/ipc/extract-docs.py b/utils/ipc/extract-docs.py\n> index 8f7fff9ff..c2050c998 100755\n> --- a/utils/ipc/extract-docs.py\n> +++ b/utils/ipc/extract-docs.py\n> @@ -10,9 +10,9 @@ import argparse\n> import re\n> import sys\n> \n> -regex_block_start = re.compile('^\\/\\*\\*$')\n> -regex_block_end = re.compile('^ \\*\\/$')\n> -regex_spdx = re.compile('^\\/\\* SPDX-License-Identifier: .* \\*\\/$')\n> +regex_block_start = re.compile(r'^/\\*\\*$')\n> +regex_block_end = re.compile(r'^ \\*/$')\n> +regex_spdx = re.compile(r'^/\\* SPDX-License-Identifier: .* \\*/$')\n> \n> \n> def main(argv):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77AD6C323E\n\tfor ;\n\tMon, 22 Jan 2024 11:17:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81AAA62936;\n\tMon, 22 Jan 2024 12:17:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4616061D30\n\tfor ;\n\tMon, 22 Jan 2024 12:17:34 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DFC6221;\n\tMon, 22 Jan 2024 12:16:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BRZzOxVa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705922181;\n\tbh=nLcw0zG+nOqeCKAAs9FwIsSbEfg7p7jdXfTSn3A+L1Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BRZzOxVaJLnKRTBRrpH/3tKSlIwT1VLMogVBXclWtG0JGR4IcdXb3vLKy049tdWmP\n\t4XFkA65rtXY08oNd+4KNphJvadoRIDRaGto23dmB6LFFj33MvKJKz/aWrjq0tL0AZz\n\tm3UPWsdq9Qh4rJhVF10ZSMJMxuokZo/GARDyXALw=","Date":"Mon, 22 Jan 2024 13:17:37 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Subject":"Re: [PATCH] utils: ipc: extract-docs: Fix escape characters in regex","Message-ID":"<20240122111737.GA28216@pendragon.ideasonboard.com>","References":"<20240122110104.3206863-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240122110104.3206863-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28545,"web_url":"https://patchwork.libcamera.org/comment/28545/","msgid":"","date":"2024-01-22T16:33:13","subject":"Re: [PATCH] utils: ipc: extract-docs: Fix escape characters in regex","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le lundi 22 janvier 2024 à 20:01 +0900, Paul Elder a écrit :\n> Newer versions of python now generate a SyntaxWarning (SyntaxError in\n> the future [1]) for invalid escape sequences. Fix this, as there were\n> invalid escape sequences in the regexes:\n> \n> \"libcamera/utils/ipc/./extract-docs.py:13: SyntaxWarning: invalid escape\n> sequence '\\/'\"\n> \n> [1] https://docs.python.org/3.12/library/re.html\n> \n> Reported-by: Nicolas Dufresne \n> Signed-off-by: Paul Elder \n\nNo more warnings, thanks,\n\nTested-by: Nicolas Dufresne \n\n> \n> ---\n> I'm not actually able to reproduce the warning in the first place, but\n> from my understanding this should fix the problem. Nicolas, could you\n> confirm this please?\n> ---\n> utils/ipc/extract-docs.py | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/utils/ipc/extract-docs.py b/utils/ipc/extract-docs.py\n> index 8f7fff9ff..c2050c998 100755\n> --- a/utils/ipc/extract-docs.py\n> +++ b/utils/ipc/extract-docs.py\n> @@ -10,9 +10,9 @@ import argparse\n> import re\n> import sys\n> \n> -regex_block_start = re.compile('^\\/\\*\\*$')\n> -regex_block_end = re.compile('^ \\*\\/$')\n> -regex_spdx = re.compile('^\\/\\* SPDX-License-Identifier: .* \\*\\/$')\n> +regex_block_start = re.compile(r'^/\\*\\*$')\n> +regex_block_end = re.compile(r'^ \\*/$')\n> +regex_spdx = re.compile(r'^/\\* SPDX-License-Identifier: .* \\*/$')\n> \n> \n> def main(argv):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1A89C323E\n\tfor ;\n\tMon, 22 Jan 2024 16:33:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FFB062916;\n\tMon, 22 Jan 2024 17:33:18 +0100 (CET)","from mail-qk1-x732.google.com (mail-qk1-x732.google.com\n\t[IPv6:2607:f8b0:4864:20::732])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5536F628B7\n\tfor ;\n\tMon, 22 Jan 2024 17:33:16 +0100 (CET)","by mail-qk1-x732.google.com with SMTP id\n\taf79cd13be357-7838d13395dso202343285a.1\n\tfor ;\n\tMon, 22 Jan 2024 08:33:16 -0800 (PST)","from nicolas-tpx395.localdomain ([2606:6d00:11:3354::580])\n\tby smtp.gmail.com with ESMTPSA id\n\tv6-20020a0ccd86000000b00683de714c89sm2519705qvm.55.2024.01.22.08.33.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Jan 2024 08:33:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"tfm+LTG4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1705941195;\n\tx=1706545995; darn=lists.libcamera.org; \n\th=mime-version:user-agent:content-transfer-encoding:autocrypt\n\t:references:in-reply-to:date:to:from:subject:message-id:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=dN+xzAV8cqahGuPJJODrv08HtcKtke8Bf3KR7VqNm14=;\n\tb=tfm+LTG4brCKgQGs4FVmF3b4XAjQ0or4rzEJpfz7L6kOqUOUjIt6GCGZK443QA7o5P\n\tHD9Gar/QGnWbMkLN6EzIujCpaY1Hy/ecbc3MMkoGw4hDaY6vSNvgpIL2+L+macKE5jee\n\tqLBjdrTLwthJMcTzWuAKWziFOX044Ch7FeqqssniNXU63g8wHrM3OQP3Oxbtr4LaQl3V\n\t2yhX+/FDSvKdL/4scif9tpTgQmlns45wJR1LMustyRiJqdmxA4b8FhYrOi7ttxXUfRPf\n\tDejcwtn5H8sJixA8JI9jd1fARWQ55Xe2C3I0IsfFqsJz27/uOwvakuLlLv8jQfn1zbwL\n\tTMlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705941195; x=1706545995;\n\th=mime-version:user-agent:content-transfer-encoding:autocrypt\n\t:references:in-reply-to:date:to:from:subject:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=dN+xzAV8cqahGuPJJODrv08HtcKtke8Bf3KR7VqNm14=;\n\tb=oOnKuG9ZiFrp/1kDPXBsu+enwJ+/v3+jADVSEzdZs+hDytw+HDYTDHDTMYZMi/8R1/\n\tPcg1mqB7GBcQn1FoznQO0i6QgnSEROSRKstXaCHROkry5Lsd1QI1ZcbGdBLfKxjYYdOo\n\tKbAXMClpqnbt5ab/+v8eAhSS+0vMMXVPlNHmh3t/gnMF5cuRJiqztZHNB6WSiGzP8crT\n\tf7VcZ0FdVUHkTgbbBz6a+YiA+ccvMSm3oxqLcQCiHb4Wr6uyt7qZwX07uJNyW/IyrLYr\n\tNb6sS2UTKdGBz7OzDB/ccTumKhbexarWZl+Fr4q/y5MtS6ct/+ENEDevG7Bg7fnM+FxT\n\tsufA==","X-Gm-Message-State":"AOJu0YwMu4qbbfr0Q5vz04heQ402q3QjIKIA9kkTmJKVS9B5i3lNBW1T\n\t4WE/6pqJCrlpHsho43Ub36Hd2PQ5vqSRXfSBlqeGkrc9ZDtCnjhPt1WrlZ1T6lIThu2Xkkn8kHS\n\ts","X-Google-Smtp-Source":"AGHT+IEhOPrkJS/dEdIO/1XCbBd1GtL7nscCdUfGcAqMs1MkHJe7HdY8GW7d3w7jMzM1vG+3wMh4dA==","X-Received":"by 2002:a05:6214:2a4f:b0:67f:940a:ed1c with SMTP id\n\tjf15-20020a0562142a4f00b0067f940aed1cmr6351423qvb.66.1705941195172; \n\tMon, 22 Jan 2024 08:33:15 -0800 (PST)","Message-ID":"","Subject":"Re: [PATCH] utils: ipc: extract-docs: Fix escape characters in regex","From":"Nicolas Dufresne ","To":"Paul Elder , \n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 22 Jan 2024 11:33:13 -0500","In-Reply-To":"<20240122110104.3206863-1-paul.elder@ideasonboard.com>","References":"<20240122110104.3206863-1-paul.elder@ideasonboard.com>","Autocrypt":"addr=nicolas@ndufresne.ca; prefer-encrypt=mutual;\n\tkeydata=mQGiBEUQN0MRBACQYceNSezSdMjx7sx6gwKkMghrrODgl3B0eXBTgNp6c431IfOOEsdvkoOh1kwoYcQgbg4MXw6beOltysX4e8fFWsiRkc2nvvRW9ir9kHDm49MkBLqaDjTqOkYKNMiurFW+gozpr/lUW15QqT6v68RYe0zRdtwGZqeLzX2LVuukGwCg4AISzswrrYHNV7vQLcbaUhPgIl0D+gILYT9TJgAEK4YHW+bFRcY+cgUFoLQqQayECMlctKoLOE69nIYOc/hDr9uih1wxrQ/yL0NJvQCohSPyoyLF9b2EuIGhQVp05XP7FzlTxhYvGO/DtO08ec85+bTfVBMV6eeY4MS3ZU+1z7ObD7Pf29YjyTehN2Dan6w1g2rBk5MoA/9nDocSlk4pbFpsYSFmVHsDiAOFje3+iY4ftVDKunKYWMhwRVBjAREOByBagmRau0cLEcElpf4hX5f978GoxSGIsiKoDAlXX+ICDOWC1/EXhEEmBR1gL0QJgiVviNyLfGJlZWnPjw6xhhmtHYWTDxBOP5peztyc2PqeKsLsLWzAr7RDTmljb2xhcyBEdWZyZXNuZSAoQi4gU2MuIEluZm9ybWF0aXF1ZSkgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPohgBBMRAgAgBQJFlCyOAhsDBgsJCAcDAgQVAggDBBYCAwECHgECF4AACgkQcVMCLawGqBwhLQCgzYlrLBj6KIAZ4gmsfjXD6ZtddT8AoIeGDicVq5WvMHNWign6ApQcZUihtElOaWNvbGFzIER1ZnJlc25lIChCLiBTYy4gSW5mb3JtYXRpcXVlKSA8bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEuY28udWs+iGIEExECACIFAkuzca8CGwMGCwkIBwMCBhUIAgkKCwQWA\n\tgMBAh4BAheAAAoJEHFTAi2sBqgcQX8An2By6LDEeMxi4B9hUbpvRnzaaeNqA\n\tJ9Rox8rfqHZnSErw9bCHiBwvwJZ77QxTmljb2xhcyBEdWZyZXNuZSA8bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEuY29tPohiBBMRAgAiBQJNzZzPAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRBxUwItrAaoHLlxAKCYAGf4JL7DYDLs/188CPMGuwLypwCfWKc9DorA9f5pyYlD5pQo6SgSoiC0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPohiBBMRAgAiBQJVwNwgAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRBxUwItrAaoHCZ4AJ0QwU6/G4c7h9CkMBT9ZxGLX4KSnQCgq0P7CX7hv/M7HeyfMFZe8t3vAEW0RE5pY29sYXMgRHVmcmVzbmUgKEIuIFNjLiBJbmZvcm1hdGlxdWUpIDxuaWNvbGFzZEBibHVlc3RyZWFrdGVjaC5jb20+iGAEExECACAFAkZjGzoCGwMGCwkIBwMCBBUCCAMEFgIDAQIeAQIXgAAKCRBxUwItrAaoHBl7AJ0d2lrzshMmJaik/EaDEakzEwqgxQCg0JVZMZm9gRfEou1FvinuZxwf/mu0R05pY29sYXMgRHVmcmVzbmUgKEIgU2MuIEluZm9ybWF0aXF1ZSkgPG5pY29sYXMuZHVmcmVzbmVAdXNoZXJicm9va2UuY2E+iGAEExECACAFAkUQN0MCGwMGCwkIBwMCBBUCCAMEFgIDAQIeAQIXgAAKCRBxUwItrAaoHPTnAJ0WGgJJVspoctAvEcI00mtp5WAFGgCgr+E7ItOqZEHAs+xabBgknYZIFPW5Ag0ERRA3UhAIAJ0rxl2HsVg/nSOAUt7U/T/W+RKzVAlD9orCB0pRVvyWNxSr8MHcH\n\tmWCxykLuB34ouM4GuDVRKfGnqLzJRBfjs7Ax9K2FI3Odund9xpviLCt1jFC0K\n\tXL04RebrFT7xjDfocDaSLFvgxMVs/Jr2/ckKPId1oKvgYgt/o+MzUabKyFB8wIvq4GMtj3LoBKLCie2nCaSt7uVUt6q2t5bNWrd3lO6/mWn7YMc5Hsn33H9pS0+9szw6m3dG08eMKNueDlt72QxiYl2rhjzkT4ltKEkFgYBdyrtIj1UO6eX+YXb4E1rCMJrdjBSgqDPK1sWHC7gliy+izr+XTHuFwlfy8gBpsAAwUIAJJNus64gri4HAL632eqVpza83EphX1IuHzLi1LlMnQ9Tm7XKag46NhmJbOByMG33LwBsBdLjjHQSVkYZFWUifq+NWSFC/kqlb72vW8rBAv64+i3QdfxK9FWbweiRsPpvuHjJQuecbPDJpubLaxKbu2aqLCN5LuHXvdQr6KiXwabT+OJ9AJAqHG7q4IEzg4RNUVn9AS6L8bxqMSocjqpWNBCY2efCVd/c6k4Acv6jXu+wDAZEbWXK+71uaUHExhigBYBpiHGrobe32YlTVE/XEIzKKywhm/Hkn5YKWzumLte6xiD9JhKabmD7uqIvLt2twUpz4BdPzj0dvGlSmvFcaaISQQYEQIACQUCRRA3UgIbDAAKCRBxUwItrAaoHJLyAKDeS3AFowM3f1Y3OFU6XRCTKK2ZhwCfT/7P9WDjkkmiq5AfeOiwVlpuHtM=","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.50.3 (3.50.3-1.fc39) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]