[{"id":28504,"web_url":"https://patchwork.libcamera.org/comment/28504/","msgid":"<20240122074123.GH4378@pendragon.ideasonboard.com>","date":"2024-01-22T07:41:23","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: base: signal:\n\tUpdate Qt documentation link to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Neal,\n\nThank you for the patch.\n\nOn Sun, Jan 21, 2024 at 05:39:54PM -0500, Neal Gompa via libcamera-devel wrote:\n> The documentation is effectively the same, but we should be pointing\n> to the actively supported and used Qt version.\n> \n> Signed-off-by: Neal Gompa \n\nReviewed-by: Laurent Pinchart \n\nI'll merge this quickly, without waiting for 1/3.\n\n> ---\n> src/libcamera/base/signal.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp\n> index a46386a0..02290ad7 100644\n> --- a/src/libcamera/base/signal.cpp\n> +++ b/src/libcamera/base/signal.cpp\n> @@ -74,7 +74,7 @@ SignalBase::SlotList SignalBase::slots()\n> *\n> * Signals and slots are a language construct aimed at communication between\n> * objects through the observer pattern without the need for boilerplate code.\n> - * See http://doc.qt.io/qt-5/signalsandslots.html for more information.\n> + * See http://doc.qt.io/qt-6/signalsandslots.html for more information.\n> *\n> * Signals model events that can be observed from objects unrelated to the event\n> * source. Slots are functions that are called in response to a signal. Signals","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDFF3C323E\n\tfor ;\n\tMon, 22 Jan 2024 07:41:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B14D62931;\n\tMon, 22 Jan 2024 08:41:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FB7C61D2D\n\tfor ;\n\tMon, 22 Jan 2024 08:41:20 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51238BEB;\n\tMon, 22 Jan 2024 08:40:07 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705909281;\n\tbh=P8fuBpQ4lxwjCFdMM2riHc9e9opaLe7NG0b8nkE4TUo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=w63ZLUjRmxKL8kNHlls1tY4M7fu4x6RCW2BicfQGdhpMzTKY/LsSkZ4f1ElAlqEO1\n\to8JtVYb9GWdLNUM6kfD8SN/Czy/RAYcaXDVx1l0RR7fbtoGblqkEWme0cf/RMayRTt\n\t0Jscnw98RR/CNWbZ1JBOK+oJ41X2LxqUaJ1pGzD05gaJaTNE+tm5hntocRgCqSTfbq\n\tYWRbhS6X8eV1SGf9N4XEuA3bmVEr7S0GA6bmuOwbII7DCghPfST6tG5lGvFu2oO4Me\n\tAjkVZH0pTkUeOR29UcXWjty+2wrdjym6ZaVMiAAELx/dCx1Z9mIEiDKv4JvgbiNsCd\n\tRz/jbzfvEqZWA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705909207;\n\tbh=P8fuBpQ4lxwjCFdMM2riHc9e9opaLe7NG0b8nkE4TUo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hHdaey/87kYi5nZH+Ukh0ReST7gWnZb9xS0oHONJ2avNdfJAEE9eerCgORHLX990f\n\tYBZbm3rF3+HM9/MxWzcCdLzbakmoHitcTAP+igJ9NXrbUb/KMrNcJ/CgOu+BgUfPu0\n\tZk2uJiYYqvjjWR1qPNQ3/gzREs09NT5+tCdTbXDU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hHdaey/8\"; dkim-atps=neutral","Date":"Mon, 22 Jan 2024 09:41:23 +0200","To":"Neal Gompa ","Message-ID":"<20240122074123.GH4378@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-3-neal@gompa.dev>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240121224052.1049989-3-neal@gompa.dev>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: base: signal:\n\tUpdate Qt documentation link to Qt 6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28526,"web_url":"https://patchwork.libcamera.org/comment/28526/","msgid":"","date":"2024-01-22T11:39:36","subject":"Re: [PATCH v2 2/3] libcamera: base: signal: Update Qt documentation\n\tlink to Qt 6","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Sun, 21 Jan 2024 at 22:41, Neal Gompa wrote:\n>\n> The documentation is effectively the same, but we should be pointing\n> to the actively supported and used Qt version.\n>\n> Signed-off-by: Neal Gompa \n\nReviewed-by: Eric Curtin \n\nIs mise le meas/Regards,\n\nEric Curtin\n\n> ---\n> src/libcamera/base/signal.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp\n> index a46386a0..02290ad7 100644\n> --- a/src/libcamera/base/signal.cpp\n> +++ b/src/libcamera/base/signal.cpp\n> @@ -74,7 +74,7 @@ SignalBase::SlotList SignalBase::slots()\n> *\n> * Signals and slots are a language construct aimed at communication between\n> * objects through the observer pattern without the need for boilerplate code.\n> - * See http://doc.qt.io/qt-5/signalsandslots.html for more information.\n> + * See http://doc.qt.io/qt-6/signalsandslots.html for more information.\n> *\n> * Signals model events that can be observed from objects unrelated to the event\n> * source. Slots are functions that are called in response to a signal. Signals\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D56CEC323E\n\tfor ;\n\tMon, 22 Jan 2024 11:40:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88D0862916;\n\tMon, 22 Jan 2024 12:40:17 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0678D628B7\n\tfor ;\n\tMon, 22 Jan 2024 12:40:15 +0100 (CET)","from mail-pg1-f198.google.com (mail-pg1-f198.google.com\n\t[209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-326-ccjLu1b1MYC3OC2iPwNivg-1; Mon, 22 Jan 2024 06:40:13 -0500","by mail-pg1-f198.google.com with SMTP id\n\t41be03b00d2f7-5cf962e1fcbso3273063a12.3\n\tfor ;\n\tMon, 22 Jan 2024 03:40:13 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ERFSCnA9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1705923615;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=hRgPjjlwJ3MlBUdoi4kF11TVowTxnMcbnjHMkb8c4CU=;\n\tb=ERFSCnA9uaOEOyDns9I9U0rG3hveoMbHNwqsOQ5gGNqR4Wgznv36FfG5gHrj5yPzh5KbO9\n\t22x7NgmMrDlOS2T0b+FsW2lnoHIIu0ZCdJT2SbR5dRHOfVetAQVnVKbNSvLlk/XzXj9tlU\n\tKqGhvDZG3N8vPwHbyeU93EuOdT3f8ic=","X-MC-Unique":"ccjLu1b1MYC3OC2iPwNivg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705923612; x=1706528412;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=hRgPjjlwJ3MlBUdoi4kF11TVowTxnMcbnjHMkb8c4CU=;\n\tb=GEfuM94qRt0a4VGg2HcJoff6T5hy1+HTi+KYaq3s0Fwgxl1eCOiG/yeKskdnASjSj4\n\tMZj2zq/1vhC995+34hkWkYUJutShtvN02eA1uNZPKgaEOrruVfqG0nnUpklR4koIY3VO\n\t3QzGlVPXSnzxjg3eJheFXauXTZlL+l03G5WkvvPQxDD0TApnw5EmwHQo7/a8WbF81s+S\n\tgh7DQtM/Qa3VhkcmAS3D1ExniJKXXAjbezHOMX1FE+FJSoDjoY4e8Fn/sSpt52FuSkJV\n\twiRXfWke6nqL2nvoqygL0A6ZvR+967SaB0ne7cct0nAAVNFfEUjIBb2W7Y6NguVfkKGt\n\tAnCA==","X-Gm-Message-State":"AOJu0YzjYuJatGDbLTDzALLpiNr1mSh+OLSZnZ9TviFoHHCX3rbwUu2E\n\tzysmTxssKT6J890O82jjKYAIVxmFwCAm4HFNe7m6WnTtENKk0MJ5nQU+zo1hH2nkqls15gBDoK8\n\tAoUrq2dSApAhbGT4DAoJoGtr03BAeShssN8uFyYOAm+IqLayTWwOArApKVVXS/43HeEgmDQyACN\n\ta52tf9cnPp9HSVI47emSjAxhrDGdKUvkOC+ValZpr4y5gMxg==","X-Received":["by 2002:a05:6a20:d38c:b0:19b:559a:683b with SMTP id\n\tiq12-20020a056a20d38c00b0019b559a683bmr4355137pzb.23.1705923612418; \n\tMon, 22 Jan 2024 03:40:12 -0800 (PST)","by 2002:a05:6a20:d38c:b0:19b:559a:683b with SMTP id\n\tiq12-20020a056a20d38c00b0019b559a683bmr4355125pzb.23.1705923612070;\n\tMon, 22 Jan 2024 03:40:12 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEGKxD4NIBYMz8Ri2Ms2rI5ve2efDgO0OJUhCCZajWqvZn36aUPTcTX3rgWE9PfztWL5OK/dLfHJt9O9RAaMHw=","MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-3-neal@gompa.dev>","In-Reply-To":"<20240121224052.1049989-3-neal@gompa.dev>","From":"Eric Curtin ","Date":"Mon, 22 Jan 2024 11:39:36 +0000","Message-ID":"","Subject":"Re: [PATCH v2 2/3] libcamera: base: signal: Update Qt documentation\n\tlink to Qt 6","To":"Neal Gompa ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]