[{"id":28509,"web_url":"https://patchwork.libcamera.org/comment/28509/","msgid":"<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>","date":"2024-01-22T09:38:33","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Aha, I missed that there was already a v2.\n\nQuoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> Open source Qt 5 has been effectively end of life since the release\n> of Qt 6, and Qt 6 has current LTS releases now.\n> \n> This change ports qcam to Qt 6.2 and drops some of the baggage related\n> to Qt 5 that is no longer applicable.\n> \n> Signed-off-by: Neal Gompa \n> ---\n> README.rst | 2 +-\n> meson.build | 2 +-\n> src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> 3 files changed, 15 insertions(+), 34 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 315738ee..6f1c9302 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -88,7 +88,7 @@ for cam: [optional]\n> - libsdl2-dev: Enables the SDL sink\n> \n> for qcam: [optional]\n> - libtiff-dev qtbase5-dev qttools5-dev-tools\n> + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> \n> for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n> diff --git a/meson.build b/meson.build\n> index cb6b666a..4c315e2a 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> project('libcamera', 'c', 'cpp',\n> - meson_version : '>= 0.60',\n> + meson_version : '>= 0.63',\n\nDebian Bookworm: is currently at 1.0.1-5\nhttps://packages.debian.org/source/stable/meson\n\nUbuntu 22.04.3 is currently at 0.61.2-1 :-(\nhttps://packages.ubuntu.com/jammy/meson\n\nWe're about 3 months away from Ubuntu 24.04 ...\n\n\nFedora is in a better shape, and all Fedora releases in support have a\nrecent Meson at 1.2.3 or later:\n https://src.fedoraproject.org/rpms/meson\n\nRedhat Enterprise linux looks more problematic - So I'm not sure if that\nshould be included in fact.\n\nOpenSuse seems to be already at 1.3.1 too:\nhttps://software.opensuse.org/package/meson?locale=en\n\nSo it's just Ubuntu/Canonical holding us back here ...\n\nAny thoughts anyone?\n\n--\nKieran\n\n\n\n\n> version : '0.2.0',\n> default_options : [\n> 'werror=true',\n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index 6cf4c171..c7fcfbeb 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -1,13 +1,13 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -qt5 = import('qt5')\n> -qt5_dep = dependency('qt5',\n> +qt6 = import('qt6')\n> +qt6_dep = dependency('qt6',\n> method : 'pkg-config',\n> - modules : ['Core', 'Gui', 'Widgets'],\n> + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> required : get_option('qcam'),\n> - version : '>=5.4')\n> + version : '>=6.2')\n> \n> -if not qt5_dep.found()\n> +if not qt6_dep.found()\n> qcam_enabled = false\n> subdir_done()\n> endif\n> @@ -20,46 +20,27 @@ qcam_sources = files([\n> 'main.cpp',\n> 'main_window.cpp',\n> 'message_handler.cpp',\n> + 'viewfinder_gl.cpp',\n> 'viewfinder_qt.cpp',\n> ])\n> \n> qcam_moc_headers = files([\n> 'cam_select_dialog.h',\n> 'main_window.h',\n> + 'viewfinder_gl.h',\n> 'viewfinder_qt.h',\n> ])\n> \n> qcam_resources = files([\n> 'assets/feathericons/feathericons.qrc',\n> + 'assets/shader/shaders.qrc',\n> ])\n> \n> -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> \n> -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> - dependencies : qt5_dep, args : '-fPIC')\n> - qcam_sources += files([\n> - 'viewfinder_gl.cpp',\n> - ])\n> - qcam_moc_headers += files([\n> - 'viewfinder_gl.h',\n> - ])\n> - qcam_resources += files([\n> - 'assets/shader/shaders.qrc'\n> - ])\n> -endif\n> -\n> -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> - qt5_dep.version().version_compare('<5.13')) or\n> - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> - qt5_cpp_args += ['-Wno-deprecated-copy']\n> -endif\n> -\n> -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> qresources : qcam_resources,\n> - dependencies : qt5_dep)\n> + dependencies : qt6_dep)\n> \n> qcam = executable('qcam', qcam_sources, resources,\n> install : true,\n> @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> libatomic,\n> libcamera_public,\n> libtiff,\n> - qt5_dep,\n> + qt6_dep,\n> ],\n> - cpp_args : qt5_cpp_args)\n> + cpp_args : qt6_cpp_args)\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9511EBDB1C\n\tfor ;\n\tMon, 22 Jan 2024 09:38:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D58B6291F;\n\tMon, 22 Jan 2024 10:38:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6EFC628AD\n\tfor ;\n\tMon, 22 Jan 2024 10:38:36 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE1D6221;\n\tMon, 22 Jan 2024 10:37:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705916318;\n\tbh=b4iRFIBiu34vmVakV2atX3UNi9PqhXWcRic1BG8yRBA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vOaeh4yxJ2eph9CT2qzFTuQcvBlSkM/fP7HKqYBR2IMyiqRp9S57pG0ElzaEvSPRf\n\ttXqr1D1Rbx5cUDy0PWWsSn4cUmF4PDNEIM+VdIRAmsCFuSlKE8JUedNIN4n3Zt27j7\n\tA6Of45mkCZyTBwiT/BhQ00suV2AxtLu5R2LoQDZrip58V/Q+0SSiy+85UlJIvZ1Kmz\n\tJ11eLKZEJilTKVfnA+w1RPs2Frfx4RydZgfQtQlXZ3Iz6KTHgPV6q3IwGrOXZVUBT9\n\tLUt08FDTaCHt/dDrauQccM55Sq6zi+HAOzw0DZ21D0fkZIkkCPeI1+ks8lCmo/8Epp\n\tsrktaKrm0HQBg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705916243;\n\tbh=b4iRFIBiu34vmVakV2atX3UNi9PqhXWcRic1BG8yRBA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=IR6ZGouyPcc5k4Yg//+0wunF7pYfKAYz5Kq4KWONvlYVQfbux2iJ0f42izXHROw3R\n\tYdYG3OEy778wf1J2SmlQsaakfCWLghNclJDUHWbkU483ILJTUJVHBK/JsCDeMJ5sqC\n\t2P0E0fANS+jb0BOlqjlllerOKxiXc2yxI1jcpJx8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IR6ZGouy\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240121224052.1049989-2-neal@gompa.dev>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>","To":"Neal Gompa ,\n\tlibcamera-devel ","Date":"Mon, 22 Jan 2024 09:38:33 +0000","Message-ID":"<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Neal Gompa , Wim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28511,"web_url":"https://patchwork.libcamera.org/comment/28511/","msgid":"<20240122095339.GM4378@pendragon.ideasonboard.com>","date":"2024-01-22T09:53:39","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> Aha, I missed that there was already a v2.\n> \n> Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > Open source Qt 5 has been effectively end of life since the release\n> > of Qt 6, and Qt 6 has current LTS releases now.\n> > \n> > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > to Qt 5 that is no longer applicable.\n> > \n> > Signed-off-by: Neal Gompa \n> > ---\n> > README.rst | 2 +-\n> > meson.build | 2 +-\n> > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 315738ee..6f1c9302 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -88,7 +88,7 @@ for cam: [optional]\n> > - libsdl2-dev: Enables the SDL sink\n> > \n> > for qcam: [optional]\n> > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > \n> > for tracing with lttng: [optional]\n> > liblttng-ust-dev python3-jinja2 lttng-tools\n> > diff --git a/meson.build b/meson.build\n> > index cb6b666a..4c315e2a 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -1,7 +1,7 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > project('libcamera', 'c', 'cpp',\n> > - meson_version : '>= 0.60',\n> > + meson_version : '>= 0.63',\n> \n> Debian Bookworm: is currently at 1.0.1-5\n> https://packages.debian.org/source/stable/meson\n> \n> Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> https://packages.ubuntu.com/jammy/meson\n> \n> We're about 3 months away from Ubuntu 24.04 ...\n> \n> \n> Fedora is in a better shape, and all Fedora releases in support have a\n> recent Meson at 1.2.3 or later:\n> https://src.fedoraproject.org/rpms/meson\n> \n> Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> should be included in fact.\n> \n> OpenSuse seems to be already at 1.3.1 too:\n> https://software.opensuse.org/package/meson?locale=en\n> \n> So it's just Ubuntu/Canonical holding us back here ...\n> \n> Any thoughts anyone?\n\nI was hoping jammy-backports would help us, but that doesn't seem to be\nthe case :-(\n\nAs there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\nmissing something), I'm tempted to propose waiting until Ubuntu 24.04\ngets released.\n\n> > version : '0.2.0',\n> > default_options : [\n> > 'werror=true',\n> > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > index 6cf4c171..c7fcfbeb 100644\n> > --- a/src/apps/qcam/meson.build\n> > +++ b/src/apps/qcam/meson.build\n> > @@ -1,13 +1,13 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > -qt5 = import('qt5')\n> > -qt5_dep = dependency('qt5',\n> > +qt6 = import('qt6')\n> > +qt6_dep = dependency('qt6',\n> > method : 'pkg-config',\n> > - modules : ['Core', 'Gui', 'Widgets'],\n> > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > required : get_option('qcam'),\n> > - version : '>=5.4')\n> > + version : '>=6.2')\n> > \n> > -if not qt5_dep.found()\n> > +if not qt6_dep.found()\n> > qcam_enabled = false\n> > subdir_done()\n> > endif\n> > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > 'main.cpp',\n> > 'main_window.cpp',\n> > 'message_handler.cpp',\n> > + 'viewfinder_gl.cpp',\n> > 'viewfinder_qt.cpp',\n> > ])\n> > \n> > qcam_moc_headers = files([\n> > 'cam_select_dialog.h',\n> > 'main_window.h',\n> > + 'viewfinder_gl.h',\n> > 'viewfinder_qt.h',\n> > ])\n> > \n> > qcam_resources = files([\n> > 'assets/feathericons/feathericons.qrc',\n> > + 'assets/shader/shaders.qrc',\n> > ])\n> > \n> > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > \n> > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > - dependencies : qt5_dep, args : '-fPIC')\n> > - qcam_sources += files([\n> > - 'viewfinder_gl.cpp',\n> > - ])\n> > - qcam_moc_headers += files([\n> > - 'viewfinder_gl.h',\n> > - ])\n> > - qcam_resources += files([\n> > - 'assets/shader/shaders.qrc'\n> > - ])\n> > -endif\n> > -\n> > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > - qt5_dep.version().version_compare('<5.13')) or\n> > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > -endif\n> > -\n> > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > qresources : qcam_resources,\n> > - dependencies : qt5_dep)\n> > + dependencies : qt6_dep)\n> > \n> > qcam = executable('qcam', qcam_sources, resources,\n> > install : true,\n> > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > libatomic,\n> > libcamera_public,\n> > libtiff,\n> > - qt5_dep,\n> > + qt6_dep,\n> > ],\n> > - cpp_args : qt5_cpp_args)\n> > + cpp_args : qt6_cpp_args)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DBABC323E\n\tfor ;\n\tMon, 22 Jan 2024 09:53:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43CAF6291F;\n\tMon, 22 Jan 2024 10:53:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEA19628AD\n\tfor ;\n\tMon, 22 Jan 2024 10:53:35 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D71B9221;\n\tMon, 22 Jan 2024 10:52:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705917217;\n\tbh=Ftl0YVbFUFs//eh6FDwD8LtkgmiDbki6iQI9oq2JEAc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LTzqX7/akZVkpzplb2heaRNTuN01Yy9wenwzQ4mTV0U/EmflN290zSiJ5YEOZovZR\n\tcRhy+iLuqtjfUsmDzslbbYGcTXFCIFfpLN25NQPOcAMMokjDipKPx9MbUP05KzcAfg\n\txZYdQ88yLFFaf4aOf1mnFOABn+ZCGdXK++nPWZlETuAc9oARSXldAT+/ytKwZt5ATs\n\tsG2/uP8gypfWjaFRLRqZ8SVLQwHrJBhXkKFqbbyEpjK24jGouFYxhgBoVJqx20d2CU\n\tR96fMexTD7Tyub9UwOaWOpxkN4Tl9GbHElM7iNw9afw/uhYSrUj9x7GwgvhccTWMe+\n\t3HJEeZssJPoYw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705917143;\n\tbh=Ftl0YVbFUFs//eh6FDwD8LtkgmiDbki6iQI9oq2JEAc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aJ2ZxeRQEZ5+AkmmPSHw5w9zpxwWl90NefNTHqB/l/JvgTLo/44eA9+hPOag6zLPG\n\t/MRvaMz/NH/hDJ+hEJAnsg/NGnPxFltkOeHUaV+EQxFRm559nBOOZ6QTiTCRHCjHhU\n\tX+hJcozOeeJ3TWAgnjJjiNcxujDFIhizIWiyuhjM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aJ2ZxeRQ\"; dkim-atps=neutral","Date":"Mon, 22 Jan 2024 11:53:39 +0200","To":"Kieran Bingham ","Message-ID":"<20240122095339.GM4378@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Neal Gompa ,\n\tlibcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28517,"web_url":"https://patchwork.libcamera.org/comment/28517/","msgid":"<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>","date":"2024-01-22T11:00:25","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-01-22 09:53:39)\n> On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > Aha, I missed that there was already a v2.\n> > \n> > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > Open source Qt 5 has been effectively end of life since the release\n> > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > \n> > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > to Qt 5 that is no longer applicable.\n> > > \n> > > Signed-off-by: Neal Gompa \n> > > ---\n> > > README.rst | 2 +-\n> > > meson.build | 2 +-\n> > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > \n> > > diff --git a/README.rst b/README.rst\n> > > index 315738ee..6f1c9302 100644\n> > > --- a/README.rst\n> > > +++ b/README.rst\n> > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > - libsdl2-dev: Enables the SDL sink\n> > > \n> > > for qcam: [optional]\n> > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > \n> > > for tracing with lttng: [optional]\n> > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > diff --git a/meson.build b/meson.build\n> > > index cb6b666a..4c315e2a 100644\n> > > --- a/meson.build\n> > > +++ b/meson.build\n> > > @@ -1,7 +1,7 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > > \n> > > project('libcamera', 'c', 'cpp',\n> > > - meson_version : '>= 0.60',\n> > > + meson_version : '>= 0.63',\n> > \n> > Debian Bookworm: is currently at 1.0.1-5\n> > https://packages.debian.org/source/stable/meson\n> > \n> > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > https://packages.ubuntu.com/jammy/meson\n> > \n> > We're about 3 months away from Ubuntu 24.04 ...\n> > \n> > \n> > Fedora is in a better shape, and all Fedora releases in support have a\n> > recent Meson at 1.2.3 or later:\n> > https://src.fedoraproject.org/rpms/meson\n> > \n> > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > should be included in fact.\n> > \n> > OpenSuse seems to be already at 1.3.1 too:\n> > https://software.opensuse.org/package/meson?locale=en\n> > \n> > So it's just Ubuntu/Canonical holding us back here ...\n> > \n> > Any thoughts anyone?\n> \n> I was hoping jammy-backports would help us, but that doesn't seem to be\n> the case :-(\n> \n> As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> gets released.\n\nNoble (24.04) will have either 1.2.1 or 1.3.1 (there are different\nversions in proposed and Release). Either way it will be > 1.2! :\n https://launchpad.net/ubuntu/noble/+package/meson\n\nI would propose that the meson version update is separated from the\npatch as a preceeding commit, and could already be resent. Then we can\nsimply pick these in April. I'd probably say we could merge this in\nearly April, such that we can make a release of libcamera with that\nsupport merged soon after Ubuntu 24.04 is released on April 25th.\n\n--\nRegards\nKieran\n\n\n> \n> > > version : '0.2.0',\n> > > default_options : [\n> > > 'werror=true',\n> > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > index 6cf4c171..c7fcfbeb 100644\n> > > --- a/src/apps/qcam/meson.build\n> > > +++ b/src/apps/qcam/meson.build\n> > > @@ -1,13 +1,13 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > > \n> > > -qt5 = import('qt5')\n> > > -qt5_dep = dependency('qt5',\n> > > +qt6 = import('qt6')\n> > > +qt6_dep = dependency('qt6',\n> > > method : 'pkg-config',\n> > > - modules : ['Core', 'Gui', 'Widgets'],\n> > > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > > required : get_option('qcam'),\n> > > - version : '>=5.4')\n> > > + version : '>=6.2')\n> > > \n> > > -if not qt5_dep.found()\n> > > +if not qt6_dep.found()\n> > > qcam_enabled = false\n> > > subdir_done()\n> > > endif\n> > > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > > 'main.cpp',\n> > > 'main_window.cpp',\n> > > 'message_handler.cpp',\n> > > + 'viewfinder_gl.cpp',\n> > > 'viewfinder_qt.cpp',\n> > > ])\n> > > \n> > > qcam_moc_headers = files([\n> > > 'cam_select_dialog.h',\n> > > 'main_window.h',\n> > > + 'viewfinder_gl.h',\n> > > 'viewfinder_qt.h',\n> > > ])\n> > > \n> > > qcam_resources = files([\n> > > 'assets/feathericons/feathericons.qrc',\n> > > + 'assets/shader/shaders.qrc',\n> > > ])\n> > > \n> > > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > \n> > > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > > - dependencies : qt5_dep, args : '-fPIC')\n> > > - qcam_sources += files([\n> > > - 'viewfinder_gl.cpp',\n> > > - ])\n> > > - qcam_moc_headers += files([\n> > > - 'viewfinder_gl.h',\n> > > - ])\n> > > - qcam_resources += files([\n> > > - 'assets/shader/shaders.qrc'\n> > > - ])\n> > > -endif\n> > > -\n> > > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > > - qt5_dep.version().version_compare('<5.13')) or\n> > > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > > -endif\n> > > -\n> > > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > > qresources : qcam_resources,\n> > > - dependencies : qt5_dep)\n> > > + dependencies : qt6_dep)\n> > > \n> > > qcam = executable('qcam', qcam_sources, resources,\n> > > install : true,\n> > > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > > libatomic,\n> > > libcamera_public,\n> > > libtiff,\n> > > - qt5_dep,\n> > > + qt6_dep,\n> > > ],\n> > > - cpp_args : qt5_cpp_args)\n> > > + cpp_args : qt6_cpp_args)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39E36BDB1C\n\tfor ;\n\tMon, 22 Jan 2024 11:00:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C40AB62936;\n\tMon, 22 Jan 2024 12:00:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF20C61D30\n\tfor ;\n\tMon, 22 Jan 2024 12:00:27 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B062F74A;\n\tMon, 22 Jan 2024 11:59:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mScY8LOW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705921154;\n\tbh=nLjZwhDFHNIFhSIJgFbTtrgXj4w2tkaVxOEoqRChAXM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mScY8LOW1Sn0HcchOEIQ+f6veeCGq0S4/9Ku4mdPpBJyYsgrIy83+KVqE2vYe0AUH\n\tqKE+uyDGVkkH3rWgYO45eDFWCjn0gjXfHsztHhteeB5UJVpjem6JatzalCkixy/2LG\n\t6XP/aNgrQZLZNGCCL2TNSqcKLbBtXcAVre/v7hxc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240122095339.GM4378@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","To":"Laurent Pinchart ","Date":"Mon, 22 Jan 2024 11:00:25 +0000","Message-ID":"<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Neal Gompa ,\n\tlibcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28519,"web_url":"https://patchwork.libcamera.org/comment/28519/","msgid":"","date":"2024-01-22T11:08:33","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 6:00 AM Kieran Bingham\n wrote:\n>\n> Quoting Laurent Pinchart (2024-01-22 09:53:39)\n> > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > Aha, I missed that there was already a v2.\n> > >\n> > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > Open source Qt 5 has been effectively end of life since the release\n> > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > >\n> > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > to Qt 5 that is no longer applicable.\n> > > >\n> > > > Signed-off-by: Neal Gompa \n> > > > ---\n> > > > README.rst | 2 +-\n> > > > meson.build | 2 +-\n> > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > >\n> > > > diff --git a/README.rst b/README.rst\n> > > > index 315738ee..6f1c9302 100644\n> > > > --- a/README.rst\n> > > > +++ b/README.rst\n> > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > - libsdl2-dev: Enables the SDL sink\n> > > >\n> > > > for qcam: [optional]\n> > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > >\n> > > > for tracing with lttng: [optional]\n> > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > diff --git a/meson.build b/meson.build\n> > > > index cb6b666a..4c315e2a 100644\n> > > > --- a/meson.build\n> > > > +++ b/meson.build\n> > > > @@ -1,7 +1,7 @@\n> > > > # SPDX-License-Identifier: CC0-1.0\n> > > >\n> > > > project('libcamera', 'c', 'cpp',\n> > > > - meson_version : '>= 0.60',\n> > > > + meson_version : '>= 0.63',\n> > >\n> > > Debian Bookworm: is currently at 1.0.1-5\n> > > https://packages.debian.org/source/stable/meson\n> > >\n> > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > https://packages.ubuntu.com/jammy/meson\n> > >\n> > > We're about 3 months away from Ubuntu 24.04 ...\n> > >\n> > >\n> > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > recent Meson at 1.2.3 or later:\n> > > https://src.fedoraproject.org/rpms/meson\n> > >\n> > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > should be included in fact.\n> > >\n> > > OpenSuse seems to be already at 1.3.1 too:\n> > > https://software.opensuse.org/package/meson?locale=en\n> > >\n> > > So it's just Ubuntu/Canonical holding us back here ...\n> > >\n> > > Any thoughts anyone?\n> >\n> > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > the case :-(\n> >\n> > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > gets released.\n>\n> Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> versions in proposed and Release). Either way it will be > 1.2! :\n> https://launchpad.net/ubuntu/noble/+package/meson\n>\n> I would propose that the meson version update is separated from the\n> patch as a preceeding commit, and could already be resent. Then we can\n> simply pick these in April. I'd probably say we could merge this in\n> early April, such that we can make a release of libcamera with that\n> support merged soon after Ubuntu 24.04 is released on April 25th.\n>\n\nOn the flip side, if it's merged and released into Debian before the\nUbuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\nitself.\n\n[1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDCEFC323E\n\tfor ;\n\tMon, 22 Jan 2024 11:09:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DE3F62916;\n\tMon, 22 Jan 2024 12:09:13 +0100 (CET)","from mail-ej1-f48.google.com (mail-ej1-f48.google.com\n\t[209.85.218.48])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E29661D30\n\tfor ;\n\tMon, 22 Jan 2024 12:09:11 +0100 (CET)","by mail-ej1-f48.google.com with SMTP id\n\ta640c23a62f3a-a2a17f3217aso278019966b.2\n\tfor ;\n\tMon, 22 Jan 2024 03:09:11 -0800 (PST)","from mail-ed1-f44.google.com (mail-ed1-f44.google.com.\n\t[209.85.208.44]) by smtp.gmail.com with ESMTPSA id\n\tvo11-20020a170907a80b00b00a307886e458sm391675ejc.108.2024.01.22.03.09.10\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 03:09:10 -0800 (PST)","by mail-ed1-f44.google.com with SMTP id\n\t4fb4d7f45d1cf-55a90b2b554so1602383a12.1\n\tfor ;\n\tMon, 22 Jan 2024 03:09:10 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705921751; x=1706526551;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=9ii2Nj1EtQn3akfj7H+7eDq9y+wZ5Zsz+APwBteMLkE=;\n\tb=C5g8SKqs2Y9o8A49zGErscq5PbkuDsXqVDBzEEEVop0/JDxKoYtAJEYi6NpClJnIju\n\tLE6da1dlVguT/0vjYv+vcuHDohtrrJ81MqEtzsa49AH2nyKL7sLuW49QISyJUz84/mpT\n\tZxOY7f0X1d/EvT2MtuMEYxqCurt/d5+H55mdsxjJJTwQ8xOk7jMpPtYIZF0Q1PgOYInq\n\tc12+++zEHBWYKle5gjtklnTk6Kn5Tc5T/SngGunlyGgG0nvgZ1S1wr942N47I+pDQxrR\n\taBnDrbjz0g0p+LlTSTGOfZqpQ/LkB40rSNQSUYMbf383OCI9KzQzq3uEGlLVk9Z61agC\n\t+NyQ==","X-Gm-Message-State":"AOJu0YzkPZfQQJ6xdoWrlBT0IWvtf7YTbMb8qyJlSdSVzrtPSUBWDd18\n\tXAieKCADa7nAGMeVSiTOZFpW5o71XP9YheoQBe4cbfbm1VoS9F1eULB3HzD75a8=","X-Google-Smtp-Source":"AGHT+IHYE3A6udwHuy4jjIdAmKO7n18BCNGlb6dl0Th1cfGqqP1BtEyRxKnnSyixiHnLo4li540+KA==","X-Received":["by 2002:a17:907:160b:b0:a2f:d615:b615 with SMTP id\n\tcw11-20020a170907160b00b00a2fd615b615mr2378171ejd.143.1705921750280; \n\tMon, 22 Jan 2024 03:09:10 -0800 (PST)","by 2002:aa7:d645:0:b0:55a:72e1:815a with SMTP id\n\tv5-20020aa7d645000000b0055a72e1815amr1929630edr.16.1705921749878;\n\tMon, 22 Jan 2024 03:09:09 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>","In-Reply-To":"<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 06:08:33 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28520,"web_url":"https://patchwork.libcamera.org/comment/28520/","msgid":"","date":"2024-01-22T11:12:08","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 4:53 AM Laurent Pinchart via libcamera-devel\n wrote:\n>\n> On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > Aha, I missed that there was already a v2.\n> >\n> > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > Open source Qt 5 has been effectively end of life since the release\n> > > of Qt 6, and Qt 6 has current LTS releases now.\n> > >\n> > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > to Qt 5 that is no longer applicable.\n> > >\n> > > Signed-off-by: Neal Gompa \n> > > ---\n> > > README.rst | 2 +-\n> > > meson.build | 2 +-\n> > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > >\n> > > diff --git a/README.rst b/README.rst\n> > > index 315738ee..6f1c9302 100644\n> > > --- a/README.rst\n> > > +++ b/README.rst\n> > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > - libsdl2-dev: Enables the SDL sink\n> > >\n> > > for qcam: [optional]\n> > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > >\n> > > for tracing with lttng: [optional]\n> > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > diff --git a/meson.build b/meson.build\n> > > index cb6b666a..4c315e2a 100644\n> > > --- a/meson.build\n> > > +++ b/meson.build\n> > > @@ -1,7 +1,7 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > >\n> > > project('libcamera', 'c', 'cpp',\n> > > - meson_version : '>= 0.60',\n> > > + meson_version : '>= 0.63',\n> >\n> > Debian Bookworm: is currently at 1.0.1-5\n> > https://packages.debian.org/source/stable/meson\n> >\n> > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > https://packages.ubuntu.com/jammy/meson\n> >\n> > We're about 3 months away from Ubuntu 24.04 ...\n> >\n> >\n> > Fedora is in a better shape, and all Fedora releases in support have a\n> > recent Meson at 1.2.3 or later:\n> > https://src.fedoraproject.org/rpms/meson\n> >\n> > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > should be included in fact.\n> >\n> > OpenSuse seems to be already at 1.3.1 too:\n> > https://software.opensuse.org/package/meson?locale=en\n> >\n> > So it's just Ubuntu/Canonical holding us back here ...\n> >\n> > Any thoughts anyone?\n>\n> I was hoping jammy-backports would help us, but that doesn't seem to be\n> the case :-(\n>\n> As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> gets released.\n>\n> > > version : '0.2.0',\n> > > default_options : [\n> > > 'werror=true',\n> > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > index 6cf4c171..c7fcfbeb 100644\n> > > --- a/src/apps/qcam/meson.build\n> > > +++ b/src/apps/qcam/meson.build\n> > > @@ -1,13 +1,13 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > >\n> > > -qt5 = import('qt5')\n> > > -qt5_dep = dependency('qt5',\n> > > +qt6 = import('qt6')\n> > > +qt6_dep = dependency('qt6',\n> > > method : 'pkg-config',\n> > > - modules : ['Core', 'Gui', 'Widgets'],\n> > > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > > required : get_option('qcam'),\n> > > - version : '>=5.4')\n> > > + version : '>=6.2')\n> > >\n> > > -if not qt5_dep.found()\n> > > +if not qt6_dep.found()\n> > > qcam_enabled = false\n> > > subdir_done()\n> > > endif\n> > > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > > 'main.cpp',\n> > > 'main_window.cpp',\n> > > 'message_handler.cpp',\n> > > + 'viewfinder_gl.cpp',\n> > > 'viewfinder_qt.cpp',\n> > > ])\n> > >\n> > > qcam_moc_headers = files([\n> > > 'cam_select_dialog.h',\n> > > 'main_window.h',\n> > > + 'viewfinder_gl.h',\n> > > 'viewfinder_qt.h',\n> > > ])\n> > >\n> > > qcam_resources = files([\n> > > 'assets/feathericons/feathericons.qrc',\n> > > + 'assets/shader/shaders.qrc',\n> > > ])\n> > >\n> > > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > >\n> > > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > > - dependencies : qt5_dep, args : '-fPIC')\n> > > - qcam_sources += files([\n> > > - 'viewfinder_gl.cpp',\n> > > - ])\n> > > - qcam_moc_headers += files([\n> > > - 'viewfinder_gl.h',\n> > > - ])\n> > > - qcam_resources += files([\n> > > - 'assets/shader/shaders.qrc'\n> > > - ])\n> > > -endif\n> > > -\n> > > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > > - qt5_dep.version().version_compare('<5.13')) or\n> > > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > > -endif\n> > > -\n> > > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > > qresources : qcam_resources,\n> > > - dependencies : qt5_dep)\n> > > + dependencies : qt6_dep)\n> > >\n> > > qcam = executable('qcam', qcam_sources, resources,\n> > > install : true,\n> > > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > > libatomic,\n> > > libcamera_public,\n> > > libtiff,\n> > > - qt5_dep,\n> > > + qt6_dep,\n> > > ],\n> > > - cpp_args : qt5_cpp_args)\n> > > + cpp_args : qt6_cpp_args)\n>\n\nI'd like to have this in place for Fedora 40 as that's the release\nwe're moving to KDE Plasma 6[1] and thus generally preferring\neverything to be Qt 6 whenever possible. Additionally, CentOS/RHEL 10\n(which forks from Fedora 40) will only have Qt 6. The freeze for\nFedora is in two weeks[2], and I'd like to have this landed before\nthen.\n\n[1]: https://fedoraproject.org/wiki/Changes/KDE_Plasma_6\n[2]: https://fedorapeople.org/groups/schedule/f-40/f-40-key-tasks.html","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95301BDB1C\n\tfor ;\n\tMon, 22 Jan 2024 11:12:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7A6B62936;\n\tMon, 22 Jan 2024 12:12:47 +0100 (CET)","from mail-lf1-f44.google.com (mail-lf1-f44.google.com\n\t[209.85.167.44])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F7B261D30\n\tfor ;\n\tMon, 22 Jan 2024 12:12:47 +0100 (CET)","by mail-lf1-f44.google.com with SMTP id\n\t2adb3069b0e04-50eabd1c701so3188441e87.3\n\tfor ;\n\tMon, 22 Jan 2024 03:12:47 -0800 (PST)","from mail-ed1-f48.google.com (mail-ed1-f48.google.com.\n\t[209.85.208.48]) by smtp.gmail.com with ESMTPSA id\n\ten7-20020a056402528700b0055731d8f459sm14065557edb.24.2024.01.22.03.12.45\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 03:12:45 -0800 (PST)","by mail-ed1-f48.google.com with SMTP id\n\t4fb4d7f45d1cf-55a90b2b554so1606594a12.1\n\tfor ;\n\tMon, 22 Jan 2024 03:12:45 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705921966; x=1706526766;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=dMhr9zlZUfAaSOKKEn4WKWhZXHV9V+k0tHqc1gDGEgU=;\n\tb=trQDg6d9sZnbcJ0+IfHjAIivhphX3i4QRjX0QtyZt8QF+zjOYNtg8mvldTWS9/FQIt\n\tdXrsg9/YgjDPF1+R6HYf6/XZ00z0yz2/nlDbi3M+1aRTfiKQgM51mwALw5jzgPMR0UpA\n\tHK3hZX8RQBshGxAY2wKX8o9ifrfMGsORtDxJZcgbbqOKYIcw5ZWkEqOOsohYu4I4KBa8\n\tjNtp7Jo4WMfnZCeX466WYho2pOZY1oy49sVp2fKi2LeAW7gbqInxr1Jg+DSE1H/KL2NT\n\tn6Ph8OJnqWa15tv6TUQOrizrQNpiOyJ5L7ct3SFEVNdi77WieE7Th8JctQKFI5/u4bb4\n\t3BlA==","X-Gm-Message-State":"AOJu0YxvO1b4D3p4Tt3WkFcIaX7Ev+abiBo7W0iLcB0EK5i0E2pg/6cn\n\tMzYqbuVRgmV9QMXlRL33tq5WUMF4OUeiygbDiTA9rB0J3jW+vOa7oANTGb1OMAY=","X-Google-Smtp-Source":"AGHT+IGP8MEjgUom4s0vxcZkpKajNi84hVNaeL7WRyR8vg0tX4r6MV2zLXVQcTncdw0Jhc6AZpSrxw==","X-Received":["by 2002:a05:6512:48cf:b0:50e:74c1:64d2 with SMTP id\n\ter15-20020a05651248cf00b0050e74c164d2mr1586381lfb.94.1705921965711; \n\tMon, 22 Jan 2024 03:12:45 -0800 (PST)","by 2002:a05:6402:1351:b0:558:cf66:9749 with SMTP id\n\ty17-20020a056402135100b00558cf669749mr2105124edw.7.1705921965212;\n\tMon, 22 Jan 2024 03:12:45 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>","In-Reply-To":"<20240122095339.GM4378@pendragon.ideasonboard.com>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 06:12:08 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28522,"web_url":"https://patchwork.libcamera.org/comment/28522/","msgid":"<20240122113356.GA29275@pendragon.ideasonboard.com>","date":"2024-01-22T11:33:56","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 06:12:08AM -0500, Neal Gompa wrote:\n> On Mon, Jan 22, 2024 at 4:53 AM Laurent Pinchart via libcamera-devel\n> wrote:\n> >\n> > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > Aha, I missed that there was already a v2.\n> > >\n> > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > Open source Qt 5 has been effectively end of life since the release\n> > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > >\n> > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > to Qt 5 that is no longer applicable.\n> > > >\n> > > > Signed-off-by: Neal Gompa \n> > > > ---\n> > > > README.rst | 2 +-\n> > > > meson.build | 2 +-\n> > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > >\n> > > > diff --git a/README.rst b/README.rst\n> > > > index 315738ee..6f1c9302 100644\n> > > > --- a/README.rst\n> > > > +++ b/README.rst\n> > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > - libsdl2-dev: Enables the SDL sink\n> > > >\n> > > > for qcam: [optional]\n> > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > >\n> > > > for tracing with lttng: [optional]\n> > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > diff --git a/meson.build b/meson.build\n> > > > index cb6b666a..4c315e2a 100644\n> > > > --- a/meson.build\n> > > > +++ b/meson.build\n> > > > @@ -1,7 +1,7 @@\n> > > > # SPDX-License-Identifier: CC0-1.0\n> > > >\n> > > > project('libcamera', 'c', 'cpp',\n> > > > - meson_version : '>= 0.60',\n> > > > + meson_version : '>= 0.63',\n> > >\n> > > Debian Bookworm: is currently at 1.0.1-5\n> > > https://packages.debian.org/source/stable/meson\n> > >\n> > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > https://packages.ubuntu.com/jammy/meson\n> > >\n> > > We're about 3 months away from Ubuntu 24.04 ...\n> > >\n> > >\n> > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > recent Meson at 1.2.3 or later:\n> > > https://src.fedoraproject.org/rpms/meson\n> > >\n> > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > should be included in fact.\n> > >\n> > > OpenSuse seems to be already at 1.3.1 too:\n> > > https://software.opensuse.org/package/meson?locale=en\n> > >\n> > > So it's just Ubuntu/Canonical holding us back here ...\n> > >\n> > > Any thoughts anyone?\n> >\n> > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > the case :-(\n> >\n> > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > gets released.\n> >\n> > > > version : '0.2.0',\n> > > > default_options : [\n> > > > 'werror=true',\n> > > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > > index 6cf4c171..c7fcfbeb 100644\n> > > > --- a/src/apps/qcam/meson.build\n> > > > +++ b/src/apps/qcam/meson.build\n> > > > @@ -1,13 +1,13 @@\n> > > > # SPDX-License-Identifier: CC0-1.0\n> > > >\n> > > > -qt5 = import('qt5')\n> > > > -qt5_dep = dependency('qt5',\n> > > > +qt6 = import('qt6')\n> > > > +qt6_dep = dependency('qt6',\n> > > > method : 'pkg-config',\n> > > > - modules : ['Core', 'Gui', 'Widgets'],\n> > > > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > > > required : get_option('qcam'),\n> > > > - version : '>=5.4')\n> > > > + version : '>=6.2')\n> > > >\n> > > > -if not qt5_dep.found()\n> > > > +if not qt6_dep.found()\n> > > > qcam_enabled = false\n> > > > subdir_done()\n> > > > endif\n> > > > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > > > 'main.cpp',\n> > > > 'main_window.cpp',\n> > > > 'message_handler.cpp',\n> > > > + 'viewfinder_gl.cpp',\n> > > > 'viewfinder_qt.cpp',\n> > > > ])\n> > > >\n> > > > qcam_moc_headers = files([\n> > > > 'cam_select_dialog.h',\n> > > > 'main_window.h',\n> > > > + 'viewfinder_gl.h',\n> > > > 'viewfinder_qt.h',\n> > > > ])\n> > > >\n> > > > qcam_resources = files([\n> > > > 'assets/feathericons/feathericons.qrc',\n> > > > + 'assets/shader/shaders.qrc',\n> > > > ])\n> > > >\n> > > > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > >\n> > > > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > > > - dependencies : qt5_dep, args : '-fPIC')\n> > > > - qcam_sources += files([\n> > > > - 'viewfinder_gl.cpp',\n> > > > - ])\n> > > > - qcam_moc_headers += files([\n> > > > - 'viewfinder_gl.h',\n> > > > - ])\n> > > > - qcam_resources += files([\n> > > > - 'assets/shader/shaders.qrc'\n> > > > - ])\n> > > > -endif\n> > > > -\n> > > > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > > > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > > > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > > > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > > > - qt5_dep.version().version_compare('<5.13')) or\n> > > > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > > > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > > > -endif\n> > > > -\n> > > > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > > > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > > > qresources : qcam_resources,\n> > > > - dependencies : qt5_dep)\n> > > > + dependencies : qt6_dep)\n> > > >\n> > > > qcam = executable('qcam', qcam_sources, resources,\n> > > > install : true,\n> > > > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > > > libatomic,\n> > > > libcamera_public,\n> > > > libtiff,\n> > > > - qt5_dep,\n> > > > + qt6_dep,\n> > > > ],\n> > > > - cpp_args : qt5_cpp_args)\n> > > > + cpp_args : qt6_cpp_args)\n> \n> I'd like to have this in place for Fedora 40 as that's the release\n> we're moving to KDE Plasma 6[1] and thus generally preferring\n> everything to be Qt 6 whenever possible. Additionally, CentOS/RHEL 10\n> (which forks from Fedora 40) will only have Qt 6. The freeze for\n> Fedora is in two weeks[2], and I'd like to have this landed before\n> then.\n\nThat's a pretty short notice. Could you have a look at the toolbar icon\nissue I've reported then ?\n\n> [1]: https://fedoraproject.org/wiki/Changes/KDE_Plasma_6\n> [2]: https://fedorapeople.org/groups/schedule/f-40/f-40-key-tasks.html","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58CEEBDB1C\n\tfor ;\n\tMon, 22 Jan 2024 11:33:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 774776291F;\n\tMon, 22 Jan 2024 12:33:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EB9C61D30\n\tfor ;\n\tMon, 22 Jan 2024 12:33:52 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2867E221;\n\tMon, 22 Jan 2024 12:32:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tz9A/OGM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705923159;\n\tbh=CSZ2gF//m3GMKuKY4YT39WVeFrmWY0igezKIDwLktuc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tz9A/OGMViub6e3P8bR9q4gSwK3wF6ojmFnQBhhF6v00RZnhbGbih/em9E5Vyqen0\n\tReWJmrKwZ+OrLQ4okVtKma5/R4b/O+J9JnxhF/BLKL+rbQKvysG0DwJEW7grEZbbZx\n\t2X5Prj8G7cUf6P7YUiUX4FLAusaJ7j4tZ8JZgO6M=","Date":"Mon, 22 Jan 2024 13:33:56 +0200","From":"Laurent Pinchart ","To":"Neal Gompa ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","Message-ID":"<20240122113356.GA29275@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28523,"web_url":"https://patchwork.libcamera.org/comment/28523/","msgid":"","date":"2024-01-22T11:38:25","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 6:33 AM Laurent Pinchart\n wrote:\n>\n> On Mon, Jan 22, 2024 at 06:12:08AM -0500, Neal Gompa wrote:\n> > On Mon, Jan 22, 2024 at 4:53 AM Laurent Pinchart via libcamera-devel\n> > wrote:\n> > >\n> > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > Aha, I missed that there was already a v2.\n> > > >\n> > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > >\n> > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > to Qt 5 that is no longer applicable.\n> > > > >\n> > > > > Signed-off-by: Neal Gompa \n> > > > > ---\n> > > > > README.rst | 2 +-\n> > > > > meson.build | 2 +-\n> > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > >\n> > > > > diff --git a/README.rst b/README.rst\n> > > > > index 315738ee..6f1c9302 100644\n> > > > > --- a/README.rst\n> > > > > +++ b/README.rst\n> > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > - libsdl2-dev: Enables the SDL sink\n> > > > >\n> > > > > for qcam: [optional]\n> > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > >\n> > > > > for tracing with lttng: [optional]\n> > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > diff --git a/meson.build b/meson.build\n> > > > > index cb6b666a..4c315e2a 100644\n> > > > > --- a/meson.build\n> > > > > +++ b/meson.build\n> > > > > @@ -1,7 +1,7 @@\n> > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > >\n> > > > > project('libcamera', 'c', 'cpp',\n> > > > > - meson_version : '>= 0.60',\n> > > > > + meson_version : '>= 0.63',\n> > > >\n> > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > https://packages.debian.org/source/stable/meson\n> > > >\n> > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > https://packages.ubuntu.com/jammy/meson\n> > > >\n> > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > >\n> > > >\n> > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > recent Meson at 1.2.3 or later:\n> > > > https://src.fedoraproject.org/rpms/meson\n> > > >\n> > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > should be included in fact.\n> > > >\n> > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > https://software.opensuse.org/package/meson?locale=en\n> > > >\n> > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > >\n> > > > Any thoughts anyone?\n> > >\n> > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > the case :-(\n> > >\n> > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > gets released.\n> > >\n> > > > > version : '0.2.0',\n> > > > > default_options : [\n> > > > > 'werror=true',\n> > > > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > > > index 6cf4c171..c7fcfbeb 100644\n> > > > > --- a/src/apps/qcam/meson.build\n> > > > > +++ b/src/apps/qcam/meson.build\n> > > > > @@ -1,13 +1,13 @@\n> > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > >\n> > > > > -qt5 = import('qt5')\n> > > > > -qt5_dep = dependency('qt5',\n> > > > > +qt6 = import('qt6')\n> > > > > +qt6_dep = dependency('qt6',\n> > > > > method : 'pkg-config',\n> > > > > - modules : ['Core', 'Gui', 'Widgets'],\n> > > > > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > > > > required : get_option('qcam'),\n> > > > > - version : '>=5.4')\n> > > > > + version : '>=6.2')\n> > > > >\n> > > > > -if not qt5_dep.found()\n> > > > > +if not qt6_dep.found()\n> > > > > qcam_enabled = false\n> > > > > subdir_done()\n> > > > > endif\n> > > > > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > > > > 'main.cpp',\n> > > > > 'main_window.cpp',\n> > > > > 'message_handler.cpp',\n> > > > > + 'viewfinder_gl.cpp',\n> > > > > 'viewfinder_qt.cpp',\n> > > > > ])\n> > > > >\n> > > > > qcam_moc_headers = files([\n> > > > > 'cam_select_dialog.h',\n> > > > > 'main_window.h',\n> > > > > + 'viewfinder_gl.h',\n> > > > > 'viewfinder_qt.h',\n> > > > > ])\n> > > > >\n> > > > > qcam_resources = files([\n> > > > > 'assets/feathericons/feathericons.qrc',\n> > > > > + 'assets/shader/shaders.qrc',\n> > > > > ])\n> > > > >\n> > > > > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > >\n> > > > > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > > > > - dependencies : qt5_dep, args : '-fPIC')\n> > > > > - qcam_sources += files([\n> > > > > - 'viewfinder_gl.cpp',\n> > > > > - ])\n> > > > > - qcam_moc_headers += files([\n> > > > > - 'viewfinder_gl.h',\n> > > > > - ])\n> > > > > - qcam_resources += files([\n> > > > > - 'assets/shader/shaders.qrc'\n> > > > > - ])\n> > > > > -endif\n> > > > > -\n> > > > > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > > > > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > > > > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > > > > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > > > > - qt5_dep.version().version_compare('<5.13')) or\n> > > > > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > > > > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > > > > -endif\n> > > > > -\n> > > > > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > > > > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > > > > qresources : qcam_resources,\n> > > > > - dependencies : qt5_dep)\n> > > > > + dependencies : qt6_dep)\n> > > > >\n> > > > > qcam = executable('qcam', qcam_sources, resources,\n> > > > > install : true,\n> > > > > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > > > > libatomic,\n> > > > > libcamera_public,\n> > > > > libtiff,\n> > > > > - qt5_dep,\n> > > > > + qt6_dep,\n> > > > > ],\n> > > > > - cpp_args : qt5_cpp_args)\n> > > > > + cpp_args : qt6_cpp_args)\n> >\n> > I'd like to have this in place for Fedora 40 as that's the release\n> > we're moving to KDE Plasma 6[1] and thus generally preferring\n> > everything to be Qt 6 whenever possible. Additionally, CentOS/RHEL 10\n> > (which forks from Fedora 40) will only have Qt 6. The freeze for\n> > Fedora is in two weeks[2], and I'd like to have this landed before\n> > then.\n>\n> That's a pretty short notice. Could you have a look at the toolbar icon\n> issue I've reported then ?\n>\n\nYup. I cannot reproduce the issue. It works here. Here's a screenshot:\nhttps://i.imgur.com/zle2XbL.png","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77997C323E\n\tfor ;\n\tMon, 22 Jan 2024 11:39:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEE8C6291F;\n\tMon, 22 Jan 2024 12:39:05 +0100 (CET)","from mail-ej1-f45.google.com (mail-ej1-f45.google.com\n\t[209.85.218.45])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EAD261D30\n\tfor ;\n\tMon, 22 Jan 2024 12:39:04 +0100 (CET)","by mail-ej1-f45.google.com with SMTP id\n\ta640c23a62f3a-a2d7e2e7fe0so516840066b.1\n\tfor ;\n\tMon, 22 Jan 2024 03:39:04 -0800 (PST)","from mail-ed1-f48.google.com (mail-ed1-f48.google.com.\n\t[209.85.208.48]) by smtp.gmail.com with ESMTPSA id\n\tt4-20020a056402020400b0055c26f9275dsm1528640edv.42.2024.01.22.03.39.02\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 03:39:02 -0800 (PST)","by mail-ed1-f48.google.com with SMTP id\n\t4fb4d7f45d1cf-55a9008c185so2793891a12.1\n\tfor ;\n\tMon, 22 Jan 2024 03:39:02 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705923543; x=1706528343;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=OdC1+zqRDIHnMLbbcNC5LqU/HVV0kDr54DwtDVXGR0E=;\n\tb=nycplGG6Qbw1arZJaoV4x7U/ab9gIAVw66Yg1X81CLitp6UVRL2VMbHQP070VI9jBI\n\tGz18N547N9Q8DDUK8hsaDCPXUccLBcz4IpMO9nynmWvnc9o/TG17PggSSUKwxBuRezA1\n\t04/J+1pVWLKeX3uJRyuFyca9kFx1ZFj0Sm02KwyZN77Bt8XbOt8h84Kg0n0TF1EDcWEh\n\ttOm6MX/560vWsX4Nu0WRmUyxxGUNbwdlUtwSjBbtCDZUpeLXC8sRY9abWEZfAQTqOMgz\n\twe5FFizYC+JPVyTk4Qb18q31vmtvymaRpCkCo4SaWgtRP3q8cIy+WqtvL/xcIn5jwqvS\n\tewsA==","X-Gm-Message-State":"AOJu0YyInPOYGMcmwwLL+AZ2XrBlfn3XwZrPoCe+fkDu9RnUMfwZg8yG\n\t35StwO+xxfZrpLYkfuaJy27DhhXicJf55OWgF7iC3Wry95wbE00dlLp+d7WOpqU=","X-Google-Smtp-Source":"AGHT+IGRR//EmdlxfpWSbbwtboSvOaUOq/oCtl8locljZMjVa8pzSl3nmx1N93HmvGLZm2y0rrFuZw==","X-Received":["by 2002:a17:906:3142:b0:a2b:130c:a897 with SMTP id\n\te2-20020a170906314200b00a2b130ca897mr5234394eje.17.1705923543020; \n\tMon, 22 Jan 2024 03:39:03 -0800 (PST)","by 2002:a05:6402:148c:b0:55a:8a83:dd9 with SMTP id\n\te12-20020a056402148c00b0055a8a830dd9mr3572275edv.23.1705923542454;\n\tMon, 22 Jan 2024 03:39:02 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t\n\t<20240122113356.GA29275@pendragon.ideasonboard.com>","In-Reply-To":"<20240122113356.GA29275@pendragon.ideasonboard.com>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 06:38:25 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28524,"web_url":"https://patchwork.libcamera.org/comment/28524/","msgid":"","date":"2024-01-22T11:39:03","subject":"Re: [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Sun, 21 Jan 2024 at 22:41, Neal Gompa wrote:\n>\n> Open source Qt 5 has been effectively end of life since the release\n> of Qt 6, and Qt 6 has current LTS releases now.\n>\n> This change ports qcam to Qt 6.2 and drops some of the baggage related\n> to Qt 5 that is no longer applicable.\n>\n> Signed-off-by: Neal Gompa \n\nQt 6 ftw\n\nReviewed-by: Eric Curtin \n\nIs mise le meas/Regards,\n\nEric Curtin\n\n> ---\n> README.rst | 2 +-\n> meson.build | 2 +-\n> src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> 3 files changed, 15 insertions(+), 34 deletions(-)\n>\n> diff --git a/README.rst b/README.rst\n> index 315738ee..6f1c9302 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -88,7 +88,7 @@ for cam: [optional]\n> - libsdl2-dev: Enables the SDL sink\n>\n> for qcam: [optional]\n> - libtiff-dev qtbase5-dev qttools5-dev-tools\n> + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n>\n> for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n> diff --git a/meson.build b/meson.build\n> index cb6b666a..4c315e2a 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> project('libcamera', 'c', 'cpp',\n> - meson_version : '>= 0.60',\n> + meson_version : '>= 0.63',\n> version : '0.2.0',\n> default_options : [\n> 'werror=true',\n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index 6cf4c171..c7fcfbeb 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -1,13 +1,13 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> -qt5 = import('qt5')\n> -qt5_dep = dependency('qt5',\n> +qt6 = import('qt6')\n> +qt6_dep = dependency('qt6',\n> method : 'pkg-config',\n> - modules : ['Core', 'Gui', 'Widgets'],\n> + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> required : get_option('qcam'),\n> - version : '>=5.4')\n> + version : '>=6.2')\n>\n> -if not qt5_dep.found()\n> +if not qt6_dep.found()\n> qcam_enabled = false\n> subdir_done()\n> endif\n> @@ -20,46 +20,27 @@ qcam_sources = files([\n> 'main.cpp',\n> 'main_window.cpp',\n> 'message_handler.cpp',\n> + 'viewfinder_gl.cpp',\n> 'viewfinder_qt.cpp',\n> ])\n>\n> qcam_moc_headers = files([\n> 'cam_select_dialog.h',\n> 'main_window.h',\n> + 'viewfinder_gl.h',\n> 'viewfinder_qt.h',\n> ])\n>\n> qcam_resources = files([\n> 'assets/feathericons/feathericons.qrc',\n> + 'assets/shader/shaders.qrc',\n> ])\n>\n> -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n>\n> -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> - dependencies : qt5_dep, args : '-fPIC')\n> - qcam_sources += files([\n> - 'viewfinder_gl.cpp',\n> - ])\n> - qcam_moc_headers += files([\n> - 'viewfinder_gl.h',\n> - ])\n> - qcam_resources += files([\n> - 'assets/shader/shaders.qrc'\n> - ])\n> -endif\n> -\n> -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> - qt5_dep.version().version_compare('<5.13')) or\n> - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> - qt5_cpp_args += ['-Wno-deprecated-copy']\n> -endif\n> -\n> -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> qresources : qcam_resources,\n> - dependencies : qt5_dep)\n> + dependencies : qt6_dep)\n>\n> qcam = executable('qcam', qcam_sources, resources,\n> install : true,\n> @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> libatomic,\n> libcamera_public,\n> libtiff,\n> - qt5_dep,\n> + qt6_dep,\n> ],\n> - cpp_args : qt5_cpp_args)\n> + cpp_args : qt6_cpp_args)\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3394C323E\n\tfor ;\n\tMon, 22 Jan 2024 11:39:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D17C61D30;\n\tMon, 22 Jan 2024 12:39:45 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB1A861D30\n\tfor ;\n\tMon, 22 Jan 2024 12:39:43 +0100 (CET)","from mail-oo1-f69.google.com (mail-oo1-f69.google.com\n\t[209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-651-atNqMhlLPBeOBaKtiHqMmg-1; Mon, 22 Jan 2024 06:39:40 -0500","by mail-oo1-f69.google.com with SMTP id\n\t006d021491bc7-59927811bf8so3649698eaf.1\n\tfor ;\n\tMon, 22 Jan 2024 03:39:40 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Am5jB4BQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1705923582;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ih5w6Jw6sw6sKARbL2FX/faW2JD4iVljpMi8PepG/o0=;\n\tb=Am5jB4BQUJmce9xxQ6oqePLtGwOeYRzzWb0U00EdcHU2TRIWcrcO+s3mtDnGLlypl2KoYa\n\tZPTNpAQXlHNBVd1Ao/3xguhhkS0d5upGTLTvcYml0OG31b7gVklTeXohG9t/gqPTFYcq5f\n\tYCaE1kHKZsbvSbqjlszFTMxGWw5rYBE=","X-MC-Unique":"atNqMhlLPBeOBaKtiHqMmg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705923580; x=1706528380;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ih5w6Jw6sw6sKARbL2FX/faW2JD4iVljpMi8PepG/o0=;\n\tb=TxF21jyTVPr6O7wVYoZajUNljNz2tT7gSCfSY5jONrmF0y1kLN0lQHVeFFejstLP7T\n\tImB/Ca1f+irc0xPUJKRWLK4Ko72aPRGemMTKFKDUuGqAFLr/pq6icaHboq9jQPKMUMZT\n\tzf8q4ilKd4heL8949EajZFyzWOjQDDNB1Bg8WNxOF429R9DusZ3BJBxEOLUeb0KlTOe5\n\tyufWx+n1L48wBKGThVoN85AOaxUhhSo7SBPWZAOP9nCT1lP4qbFEIxzr/3P+A1OVbnpT\n\tRcuiMlkQHoR//WDhxGhNVkyE+ZrRuZd+ryL7/kni+KB9CuH3VgqT5m3mXlWlfCPtmA6x\n\t+MLg==","X-Gm-Message-State":"AOJu0YwrIbRZ6HWZLvDitRo4Uazh99lzr48McPQg+HG5/m7kIT16D6Sv\n\tjTJoMUS7hoj+ajs+6YUoczkju5OBJXZ59XhjqBmr8PbBOpDQzvG7zA3aip47tb6hld1BHablqAz\n\tasGnsNhTBzhL62EWWmtYWp40B13R+EC58Eh6NddZzoBgVZPUuUoyvsyJuVUuCGxl1aT0UmjQ4tP\n\tdvQDYbH+EQJuCMw3QkcZu7JpAeSghN28UjmNpCfx2kGopY7w==","X-Received":["by 2002:a05:6358:2908:b0:176:3586:d42d with SMTP id\n\ty8-20020a056358290800b001763586d42dmr2846836rwb.54.1705923579905; \n\tMon, 22 Jan 2024 03:39:39 -0800 (PST)","by 2002:a05:6358:2908:b0:176:3586:d42d with SMTP id\n\ty8-20020a056358290800b001763586d42dmr2846822rwb.54.1705923579541;\n\tMon, 22 Jan 2024 03:39:39 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGjczdVDTXP2qZL2VNGGzI28vCvK7KakgeDqmvtLuALBCkvGIvlSN7MdErRj9qOpjrVKchZwrG+NKo2f3o3iPQ=","MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>","In-Reply-To":"<20240121224052.1049989-2-neal@gompa.dev>","From":"Eric Curtin ","Date":"Mon, 22 Jan 2024 11:39:03 +0000","Message-ID":"","Subject":"Re: [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Neal Gompa ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28527,"web_url":"https://patchwork.libcamera.org/comment/28527/","msgid":"<20240122115702.GB29275@pendragon.ideasonboard.com>","date":"2024-01-22T11:57:02","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 06:38:25AM -0500, Neal Gompa wrote:\n> On Mon, Jan 22, 2024 at 6:33 AM Laurent Pinchart wrote:\n> > On Mon, Jan 22, 2024 at 06:12:08AM -0500, Neal Gompa wrote:\n> > > On Mon, Jan 22, 2024 at 4:53 AM Laurent Pinchart via libcamera-devel wrote:\n> > > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > > Aha, I missed that there was already a v2.\n> > > > >\n> > > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > > >\n> > > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > > to Qt 5 that is no longer applicable.\n> > > > > >\n> > > > > > Signed-off-by: Neal Gompa \n> > > > > > ---\n> > > > > > README.rst | 2 +-\n> > > > > > meson.build | 2 +-\n> > > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > > >\n> > > > > > diff --git a/README.rst b/README.rst\n> > > > > > index 315738ee..6f1c9302 100644\n> > > > > > --- a/README.rst\n> > > > > > +++ b/README.rst\n> > > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > > - libsdl2-dev: Enables the SDL sink\n> > > > > >\n> > > > > > for qcam: [optional]\n> > > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > > >\n> > > > > > for tracing with lttng: [optional]\n> > > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > > diff --git a/meson.build b/meson.build\n> > > > > > index cb6b666a..4c315e2a 100644\n> > > > > > --- a/meson.build\n> > > > > > +++ b/meson.build\n> > > > > > @@ -1,7 +1,7 @@\n> > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > >\n> > > > > > project('libcamera', 'c', 'cpp',\n> > > > > > - meson_version : '>= 0.60',\n> > > > > > + meson_version : '>= 0.63',\n> > > > >\n> > > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > > https://packages.debian.org/source/stable/meson\n> > > > >\n> > > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > > https://packages.ubuntu.com/jammy/meson\n> > > > >\n> > > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > > >\n> > > > >\n> > > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > > recent Meson at 1.2.3 or later:\n> > > > > https://src.fedoraproject.org/rpms/meson\n> > > > >\n> > > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > > should be included in fact.\n> > > > >\n> > > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > > https://software.opensuse.org/package/meson?locale=en\n> > > > >\n> > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > >\n> > > > > Any thoughts anyone?\n> > > >\n> > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > the case :-(\n> > > >\n> > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > gets released.\n> > > >\n> > > > > > version : '0.2.0',\n> > > > > > default_options : [\n> > > > > > 'werror=true',\n> > > > > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > > > > index 6cf4c171..c7fcfbeb 100644\n> > > > > > --- a/src/apps/qcam/meson.build\n> > > > > > +++ b/src/apps/qcam/meson.build\n> > > > > > @@ -1,13 +1,13 @@\n> > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > >\n> > > > > > -qt5 = import('qt5')\n> > > > > > -qt5_dep = dependency('qt5',\n> > > > > > +qt6 = import('qt6')\n> > > > > > +qt6_dep = dependency('qt6',\n> > > > > > method : 'pkg-config',\n> > > > > > - modules : ['Core', 'Gui', 'Widgets'],\n> > > > > > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > > > > > required : get_option('qcam'),\n> > > > > > - version : '>=5.4')\n> > > > > > + version : '>=6.2')\n> > > > > >\n> > > > > > -if not qt5_dep.found()\n> > > > > > +if not qt6_dep.found()\n> > > > > > qcam_enabled = false\n> > > > > > subdir_done()\n> > > > > > endif\n> > > > > > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > > > > > 'main.cpp',\n> > > > > > 'main_window.cpp',\n> > > > > > 'message_handler.cpp',\n> > > > > > + 'viewfinder_gl.cpp',\n> > > > > > 'viewfinder_qt.cpp',\n> > > > > > ])\n> > > > > >\n> > > > > > qcam_moc_headers = files([\n> > > > > > 'cam_select_dialog.h',\n> > > > > > 'main_window.h',\n> > > > > > + 'viewfinder_gl.h',\n> > > > > > 'viewfinder_qt.h',\n> > > > > > ])\n> > > > > >\n> > > > > > qcam_resources = files([\n> > > > > > 'assets/feathericons/feathericons.qrc',\n> > > > > > + 'assets/shader/shaders.qrc',\n> > > > > > ])\n> > > > > >\n> > > > > > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > > > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > > >\n> > > > > > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > > > > > - dependencies : qt5_dep, args : '-fPIC')\n> > > > > > - qcam_sources += files([\n> > > > > > - 'viewfinder_gl.cpp',\n> > > > > > - ])\n> > > > > > - qcam_moc_headers += files([\n> > > > > > - 'viewfinder_gl.h',\n> > > > > > - ])\n> > > > > > - qcam_resources += files([\n> > > > > > - 'assets/shader/shaders.qrc'\n> > > > > > - ])\n> > > > > > -endif\n> > > > > > -\n> > > > > > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > > > > > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > > > > > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > > > > > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > > > > > - qt5_dep.version().version_compare('<5.13')) or\n> > > > > > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > > > > > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > > > > > -endif\n> > > > > > -\n> > > > > > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > > > > > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > > > > > qresources : qcam_resources,\n> > > > > > - dependencies : qt5_dep)\n> > > > > > + dependencies : qt6_dep)\n> > > > > >\n> > > > > > qcam = executable('qcam', qcam_sources, resources,\n> > > > > > install : true,\n> > > > > > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > > > > > libatomic,\n> > > > > > libcamera_public,\n> > > > > > libtiff,\n> > > > > > - qt5_dep,\n> > > > > > + qt6_dep,\n> > > > > > ],\n> > > > > > - cpp_args : qt5_cpp_args)\n> > > > > > + cpp_args : qt6_cpp_args)\n> > >\n> > > I'd like to have this in place for Fedora 40 as that's the release\n> > > we're moving to KDE Plasma 6[1] and thus generally preferring\n> > > everything to be Qt 6 whenever possible. Additionally, CentOS/RHEL 10\n> > > (which forks from Fedora 40) will only have Qt 6. The freeze for\n> > > Fedora is in two weeks[2], and I'd like to have this landed before\n> > > then.\n> >\n> > That's a pretty short notice. Could you have a look at the toolbar icon\n> > issue I've reported then ?\n> \n> Yup. I cannot reproduce the issue. It works here. Here's a screenshot:\n> https://i.imgur.com/zle2XbL.png\n\nHere's how it looks like for me.\n\n- With Qt5: https://postimg.cc/jC16fLh1\n- With Qt6: https://postimg.cc/WtGY6mhy\n\nI wonder if this could be caused by not having KDE 6 installed.\n\nWhat's the default KDE environment for Debian Bookworm and Ubuntu 24.04,\nis it KDE 5 or KDE 6 ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 487BDBDB1C\n\tfor ;\n\tMon, 22 Jan 2024 11:57:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D4616291F;\n\tMon, 22 Jan 2024 12:57:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D55A862916\n\tfor ;\n\tMon, 22 Jan 2024 12:56:58 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B65D6221;\n\tMon, 22 Jan 2024 12:55:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J8FsdqnK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705924545;\n\tbh=bXEpTALrs2UflVHHGYwAu5QJ/URI+YIPPzutqzeepeM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J8FsdqnK+UZgA5+JNpXgSzKDsp8IPDEP6osq3w6qBZHM+l+d+u7zqRJOmvVxGb4w0\n\ts3pYp+T+uC8sZVNhDladLfaSlahTxe2hAAzb8+GqqcFO8JsSfV+pHWzy8e1QMxiK6E\n\tClFFNXoxwQ02eSBICFWV3OsS3kFvMdNQvbouGn0Q=","Date":"Mon, 22 Jan 2024 13:57:02 +0200","From":"Laurent Pinchart ","To":"Neal Gompa ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","Message-ID":"<20240122115702.GB29275@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t\n\t<20240122113356.GA29275@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28528,"web_url":"https://patchwork.libcamera.org/comment/28528/","msgid":"","date":"2024-01-22T12:04:16","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 6:57 AM Laurent Pinchart\n wrote:\n>\n> On Mon, Jan 22, 2024 at 06:38:25AM -0500, Neal Gompa wrote:\n> > On Mon, Jan 22, 2024 at 6:33 AM Laurent Pinchart wrote:\n> > > On Mon, Jan 22, 2024 at 06:12:08AM -0500, Neal Gompa wrote:\n> > > > On Mon, Jan 22, 2024 at 4:53 AM Laurent Pinchart via libcamera-devel wrote:\n> > > > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > > > Aha, I missed that there was already a v2.\n> > > > > >\n> > > > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > > > >\n> > > > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > > > to Qt 5 that is no longer applicable.\n> > > > > > >\n> > > > > > > Signed-off-by: Neal Gompa \n> > > > > > > ---\n> > > > > > > README.rst | 2 +-\n> > > > > > > meson.build | 2 +-\n> > > > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > > > >\n> > > > > > > diff --git a/README.rst b/README.rst\n> > > > > > > index 315738ee..6f1c9302 100644\n> > > > > > > --- a/README.rst\n> > > > > > > +++ b/README.rst\n> > > > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > > > - libsdl2-dev: Enables the SDL sink\n> > > > > > >\n> > > > > > > for qcam: [optional]\n> > > > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > > > >\n> > > > > > > for tracing with lttng: [optional]\n> > > > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > > > diff --git a/meson.build b/meson.build\n> > > > > > > index cb6b666a..4c315e2a 100644\n> > > > > > > --- a/meson.build\n> > > > > > > +++ b/meson.build\n> > > > > > > @@ -1,7 +1,7 @@\n> > > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > > >\n> > > > > > > project('libcamera', 'c', 'cpp',\n> > > > > > > - meson_version : '>= 0.60',\n> > > > > > > + meson_version : '>= 0.63',\n> > > > > >\n> > > > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > > > https://packages.debian.org/source/stable/meson\n> > > > > >\n> > > > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > > > https://packages.ubuntu.com/jammy/meson\n> > > > > >\n> > > > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > > > >\n> > > > > >\n> > > > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > > > recent Meson at 1.2.3 or later:\n> > > > > > https://src.fedoraproject.org/rpms/meson\n> > > > > >\n> > > > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > > > should be included in fact.\n> > > > > >\n> > > > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > > > https://software.opensuse.org/package/meson?locale=en\n> > > > > >\n> > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > >\n> > > > > > Any thoughts anyone?\n> > > > >\n> > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > the case :-(\n> > > > >\n> > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > gets released.\n> > > > >\n> > > > > > > version : '0.2.0',\n> > > > > > > default_options : [\n> > > > > > > 'werror=true',\n> > > > > > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > > > > > index 6cf4c171..c7fcfbeb 100644\n> > > > > > > --- a/src/apps/qcam/meson.build\n> > > > > > > +++ b/src/apps/qcam/meson.build\n> > > > > > > @@ -1,13 +1,13 @@\n> > > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > > >\n> > > > > > > -qt5 = import('qt5')\n> > > > > > > -qt5_dep = dependency('qt5',\n> > > > > > > +qt6 = import('qt6')\n> > > > > > > +qt6_dep = dependency('qt6',\n> > > > > > > method : 'pkg-config',\n> > > > > > > - modules : ['Core', 'Gui', 'Widgets'],\n> > > > > > > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > > > > > > required : get_option('qcam'),\n> > > > > > > - version : '>=5.4')\n> > > > > > > + version : '>=6.2')\n> > > > > > >\n> > > > > > > -if not qt5_dep.found()\n> > > > > > > +if not qt6_dep.found()\n> > > > > > > qcam_enabled = false\n> > > > > > > subdir_done()\n> > > > > > > endif\n> > > > > > > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > > > > > > 'main.cpp',\n> > > > > > > 'main_window.cpp',\n> > > > > > > 'message_handler.cpp',\n> > > > > > > + 'viewfinder_gl.cpp',\n> > > > > > > 'viewfinder_qt.cpp',\n> > > > > > > ])\n> > > > > > >\n> > > > > > > qcam_moc_headers = files([\n> > > > > > > 'cam_select_dialog.h',\n> > > > > > > 'main_window.h',\n> > > > > > > + 'viewfinder_gl.h',\n> > > > > > > 'viewfinder_qt.h',\n> > > > > > > ])\n> > > > > > >\n> > > > > > > qcam_resources = files([\n> > > > > > > 'assets/feathericons/feathericons.qrc',\n> > > > > > > + 'assets/shader/shaders.qrc',\n> > > > > > > ])\n> > > > > > >\n> > > > > > > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > > > > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > > > >\n> > > > > > > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > > > > > > - dependencies : qt5_dep, args : '-fPIC')\n> > > > > > > - qcam_sources += files([\n> > > > > > > - 'viewfinder_gl.cpp',\n> > > > > > > - ])\n> > > > > > > - qcam_moc_headers += files([\n> > > > > > > - 'viewfinder_gl.h',\n> > > > > > > - ])\n> > > > > > > - qcam_resources += files([\n> > > > > > > - 'assets/shader/shaders.qrc'\n> > > > > > > - ])\n> > > > > > > -endif\n> > > > > > > -\n> > > > > > > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > > > > > > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > > > > > > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > > > > > > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > > > > > > - qt5_dep.version().version_compare('<5.13')) or\n> > > > > > > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > > > > > > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > > > > > > -endif\n> > > > > > > -\n> > > > > > > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > > > > > > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > > > > > > qresources : qcam_resources,\n> > > > > > > - dependencies : qt5_dep)\n> > > > > > > + dependencies : qt6_dep)\n> > > > > > >\n> > > > > > > qcam = executable('qcam', qcam_sources, resources,\n> > > > > > > install : true,\n> > > > > > > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > > > > > > libatomic,\n> > > > > > > libcamera_public,\n> > > > > > > libtiff,\n> > > > > > > - qt5_dep,\n> > > > > > > + qt6_dep,\n> > > > > > > ],\n> > > > > > > - cpp_args : qt5_cpp_args)\n> > > > > > > + cpp_args : qt6_cpp_args)\n> > > >\n> > > > I'd like to have this in place for Fedora 40 as that's the release\n> > > > we're moving to KDE Plasma 6[1] and thus generally preferring\n> > > > everything to be Qt 6 whenever possible. Additionally, CentOS/RHEL 10\n> > > > (which forks from Fedora 40) will only have Qt 6. The freeze for\n> > > > Fedora is in two weeks[2], and I'd like to have this landed before\n> > > > then.\n> > >\n> > > That's a pretty short notice. Could you have a look at the toolbar icon\n> > > issue I've reported then ?\n> >\n> > Yup. I cannot reproduce the issue. It works here. Here's a screenshot:\n> > https://i.imgur.com/zle2XbL.png\n>\n> Here's how it looks like for me.\n>\n> - With Qt5: https://postimg.cc/jC16fLh1\n> - With Qt6: https://postimg.cc/WtGY6mhy\n>\n> I wonder if this could be caused by not having KDE 6 installed.\n>\n> What's the default KDE environment for Debian Bookworm and Ubuntu 24.04,\n> is it KDE 5 or KDE 6 ?\n>\n\nKDE Plasma 5, but that screenshot is on Fedora 39 with KDE Plasma 5.27.10.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FE06C323E\n\tfor ;\n\tMon, 22 Jan 2024 12:04:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88EEB62936;\n\tMon, 22 Jan 2024 13:04:55 +0100 (CET)","from mail-ed1-f52.google.com (mail-ed1-f52.google.com\n\t[209.85.208.52])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFC4C61D30\n\tfor ;\n\tMon, 22 Jan 2024 13:04:54 +0100 (CET)","by mail-ed1-f52.google.com with SMTP id\n\t4fb4d7f45d1cf-55a6833c21eso2055385a12.2\n\tfor ;\n\tMon, 22 Jan 2024 04:04:54 -0800 (PST)","from mail-ed1-f49.google.com (mail-ed1-f49.google.com.\n\t[209.85.208.49]) by smtp.gmail.com with ESMTPSA id\n\te6-20020a50ec86000000b0055a6882f168sm3851268edr.14.2024.01.22.04.04.53\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 04:04:53 -0800 (PST)","by mail-ed1-f49.google.com with SMTP id\n\t4fb4d7f45d1cf-5578485fc0eso2930007a12.1\n\tfor ;\n\tMon, 22 Jan 2024 04:04:53 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705925094; x=1706529894;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=eeMhVM91CSkxOlPCjGplIhhaiCacBha6/k1/eivTtiE=;\n\tb=GGaLFVi4ORIKdyPtfeRbPkw0KVKtNYAF8vnEh/aoKyxU6bMfjn6uuz0YsTUOyIYdgC\n\tI4hReksHqo33U6Zo1xCtWU7HDBNwvnpyjaLQ5qbFO0oyDTh6wJEpiqRPu806Wq9qYQBN\n\tuc32KTGxYMZ6dQZGJZ3engIq8B7A7CVRnTHSllvAXDTvnxKV4oBQ3upX8Z76DnxuaNfR\n\tvYBst58ubQda9Ei74ygh4BLwaedInwTgRKQHxEED+Nn5ZTxwj/QaEjURHzcewNwQelzw\n\t0wPtHKuBBBDEkLxPuWMuc1X7iR8I6xmbkusoP6GmK6avRbvmlStUUXE8Vv4n8+CgdZEQ\n\tzX1A==","X-Gm-Message-State":"AOJu0YxNopBt91n1DY6+rhLW8z58OSeu2TznQsebS/H2TVYRGQXUOsqb\n\tkMnZQpU2knD9qb38M45BlNYtON9uVO/ceOPoDNMbivqOXDJLQuqK8qER6GvQj/w=","X-Google-Smtp-Source":"AGHT+IGcppg+IJwvKPaW8fiEXFm3X128/03Uj4kXhhw+JUuTKMd30R1rSkbO9yTXokXqviBE/oDEmw==","X-Received":["by 2002:a05:6402:26d3:b0:55c:3601:2831 with SMTP id\n\tx19-20020a05640226d300b0055c36012831mr1009510edd.9.1705925093981; \n\tMon, 22 Jan 2024 04:04:53 -0800 (PST)","by 2002:aa7:d610:0:b0:559:e728:24e7 with SMTP id\n\tc16-20020aa7d610000000b00559e72824e7mr2171760edr.42.1705925093502;\n\tMon, 22 Jan 2024 04:04:53 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t\n\t<20240122113356.GA29275@pendragon.ideasonboard.com>\n\t\n\t<20240122115702.GB29275@pendragon.ideasonboard.com>","In-Reply-To":"<20240122115702.GB29275@pendragon.ideasonboard.com>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 07:04:16 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28529,"web_url":"https://patchwork.libcamera.org/comment/28529/","msgid":"<20240122120857.GC29275@pendragon.ideasonboard.com>","date":"2024-01-22T12:08:57","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 01:57:02PM +0200, Laurent Pinchart wrote:\n> On Mon, Jan 22, 2024 at 06:38:25AM -0500, Neal Gompa wrote:\n> > On Mon, Jan 22, 2024 at 6:33 AM Laurent Pinchart wrote:\n> > > On Mon, Jan 22, 2024 at 06:12:08AM -0500, Neal Gompa wrote:\n> > > > On Mon, Jan 22, 2024 at 4:53 AM Laurent Pinchart via libcamera-devel wrote:\n> > > > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > > > Aha, I missed that there was already a v2.\n> > > > > >\n> > > > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > > > >\n> > > > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > > > to Qt 5 that is no longer applicable.\n> > > > > > >\n> > > > > > > Signed-off-by: Neal Gompa \n> > > > > > > ---\n> > > > > > > README.rst | 2 +-\n> > > > > > > meson.build | 2 +-\n> > > > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > > > >\n> > > > > > > diff --git a/README.rst b/README.rst\n> > > > > > > index 315738ee..6f1c9302 100644\n> > > > > > > --- a/README.rst\n> > > > > > > +++ b/README.rst\n> > > > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > > > - libsdl2-dev: Enables the SDL sink\n> > > > > > >\n> > > > > > > for qcam: [optional]\n> > > > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > > > >\n> > > > > > > for tracing with lttng: [optional]\n> > > > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > > > diff --git a/meson.build b/meson.build\n> > > > > > > index cb6b666a..4c315e2a 100644\n> > > > > > > --- a/meson.build\n> > > > > > > +++ b/meson.build\n> > > > > > > @@ -1,7 +1,7 @@\n> > > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > > >\n> > > > > > > project('libcamera', 'c', 'cpp',\n> > > > > > > - meson_version : '>= 0.60',\n> > > > > > > + meson_version : '>= 0.63',\n> > > > > >\n> > > > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > > > https://packages.debian.org/source/stable/meson\n> > > > > >\n> > > > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > > > https://packages.ubuntu.com/jammy/meson\n> > > > > >\n> > > > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > > > >\n> > > > > >\n> > > > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > > > recent Meson at 1.2.3 or later:\n> > > > > > https://src.fedoraproject.org/rpms/meson\n> > > > > >\n> > > > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > > > should be included in fact.\n> > > > > >\n> > > > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > > > https://software.opensuse.org/package/meson?locale=en\n> > > > > >\n> > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > >\n> > > > > > Any thoughts anyone?\n> > > > >\n> > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > the case :-(\n> > > > >\n> > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > gets released.\n> > > > >\n> > > > > > > version : '0.2.0',\n> > > > > > > default_options : [\n> > > > > > > 'werror=true',\n> > > > > > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > > > > > index 6cf4c171..c7fcfbeb 100644\n> > > > > > > --- a/src/apps/qcam/meson.build\n> > > > > > > +++ b/src/apps/qcam/meson.build\n> > > > > > > @@ -1,13 +1,13 @@\n> > > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > > >\n> > > > > > > -qt5 = import('qt5')\n> > > > > > > -qt5_dep = dependency('qt5',\n> > > > > > > +qt6 = import('qt6')\n> > > > > > > +qt6_dep = dependency('qt6',\n> > > > > > > method : 'pkg-config',\n> > > > > > > - modules : ['Core', 'Gui', 'Widgets'],\n> > > > > > > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > > > > > > required : get_option('qcam'),\n> > > > > > > - version : '>=5.4')\n> > > > > > > + version : '>=6.2')\n> > > > > > >\n> > > > > > > -if not qt5_dep.found()\n> > > > > > > +if not qt6_dep.found()\n> > > > > > > qcam_enabled = false\n> > > > > > > subdir_done()\n> > > > > > > endif\n> > > > > > > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > > > > > > 'main.cpp',\n> > > > > > > 'main_window.cpp',\n> > > > > > > 'message_handler.cpp',\n> > > > > > > + 'viewfinder_gl.cpp',\n> > > > > > > 'viewfinder_qt.cpp',\n> > > > > > > ])\n> > > > > > >\n> > > > > > > qcam_moc_headers = files([\n> > > > > > > 'cam_select_dialog.h',\n> > > > > > > 'main_window.h',\n> > > > > > > + 'viewfinder_gl.h',\n> > > > > > > 'viewfinder_qt.h',\n> > > > > > > ])\n> > > > > > >\n> > > > > > > qcam_resources = files([\n> > > > > > > 'assets/feathericons/feathericons.qrc',\n> > > > > > > + 'assets/shader/shaders.qrc',\n> > > > > > > ])\n> > > > > > >\n> > > > > > > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > > > > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > > > > > >\n> > > > > > > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > > > > > > - dependencies : qt5_dep, args : '-fPIC')\n> > > > > > > - qcam_sources += files([\n> > > > > > > - 'viewfinder_gl.cpp',\n> > > > > > > - ])\n> > > > > > > - qcam_moc_headers += files([\n> > > > > > > - 'viewfinder_gl.h',\n> > > > > > > - ])\n> > > > > > > - qcam_resources += files([\n> > > > > > > - 'assets/shader/shaders.qrc'\n> > > > > > > - ])\n> > > > > > > -endif\n> > > > > > > -\n> > > > > > > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > > > > > > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > > > > > > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > > > > > > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > > > > > > - qt5_dep.version().version_compare('<5.13')) or\n> > > > > > > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > > > > > > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > > > > > > -endif\n> > > > > > > -\n> > > > > > > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > > > > > > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > > > > > > qresources : qcam_resources,\n> > > > > > > - dependencies : qt5_dep)\n> > > > > > > + dependencies : qt6_dep)\n> > > > > > >\n> > > > > > > qcam = executable('qcam', qcam_sources, resources,\n> > > > > > > install : true,\n> > > > > > > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > > > > > > libatomic,\n> > > > > > > libcamera_public,\n> > > > > > > libtiff,\n> > > > > > > - qt5_dep,\n> > > > > > > + qt6_dep,\n> > > > > > > ],\n> > > > > > > - cpp_args : qt5_cpp_args)\n> > > > > > > + cpp_args : qt6_cpp_args)\n> > > >\n> > > > I'd like to have this in place for Fedora 40 as that's the release\n> > > > we're moving to KDE Plasma 6[1] and thus generally preferring\n> > > > everything to be Qt 6 whenever possible. Additionally, CentOS/RHEL 10\n> > > > (which forks from Fedora 40) will only have Qt 6. The freeze for\n> > > > Fedora is in two weeks[2], and I'd like to have this landed before\n> > > > then.\n> > >\n> > > That's a pretty short notice. Could you have a look at the toolbar icon\n> > > issue I've reported then ?\n> > \n> > Yup. I cannot reproduce the issue. It works here. Here's a screenshot:\n> > https://i.imgur.com/zle2XbL.png\n> \n> Here's how it looks like for me.\n> \n> - With Qt5: https://postimg.cc/jC16fLh1\n> - With Qt6: https://postimg.cc/WtGY6mhy\n> \n> I wonder if this could be caused by not having KDE 6 installed.\n> \n> What's the default KDE environment for Debian Bookworm and Ubuntu 24.04,\n> is it KDE 5 or KDE 6 ?\n\nAccording to https://community.kde.org/Schedules/Plasma_6, Plasma 6 will\nbe released on 2024-02-01. It would sounds a bit ambitious to already\ndepend on it.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1F13BDB1C\n\tfor ;\n\tMon, 22 Jan 2024 12:08:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FE136291F;\n\tMon, 22 Jan 2024 13:08:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 000A061D30\n\tfor ;\n\tMon, 22 Jan 2024 13:08:53 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E01FA74A;\n\tMon, 22 Jan 2024 13:07:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DKG6uEnd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705925261;\n\tbh=6Et9Hg1NGBD5xnGPVcjyYuDz9LyMae+hiBA4TVYvcGI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DKG6uEndAkyaY7/dVfPglwc6ssZy5/EZ9kZNQiKb/WyuqdwX+8ee2q93gd624gkqA\n\tSJP/Reb6ZsbSsMTYYhzgyisEGBwf9Bpc4Gf9t4sVg32aPGVBMhuFY0xJBLybUYFWy2\n\tyzt712LKDoxsFfMiVSJLn+pBoPOThbP9iCRCxdng=","Date":"Mon, 22 Jan 2024 14:08:57 +0200","From":"Laurent Pinchart ","To":"Neal Gompa ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","Message-ID":"<20240122120857.GC29275@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t\n\t<20240122113356.GA29275@pendragon.ideasonboard.com>\n\t\n\t<20240122115702.GB29275@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20240122115702.GB29275@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28530,"web_url":"https://patchwork.libcamera.org/comment/28530/","msgid":"<048b9a8a7effc6ddd717e809d05ecb8c33a3e5e8.camel@irl.hu>","date":"2024-01-22T12:10:09","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":183,"url":"https://patchwork.libcamera.org/api/people/183/","name":"Gergo Koteles","email":"soyer@irl.hu"},"content":"Hi Laurent,\n\nOn Mon, 2024-01-22 at 13:57 +0200, Laurent Pinchart wrote:\n> > \n> > Yup. I cannot reproduce the issue. It works here. Here's a screenshot:\n> > https://i.imgur.com/zle2XbL.png\n> \n> Here's how it looks like for me.\n> \n> - With Qt5: https://postimg.cc/jC16fLh1\n> - With Qt6: https://postimg.cc/WtGY6mhy\n> \n> I wonder if this could be caused by not having KDE 6 installed.\n> \n> What's the default KDE environment for Debian Bookworm and Ubuntu 24.04,\n> is it KDE 5 or KDE 6 ?\n> \n\nDo you have libqt6svg6? That is needed for Qt6 svg icons.\n\nRegards,\nGergo","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A35BBDB1C\n\tfor ;\n\tMon, 22 Jan 2024 12:10:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C883362945;\n\tMon, 22 Jan 2024 13:10:11 +0100 (CET)","from irl.hu (irl.hu [95.85.9.111])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94C0161D30\n\tfor ;\n\tMon, 22 Jan 2024 13:10:10 +0100 (CET)","from [192.168.2.4] (51b68f75.dsl.pool.telekom.hu\n\t[::ffff:81.182.143.117]) (AUTH: CRAM-MD5 soyer@irl.hu, )\n\tby irl.hu with ESMTPSA\n\tid 0000000000073634.0000000065AE5B21.00183DAD;\n\tMon, 22 Jan 2024 13:10:09 +0100"],"Message-ID":"<048b9a8a7effc6ddd717e809d05ecb8c33a3e5e8.camel@irl.hu>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Gergo Koteles ","To":"Laurent Pinchart ,\n\tNeal Gompa ","Date":"Mon, 22 Jan 2024 13:10:09 +0100","In-Reply-To":"<20240122115702.GB29275@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t\n\t<20240122113356.GA29275@pendragon.ideasonboard.com>\n\t\n\t<20240122115702.GB29275@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.50.3 (3.50.3-1.fc39) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28531,"web_url":"https://patchwork.libcamera.org/comment/28531/","msgid":"<20240122124020.GA2657@pendragon.ideasonboard.com>","date":"2024-01-22T12:40:20","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 01:10:09PM +0100, Gergo Koteles wrote:\n> Hi Laurent,\n> \n> On Mon, 2024-01-22 at 13:57 +0200, Laurent Pinchart wrote:\n> > > \n> > > Yup. I cannot reproduce the issue. It works here. Here's a screenshot:\n> > > https://i.imgur.com/zle2XbL.png\n> > \n> > Here's how it looks like for me.\n> > \n> > - With Qt5: https://postimg.cc/jC16fLh1\n> > - With Qt6: https://postimg.cc/WtGY6mhy\n> > \n> > I wonder if this could be caused by not having KDE 6 installed.\n> > \n> > What's the default KDE environment for Debian Bookworm and Ubuntu 24.04,\n> > is it KDE 5 or KDE 6 ?\n> \n> Do you have libqt6svg6? That is needed for Qt6 svg icons.\n\nI was missing it indeed (the package is called dev-qt/qtsvg in Gentoo).\nThat fixed the problem, thank you.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D86ABBDB1C\n\tfor ;\n\tMon, 22 Jan 2024 12:40:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39A7C6291F;\n\tMon, 22 Jan 2024 13:40:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 888B061D30\n\tfor ;\n\tMon, 22 Jan 2024 13:40:17 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5471174A;\n\tMon, 22 Jan 2024 13:39:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vkXAg0mi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705927144;\n\tbh=NicOcsOERr4mKIXc091we91Murtm9tU/Yj+cGnPD99g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vkXAg0miQVW9xZz8idD8KDNOihQYfRAlkKFM8FBQ2X5xpgh09reYFtGRzlH5bZhjh\n\ttiKMNRl8nlTaZ9K+oK+IXdFzRi8HGgUNQhA1Ig9mUx+cThbSHhuKgsh5uBgz+QUdAy\n\tEDci1a+Dyid/3Aiv0//2QXuKt9zpudSXpO2N5YK0=","Date":"Mon, 22 Jan 2024 14:40:20 +0200","From":"Laurent Pinchart ","To":"Gergo Koteles ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","Message-ID":"<20240122124020.GA2657@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t\n\t<20240122113356.GA29275@pendragon.ideasonboard.com>\n\t\n\t<20240122115702.GB29275@pendragon.ideasonboard.com>\n\t<048b9a8a7effc6ddd717e809d05ecb8c33a3e5e8.camel@irl.hu>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<048b9a8a7effc6ddd717e809d05ecb8c33a3e5e8.camel@irl.hu>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Neal Gompa ,\n\tlibcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28532,"web_url":"https://patchwork.libcamera.org/comment/28532/","msgid":"<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>","date":"2024-01-22T13:07:45","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Neal Gompa (2024-01-22 11:08:33)\n> On Mon, Jan 22, 2024 at 6:00 AM Kieran Bingham\n> wrote:\n> >\n> > Quoting Laurent Pinchart (2024-01-22 09:53:39)\n> > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > Aha, I missed that there was already a v2.\n> > > >\n> > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > >\n> > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > to Qt 5 that is no longer applicable.\n> > > > >\n> > > > > Signed-off-by: Neal Gompa \n> > > > > ---\n> > > > > README.rst | 2 +-\n> > > > > meson.build | 2 +-\n> > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > >\n> > > > > diff --git a/README.rst b/README.rst\n> > > > > index 315738ee..6f1c9302 100644\n> > > > > --- a/README.rst\n> > > > > +++ b/README.rst\n> > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > - libsdl2-dev: Enables the SDL sink\n> > > > >\n> > > > > for qcam: [optional]\n> > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > >\n> > > > > for tracing with lttng: [optional]\n> > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > diff --git a/meson.build b/meson.build\n> > > > > index cb6b666a..4c315e2a 100644\n> > > > > --- a/meson.build\n> > > > > +++ b/meson.build\n> > > > > @@ -1,7 +1,7 @@\n> > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > >\n> > > > > project('libcamera', 'c', 'cpp',\n> > > > > - meson_version : '>= 0.60',\n> > > > > + meson_version : '>= 0.63',\n> > > >\n> > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > https://packages.debian.org/source/stable/meson\n> > > >\n> > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > https://packages.ubuntu.com/jammy/meson\n> > > >\n> > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > >\n> > > >\n> > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > recent Meson at 1.2.3 or later:\n> > > > https://src.fedoraproject.org/rpms/meson\n> > > >\n> > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > should be included in fact.\n> > > >\n> > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > https://software.opensuse.org/package/meson?locale=en\n> > > >\n> > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > >\n> > > > Any thoughts anyone?\n> > >\n> > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > the case :-(\n> > >\n> > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > gets released.\n> >\n> > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > versions in proposed and Release). Either way it will be > 1.2! :\n> > https://launchpad.net/ubuntu/noble/+package/meson\n> >\n> > I would propose that the meson version update is separated from the\n> > patch as a preceeding commit, and could already be resent. Then we can\n> > simply pick these in April. I'd probably say we could merge this in\n> > early April, such that we can make a release of libcamera with that\n> > support merged soon after Ubuntu 24.04 is released on April 25th.\n> >\n> \n> On the flip side, if it's merged and released into Debian before the\n> Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> itself.\n\nThat's an interesting take too.\n\nWhich one is the chicken and which one is the egg?\n\nOur early requirement for meeting the dependencies in the distributions\nwas because the distributions themselves were not including libcamera.\nTherefore, users of libcamera /had/ to be able to build libcamera.\n\nNow that things can be included, perhaps that's reason enough to say\naiming for integration is better.\n\n> [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n\nIt looks like libcamera-0.2 is already included in the noble release, so\npackage updates into debian look like they get into Ubuntu quite 'fast'.\n\nI feel like targetting getting /into/ the next Ubuntu LTS with updates\nis better than working on /top/ of it.\n\nThe expense/cost is that in between we would no longer support compiling\nthe master branch (or intermediate releases) with the 'current' LTS of\nUbuntu.\n\nI could say \"Oh well, that probably doesn't matter\" ... except ... I use\nUbuntu-22.04 as my main distro ... and I would plan to upgrade at the\nnext release.\n\nI'm aware that I can work around this issue by upgrading meson myself.\nThe question is what will happen to others ... and maybe it's just\nsomething we should bite and help them upgrade meson in the interim.\n\n--\nKieran\n\n\n\n> -- \n> 真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96DB2C323E\n\tfor ;\n\tMon, 22 Jan 2024 13:07:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B04B628B7;\n\tMon, 22 Jan 2024 14:07:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9C2561D30\n\tfor ;\n\tMon, 22 Jan 2024 14:07:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9B71221;\n\tMon, 22 Jan 2024 14:06:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nzSkkp7b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705928795;\n\tbh=H7KJFKcUm/SdYynpeMBaOGqcHlrIyOdxxhqZLh6/Vf4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=nzSkkp7bSJ7j0Qijcj4qDLhXDdw+7gc5p/m0T3QSEFwWbjLOTT5ROIQ4DCucsJw41\n\t9gliZznPctfKRZqO1XmQkQrZ0r/E+1KKdPXmnsdR/UKA6cjpcZc+g/ydQzw2dzCX94\n\tCgHqGvsDYZVXfQhp1k6xiLP0gR+w0Ib3VS6Of3aA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","To":"Neal Gompa ","Date":"Mon, 22 Jan 2024 13:07:45 +0000","Message-ID":"<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28534,"web_url":"https://patchwork.libcamera.org/comment/28534/","msgid":"","date":"2024-01-22T14:08:37","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 8:07 AM Kieran Bingham\n wrote:\n>\n> Quoting Neal Gompa (2024-01-22 11:08:33)\n> > On Mon, Jan 22, 2024 at 6:00 AM Kieran Bingham\n> > wrote:\n> > >\n> > > Quoting Laurent Pinchart (2024-01-22 09:53:39)\n> > > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > > Aha, I missed that there was already a v2.\n> > > > >\n> > > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > > >\n> > > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > > to Qt 5 that is no longer applicable.\n> > > > > >\n> > > > > > Signed-off-by: Neal Gompa \n> > > > > > ---\n> > > > > > README.rst | 2 +-\n> > > > > > meson.build | 2 +-\n> > > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > > >\n> > > > > > diff --git a/README.rst b/README.rst\n> > > > > > index 315738ee..6f1c9302 100644\n> > > > > > --- a/README.rst\n> > > > > > +++ b/README.rst\n> > > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > > - libsdl2-dev: Enables the SDL sink\n> > > > > >\n> > > > > > for qcam: [optional]\n> > > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > > >\n> > > > > > for tracing with lttng: [optional]\n> > > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > > diff --git a/meson.build b/meson.build\n> > > > > > index cb6b666a..4c315e2a 100644\n> > > > > > --- a/meson.build\n> > > > > > +++ b/meson.build\n> > > > > > @@ -1,7 +1,7 @@\n> > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > >\n> > > > > > project('libcamera', 'c', 'cpp',\n> > > > > > - meson_version : '>= 0.60',\n> > > > > > + meson_version : '>= 0.63',\n> > > > >\n> > > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > > https://packages.debian.org/source/stable/meson\n> > > > >\n> > > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > > https://packages.ubuntu.com/jammy/meson\n> > > > >\n> > > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > > >\n> > > > >\n> > > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > > recent Meson at 1.2.3 or later:\n> > > > > https://src.fedoraproject.org/rpms/meson\n> > > > >\n> > > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > > should be included in fact.\n> > > > >\n> > > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > > https://software.opensuse.org/package/meson?locale=en\n> > > > >\n> > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > >\n> > > > > Any thoughts anyone?\n> > > >\n> > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > the case :-(\n> > > >\n> > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > gets released.\n> > >\n> > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > https://launchpad.net/ubuntu/noble/+package/meson\n> > >\n> > > I would propose that the meson version update is separated from the\n> > > patch as a preceeding commit, and could already be resent. Then we can\n> > > simply pick these in April. I'd probably say we could merge this in\n> > > early April, such that we can make a release of libcamera with that\n> > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > >\n> >\n> > On the flip side, if it's merged and released into Debian before the\n> > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > itself.\n>\n> That's an interesting take too.\n>\n> Which one is the chicken and which one is the egg?\n>\n> Our early requirement for meeting the dependencies in the distributions\n> was because the distributions themselves were not including libcamera.\n> Therefore, users of libcamera /had/ to be able to build libcamera.\n>\n> Now that things can be included, perhaps that's reason enough to say\n> aiming for integration is better.\n>\n> > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n>\n> It looks like libcamera-0.2 is already included in the noble release, so\n> package updates into debian look like they get into Ubuntu quite 'fast'.\n>\n> I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> is better than working on /top/ of it.\n>\n> The expense/cost is that in between we would no longer support compiling\n> the master branch (or intermediate releases) with the 'current' LTS of\n> Ubuntu.\n>\n> I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> next release.\n>\n> I'm aware that I can work around this issue by upgrading meson myself.\n> The question is what will happen to others ... and maybe it's just\n> something we should bite and help them upgrade meson in the interim.\n>\n\nWell, in a previous life I used to maintain Meson backports for Ubuntu.\n\nI'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n22.04 until 24.04 is released if it would help you:\nhttps://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n\n\n\n\n--\n真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A83DC323E\n\tfor ;\n\tMon, 22 Jan 2024 14:09:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B6516291F;\n\tMon, 22 Jan 2024 15:09:17 +0100 (CET)","from mail-lf1-f42.google.com (mail-lf1-f42.google.com\n\t[209.85.167.42])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5BAD61D30\n\tfor ;\n\tMon, 22 Jan 2024 15:09:16 +0100 (CET)","by mail-lf1-f42.google.com with SMTP id\n\t2adb3069b0e04-50e7abe4be4so4188290e87.2\n\tfor ;\n\tMon, 22 Jan 2024 06:09:16 -0800 (PST)","from mail-lj1-f175.google.com (mail-lj1-f175.google.com.\n\t[209.85.208.175]) by smtp.gmail.com with ESMTPSA id\n\tg21-20020a19e055000000b0050e94329e7csm2051100lfj.269.2024.01.22.06.09.14\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 06:09:15 -0800 (PST)","by mail-lj1-f175.google.com with SMTP id\n\t38308e7fff4ca-2cddb11b2e2so38220131fa.1\n\tfor ;\n\tMon, 22 Jan 2024 06:09:14 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705932555; x=1706537355;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=2rWKUoqadlxBvTqPddditU7sNgNKXRb/f4HXAn5N5hM=;\n\tb=fwa7mKl6APGsFHyCYqVZ07147+fprwIwByDbGCIwCLGKVVEOvZwtVNQVBglf6MKddp\n\t1WjLXwDkie82KFE32iKK0oV1pCNML3JUetrXkcv7268ZLNrJsH0v5iZdmraa5O35umD+\n\taKAXa7IiceoHw9Qj2DmcJQ6F/od8uc+Q//B2pwbU16ze3Sv4Cc6nvX5CxT1jU4dArmtE\n\t7pUZr/+/KYMpfrqCbCbMnq7t/zi7zJkV04y+yiVQUJfO8BWVcR06LCfLjFsrbITMNyzQ\n\tSDQndz+cBx7MjBLlCJsvpT3dj6TgyGZe7gvm8Ps197oZFWSH+bLCkjjL55MrPS6iK8Gf\n\tVXxQ==","X-Gm-Message-State":"AOJu0YxHvKwxupXmcUBV45IWUXcWoPXvNsacg/Uz3aaL9r2pjRDcGTDv\n\tcqYZ1sS8ntmrZeeXzr0s7H4hSrP7smzgulaqy+sE6hsKJDRVzNOBgE0L0XvP8c4=","X-Google-Smtp-Source":"AGHT+IET3O74Lk7tsV98aRyzawvAsSerKmLkqdY2C1K3nVYA8b8bhfW3JhkJUoxFVNAENlZs5Qr//g==","X-Received":["by 2002:a05:6512:3135:b0:50b:f03c:1ea2 with SMTP id\n\tp21-20020a056512313500b0050bf03c1ea2mr1738677lfd.84.1705932555217; \n\tMon, 22 Jan 2024 06:09:15 -0800 (PST)","by 2002:a2e:9ed6:0:b0:2cf:121:3ccb with SMTP id\n\th22-20020a2e9ed6000000b002cf01213ccbmr460002ljk.55.1705932554638;\n\tMon, 22 Jan 2024 06:09:14 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>","In-Reply-To":"<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 09:08:37 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28540,"web_url":"https://patchwork.libcamera.org/comment/28540/","msgid":"<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>","date":"2024-01-22T16:02:08","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Neal Gompa (2024-01-22 14:08:37)\n> On Mon, Jan 22, 2024 at 8:07 AM Kieran Bingham\n> wrote:\n> >\n> > Quoting Neal Gompa (2024-01-22 11:08:33)\n> > > On Mon, Jan 22, 2024 at 6:00 AM Kieran Bingham\n> > > wrote:\n> > > >\n> > > > Quoting Laurent Pinchart (2024-01-22 09:53:39)\n> > > > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > > > Aha, I missed that there was already a v2.\n> > > > > >\n> > > > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > > > >\n> > > > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > > > to Qt 5 that is no longer applicable.\n> > > > > > >\n> > > > > > > Signed-off-by: Neal Gompa \n> > > > > > > ---\n> > > > > > > README.rst | 2 +-\n> > > > > > > meson.build | 2 +-\n> > > > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > > > >\n> > > > > > > diff --git a/README.rst b/README.rst\n> > > > > > > index 315738ee..6f1c9302 100644\n> > > > > > > --- a/README.rst\n> > > > > > > +++ b/README.rst\n> > > > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > > > - libsdl2-dev: Enables the SDL sink\n> > > > > > >\n> > > > > > > for qcam: [optional]\n> > > > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > > > >\n> > > > > > > for tracing with lttng: [optional]\n> > > > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > > > diff --git a/meson.build b/meson.build\n> > > > > > > index cb6b666a..4c315e2a 100644\n> > > > > > > --- a/meson.build\n> > > > > > > +++ b/meson.build\n> > > > > > > @@ -1,7 +1,7 @@\n> > > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > > >\n> > > > > > > project('libcamera', 'c', 'cpp',\n> > > > > > > - meson_version : '>= 0.60',\n> > > > > > > + meson_version : '>= 0.63',\n> > > > > >\n> > > > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > > > https://packages.debian.org/source/stable/meson\n> > > > > >\n> > > > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > > > https://packages.ubuntu.com/jammy/meson\n> > > > > >\n> > > > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > > > >\n> > > > > >\n> > > > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > > > recent Meson at 1.2.3 or later:\n> > > > > > https://src.fedoraproject.org/rpms/meson\n> > > > > >\n> > > > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > > > should be included in fact.\n> > > > > >\n> > > > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > > > https://software.opensuse.org/package/meson?locale=en\n> > > > > >\n> > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > >\n> > > > > > Any thoughts anyone?\n> > > > >\n> > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > the case :-(\n> > > > >\n> > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > gets released.\n> > > >\n> > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > >\n> > > > I would propose that the meson version update is separated from the\n> > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > simply pick these in April. I'd probably say we could merge this in\n> > > > early April, such that we can make a release of libcamera with that\n> > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > >\n> > >\n> > > On the flip side, if it's merged and released into Debian before the\n> > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > itself.\n> >\n> > That's an interesting take too.\n> >\n> > Which one is the chicken and which one is the egg?\n> >\n> > Our early requirement for meeting the dependencies in the distributions\n> > was because the distributions themselves were not including libcamera.\n> > Therefore, users of libcamera /had/ to be able to build libcamera.\n> >\n> > Now that things can be included, perhaps that's reason enough to say\n> > aiming for integration is better.\n> >\n> > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> >\n> > It looks like libcamera-0.2 is already included in the noble release, so\n> > package updates into debian look like they get into Ubuntu quite 'fast'.\n> >\n> > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > is better than working on /top/ of it.\n> >\n> > The expense/cost is that in between we would no longer support compiling\n> > the master branch (or intermediate releases) with the 'current' LTS of\n> > Ubuntu.\n> >\n> > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > next release.\n> >\n> > I'm aware that I can work around this issue by upgrading meson myself.\n> > The question is what will happen to others ... and maybe it's just\n> > something we should bite and help them upgrade meson in the interim.\n> >\n> \n> Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> \n> I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> 22.04 until 24.04 is released if it would help you:\n> https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n\nIs there an official Ubuntu channel for that? If you can make\n'ubuntu-22.04' support a later meson - I have no argument to prevent this\nbeing merged already!\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88EEEC323E\n\tfor ;\n\tMon, 22 Jan 2024 16:02:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A8616291F;\n\tMon, 22 Jan 2024 17:02:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5425D61D30\n\tfor ;\n\tMon, 22 Jan 2024 17:02:11 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CD89221;\n\tMon, 22 Jan 2024 17:00:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pENDBdeA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705939258;\n\tbh=tjbJzPcfQuRp0VZnAfufc1cVLMLTACkoQ5NLiQ/J778=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pENDBdeA50KM/uQUSYj1jrlHh7styHzIDKC3CsIfQzL0ItF6ia0ZARSK/8aNVeNWx\n\tTVbWfiwQ/eZGV2GxkVRnt0wPtVCnrQRqm+V5MWmNyNbA+ybicjFAtH2KJXQCU8AJZL\n\txW9NqNRmGEAms6HF6YtUDe1zlqME/omxvDWt0ETw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","To":"Neal Gompa ","Date":"Mon, 22 Jan 2024 16:02:08 +0000","Message-ID":"<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28553,"web_url":"https://patchwork.libcamera.org/comment/28553/","msgid":"","date":"2024-01-22T19:55:20","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham\n wrote:\n>\n> Quoting Neal Gompa (2024-01-22 14:08:37)\n> > On Mon, Jan 22, 2024 at 8:07 AM Kieran Bingham\n> > wrote:\n> > >\n> > > Quoting Neal Gompa (2024-01-22 11:08:33)\n> > > > On Mon, Jan 22, 2024 at 6:00 AM Kieran Bingham\n> > > > wrote:\n> > > > >\n> > > > > Quoting Laurent Pinchart (2024-01-22 09:53:39)\n> > > > > > On Mon, Jan 22, 2024 at 09:38:33AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > > > > > Aha, I missed that there was already a v2.\n> > > > > > >\n> > > > > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > > > > >\n> > > > > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > > > > to Qt 5 that is no longer applicable.\n> > > > > > > >\n> > > > > > > > Signed-off-by: Neal Gompa \n> > > > > > > > ---\n> > > > > > > > README.rst | 2 +-\n> > > > > > > > meson.build | 2 +-\n> > > > > > > > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > > > > > > > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > > > > > > >\n> > > > > > > > diff --git a/README.rst b/README.rst\n> > > > > > > > index 315738ee..6f1c9302 100644\n> > > > > > > > --- a/README.rst\n> > > > > > > > +++ b/README.rst\n> > > > > > > > @@ -88,7 +88,7 @@ for cam: [optional]\n> > > > > > > > - libsdl2-dev: Enables the SDL sink\n> > > > > > > >\n> > > > > > > > for qcam: [optional]\n> > > > > > > > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > > > > > > > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> > > > > > > >\n> > > > > > > > for tracing with lttng: [optional]\n> > > > > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> > > > > > > > diff --git a/meson.build b/meson.build\n> > > > > > > > index cb6b666a..4c315e2a 100644\n> > > > > > > > --- a/meson.build\n> > > > > > > > +++ b/meson.build\n> > > > > > > > @@ -1,7 +1,7 @@\n> > > > > > > > # SPDX-License-Identifier: CC0-1.0\n> > > > > > > >\n> > > > > > > > project('libcamera', 'c', 'cpp',\n> > > > > > > > - meson_version : '>= 0.60',\n> > > > > > > > + meson_version : '>= 0.63',\n> > > > > > >\n> > > > > > > Debian Bookworm: is currently at 1.0.1-5\n> > > > > > > https://packages.debian.org/source/stable/meson\n> > > > > > >\n> > > > > > > Ubuntu 22.04.3 is currently at 0.61.2-1 :-(\n> > > > > > > https://packages.ubuntu.com/jammy/meson\n> > > > > > >\n> > > > > > > We're about 3 months away from Ubuntu 24.04 ...\n> > > > > > >\n> > > > > > >\n> > > > > > > Fedora is in a better shape, and all Fedora releases in support have a\n> > > > > > > recent Meson at 1.2.3 or later:\n> > > > > > > https://src.fedoraproject.org/rpms/meson\n> > > > > > >\n> > > > > > > Redhat Enterprise linux looks more problematic - So I'm not sure if that\n> > > > > > > should be included in fact.\n> > > > > > >\n> > > > > > > OpenSuse seems to be already at 1.3.1 too:\n> > > > > > > https://software.opensuse.org/package/meson?locale=en\n> > > > > > >\n> > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > >\n> > > > > > > Any thoughts anyone?\n> > > > > >\n> > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > the case :-(\n> > > > > >\n> > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > gets released.\n> > > > >\n> > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > >\n> > > > > I would propose that the meson version update is separated from the\n> > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > early April, such that we can make a release of libcamera with that\n> > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > >\n> > > >\n> > > > On the flip side, if it's merged and released into Debian before the\n> > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > itself.\n> > >\n> > > That's an interesting take too.\n> > >\n> > > Which one is the chicken and which one is the egg?\n> > >\n> > > Our early requirement for meeting the dependencies in the distributions\n> > > was because the distributions themselves were not including libcamera.\n> > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > >\n> > > Now that things can be included, perhaps that's reason enough to say\n> > > aiming for integration is better.\n> > >\n> > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > >\n> > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > >\n> > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > is better than working on /top/ of it.\n> > >\n> > > The expense/cost is that in between we would no longer support compiling\n> > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > Ubuntu.\n> > >\n> > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > next release.\n> > >\n> > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > The question is what will happen to others ... and maybe it's just\n> > > something we should bite and help them upgrade meson in the interim.\n> > >\n> >\n> > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> >\n> > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > 22.04 until 24.04 is released if it would help you:\n> > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n>\n> Is there an official Ubuntu channel for that? If you can make\n> 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> being merged already!\n>\n\nNo. At this point, it would be unlikely to get updated unless you know\nsomeone who can ship something in jammy-backports. But even then, with\n24.04 coming in a few months, 22.04 has been in its zombie period for\na while now. Typically, the expectation is that you either use later\nUbuntu STS releases (23.10 is a perfectly fine release, as an example)\nor backport what you need while you wait for the next LTS.\n\nIf you intend to hold back the patch until after 24.04 releases, then\nthere is no chance for this to be part of Ubuntu 24.04 itself, which I\nthink would be a shame. I prepared a backport for meson for Ubuntu\n22.04 because you said it would help you for developing on 22.04. I am\nnot about to ask you to move to Fedora (which is what I use) or CentOS\nStream 9 (which would be an analogous LTS that does have a recent\nenough Meson).\n\nMy only argument at this point is that you can choose to include the\npatch now and make a release so it can land in Debian sid now, and\nthus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\nit. From my perspective, I want this so that Fedora users and later\nCentOS 10 users will benefit from it. I also think that Debian/Ubuntu\nfolks would benefit from it because it's one less thing depending on\nessentially unsupported versions of Qt.\n\n\n\n\n--\n真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCE3ABDB1C\n\tfor ;\n\tMon, 22 Jan 2024 19:56:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2048A62916;\n\tMon, 22 Jan 2024 20:56:01 +0100 (CET)","from mail-wm1-f50.google.com (mail-wm1-f50.google.com\n\t[209.85.128.50])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCBE7628B7\n\tfor ;\n\tMon, 22 Jan 2024 20:55:59 +0100 (CET)","by mail-wm1-f50.google.com with SMTP id\n\t5b1f17b1804b1-40e80046264so45856885e9.0\n\tfor ;\n\tMon, 22 Jan 2024 11:55:59 -0800 (PST)","from mail-ed1-f50.google.com (mail-ed1-f50.google.com.\n\t[209.85.208.50]) by smtp.gmail.com with ESMTPSA id\n\tg22-20020a17090613d600b00a26aaf9f79asm13584090ejc.20.2024.01.22.11.55.58\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 11:55:58 -0800 (PST)","by mail-ed1-f50.google.com with SMTP id\n\t4fb4d7f45d1cf-55a6833c21eso2483619a12.2\n\tfor ;\n\tMon, 22 Jan 2024 11:55:58 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705953359; x=1706558159;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=8puoJYZ6rz3GTs3TjepKmO9xaPwMjG9/bYyZBLBJkUY=;\n\tb=jfiNq+E/w4PtYC8lrriHYgHj7lQwceZVP3cjdpiVIGWblbp8e7K0T502jaxJRtkN5h\n\tNXiH0qBfopl5eId2419hM3Sz6NAwVD4HbYikbivSdXkqtTKmeWe2fTNWFDsjPJ4EQ7Hm\n\tpdI8vp5bC7W3k6w/NH23OmKTjTXCNsdAkfE1SAB10O7DKWsCfE4evJVv7glHv8fkYnkU\n\tn2KFgsKmDI5q08KhECI9DAvs8wgSuo5wkEWJYHSgJD3UJT7pjW4xzqFhCfxZdpRO6OYo\n\tPWmF9fYOPh4UAW49Vh6pv5TNLh1T0kEZ23qTLkHnPgtTfS1gvB3SQo0KweFfX/irnGLX\n\t9UXQ==","X-Gm-Message-State":"AOJu0YxnqV6M63AsmTtuumIw9hhMEK7L5Wg5s4VlfK4+4woJTxOaLxWd\n\tL1CaPXbBvzyaIZFBYhfvccyr8yEywhWwplmtav4VMYxRaZ3VFvYDu31LDpQG9l8=","X-Google-Smtp-Source":"AGHT+IE8mPwi9eOwp2gTiQEEXfPXAPOAdOWm4sOP5Xx208kYIoUIXI75LjSyz01xZpL2RiUPY9QA9A==","X-Received":["by 2002:a05:600c:46d3:b0:40e:ab7f:3448 with SMTP id\n\tq19-20020a05600c46d300b0040eab7f3448mr1496262wmo.144.1705953358653; \n\tMon, 22 Jan 2024 11:55:58 -0800 (PST)","by 2002:a05:6402:1c1b:b0:559:d17f:bceb with SMTP id\n\tck27-20020a0564021c1b00b00559d17fbcebmr272623edb.26.1705953358170;\n\tMon, 22 Jan 2024 11:55:58 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>","In-Reply-To":"<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 14:55:20 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28561,"web_url":"https://patchwork.libcamera.org/comment/28561/","msgid":"<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>","date":"2024-01-22T22:31:26","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Neal Gompa (2024-01-22 19:55:20)\n> On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham\n> wrote:\n> >\n> > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > >\n> > > > > > > > Any thoughts anyone?\n> > > > > > >\n> > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > the case :-(\n> > > > > > >\n> > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > gets released.\n\nIs there an urgency? Is there a requirement to move to QT6 for Fedora or\notherwise?\n\n> > > > > >\n> > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > >\n> > > > > > I would propose that the meson version update is separated from the\n> > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > >\n> > > > >\n> > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > itself.\n> > > >\n> > > > That's an interesting take too.\n> > > >\n> > > > Which one is the chicken and which one is the egg?\n> > > >\n> > > > Our early requirement for meeting the dependencies in the distributions\n> > > > was because the distributions themselves were not including libcamera.\n> > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > >\n> > > > Now that things can be included, perhaps that's reason enough to say\n> > > > aiming for integration is better.\n> > > >\n> > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > >\n> > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > >\n> > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > is better than working on /top/ of it.\n> > > >\n> > > > The expense/cost is that in between we would no longer support compiling\n> > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > Ubuntu.\n> > > >\n> > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > next release.\n> > > >\n> > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > The question is what will happen to others ... and maybe it's just\n> > > > something we should bite and help them upgrade meson in the interim.\n> > > >\n> > >\n> > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > >\n> > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > 22.04 until 24.04 is released if it would help you:\n> > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> >\n> > Is there an official Ubuntu channel for that? If you can make\n> > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > being merged already!\n> >\n> \n> No. At this point, it would be unlikely to get updated unless you know\n> someone who can ship something in jammy-backports. But even then, with\n> 24.04 coming in a few months, 22.04 has been in its zombie period for\n> a while now. Typically, the expectation is that you either use later\n> Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> or backport what you need while you wait for the next LTS.\n> \n> If you intend to hold back the patch until after 24.04 releases, then\n> there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> think would be a shame. I prepared a backport for meson for Ubuntu\n> 22.04 because you said it would help you for developing on 22.04. I am\n\nI myself am quite capable of updating meson. I was highlighting that\nthere are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\nto make sure that libcamera can be built on the 'main distributions'.\nFor which we define that as 'the latest LTS of the big distros'.\n\nMy question above was because it sounded like you could get that solved\nby fixing the one remaining stuck-in-the-past distro which is blocking\nus.\n\n\"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n\nAnd if you could do that - there would be nothing blocking the patch!\n\n> not about to ask you to move to Fedora (which is what I use) or CentOS\n> Stream 9 (which would be an analogous LTS that does have a recent\n> enough Meson).\n> \n> My only argument at this point is that you can choose to include the\n> patch now and make a release so it can land in Debian sid now, and\n> thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> it. From my perspective, I want this so that Fedora users and later\n> CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n\nThe question for us though is how many people's set ups will we break by\nupdating and merging this patch? I don't know the answer - it could be a\nhandfull or less, which may be worth the 'short term' support cost.\nMaybe its none (one including me?) Or maybe its more? We don't have a\nway to know until they shout angrily ...\n\n\n> folks would benefit from it because it's one less thing depending on\n> essentially unsupported versions of Qt.\n\nI don't disagree. Hence earlier - which is the chicken, and which is the\negg ...\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FDE5BDB1C\n\tfor ;\n\tMon, 22 Jan 2024 22:31:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F48F6291F;\n\tMon, 22 Jan 2024 23:31:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0472D61D30\n\tfor ;\n\tMon, 22 Jan 2024 23:31:28 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D901221;\n\tMon, 22 Jan 2024 23:30:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qsJYuhNd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705962615;\n\tbh=Ykmrk/SHKxCXCIYGaBcL9BvQBMOT48Bk483D+S7kJCQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qsJYuhNdyqJ4obPKPT5toyAhgueDxENFFSpBjQly0GF/yUoDIg45t0qC3xT6TFwdk\n\tqON7jpNIXX6TDH+yJrQUucjE3fE6ECR4D7AhKcct0CC7a+HUjKbZiDQ5x7AWHhtWeX\n\t7m5Kyyim/ffU5Lddrdkuc/2aTZ5ECi5mmCx49mmk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","To":"Neal Gompa ","Date":"Mon, 22 Jan 2024 22:31:26 +0000","Message-ID":"<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28564,"web_url":"https://patchwork.libcamera.org/comment/28564/","msgid":"","date":"2024-01-22T22:40:42","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 5:31 PM Kieran Bingham\n wrote:\n>\n> Quoting Neal Gompa (2024-01-22 19:55:20)\n> > On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham\n> > wrote:\n> > >\n> > > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > > >\n> > > > > > > > > Any thoughts anyone?\n> > > > > > > >\n> > > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > > the case :-(\n> > > > > > > >\n> > > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > > gets released.\n>\n> Is there an urgency? Is there a requirement to move to QT6 for Fedora or\n> otherwise?\n>\n> > > > > > >\n> > > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > > >\n> > > > > > > I would propose that the meson version update is separated from the\n> > > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > > >\n> > > > > >\n> > > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > > itself.\n> > > > >\n> > > > > That's an interesting take too.\n> > > > >\n> > > > > Which one is the chicken and which one is the egg?\n> > > > >\n> > > > > Our early requirement for meeting the dependencies in the distributions\n> > > > > was because the distributions themselves were not including libcamera.\n> > > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > > >\n> > > > > Now that things can be included, perhaps that's reason enough to say\n> > > > > aiming for integration is better.\n> > > > >\n> > > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > > >\n> > > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > > >\n> > > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > > is better than working on /top/ of it.\n> > > > >\n> > > > > The expense/cost is that in between we would no longer support compiling\n> > > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > > Ubuntu.\n> > > > >\n> > > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > > next release.\n> > > > >\n> > > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > > The question is what will happen to others ... and maybe it's just\n> > > > > something we should bite and help them upgrade meson in the interim.\n> > > > >\n> > > >\n> > > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > > >\n> > > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > > 22.04 until 24.04 is released if it would help you:\n> > > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> > >\n> > > Is there an official Ubuntu channel for that? If you can make\n> > > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > > being merged already!\n> > >\n> >\n> > No. At this point, it would be unlikely to get updated unless you know\n> > someone who can ship something in jammy-backports. But even then, with\n> > 24.04 coming in a few months, 22.04 has been in its zombie period for\n> > a while now. Typically, the expectation is that you either use later\n> > Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> > or backport what you need while you wait for the next LTS.\n> >\n> > If you intend to hold back the patch until after 24.04 releases, then\n> > there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> > think would be a shame. I prepared a backport for meson for Ubuntu\n> > 22.04 because you said it would help you for developing on 22.04. I am\n>\n> I myself am quite capable of updating meson. I was highlighting that\n> there are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\n> to make sure that libcamera can be built on the 'main distributions'.\n> For which we define that as 'the latest LTS of the big distros'.\n>\n> My question above was because it sounded like you could get that solved\n> by fixing the one remaining stuck-in-the-past distro which is blocking\n> us.\n>\n> \"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n>\n> And if you could do that - there would be nothing blocking the patch!\n>\n\nUnfortunately, not in Ubuntu proper. I did it outside of the distribution.\n\nIt's actually very hard to get a backport of Meson through because it\nis not behavior-stable across releases. This is incredibly important\nfor Debian and Ubuntu, which is likely why Meson almost never sees\nofficial backports. Even CentOS Meson upgrades required a lot of work\nto bend new releases to be more backward compatible so nothing would\nbreak.\n\n> > not about to ask you to move to Fedora (which is what I use) or CentOS\n> > Stream 9 (which would be an analogous LTS that does have a recent\n> > enough Meson).\n> >\n> > My only argument at this point is that you can choose to include the\n> > patch now and make a release so it can land in Debian sid now, and\n> > thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> > it. From my perspective, I want this so that Fedora users and later\n> > CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n>\n> The question for us though is how many people's set ups will we break by\n> updating and merging this patch? I don't know the answer - it could be a\n> handfull or less, which may be worth the 'short term' support cost.\n> Maybe its none (one including me?) Or maybe its more? We don't have a\n> way to know until they shout angrily ...\n>\n>\n\nI think realistically most people use libcamera from the distributions\nthemselves. And in Debian and Ubuntu, libcamera is not updated in\nstable releases at all. If people are trying to use updated libcamera\non those distributions, then they are either 1) building from source\nor 2) installing a third party build. In both scenarios, handling a\nmeson upgrade is probably reasonable.\n\n> > folks would benefit from it because it's one less thing depending on\n> > essentially unsupported versions of Qt.\n>\n> I don't disagree. Hence earlier - which is the chicken, and which is the\n> egg ...\n\n🤷‍♂️","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7B55C323E\n\tfor ;\n\tMon, 22 Jan 2024 22:41:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B7E062949;\n\tMon, 22 Jan 2024 23:41:21 +0100 (CET)","from mail-wm1-f48.google.com (mail-wm1-f48.google.com\n\t[209.85.128.48])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5CCE628B7\n\tfor ;\n\tMon, 22 Jan 2024 23:41:20 +0100 (CET)","by mail-wm1-f48.google.com with SMTP id\n\t5b1f17b1804b1-40e9d4ab5f3so39947045e9.2\n\tfor ;\n\tMon, 22 Jan 2024 14:41:20 -0800 (PST)","from mail-ed1-f53.google.com (mail-ed1-f53.google.com.\n\t[209.85.208.53]) by smtp.gmail.com with ESMTPSA id\n\ti13-20020a056402054d00b0055c69e0751fsm592107edx.3.2024.01.22.14.41.19\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 14:41:19 -0800 (PST)","by mail-ed1-f53.google.com with SMTP id\n\t4fb4d7f45d1cf-557dcb0f870so4189703a12.2\n\tfor ;\n\tMon, 22 Jan 2024 14:41:19 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705963280; x=1706568080;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=vgz6Kw7luMJWlG33RsZfp5h/xxMAa8t/HnQXM4dLQQQ=;\n\tb=dXdHKV9ratGqtIrnM4fRZh6sXwdktW2Yvfxrv6mriyxlVdRwiV4YvVbHt8qbv3cel5\n\tUwK7DLbn0XJk3KoxYoA4xRt9qzt0jWF0IVgbFDf6ozxXWekczcuxeZrRiGDj4LpXhAxX\n\tIes7/1JMZBCfYgsX2+Ak7lGqB7dOe/GqRxhgKb3cVvF/NqRStpZW1V0vZKgBY/pcCEWz\n\tPSXJ22fVf6DvYto92p/kq/P9SNgaVL0a2hRwje7vN1NXqB3Dl6qqjXVqRZANGJhA8VFj\n\tVT+ulILJ59iywQyHWOhwgwgd9L92U6t0DMpo3G0xEFq4ENgiiHucpHDye+UGpU7lNbaa\n\t9eUw==","X-Gm-Message-State":"AOJu0YxJb2qUcoN5o2X3BhdzUma3SFGY8DVM8y5lNHpalB//suYrCaL3\n\tuSPjwcEzDIEhcHvmaDn/or4FRlql1QcczGdmjZGpEBayzu/NCEU71m9FnuJV8JQ=","X-Google-Smtp-Source":"AGHT+IGzrfDge8DGQ2asPiPmwRiuUSlG1O+UK5TilDJbDaq2an9RpcfNJCVJVdfN0mYi4Gu0oIBl6Q==","X-Received":["by 2002:a05:600c:2106:b0:40e:5181:63e4 with SMTP id\n\tu6-20020a05600c210600b0040e518163e4mr2886653wml.165.1705963279790; \n\tMon, 22 Jan 2024 14:41:19 -0800 (PST)","by 2002:a05:6402:2691:b0:55a:6e81:7ec3 with SMTP id\n\tw17-20020a056402269100b0055a6e817ec3mr383069edd.84.1705963279046;\n\tMon, 22 Jan 2024 14:41:19 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t\n\t<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>","In-Reply-To":"<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 17:40:42 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28570,"web_url":"https://patchwork.libcamera.org/comment/28570/","msgid":"<20240123001925.GD10843@pendragon.ideasonboard.com>","date":"2024-01-23T00:19:25","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 05:40:42PM -0500, Neal Gompa wrote:\n> On Mon, Jan 22, 2024 at 5:31 PM Kieran Bingham wrote:\n> > Quoting Neal Gompa (2024-01-22 19:55:20)\n> > > On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham wrote:\n> > > >\n> > > > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > > > >\n> > > > > > > > > > Any thoughts anyone?\n> > > > > > > > >\n> > > > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > > > the case :-(\n> > > > > > > > >\n> > > > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > > > gets released.\n> >\n> > Is there an urgency? Is there a requirement to move to QT6 for Fedora or\n> > otherwise?\n> >\n> > > > > > > >\n> > > > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > > > >\n> > > > > > > > I would propose that the meson version update is separated from the\n> > > > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > > > >\n> > > > > > >\n> > > > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > > > itself.\n> > > > > >\n> > > > > > That's an interesting take too.\n> > > > > >\n> > > > > > Which one is the chicken and which one is the egg?\n> > > > > >\n> > > > > > Our early requirement for meeting the dependencies in the distributions\n> > > > > > was because the distributions themselves were not including libcamera.\n> > > > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > > > >\n> > > > > > Now that things can be included, perhaps that's reason enough to say\n> > > > > > aiming for integration is better.\n> > > > > >\n> > > > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > > > >\n> > > > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > > > >\n> > > > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > > > is better than working on /top/ of it.\n> > > > > >\n> > > > > > The expense/cost is that in between we would no longer support compiling\n> > > > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > > > Ubuntu.\n> > > > > >\n> > > > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > > > next release.\n> > > > > >\n> > > > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > > > The question is what will happen to others ... and maybe it's just\n> > > > > > something we should bite and help them upgrade meson in the interim.\n> > > > > >\n> > > > >\n> > > > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > > > >\n> > > > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > > > 22.04 until 24.04 is released if it would help you:\n> > > > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> > > >\n> > > > Is there an official Ubuntu channel for that? If you can make\n> > > > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > > > being merged already!\n> > > >\n> > >\n> > > No. At this point, it would be unlikely to get updated unless you know\n> > > someone who can ship something in jammy-backports. But even then, with\n> > > 24.04 coming in a few months, 22.04 has been in its zombie period for\n> > > a while now. Typically, the expectation is that you either use later\n> > > Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> > > or backport what you need while you wait for the next LTS.\n> > >\n> > > If you intend to hold back the patch until after 24.04 releases, then\n> > > there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> > > think would be a shame. I prepared a backport for meson for Ubuntu\n> > > 22.04 because you said it would help you for developing on 22.04. I am\n> >\n> > I myself am quite capable of updating meson. I was highlighting that\n> > there are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\n> > to make sure that libcamera can be built on the 'main distributions'.\n> > For which we define that as 'the latest LTS of the big distros'.\n> >\n> > My question above was because it sounded like you could get that solved\n> > by fixing the one remaining stuck-in-the-past distro which is blocking\n> > us.\n> >\n> > \"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n> >\n> > And if you could do that - there would be nothing blocking the patch!\n> >\n> \n> Unfortunately, not in Ubuntu proper. I did it outside of the distribution.\n> \n> It's actually very hard to get a backport of Meson through because it\n> is not behavior-stable across releases. This is incredibly important\n> for Debian and Ubuntu, which is likely why Meson almost never sees\n> official backports. Even CentOS Meson upgrades required a lot of work\n> to bend new releases to be more backward compatible so nothing would\n> break.\n\nI don't know if it can help convincing Ubuntu, but Debian has the\nfollowing meson versions:\n\nbullseye (oldstable) (devel): high-productivity build system\n0.56.2-1: all\n\nbullseye-backports (devel): high-productivity build system\n1.0.0-1.1~bpo11+1: all \n\n> > > not about to ask you to move to Fedora (which is what I use) or CentOS\n> > > Stream 9 (which would be an analogous LTS that does have a recent\n> > > enough Meson).\n> > >\n> > > My only argument at this point is that you can choose to include the\n> > > patch now and make a release so it can land in Debian sid now, and\n> > > thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> > > it. From my perspective, I want this so that Fedora users and later\n> > > CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n> >\n> > The question for us though is how many people's set ups will we break by\n> > updating and merging this patch? I don't know the answer - it could be a\n> > handfull or less, which may be worth the 'short term' support cost.\n> > Maybe its none (one including me?) Or maybe its more? We don't have a\n> > way to know until they shout angrily ...\n> \n> I think realistically most people use libcamera from the distributions\n> themselves. And in Debian and Ubuntu, libcamera is not updated in\n> stable releases at all. If people are trying to use updated libcamera\n> on those distributions, then they are either 1) building from source\n> or 2) installing a third party build. In both scenarios, handling a\n> meson upgrade is probably reasonable.\n> \n> > > folks would benefit from it because it's one less thing depending on\n> > > essentially unsupported versions of Qt.\n> >\n> > I don't disagree. Hence earlier - which is the chicken, and which is the\n> > egg ...\n> \n> 🤷‍♂️","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E881BDC71\n\tfor ;\n\tTue, 23 Jan 2024 00:19:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EEA7628B7;\n\tTue, 23 Jan 2024 01:19:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC3C261D46\n\tfor ;\n\tTue, 23 Jan 2024 01:19:22 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42BB91583;\n\tTue, 23 Jan 2024 01:18:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H2zXNzzI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705969089;\n\tbh=efvGJR0+66r/606sSARVOx4bGwEyK5xkZISFCytEpVs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H2zXNzzIehiHrDWOlWSHKDxRpQM1u+6bafEGLvYys3N3IE3kh/vSjQRwHrKpuJMal\n\ttZVUg/OvTk3N7jGLN/t8t3wTst7W1ChsnpD1a733D/GOVjqGaTD8RrA+gq7QpAHBIi\n\t3RhR83RoquvJFqIlGehn7LzuIjF/zGKPxRVm0p5k=","Date":"Tue, 23 Jan 2024 02:19:25 +0200","From":"Laurent Pinchart ","To":"Neal Gompa ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","Message-ID":"<20240123001925.GD10843@pendragon.ideasonboard.com>","References":"<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t\n\t<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28571,"web_url":"https://patchwork.libcamera.org/comment/28571/","msgid":"<1b3b5c517cc2b961dbaba1cf19bcb3e255c9973f.camel@irl.hu>","date":"2024-01-23T00:21:07","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":183,"url":"https://patchwork.libcamera.org/api/people/183/","name":"Gergo Koteles","email":"soyer@irl.hu"},"content":"On Mon, 2024-01-22 at 17:40 -0500, Neal Gompa wrote:\n> On Mon, Jan 22, 2024 at 5:31 PM Kieran Bingham\n> wrote:\n> > \n> > Quoting Neal Gompa (2024-01-22 19:55:20)\n> > > On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham\n> > > wrote:\n> > > > \n> > > > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > > > > \n> > > > > > > > > > Any thoughts anyone?\n> > > > > > > > > \n> > > > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > > > the case :-(\n> > > > > > > > > \n> > > > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > > > gets released.\n> > \n> > Is there an urgency? Is there a requirement to move to QT6 for Fedora or\n> > otherwise?\n> > \n> > > > > > > > \n> > > > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > > > > \n> > > > > > > > I would propose that the meson version update is separated from the\n> > > > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > > > > \n> > > > > > > \n> > > > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > > > itself.\n> > > > > > \n> > > > > > That's an interesting take too.\n> > > > > > \n> > > > > > Which one is the chicken and which one is the egg?\n> > > > > > \n> > > > > > Our early requirement for meeting the dependencies in the distributions\n> > > > > > was because the distributions themselves were not including libcamera.\n> > > > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > > > > \n> > > > > > Now that things can be included, perhaps that's reason enough to say\n> > > > > > aiming for integration is better.\n> > > > > > \n> > > > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > > > > \n> > > > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > > > > \n> > > > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > > > is better than working on /top/ of it.\n> > > > > > \n> > > > > > The expense/cost is that in between we would no longer support compiling\n> > > > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > > > Ubuntu.\n> > > > > > \n> > > > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > > > next release.\n> > > > > > \n> > > > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > > > The question is what will happen to others ... and maybe it's just\n> > > > > > something we should bite and help them upgrade meson in the interim.\n> > > > > > \n> > > > > \n> > > > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > > > > \n> > > > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > > > 22.04 until 24.04 is released if it would help you:\n> > > > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> > > > \n> > > > Is there an official Ubuntu channel for that? If you can make\n> > > > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > > > being merged already!\n> > > > \n> > > \n> > > No. At this point, it would be unlikely to get updated unless you know\n> > > someone who can ship something in jammy-backports. But even then, with\n> > > 24.04 coming in a few months, 22.04 has been in its zombie period for\n> > > a while now. Typically, the expectation is that you either use later\n> > > Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> > > or backport what you need while you wait for the next LTS.\n> > > \n> > > If you intend to hold back the patch until after 24.04 releases, then\n> > > there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> > > think would be a shame. I prepared a backport for meson for Ubuntu\n> > > 22.04 because you said it would help you for developing on 22.04. I am\n> > \n> > I myself am quite capable of updating meson. I was highlighting that\n> > there are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\n> > to make sure that libcamera can be built on the 'main distributions'.\n> > For which we define that as 'the latest LTS of the big distros'.\n> > \n> > My question above was because it sounded like you could get that solved\n> > by fixing the one remaining stuck-in-the-past distro which is blocking\n> > us.\n> > \n> > \"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n> > \n> > And if you could do that - there would be nothing blocking the patch!\n> > \n> \n> Unfortunately, not in Ubuntu proper. I did it outside of the distribution.\n> \n> It's actually very hard to get a backport of Meson through because it\n> is not behavior-stable across releases. This is incredibly important\n> for Debian and Ubuntu, which is likely why Meson almost never sees\n> official backports. Even CentOS Meson upgrades required a lot of work\n> to bend new releases to be more backward compatible so nothing would\n> break.\n> \n> > > not about to ask you to move to Fedora (which is what I use) or CentOS\n> > > Stream 9 (which would be an analogous LTS that does have a recent\n> > > enough Meson).\n> > > \n> > > My only argument at this point is that you can choose to include the\n> > > patch now and make a release so it can land in Debian sid now, and\n> > > thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> > > it. From my perspective, I want this so that Fedora users and later\n> > > CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n> > \n> > The question for us though is how many people's set ups will we break by\n> > updating and merging this patch? I don't know the answer - it could be a\n> > handfull or less, which may be worth the 'short term' support cost.\n> > Maybe its none (one including me?) Or maybe its more? We don't have a\n> > way to know until they shout angrily ...\n> > \n> > \n> \n> I think realistically most people use libcamera from the distributions\n> themselves. And in Debian and Ubuntu, libcamera is not updated in\n> stable releases at all. If people are trying to use updated libcamera\n> on those distributions, then they are either 1) building from source\n> or 2) installing a third party build. In both scenarios, handling a\n> meson upgrade is probably reasonable.\n> \n> > > folks would benefit from it because it's one less thing depending on\n> > > essentially unsupported versions of Qt.\n> > \n> > I don't disagree. Hence earlier - which is the chicken, and which is the\n> > egg ...\n> \n> 🤷‍♂️\n> \n> \n\nWhy not support both Qt5 and Qt6 for about a year? Drop Qt5 then?\nUse Qt5 if meson is old, otherwise use Qt6.\n\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C65B5BDC71\n\tfor ;\n\tTue, 23 Jan 2024 00:21:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B09E62936;\n\tTue, 23 Jan 2024 01:21:10 +0100 (CET)","from irl.hu (irl.hu [95.85.9.111])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A3B1628B7\n\tfor ;\n\tTue, 23 Jan 2024 01:21:09 +0100 (CET)","from [192.168.2.4] (51b68f75.dsl.pool.telekom.hu\n\t[::ffff:81.182.143.117]) (AUTH: CRAM-MD5 soyer@irl.hu, )\n\tby irl.hu with ESMTPSA\n\tid 0000000000073813.0000000065AF0674.00185722;\n\tTue, 23 Jan 2024 01:21:08 +0100"],"Message-ID":"<1b3b5c517cc2b961dbaba1cf19bcb3e255c9973f.camel@irl.hu>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Gergo Koteles ","To":"Neal Gompa ,\n\tKieran Bingham ","Date":"Tue, 23 Jan 2024 01:21:07 +0100","In-Reply-To":"","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t\n\t<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.50.3 (3.50.3-1.fc39) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28574,"web_url":"https://patchwork.libcamera.org/comment/28574/","msgid":"","date":"2024-01-23T01:14:10","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 7:21 PM Gergo Koteles wrote:\n>\n> On Mon, 2024-01-22 at 17:40 -0500, Neal Gompa wrote:\n> > On Mon, Jan 22, 2024 at 5:31 PM Kieran Bingham\n> > wrote:\n> > >\n> > > Quoting Neal Gompa (2024-01-22 19:55:20)\n> > > > On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham\n> > > > wrote:\n> > > > >\n> > > > > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > > > > >\n> > > > > > > > > > > Any thoughts anyone?\n> > > > > > > > > >\n> > > > > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > > > > the case :-(\n> > > > > > > > > >\n> > > > > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > > > > gets released.\n> > >\n> > > Is there an urgency? Is there a requirement to move to QT6 for Fedora or\n> > > otherwise?\n> > >\n> > > > > > > > >\n> > > > > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > > > > >\n> > > > > > > > > I would propose that the meson version update is separated from the\n> > > > > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > > > > >\n> > > > > > > >\n> > > > > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > > > > itself.\n> > > > > > >\n> > > > > > > That's an interesting take too.\n> > > > > > >\n> > > > > > > Which one is the chicken and which one is the egg?\n> > > > > > >\n> > > > > > > Our early requirement for meeting the dependencies in the distributions\n> > > > > > > was because the distributions themselves were not including libcamera.\n> > > > > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > > > > >\n> > > > > > > Now that things can be included, perhaps that's reason enough to say\n> > > > > > > aiming for integration is better.\n> > > > > > >\n> > > > > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > > > > >\n> > > > > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > > > > >\n> > > > > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > > > > is better than working on /top/ of it.\n> > > > > > >\n> > > > > > > The expense/cost is that in between we would no longer support compiling\n> > > > > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > > > > Ubuntu.\n> > > > > > >\n> > > > > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > > > > next release.\n> > > > > > >\n> > > > > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > > > > The question is what will happen to others ... and maybe it's just\n> > > > > > > something we should bite and help them upgrade meson in the interim.\n> > > > > > >\n> > > > > >\n> > > > > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > > > > >\n> > > > > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > > > > 22.04 until 24.04 is released if it would help you:\n> > > > > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> > > > >\n> > > > > Is there an official Ubuntu channel for that? If you can make\n> > > > > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > > > > being merged already!\n> > > > >\n> > > >\n> > > > No. At this point, it would be unlikely to get updated unless you know\n> > > > someone who can ship something in jammy-backports. But even then, with\n> > > > 24.04 coming in a few months, 22.04 has been in its zombie period for\n> > > > a while now. Typically, the expectation is that you either use later\n> > > > Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> > > > or backport what you need while you wait for the next LTS.\n> > > >\n> > > > If you intend to hold back the patch until after 24.04 releases, then\n> > > > there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> > > > think would be a shame. I prepared a backport for meson for Ubuntu\n> > > > 22.04 because you said it would help you for developing on 22.04. I am\n> > >\n> > > I myself am quite capable of updating meson. I was highlighting that\n> > > there are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\n> > > to make sure that libcamera can be built on the 'main distributions'.\n> > > For which we define that as 'the latest LTS of the big distros'.\n> > >\n> > > My question above was because it sounded like you could get that solved\n> > > by fixing the one remaining stuck-in-the-past distro which is blocking\n> > > us.\n> > >\n> > > \"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n> > >\n> > > And if you could do that - there would be nothing blocking the patch!\n> > >\n> >\n> > Unfortunately, not in Ubuntu proper. I did it outside of the distribution.\n> >\n> > It's actually very hard to get a backport of Meson through because it\n> > is not behavior-stable across releases. This is incredibly important\n> > for Debian and Ubuntu, which is likely why Meson almost never sees\n> > official backports. Even CentOS Meson upgrades required a lot of work\n> > to bend new releases to be more backward compatible so nothing would\n> > break.\n> >\n> > > > not about to ask you to move to Fedora (which is what I use) or CentOS\n> > > > Stream 9 (which would be an analogous LTS that does have a recent\n> > > > enough Meson).\n> > > >\n> > > > My only argument at this point is that you can choose to include the\n> > > > patch now and make a release so it can land in Debian sid now, and\n> > > > thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> > > > it. From my perspective, I want this so that Fedora users and later\n> > > > CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n> > >\n> > > The question for us though is how many people's set ups will we break by\n> > > updating and merging this patch? I don't know the answer - it could be a\n> > > handfull or less, which may be worth the 'short term' support cost.\n> > > Maybe its none (one including me?) Or maybe its more? We don't have a\n> > > way to know until they shout angrily ...\n> > >\n> > >\n> >\n> > I think realistically most people use libcamera from the distributions\n> > themselves. And in Debian and Ubuntu, libcamera is not updated in\n> > stable releases at all. If people are trying to use updated libcamera\n> > on those distributions, then they are either 1) building from source\n> > or 2) installing a third party build. In both scenarios, handling a\n> > meson upgrade is probably reasonable.\n> >\n> > > > folks would benefit from it because it's one less thing depending on\n> > > > essentially unsupported versions of Qt.\n> > >\n> > > I don't disagree. Hence earlier - which is the chicken, and which is the\n> > > egg ...\n> >\n> > 🤷‍♂️\n> >\n> >\n>\n> Why not support both Qt5 and Qt6 for about a year? Drop Qt5 then?\n> Use Qt5 if meson is old, otherwise use Qt6.\n>\n\nTwo problems with it:\n\n1. It's a lot of complexity for the meson scripts\n2. Open Source Qt 5 is EOL. It's super-EOL now that both Qt 6.2 LTS\nand Qt 6.5 LTS are available. KDE itself requires Qt 6.6 now. Qt 6.7\nis coming in March!\n\nIf I were going to do anything, I'd make qcam conditional on newer\nmeson instead until we can drop that once everyone developing\nlibcamera on Ubuntu 22.04 moves to Ubuntu 24.04.\n\nBut I still think we should bite the bullet, land this, and get a\nrelease that can be included in 24.04.\n\n\n\n\n--\n真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 651E3C32BC\n\tfor ;\n\tTue, 23 Jan 2024 01:14:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7A7B62948;\n\tTue, 23 Jan 2024 02:14:51 +0100 (CET)","from mail-lf1-f45.google.com (mail-lf1-f45.google.com\n\t[209.85.167.45])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1D3861D46\n\tfor ;\n\tTue, 23 Jan 2024 02:14:49 +0100 (CET)","by mail-lf1-f45.google.com with SMTP id\n\t2adb3069b0e04-50f1c524010so3710657e87.3\n\tfor ;\n\tMon, 22 Jan 2024 17:14:49 -0800 (PST)","from mail-wm1-f50.google.com (mail-wm1-f50.google.com.\n\t[209.85.128.50]) by smtp.gmail.com with ESMTPSA id\n\tf1-20020a1709062c4100b00a2cfb31290fsm12094455ejh.191.2024.01.22.17.14.48\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 22 Jan 2024 17:14:48 -0800 (PST)","by mail-wm1-f50.google.com with SMTP id\n\t5b1f17b1804b1-40eb28271f8so8239835e9.2\n\tfor ;\n\tMon, 22 Jan 2024 17:14:48 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705972489; x=1706577289;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=k0yFJH4Zk2kkM58ZHz4Qktn0ciWfHKnAAfIhhK2bxnU=;\n\tb=hgbA3MJjbyJ7qXs4M589A/i881ml3UMzKmh6F1MaMtgNlt87gWLI70jMeP1bOuykhY\n\ttOUf9J94M6DSxAQMKL1TpGSCPNIPJSxYz9LgENgx2zkY7HZTFOTQtGRAab8Nb7mV846d\n\tVlafvZESEFMRkgKCC7qNH7HZuiq7Ll97yF86tJ3pw24tLNMcrH3Gi/n4tPafbDrMJm1m\n\tiKAUH2dyaF7On5YQlw9HUcBjx1wg3DHxHirXIwfDj3Za86orwzOLkkFQA4ms6UXKziGq\n\tJtABdtkzNKgKeSBrubomf8gsHd4d/wIIqtYVo9A3yU3RlF/6q9yGX+syCNeR8mVVxCC2\n\tNzAg==","X-Gm-Message-State":"AOJu0YzJYKZhYJlu389noO0qI3UoEZwYI8b87eftW7Lw5iVdQSPIv3PL\n\tme67aWw25RkhI6BOlJytHuXEudRO2Yc+EMGMrHkJupe0xBNntNPqc+0fa9mkitB6Pg==","X-Google-Smtp-Source":"AGHT+IFqWnZEPwGw+m5qIXaOlWybhUnTkC+QYGe1ja3npF+Ikm1K36uYymWDTUN4IEWll53SVq/vIA==","X-Received":["by 2002:a05:6512:2312:b0:50e:700:bdbb with SMTP id\n\to18-20020a056512231200b0050e0700bdbbmr1266269lfu.21.1705972488391; \n\tMon, 22 Jan 2024 17:14:48 -0800 (PST)","by 2002:a05:600c:35d1:b0:40e:4a2c:c891 with SMTP id\n\tr17-20020a05600c35d100b0040e4a2cc891mr28419wmq.200.1705972487921;\n\tMon, 22 Jan 2024 17:14:47 -0800 (PST)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<170591631363.1676185.7868288900547507483@ping.linuxembedded.co.uk>\n\t<20240122095339.GM4378@pendragon.ideasonboard.com>\n\t<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t\n\t<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>\n\t\n\t<1b3b5c517cc2b961dbaba1cf19bcb3e255c9973f.camel@irl.hu>","In-Reply-To":"<1b3b5c517cc2b961dbaba1cf19bcb3e255c9973f.camel@irl.hu>","From":"Neal Gompa ","Date":"Mon, 22 Jan 2024 20:14:10 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Gergo Koteles ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28575,"web_url":"https://patchwork.libcamera.org/comment/28575/","msgid":"<20240123013144.GE22880@pendragon.ideasonboard.com>","date":"2024-01-23T01:31:44","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 08:14:10PM -0500, Neal Gompa wrote:\n> On Mon, Jan 22, 2024 at 7:21 PM Gergo Koteles wrote:\n> > On Mon, 2024-01-22 at 17:40 -0500, Neal Gompa wrote:\n> > > On Mon, Jan 22, 2024 at 5:31 PM Kieran Bingham wrote:\n> > > > Quoting Neal Gompa (2024-01-22 19:55:20)\n> > > > > On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham wrote:\n> > > > > >\n> > > > > > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > > > > > >\n> > > > > > > > > > > > Any thoughts anyone?\n> > > > > > > > > > >\n> > > > > > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > > > > > the case :-(\n> > > > > > > > > > >\n> > > > > > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > > > > > gets released.\n> > > >\n> > > > Is there an urgency? Is there a requirement to move to QT6 for Fedora or\n> > > > otherwise?\n> > > >\n> > > > > > > > > >\n> > > > > > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > > > > > >\n> > > > > > > > > > I would propose that the meson version update is separated from the\n> > > > > > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > > > > > >\n> > > > > > > > >\n> > > > > > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > > > > > itself.\n> > > > > > > >\n> > > > > > > > That's an interesting take too.\n> > > > > > > >\n> > > > > > > > Which one is the chicken and which one is the egg?\n> > > > > > > >\n> > > > > > > > Our early requirement for meeting the dependencies in the distributions\n> > > > > > > > was because the distributions themselves were not including libcamera.\n> > > > > > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > > > > > >\n> > > > > > > > Now that things can be included, perhaps that's reason enough to say\n> > > > > > > > aiming for integration is better.\n> > > > > > > >\n> > > > > > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > > > > > >\n> > > > > > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > > > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > > > > > >\n> > > > > > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > > > > > is better than working on /top/ of it.\n> > > > > > > >\n> > > > > > > > The expense/cost is that in between we would no longer support compiling\n> > > > > > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > > > > > Ubuntu.\n> > > > > > > >\n> > > > > > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > > > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > > > > > next release.\n> > > > > > > >\n> > > > > > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > > > > > The question is what will happen to others ... and maybe it's just\n> > > > > > > > something we should bite and help them upgrade meson in the interim.\n> > > > > > >\n> > > > > > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > > > > > >\n> > > > > > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > > > > > 22.04 until 24.04 is released if it would help you:\n> > > > > > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> > > > > >\n> > > > > > Is there an official Ubuntu channel for that? If you can make\n> > > > > > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > > > > > being merged already!\n> > > > >\n> > > > > No. At this point, it would be unlikely to get updated unless you know\n> > > > > someone who can ship something in jammy-backports. But even then, with\n> > > > > 24.04 coming in a few months, 22.04 has been in its zombie period for\n> > > > > a while now. Typically, the expectation is that you either use later\n> > > > > Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> > > > > or backport what you need while you wait for the next LTS.\n> > > > >\n> > > > > If you intend to hold back the patch until after 24.04 releases, then\n> > > > > there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> > > > > think would be a shame. I prepared a backport for meson for Ubuntu\n> > > > > 22.04 because you said it would help you for developing on 22.04. I am\n> > > >\n> > > > I myself am quite capable of updating meson. I was highlighting that\n> > > > there are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\n> > > > to make sure that libcamera can be built on the 'main distributions'.\n> > > > For which we define that as 'the latest LTS of the big distros'.\n> > > >\n> > > > My question above was because it sounded like you could get that solved\n> > > > by fixing the one remaining stuck-in-the-past distro which is blocking\n> > > > us.\n> > > >\n> > > > \"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n> > > >\n> > > > And if you could do that - there would be nothing blocking the patch!\n> > >\n> > > Unfortunately, not in Ubuntu proper. I did it outside of the distribution.\n> > >\n> > > It's actually very hard to get a backport of Meson through because it\n> > > is not behavior-stable across releases. This is incredibly important\n> > > for Debian and Ubuntu, which is likely why Meson almost never sees\n> > > official backports. Even CentOS Meson upgrades required a lot of work\n> > > to bend new releases to be more backward compatible so nothing would\n> > > break.\n> > >\n> > > > > not about to ask you to move to Fedora (which is what I use) or CentOS\n> > > > > Stream 9 (which would be an analogous LTS that does have a recent\n> > > > > enough Meson).\n> > > > >\n> > > > > My only argument at this point is that you can choose to include the\n> > > > > patch now and make a release so it can land in Debian sid now, and\n> > > > > thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> > > > > it. From my perspective, I want this so that Fedora users and later\n> > > > > CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n> > > >\n> > > > The question for us though is how many people's set ups will we break by\n> > > > updating and merging this patch? I don't know the answer - it could be a\n> > > > handfull or less, which may be worth the 'short term' support cost.\n> > > > Maybe its none (one including me?) Or maybe its more? We don't have a\n> > > > way to know until they shout angrily ...\n> > >\n> > > I think realistically most people use libcamera from the distributions\n> > > themselves. And in Debian and Ubuntu, libcamera is not updated in\n> > > stable releases at all. If people are trying to use updated libcamera\n> > > on those distributions, then they are either 1) building from source\n> > > or 2) installing a third party build. In both scenarios, handling a\n> > > meson upgrade is probably reasonable.\n> > >\n> > > > > folks would benefit from it because it's one less thing depending on\n> > > > > essentially unsupported versions of Qt.\n> > > >\n> > > > I don't disagree. Hence earlier - which is the chicken, and which is the\n> > > > egg ...\n> > >\n> > > 🤷‍♂️\n> >\n> > Why not support both Qt5 and Qt6 for about a year? Drop Qt5 then?\n> > Use Qt5 if meson is old, otherwise use Qt6.\n> \n> Two problems with it:\n> \n> 1. It's a lot of complexity for the meson scripts\n> 2. Open Source Qt 5 is EOL. It's super-EOL now that both Qt 6.2 LTS\n> and Qt 6.5 LTS are available. KDE itself requires Qt 6.6 now. Qt 6.7\n> is coming in March!\n> \n> If I were going to do anything, I'd make qcam conditional on newer\n> meson instead until we can drop that once everyone developing\n> libcamera on Ubuntu 22.04 moves to Ubuntu 24.04.\n\nmeson doesn't allow using features of versions higher than the one\nlisted in the project() call, even if you make such usage conditional on\nthe meson version. If we're lucky, we'll only get a warning with older\nmeson versions, this could be tested if desired.\n\n> But I still think we should bite the bullet, land this, and get a\n> release that can be included in 24.04.\n\nI still don't get the urgency to be honest. Yes, Qt5 is EOL, but it will\nstill be shipped by Ubuntu 24.04, won't it ? Beside, qcam is meant to be\na test application for development only. And if it's really important\nfor Ubuntu 24.04 to ship a Qt6-based qcam, why can't it bump the\nlibcamera version later ? And what about users who rely on Qt5, don't\nthey deserve more than a week notice before we switch ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D4CBBDC71\n\tfor ;\n\tTue, 23 Jan 2024 01:31:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DF886291F;\n\tTue, 23 Jan 2024 02:31:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A6C861D46\n\tfor ;\n\tTue, 23 Jan 2024 02:31:41 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8340E4;\n\tTue, 23 Jan 2024 02:30:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qiayq9QC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705973428;\n\tbh=FZv7uqVuD1GhCoiiqcJez3MO40mFw9Zpf1IqFnYeMLg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Qiayq9QCCts9ZBxSKdj08GXehZ/agBg81fqWE6wRwgaaiCZFqMqiFe1rfCFRuJuoY\n\tRWT8sd3LXFwBavuZRGH3X186xxNo/CsRDGpIl/G2D09O02VGA69HR5VCyfPlf1jjm+\n\t9aT8pwqdIT7hAQrmdrI7NqaZyS8xkcUpwOoLaoPc=","Date":"Tue, 23 Jan 2024 03:31:44 +0200","From":"Laurent Pinchart ","To":"Neal Gompa ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","Message-ID":"<20240123013144.GE22880@pendragon.ideasonboard.com>","References":"<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t\n\t<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>\n\t\n\t<1b3b5c517cc2b961dbaba1cf19bcb3e255c9973f.camel@irl.hu>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28618,"web_url":"https://patchwork.libcamera.org/comment/28618/","msgid":"","date":"2024-01-23T22:01:43","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Mon, Jan 22, 2024 at 8:31 PM Laurent Pinchart\n wrote:\n>\n> On Mon, Jan 22, 2024 at 08:14:10PM -0500, Neal Gompa wrote:\n> > On Mon, Jan 22, 2024 at 7:21 PM Gergo Koteles wrote:\n> > > On Mon, 2024-01-22 at 17:40 -0500, Neal Gompa wrote:\n> > > > On Mon, Jan 22, 2024 at 5:31 PM Kieran Bingham wrote:\n> > > > > Quoting Neal Gompa (2024-01-22 19:55:20)\n> > > > > > On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham wrote:\n> > > > > > >\n> > > > > > > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > > > > > > >\n> > > > > > > > > > > > > Any thoughts anyone?\n> > > > > > > > > > > >\n> > > > > > > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > > > > > > the case :-(\n> > > > > > > > > > > >\n> > > > > > > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > > > > > > gets released.\n> > > > >\n> > > > > Is there an urgency? Is there a requirement to move to QT6 for Fedora or\n> > > > > otherwise?\n> > > > >\n> > > > > > > > > > >\n> > > > > > > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > > > > > > >\n> > > > > > > > > > > I would propose that the meson version update is separated from the\n> > > > > > > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > > > > > > >\n> > > > > > > > > >\n> > > > > > > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > > > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > > > > > > itself.\n> > > > > > > > >\n> > > > > > > > > That's an interesting take too.\n> > > > > > > > >\n> > > > > > > > > Which one is the chicken and which one is the egg?\n> > > > > > > > >\n> > > > > > > > > Our early requirement for meeting the dependencies in the distributions\n> > > > > > > > > was because the distributions themselves were not including libcamera.\n> > > > > > > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > > > > > > >\n> > > > > > > > > Now that things can be included, perhaps that's reason enough to say\n> > > > > > > > > aiming for integration is better.\n> > > > > > > > >\n> > > > > > > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > > > > > > >\n> > > > > > > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > > > > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > > > > > > >\n> > > > > > > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > > > > > > is better than working on /top/ of it.\n> > > > > > > > >\n> > > > > > > > > The expense/cost is that in between we would no longer support compiling\n> > > > > > > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > > > > > > Ubuntu.\n> > > > > > > > >\n> > > > > > > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > > > > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > > > > > > next release.\n> > > > > > > > >\n> > > > > > > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > > > > > > The question is what will happen to others ... and maybe it's just\n> > > > > > > > > something we should bite and help them upgrade meson in the interim.\n> > > > > > > >\n> > > > > > > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > > > > > > >\n> > > > > > > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > > > > > > 22.04 until 24.04 is released if it would help you:\n> > > > > > > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> > > > > > >\n> > > > > > > Is there an official Ubuntu channel for that? If you can make\n> > > > > > > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > > > > > > being merged already!\n> > > > > >\n> > > > > > No. At this point, it would be unlikely to get updated unless you know\n> > > > > > someone who can ship something in jammy-backports. But even then, with\n> > > > > > 24.04 coming in a few months, 22.04 has been in its zombie period for\n> > > > > > a while now. Typically, the expectation is that you either use later\n> > > > > > Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> > > > > > or backport what you need while you wait for the next LTS.\n> > > > > >\n> > > > > > If you intend to hold back the patch until after 24.04 releases, then\n> > > > > > there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> > > > > > think would be a shame. I prepared a backport for meson for Ubuntu\n> > > > > > 22.04 because you said it would help you for developing on 22.04. I am\n> > > > >\n> > > > > I myself am quite capable of updating meson. I was highlighting that\n> > > > > there are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\n> > > > > to make sure that libcamera can be built on the 'main distributions'.\n> > > > > For which we define that as 'the latest LTS of the big distros'.\n> > > > >\n> > > > > My question above was because it sounded like you could get that solved\n> > > > > by fixing the one remaining stuck-in-the-past distro which is blocking\n> > > > > us.\n> > > > >\n> > > > > \"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n> > > > >\n> > > > > And if you could do that - there would be nothing blocking the patch!\n> > > >\n> > > > Unfortunately, not in Ubuntu proper. I did it outside of the distribution.\n> > > >\n> > > > It's actually very hard to get a backport of Meson through because it\n> > > > is not behavior-stable across releases. This is incredibly important\n> > > > for Debian and Ubuntu, which is likely why Meson almost never sees\n> > > > official backports. Even CentOS Meson upgrades required a lot of work\n> > > > to bend new releases to be more backward compatible so nothing would\n> > > > break.\n> > > >\n> > > > > > not about to ask you to move to Fedora (which is what I use) or CentOS\n> > > > > > Stream 9 (which would be an analogous LTS that does have a recent\n> > > > > > enough Meson).\n> > > > > >\n> > > > > > My only argument at this point is that you can choose to include the\n> > > > > > patch now and make a release so it can land in Debian sid now, and\n> > > > > > thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> > > > > > it. From my perspective, I want this so that Fedora users and later\n> > > > > > CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n> > > > >\n> > > > > The question for us though is how many people's set ups will we break by\n> > > > > updating and merging this patch? I don't know the answer - it could be a\n> > > > > handfull or less, which may be worth the 'short term' support cost.\n> > > > > Maybe its none (one including me?) Or maybe its more? We don't have a\n> > > > > way to know until they shout angrily ...\n> > > >\n> > > > I think realistically most people use libcamera from the distributions\n> > > > themselves. And in Debian and Ubuntu, libcamera is not updated in\n> > > > stable releases at all. If people are trying to use updated libcamera\n> > > > on those distributions, then they are either 1) building from source\n> > > > or 2) installing a third party build. In both scenarios, handling a\n> > > > meson upgrade is probably reasonable.\n> > > >\n> > > > > > folks would benefit from it because it's one less thing depending on\n> > > > > > essentially unsupported versions of Qt.\n> > > > >\n> > > > > I don't disagree. Hence earlier - which is the chicken, and which is the\n> > > > > egg ...\n> > > >\n> > > > 🤷‍♂️\n> > >\n> > > Why not support both Qt5 and Qt6 for about a year? Drop Qt5 then?\n> > > Use Qt5 if meson is old, otherwise use Qt6.\n> >\n> > Two problems with it:\n> >\n> > 1. It's a lot of complexity for the meson scripts\n> > 2. Open Source Qt 5 is EOL. It's super-EOL now that both Qt 6.2 LTS\n> > and Qt 6.5 LTS are available. KDE itself requires Qt 6.6 now. Qt 6.7\n> > is coming in March!\n> >\n> > If I were going to do anything, I'd make qcam conditional on newer\n> > meson instead until we can drop that once everyone developing\n> > libcamera on Ubuntu 22.04 moves to Ubuntu 24.04.\n>\n> meson doesn't allow using features of versions higher than the one\n> listed in the project() call, even if you make such usage conditional on\n> the meson version. If we're lucky, we'll only get a warning with older\n> meson versions, this could be tested if desired.\n>\n\nI've done it before in libportal, it's not out of the question. Mesa\ndoes this too for some features. It's awkward to do, but it's\npossible.\n\n> > But I still think we should bite the bullet, land this, and get a\n> > release that can be included in 24.04.\n>\n> I still don't get the urgency to be honest. Yes, Qt5 is EOL, but it will\n> still be shipped by Ubuntu 24.04, won't it ? Beside, qcam is meant to be\n> a test application for development only. And if it's really important\n> for Ubuntu 24.04 to ship a Qt6-based qcam, why can't it bump the\n> libcamera version later ? And what about users who rely on Qt5, don't\n> they deserve more than a week notice before we switch ?\n>\n\nThat assumes that Ubuntu updates libcamera post-freeze. Judging by\nwhat they did with PipeWire, I don't think that will happen.\n\nhttps://packages.ubuntu.com/search?suite=all§ion=all&arch=any&keywords=pipewire&searchon=sourcenames\n\nI'm saying it's important to everyone *using* Ubuntu, but that doesn't\nmean that Ubuntu *itself* cares about it. Right now, nobody uses\nlibcamera for anything meaningful in the main Linux distributions.\nSomeday, that will change as applications use PipeWire for camera\naccess.\n\nI don't think the switch from Qt5 to Qt6 for qcam would be\ngame-breaking for people, it should generally be an improvement,\nespecially since Qt 6 has significantly better Wayland support.\nFedora, RHEL/CentOS, Ubuntu, and Debian have desktops that default or\nexclusively use Wayland too.\n\nThe main issue brought up in this thread isn't about Qt though, it's\nabout Meson.\n\n\n\n\n\n\n--\n真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2553BDC71\n\tfor ;\n\tTue, 23 Jan 2024 22:02:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0979F62945;\n\tTue, 23 Jan 2024 23:02:24 +0100 (CET)","from mail-ej1-f41.google.com (mail-ej1-f41.google.com\n\t[209.85.218.41])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8931362916\n\tfor ;\n\tTue, 23 Jan 2024 23:02:22 +0100 (CET)","by mail-ej1-f41.google.com with SMTP id\n\ta640c23a62f3a-a2d7e2e7fe0so817303566b.1\n\tfor ;\n\tTue, 23 Jan 2024 14:02:22 -0800 (PST)","from mail-ed1-f46.google.com (mail-ed1-f46.google.com.\n\t[209.85.208.46]) by smtp.gmail.com with ESMTPSA id\n\tbt16-20020a170906b15000b00a2ada87f6a1sm14796237ejb.90.2024.01.23.14.02.21\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 23 Jan 2024 14:02:21 -0800 (PST)","by mail-ed1-f46.google.com with SMTP id\n\t4fb4d7f45d1cf-559f92bf7b6so8793498a12.0\n\tfor ;\n\tTue, 23 Jan 2024 14:02:21 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1706047342; x=1706652142;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Pf8HBhSPSsOYBCatQrTsMFlH6jM2C17m7YcoodA5qWs=;\n\tb=X39OPrf4mG3O20E9+LrMEkIoo97VTt2o+Gh8Tw2ou8rsR7NUFj98FG8MkfI8iBUgGS\n\tosH+5O+w1r3JBehzTimZybI53Fo58jofhBj8bmqX73XW4i8+HayXe7jk7rjF6toIP/Vy\n\tIjpqjJ92sKeW/AB6+4Sf8IWX69dKpRJFw10WhvPF0PBccSuhKBGbBy1VhIfeWw7ip1b3\n\tYmHLrPFqGDoVJGaYy5Mnojfa5MaTQem/G9ifZ4usMS1SUCKEry9aX/A88P7M9Ts//0+F\n\tWIrmVXrJcucSUIyxGcDMw18xjHw9hUI6Z7UqMog4trn5Fv+Is8W4ygvajHBu55CbygdG\n\tv/aA==","X-Gm-Message-State":"AOJu0YxoqjJ0q0NdvDtjQJIp2nDe4R+UfduDeJ1l2r5Ynv7DZ4LfQWyh\n\t5RKTEBUiawLPY09MF4P9pAYdE6e+NQX9tcr1srEWPNU5xHDfJw1lvEBrfvw3+6uAwQ==","X-Google-Smtp-Source":"AGHT+IGGYP52NKdvUJJKZSHnJSyhjDZk9gxW5/PPpK7HEb7GC8Ux8aPJ8qBpKCT/vp4Kc3FSjonTcg==","X-Received":["by 2002:a17:906:d79b:b0:a30:6576:3efe with SMTP id\n\tpj27-20020a170906d79b00b00a3065763efemr245994ejb.74.1706047341427; \n\tTue, 23 Jan 2024 14:02:21 -0800 (PST)","by 2002:a05:6402:1cb4:b0:55c:93c1:4a50 with SMTP id\n\tcz20-20020a0564021cb400b0055c93c14a50mr205992edb.13.1706047340964;\n\tTue, 23 Jan 2024 14:02:20 -0800 (PST)"],"MIME-Version":"1.0","References":"<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t\n\t<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>\n\t\n\t<1b3b5c517cc2b961dbaba1cf19bcb3e255c9973f.camel@irl.hu>\n\t\n\t<20240123013144.GE22880@pendragon.ideasonboard.com>","In-Reply-To":"<20240123013144.GE22880@pendragon.ideasonboard.com>","From":"Neal Gompa ","Date":"Tue, 23 Jan 2024 17:01:43 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28624,"web_url":"https://patchwork.libcamera.org/comment/28624/","msgid":"","date":"2024-01-25T00:50:25","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Tue, Jan 23, 2024 at 5:01 PM Neal Gompa wrote:\n>\n> On Mon, Jan 22, 2024 at 8:31 PM Laurent Pinchart\n> wrote:\n> >\n> > On Mon, Jan 22, 2024 at 08:14:10PM -0500, Neal Gompa wrote:\n> > > On Mon, Jan 22, 2024 at 7:21 PM Gergo Koteles wrote:\n> > > > On Mon, 2024-01-22 at 17:40 -0500, Neal Gompa wrote:\n> > > > > On Mon, Jan 22, 2024 at 5:31 PM Kieran Bingham wrote:\n> > > > > > Quoting Neal Gompa (2024-01-22 19:55:20)\n> > > > > > > On Mon, Jan 22, 2024 at 11:02 AM Kieran Bingham wrote:\n> > > > > > > >\n> > > > > > > > > > > > > > So it's just Ubuntu/Canonical holding us back here ...\n> > > > > > > > > > > > > >\n> > > > > > > > > > > > > > Any thoughts anyone?\n> > > > > > > > > > > > >\n> > > > > > > > > > > > > I was hoping jammy-backports would help us, but that doesn't seem to be\n> > > > > > > > > > > > > the case :-(\n> > > > > > > > > > > > >\n> > > > > > > > > > > > > As there doesn't seem to be an urgency to switch to Qt 6 (unless I'm\n> > > > > > > > > > > > > missing something), I'm tempted to propose waiting until Ubuntu 24.04\n> > > > > > > > > > > > > gets released.\n> > > > > >\n> > > > > > Is there an urgency? Is there a requirement to move to QT6 for Fedora or\n> > > > > > otherwise?\n> > > > > >\n> > > > > > > > > > > >\n> > > > > > > > > > > > Noble (24.04) will have either 1.2.1 or 1.3.1 (there are different\n> > > > > > > > > > > > versions in proposed and Release). Either way it will be > 1.2! :\n> > > > > > > > > > > > https://launchpad.net/ubuntu/noble/+package/meson\n> > > > > > > > > > > >\n> > > > > > > > > > > > I would propose that the meson version update is separated from the\n> > > > > > > > > > > > patch as a preceeding commit, and could already be resent. Then we can\n> > > > > > > > > > > > simply pick these in April. I'd probably say we could merge this in\n> > > > > > > > > > > > early April, such that we can make a release of libcamera with that\n> > > > > > > > > > > > support merged soon after Ubuntu 24.04 is released on April 25th.\n> > > > > > > > > > > >\n> > > > > > > > > > >\n> > > > > > > > > > > On the flip side, if it's merged and released into Debian before the\n> > > > > > > > > > > Ubuntu freeze on Feb 29[1], then it would be part of Ubuntu 24.04\n> > > > > > > > > > > itself.\n> > > > > > > > > >\n> > > > > > > > > > That's an interesting take too.\n> > > > > > > > > >\n> > > > > > > > > > Which one is the chicken and which one is the egg?\n> > > > > > > > > >\n> > > > > > > > > > Our early requirement for meeting the dependencies in the distributions\n> > > > > > > > > > was because the distributions themselves were not including libcamera.\n> > > > > > > > > > Therefore, users of libcamera /had/ to be able to build libcamera.\n> > > > > > > > > >\n> > > > > > > > > > Now that things can be included, perhaps that's reason enough to say\n> > > > > > > > > > aiming for integration is better.\n> > > > > > > > > >\n> > > > > > > > > > > [1]: https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649\n> > > > > > > > > >\n> > > > > > > > > > It looks like libcamera-0.2 is already included in the noble release, so\n> > > > > > > > > > package updates into debian look like they get into Ubuntu quite 'fast'.\n> > > > > > > > > >\n> > > > > > > > > > I feel like targetting getting /into/ the next Ubuntu LTS with updates\n> > > > > > > > > > is better than working on /top/ of it.\n> > > > > > > > > >\n> > > > > > > > > > The expense/cost is that in between we would no longer support compiling\n> > > > > > > > > > the master branch (or intermediate releases) with the 'current' LTS of\n> > > > > > > > > > Ubuntu.\n> > > > > > > > > >\n> > > > > > > > > > I could say \"Oh well, that probably doesn't matter\" ... except ... I use\n> > > > > > > > > > Ubuntu-22.04 as my main distro ... and I would plan to upgrade at the\n> > > > > > > > > > next release.\n> > > > > > > > > >\n> > > > > > > > > > I'm aware that I can work around this issue by upgrading meson myself.\n> > > > > > > > > > The question is what will happen to others ... and maybe it's just\n> > > > > > > > > > something we should bite and help them upgrade meson in the interim.\n> > > > > > > > >\n> > > > > > > > > Well, in a previous life I used to maintain Meson backports for Ubuntu.\n> > > > > > > > >\n> > > > > > > > > I'm happy to provide a package (based on the CentOS 9 one) for Ubuntu\n> > > > > > > > > 22.04 until 24.04 is released if it would help you:\n> > > > > > > > > https://software.opensuse.org//download.html?project=home%3APharaoh_Atem%3AMeson&package=meson\n> > > > > > > >\n> > > > > > > > Is there an official Ubuntu channel for that? If you can make\n> > > > > > > > 'ubuntu-22.04' support a later meson - I have no argument to prevent this\n> > > > > > > > being merged already!\n> > > > > > >\n> > > > > > > No. At this point, it would be unlikely to get updated unless you know\n> > > > > > > someone who can ship something in jammy-backports. But even then, with\n> > > > > > > 24.04 coming in a few months, 22.04 has been in its zombie period for\n> > > > > > > a while now. Typically, the expectation is that you either use later\n> > > > > > > Ubuntu STS releases (23.10 is a perfectly fine release, as an example)\n> > > > > > > or backport what you need while you wait for the next LTS.\n> > > > > > >\n> > > > > > > If you intend to hold back the patch until after 24.04 releases, then\n> > > > > > > there is no chance for this to be part of Ubuntu 24.04 itself, which I\n> > > > > > > think would be a shame. I prepared a backport for meson for Ubuntu\n> > > > > > > 22.04 because you said it would help you for developing on 22.04. I am\n> > > > > >\n> > > > > > I myself am quite capable of updating meson. I was highlighting that\n> > > > > > there are 'users' of Ubuntu 22.04. Our aim for libcamera has always been\n> > > > > > to make sure that libcamera can be built on the 'main distributions'.\n> > > > > > For which we define that as 'the latest LTS of the big distros'.\n> > > > > >\n> > > > > > My question above was because it sounded like you could get that solved\n> > > > > > by fixing the one remaining stuck-in-the-past distro which is blocking\n> > > > > > us.\n> > > > > >\n> > > > > > \"> Well, in a previous life I used to maintain Meson backports for Ubuntu.\"\n> > > > > >\n> > > > > > And if you could do that - there would be nothing blocking the patch!\n> > > > >\n> > > > > Unfortunately, not in Ubuntu proper. I did it outside of the distribution.\n> > > > >\n> > > > > It's actually very hard to get a backport of Meson through because it\n> > > > > is not behavior-stable across releases. This is incredibly important\n> > > > > for Debian and Ubuntu, which is likely why Meson almost never sees\n> > > > > official backports. Even CentOS Meson upgrades required a lot of work\n> > > > > to bend new releases to be more backward compatible so nothing would\n> > > > > break.\n> > > > >\n> > > > > > > not about to ask you to move to Fedora (which is what I use) or CentOS\n> > > > > > > Stream 9 (which would be an analogous LTS that does have a recent\n> > > > > > > enough Meson).\n> > > > > > >\n> > > > > > > My only argument at this point is that you can choose to include the\n> > > > > > > patch now and make a release so it can land in Debian sid now, and\n> > > > > > > thus make it into Ubuntu 24.04 so that Ubuntu users will benefit from\n> > > > > > > it. From my perspective, I want this so that Fedora users and later\n> > > > > > > CentOS 10 users will benefit from it. I also think that Debian/Ubuntu\n> > > > > >\n> > > > > > The question for us though is how many people's set ups will we break by\n> > > > > > updating and merging this patch? I don't know the answer - it could be a\n> > > > > > handfull or less, which may be worth the 'short term' support cost.\n> > > > > > Maybe its none (one including me?) Or maybe its more? We don't have a\n> > > > > > way to know until they shout angrily ...\n> > > > >\n> > > > > I think realistically most people use libcamera from the distributions\n> > > > > themselves. And in Debian and Ubuntu, libcamera is not updated in\n> > > > > stable releases at all. If people are trying to use updated libcamera\n> > > > > on those distributions, then they are either 1) building from source\n> > > > > or 2) installing a third party build. In both scenarios, handling a\n> > > > > meson upgrade is probably reasonable.\n> > > > >\n> > > > > > > folks would benefit from it because it's one less thing depending on\n> > > > > > > essentially unsupported versions of Qt.\n> > > > > >\n> > > > > > I don't disagree. Hence earlier - which is the chicken, and which is the\n> > > > > > egg ...\n> > > > >\n> > > > > 🤷‍♂️\n> > > >\n> > > > Why not support both Qt5 and Qt6 for about a year? Drop Qt5 then?\n> > > > Use Qt5 if meson is old, otherwise use Qt6.\n> > >\n> > > Two problems with it:\n> > >\n> > > 1. It's a lot of complexity for the meson scripts\n> > > 2. Open Source Qt 5 is EOL. It's super-EOL now that both Qt 6.2 LTS\n> > > and Qt 6.5 LTS are available. KDE itself requires Qt 6.6 now. Qt 6.7\n> > > is coming in March!\n> > >\n> > > If I were going to do anything, I'd make qcam conditional on newer\n> > > meson instead until we can drop that once everyone developing\n> > > libcamera on Ubuntu 22.04 moves to Ubuntu 24.04.\n> >\n> > meson doesn't allow using features of versions higher than the one\n> > listed in the project() call, even if you make such usage conditional on\n> > the meson version. If we're lucky, we'll only get a warning with older\n> > meson versions, this could be tested if desired.\n> >\n>\n> I've done it before in libportal, it's not out of the question. Mesa\n> does this too for some features. It's awkward to do, but it's\n> possible.\n>\n> > > But I still think we should bite the bullet, land this, and get a\n> > > release that can be included in 24.04.\n> >\n> > I still don't get the urgency to be honest. Yes, Qt5 is EOL, but it will\n> > still be shipped by Ubuntu 24.04, won't it ? Beside, qcam is meant to be\n> > a test application for development only. And if it's really important\n> > for Ubuntu 24.04 to ship a Qt6-based qcam, why can't it bump the\n> > libcamera version later ? And what about users who rely on Qt5, don't\n> > they deserve more than a week notice before we switch ?\n> >\n>\n> That assumes that Ubuntu updates libcamera post-freeze. Judging by\n> what they did with PipeWire, I don't think that will happen.\n>\n> https://packages.ubuntu.com/search?suite=all§ion=all&arch=any&keywords=pipewire&searchon=sourcenames\n>\n> I'm saying it's important to everyone *using* Ubuntu, but that doesn't\n> mean that Ubuntu *itself* cares about it. Right now, nobody uses\n> libcamera for anything meaningful in the main Linux distributions.\n> Someday, that will change as applications use PipeWire for camera\n> access.\n>\n> I don't think the switch from Qt5 to Qt6 for qcam would be\n> game-breaking for people, it should generally be an improvement,\n> especially since Qt 6 has significantly better Wayland support.\n> Fedora, RHEL/CentOS, Ubuntu, and Debian have desktops that default or\n> exclusively use Wayland too.\n>\n> The main issue brought up in this thread isn't about Qt though, it's\n> about Meson.\n>\n\nIn any case, you can choose to wait as long as you like. I've\nbackported this to Fedora's package. I was hoping it'd land now, but\nI'm fine with you waiting until after Ubuntu 24.04 releases if you\nwish to do so.\n\n\n\n\n--\n真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB295C323E\n\tfor ;\n\tThu, 25 Jan 2024 00:51:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD07C6295D;\n\tThu, 25 Jan 2024 01:51:05 +0100 (CET)","from mail-ej1-f52.google.com (mail-ej1-f52.google.com\n\t[209.85.218.52])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B19A461D28\n\tfor ;\n\tThu, 25 Jan 2024 01:51:04 +0100 (CET)","by mail-ej1-f52.google.com with SMTP id\n\ta640c23a62f3a-a27733ae1dfso640319366b.3\n\tfor ;\n\tWed, 24 Jan 2024 16:51:04 -0800 (PST)","from mail-wm1-f47.google.com (mail-wm1-f47.google.com.\n\t[209.85.128.47]) by smtp.gmail.com with ESMTPSA id\n\th23-20020a17090619d700b00a2c32c5f484sm422376ejd.209.2024.01.24.16.51.03\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 24 Jan 2024 16:51:03 -0800 (PST)","by mail-wm1-f47.google.com with SMTP id\n\t5b1f17b1804b1-40ec3535225so21283885e9.2\n\tfor ;\n\tWed, 24 Jan 2024 16:51:03 -0800 (PST)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1706143864; x=1706748664;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=JrQ4J4a+vYqRjrRvRh0t1rYH6INrGzDHMpQ4oZPKVrY=;\n\tb=n3Ga8NvCGYH/ZvzQ4vvM3V8PTSkdosh1ZL5ELEUXpeeXfuN360M8QQ8XYIltCx8aSR\n\tMr8eLbMjcerIJvxsQGq5OSz8XXeOWso2I96ADsL/SQEe9h74VrsVzGEN3D4yboC82m6w\n\t/B10L8HkskNhLnO0z6mmqglTTMKl/OCEbvk+9cCnHbmB+wPfOPdfEOVbe2eUircZ/Bux\n\t76hGYlOCJhyrBNQeRY7r8lVSOwIhHfI3DZTim79Xx+xnS00dBu3IE7XxLSMKfT26hub6\n\tJ4dK0SiiKAn0ZHSZbw/fFJIdnyQCmteKHn5X7Lm7mgTPDOOfOE2k8HdNWsvIVv14cH1/\n\teoWA==","X-Gm-Message-State":"AOJu0YxtiaQ3AQzKIvPjs7sxDBlsOJX2zyLwXHTv0CXGyRct++xI7WIT\n\tjtEks7FkvGVfPCLbQdec3jjZ9mZ5QndzSKcQwuMQsl+nem1Rdl3P9RkYvcFBPHsXwQ==","X-Google-Smtp-Source":"AGHT+IEKvgoUuOsAL7AIjZziK+aQPUeYCZDuGJidP1Kf1xON6m8Z9CdVWshCsFrIK8QQPH3S9XWOYA==","X-Received":["by 2002:a17:907:96aa:b0:a26:9d1c:a73f with SMTP id\n\thd42-20020a17090796aa00b00a269d1ca73fmr59376ejc.297.1706143863604; \n\tWed, 24 Jan 2024 16:51:03 -0800 (PST)","by 2002:a05:600c:4454:b0:40e:734a:741a with SMTP id\n\tv20-20020a05600c445400b0040e734a741amr19980wmn.14.1706143862779;\n\tWed, 24 Jan 2024 16:51:02 -0800 (PST)"],"MIME-Version":"1.0","References":"<170592122535.1676185.16603573107109517374@ping.linuxembedded.co.uk>\n\t\n\t<170592886597.1011926.599200205890870680@ping.linuxembedded.co.uk>\n\t\n\t<170593932804.1011926.15544929050341899308@ping.linuxembedded.co.uk>\n\t\n\t<170596268646.2763797.17367733594074610000@ping.linuxembedded.co.uk>\n\t\n\t<1b3b5c517cc2b961dbaba1cf19bcb3e255c9973f.camel@irl.hu>\n\t\n\t<20240123013144.GE22880@pendragon.ideasonboard.com>\n\t","In-Reply-To":"","From":"Neal Gompa ","Date":"Wed, 24 Jan 2024 19:50:25 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29239,"web_url":"https://patchwork.libcamera.org/comment/29239/","msgid":"<171329127567.749723.17933607914936082659@ping.linuxembedded.co.uk>","date":"2024-04-16T18:14:35","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> Open source Qt 5 has been effectively end of life since the release\n> of Qt 6, and Qt 6 has current LTS releases now.\n> \n> This change ports qcam to Qt 6.2 and drops some of the baggage related\n> to Qt 5 that is no longer applicable.\n> \n\nWith Ubuntu 24.04 release 'imminent' (as well as the next libcamera-0.3\nafter I can merge the softISP) I believe it's time to merge this patch.\n\nHowever ...\n\n\n\n> Signed-off-by: Neal Gompa \n> ---\n> README.rst | 2 +-\n> meson.build | 2 +-\n> src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> 3 files changed, 15 insertions(+), 34 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 315738ee..6f1c9302 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -88,7 +88,7 @@ for cam: [optional]\n> - libsdl2-dev: Enables the SDL sink\n> \n> for qcam: [optional]\n> - libtiff-dev qtbase5-dev qttools5-dev-tools\n> + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n\nHaving installed these packages - I still can't enable qcam. So we must\nbe missing some more dependencies that need to be listed here.\n\n\n--\nKieran\n\n\n> \n> for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n> diff --git a/meson.build b/meson.build\n> index cb6b666a..4c315e2a 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> project('libcamera', 'c', 'cpp',\n> - meson_version : '>= 0.60',\n> + meson_version : '>= 0.63',\n> version : '0.2.0',\n> default_options : [\n> 'werror=true',\n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index 6cf4c171..c7fcfbeb 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -1,13 +1,13 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -qt5 = import('qt5')\n> -qt5_dep = dependency('qt5',\n> +qt6 = import('qt6')\n> +qt6_dep = dependency('qt6',\n> method : 'pkg-config',\n> - modules : ['Core', 'Gui', 'Widgets'],\n> + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> required : get_option('qcam'),\n> - version : '>=5.4')\n> + version : '>=6.2')\n> \n> -if not qt5_dep.found()\n> +if not qt6_dep.found()\n> qcam_enabled = false\n> subdir_done()\n> endif\n> @@ -20,46 +20,27 @@ qcam_sources = files([\n> 'main.cpp',\n> 'main_window.cpp',\n> 'message_handler.cpp',\n> + 'viewfinder_gl.cpp',\n> 'viewfinder_qt.cpp',\n> ])\n> \n> qcam_moc_headers = files([\n> 'cam_select_dialog.h',\n> 'main_window.h',\n> + 'viewfinder_gl.h',\n> 'viewfinder_qt.h',\n> ])\n> \n> qcam_resources = files([\n> 'assets/feathericons/feathericons.qrc',\n> + 'assets/shader/shaders.qrc',\n> ])\n> \n> -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> \n> -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> - dependencies : qt5_dep, args : '-fPIC')\n> - qcam_sources += files([\n> - 'viewfinder_gl.cpp',\n> - ])\n> - qcam_moc_headers += files([\n> - 'viewfinder_gl.h',\n> - ])\n> - qcam_resources += files([\n> - 'assets/shader/shaders.qrc'\n> - ])\n> -endif\n> -\n> -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> - qt5_dep.version().version_compare('<5.13')) or\n> - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> - qt5_cpp_args += ['-Wno-deprecated-copy']\n> -endif\n> -\n> -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> qresources : qcam_resources,\n> - dependencies : qt5_dep)\n> + dependencies : qt6_dep)\n> \n> qcam = executable('qcam', qcam_sources, resources,\n> install : true,\n> @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> libatomic,\n> libcamera_public,\n> libtiff,\n> - qt5_dep,\n> + qt6_dep,\n> ],\n> - cpp_args : qt5_cpp_args)\n> + cpp_args : qt6_cpp_args)\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11CA6BE08B\n\tfor ;\n\tTue, 16 Apr 2024 18:14:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1068E61B75;\n\tTue, 16 Apr 2024 20:14:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF8D361B75\n\tfor ;\n\tTue, 16 Apr 2024 20:14:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 25F4AE0C;\n\tTue, 16 Apr 2024 20:13:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IsSabTvw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713291232;\n\tbh=CFVG7m3Devm3I0hKEpelKNgsx3EeN08G7hWNBOuvs9Q=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=IsSabTvwRLZK1DpndSJiUu8NGQZMJ8YD6OUwaEGCALhsxaLVryF7wxvnVSIhFLB4K\n\t3cNN/zTutzGs1XSFAJdy7pme9K9O1wiLOhJXeIfrn99rzQFq5abNtFEL07jxmUDEu9\n\tKJTivvC3VUoK67l6UTtU783BMoLJW5VDgyNlMFoA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240121224052.1049989-2-neal@gompa.dev>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","Cc":"Wim Taymans , Neal Gompa ","To":"Neal Gompa ,\n\tlibcamera-devel ","Date":"Tue, 16 Apr 2024 19:14:35 +0100","Message-ID":"<171329127567.749723.17933607914936082659@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29243,"web_url":"https://patchwork.libcamera.org/comment/29243/","msgid":"<20240417154156.GO12561@pendragon.ideasonboard.com>","date":"2024-04-17T15:41:56","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 16, 2024 at 07:14:35PM +0100, Kieran Bingham wrote:\n> Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > Open source Qt 5 has been effectively end of life since the release\n> > of Qt 6, and Qt 6 has current LTS releases now.\n> > \n> > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > to Qt 5 that is no longer applicable.\n> \n> With Ubuntu 24.04 release 'imminent' (as well as the next libcamera-0.3\n> after I can merge the softISP) I believe it's time to merge this patch.\n\nUnless I'm mistaken, Ubuntu will still ship Qt5, so there's no urgency.\nI'm not opposed to this patch though (once fixed), as Qt6 seems to be\navailable everywhere.\n\n> However ...\n> \n> > Signed-off-by: Neal Gompa \n> > ---\n> > README.rst | 2 +-\n> > meson.build | 2 +-\n> > src/apps/qcam/meson.build | 45 +++++++++++----------------------------\n> > 3 files changed, 15 insertions(+), 34 deletions(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 315738ee..6f1c9302 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -88,7 +88,7 @@ for cam: [optional]\n> > - libsdl2-dev: Enables the SDL sink\n> > \n> > for qcam: [optional]\n> > - libtiff-dev qtbase5-dev qttools5-dev-tools\n> > + libtiff-dev qt6-base-dev qt6-tools-dev-tools\n> \n> Having installed these packages - I still can't enable qcam. So we must\n> be missing some more dependencies that need to be listed here.\n> \n> \n> --\n> Kieran\n> \n> \n> > \n> > for tracing with lttng: [optional]\n> > liblttng-ust-dev python3-jinja2 lttng-tools\n> > diff --git a/meson.build b/meson.build\n> > index cb6b666a..4c315e2a 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -1,7 +1,7 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > project('libcamera', 'c', 'cpp',\n> > - meson_version : '>= 0.60',\n> > + meson_version : '>= 0.63',\n> > version : '0.2.0',\n> > default_options : [\n> > 'werror=true',\n> > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > index 6cf4c171..c7fcfbeb 100644\n> > --- a/src/apps/qcam/meson.build\n> > +++ b/src/apps/qcam/meson.build\n> > @@ -1,13 +1,13 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > -qt5 = import('qt5')\n> > -qt5_dep = dependency('qt5',\n> > +qt6 = import('qt6')\n> > +qt6_dep = dependency('qt6',\n> > method : 'pkg-config',\n> > - modules : ['Core', 'Gui', 'Widgets'],\n> > + modules : ['Core', 'Gui', 'OpenGL', 'OpenGLWidgets', 'Widgets'],\n> > required : get_option('qcam'),\n> > - version : '>=5.4')\n> > + version : '>=6.2')\n> > \n> > -if not qt5_dep.found()\n> > +if not qt6_dep.found()\n> > qcam_enabled = false\n> > subdir_done()\n> > endif\n> > @@ -20,46 +20,27 @@ qcam_sources = files([\n> > 'main.cpp',\n> > 'main_window.cpp',\n> > 'message_handler.cpp',\n> > + 'viewfinder_gl.cpp',\n> > 'viewfinder_qt.cpp',\n> > ])\n> > \n> > qcam_moc_headers = files([\n> > 'cam_select_dialog.h',\n> > 'main_window.h',\n> > + 'viewfinder_gl.h',\n> > 'viewfinder_qt.h',\n> > ])\n> > \n> > qcam_resources = files([\n> > 'assets/feathericons/feathericons.qrc',\n> > + 'assets/shader/shaders.qrc',\n> > ])\n> > \n> > -qt5_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > +qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> > \n> > -if cxx.has_header_symbol('QOpenGLWidget', 'QOpenGLWidget',\n> > - dependencies : qt5_dep, args : '-fPIC')\n> > - qcam_sources += files([\n> > - 'viewfinder_gl.cpp',\n> > - ])\n> > - qcam_moc_headers += files([\n> > - 'viewfinder_gl.h',\n> > - ])\n> > - qcam_resources += files([\n> > - 'assets/shader/shaders.qrc'\n> > - ])\n> > -endif\n> > -\n> > -# gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> > -# Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> > -# that are not fixed in Qt yet. Disable the warning manually in both cases.\n> > -if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> > - qt5_dep.version().version_compare('<5.13')) or\n> > - (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> > - qt5_cpp_args += ['-Wno-deprecated-copy']\n> > -endif\n> > -\n> > -resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> > +resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> > qresources : qcam_resources,\n> > - dependencies : qt5_dep)\n> > + dependencies : qt6_dep)\n> > \n> > qcam = executable('qcam', qcam_sources, resources,\n> > install : true,\n> > @@ -69,6 +50,6 @@ qcam = executable('qcam', qcam_sources, resources,\n> > libatomic,\n> > libcamera_public,\n> > libtiff,\n> > - qt5_dep,\n> > + qt6_dep,\n> > ],\n> > - cpp_args : qt5_cpp_args)\n> > + cpp_args : qt6_cpp_args)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA4BBBE08B\n\tfor ;\n\tWed, 17 Apr 2024 15:42:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D20F66333E;\n\tWed, 17 Apr 2024 17:42:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10CD861B54\n\tfor ;\n\tWed, 17 Apr 2024 17:42:08 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-15-230-nat.elisa-mobile.fi\n\t[85.76.15.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C82BFDD9;\n\tWed, 17 Apr 2024 17:41:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vJxrlRzG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713368480;\n\tbh=5DX6L36cVzv6hGaXiPDZ+jgUn9g6R/5iVPbdmZfHids=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vJxrlRzG7nCFHip43LEbfFZYSp0yrIxHzh73JE5G8ntapZSaFvGVWGZN+pQ2ZZior\n\tO6Re4QRlPTgPYars5lJmv+4JBAvLAbF7p8ZI35DgiM8SQhPCWI5Su8mj/ZmUJt3T0p\n\tPifs/N3AcS5rFkNkBKuzN7XzDLxa1QeSZsf5GW5Y=","Date":"Wed, 17 Apr 2024 18:41:56 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Neal Gompa ,\n\tlibcamera-devel ,\n\tWim Taymans ","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","Message-ID":"<20240417154156.GO12561@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<171329127567.749723.17933607914936082659@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171329127567.749723.17933607914936082659@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29244,"web_url":"https://patchwork.libcamera.org/comment/29244/","msgid":"","date":"2024-04-17T19:58:16","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Wed, Apr 17, 2024 at 11:42 AM Laurent Pinchart\n wrote:\n>\n> On Tue, Apr 16, 2024 at 07:14:35PM +0100, Kieran Bingham wrote:\n> > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > Open source Qt 5 has been effectively end of life since the release\n> > > of Qt 6, and Qt 6 has current LTS releases now.\n> > >\n> > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > to Qt 5 that is no longer applicable.\n> >\n> > With Ubuntu 24.04 release 'imminent' (as well as the next libcamera-0.3\n> > after I can merge the softISP) I believe it's time to merge this patch.\n>\n> Unless I'm mistaken, Ubuntu will still ship Qt5, so there's no urgency.\n> I'm not opposed to this patch though (once fixed), as Qt6 seems to be\n> available everywhere.\n>\n\nThis patch isn't broken. I just was able to build it on Ubuntu 24.04\njust fine: https://download.opensuse.org/repositories/home:/Pharaoh_Atem:/libcamera/xUbuntu_24.04/amd64/\n\nThe build dependencies I used were the ones in the readme.\n\nYou can see for yourself in the \"debbuild\" conditional for\nbuildrequires: https://build.opensuse.org/projects/home:Pharaoh_Atem:libcamera/packages/libcamera/files/libcamera.spec?expand=1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97019BE08B\n\tfor ;\n\tWed, 17 Apr 2024 19:58:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A15D63352;\n\tWed, 17 Apr 2024 21:58:57 +0200 (CEST)","from mail-lf1-f49.google.com (mail-lf1-f49.google.com\n\t[209.85.167.49])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7768161B54\n\tfor ;\n\tWed, 17 Apr 2024 21:58:55 +0200 (CEST)","by mail-lf1-f49.google.com with SMTP id\n\t2adb3069b0e04-516d0c004b1so60536e87.2\n\tfor ;\n\tWed, 17 Apr 2024 12:58:55 -0700 (PDT)","from mail-lf1-f46.google.com (mail-lf1-f46.google.com.\n\t[209.85.167.46]) by smtp.gmail.com with ESMTPSA id\n\tn7-20020a056512388700b0051946ebdc8dsm341218lft.85.2024.04.17.12.58.53\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 17 Apr 2024 12:58:53 -0700 (PDT)","by mail-lf1-f46.google.com with SMTP id\n\t2adb3069b0e04-5194a4da476so59135e87.3\n\tfor ;\n\tWed, 17 Apr 2024 12:58:53 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1713383934; x=1713988734;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=PTVUTOXawWlaatLVgMFVuy4pdDjIfyLYfHr/75JSVAU=;\n\tb=iFf8tSsflny49/gcJXe/l1XDPCmpmbNn8FQmO+EMbY5XLd3PX8p7NLFfIumawoiqNk\n\tYmA3nMngTTMqZPAbsz2cBgPh0Nfx4MQ91A0ijQFEWRb8UZz0BEF+PhhZAztGbUH1bDHh\n\ta2sIyUuxTIv2reoRFJVBrwdMY83TiBCgzQLve4ipLICZAc88tIouuI3R8YYHaMBLhprs\n\tMB0kcuogdr3G3AmjN9MqLPO6IwvCVt7wbDOTPW1Dd7OTQrHnkKulWGT5mQoDfObRjhEG\n\tyaH4Hi6OwbqPZLDBGPDblyZ8qkS33tQWxA9+eiqPw6ume87d6Ke9aDj7R1WvITY79Tij\n\t3YkA==","X-Forwarded-Encrypted":["i=1;\n\tAJvYcCUKIzzQyG9FHHfFgmx2wcnfKvTSQDGDu2/mOthgrJ9AwzEQxieqidNetIxJ4YoLMGWP3zFWvJmAv/Xd7s6vJ87sanE9ZyoFJUGz9Un2K2mTjzDnUQ==","i=1;\n\tAJvYcCVmITA2vfDkjhzkeuth+514URiZzbAP5bTJ10Kw6nKKmGBbQ44bNqOa3+xXse2aybFpc7eTY8Xyvu/iTLzEb3hvPIjJpTT7nLv8R9XW4EBv0BAQrg=="],"X-Gm-Message-State":"AOJu0YwjmDlSpUvm3VKptH29/ye7U5c8ZWDpk8VXqz0DGnf2HeXuwoNH\n\tEEYVoY9rJHQGcjMcF8P1PTxaYihGnT3MzZ/R6rrXZ55KG5AMrfmX0QXiFMHY","X-Google-Smtp-Source":"AGHT+IGRkJEFvca1OzPQsIsXzUPs92I3YxYHIEtz3TeZMWPfpzEnEY+g41x6zWadLifARJhgUy8JjQ==","X-Received":["by 2002:ac2:4859:0:b0:516:c8e5:db35 with SMTP id\n\t25-20020ac24859000000b00516c8e5db35mr217618lfy.18.1713383934123; \n\tWed, 17 Apr 2024 12:58:54 -0700 (PDT)","by 2002:a05:6512:3748:b0:518:b93f:b5a0 with SMTP id\n\ta8-20020a056512374800b00518b93fb5a0mr216635lfs.22.1713383933687;\n\tWed, 17 Apr 2024 12:58:53 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<171329127567.749723.17933607914936082659@ping.linuxembedded.co.uk>\n\t<20240417154156.GO12561@pendragon.ideasonboard.com>","In-Reply-To":"<20240417154156.GO12561@pendragon.ideasonboard.com>","From":"Neal Gompa ","Date":"Wed, 17 Apr 2024 15:58:16 -0400","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","To":"Laurent Pinchart ","Cc":"Kieran Bingham , \n\tlibcamera-devel ,\n\tWim Taymans ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29245,"web_url":"https://patchwork.libcamera.org/comment/29245/","msgid":"<171338558433.3165863.3795210368053380951@ping.linuxembedded.co.uk>","date":"2024-04-17T20:26:24","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Neal Gompa (2024-04-17 20:58:16)\n> On Wed, Apr 17, 2024 at 11:42 AM Laurent Pinchart\n> wrote:\n> >\n> > On Tue, Apr 16, 2024 at 07:14:35PM +0100, Kieran Bingham wrote:\n> > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > Open source Qt 5 has been effectively end of life since the release\n> > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > >\n> > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > to Qt 5 that is no longer applicable.\n> > >\n> > > With Ubuntu 24.04 release 'imminent' (as well as the next libcamera-0.3\n> > > after I can merge the softISP) I believe it's time to merge this patch.\n> >\n> > Unless I'm mistaken, Ubuntu will still ship Qt5, so there's no urgency.\n> > I'm not opposed to this patch though (once fixed), as Qt6 seems to be\n> > available everywhere.\n> >\n> \n> This patch isn't broken. I just was able to build it on Ubuntu 24.04\n> just fine: https://download.opensuse.org/repositories/home:/Pharaoh_Atem:/libcamera/xUbuntu_24.04/amd64/\n\nI don't think the patch is broken, Just that there must be some\nadditional dependency required which may have been implicitly installed\nin your case, but seems not to have been in my case. \n\nI'm not going to merge a patch that will prevent me from using qcam\nuntil I know how to correctly build it again.\n\n\n--\nKieran\n\n\n> \n> The build dependencies I used were the ones in the readme.\n> \n> You can see for yourself in the \"debbuild\" conditional for\n> buildrequires: https://build.opensuse.org/projects/home:Pharaoh_Atem:libcamera/packages/libcamera/files/libcamera.spec?expand=1\n> \n> \n> \n> -- \n> 真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58324C3213\n\tfor ;\n\tWed, 17 Apr 2024 20:26:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D09561B54;\n\tWed, 17 Apr 2024 22:26:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2603C61B54\n\tfor ;\n\tWed, 17 Apr 2024 22:26:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6FC5827;\n\tWed, 17 Apr 2024 22:25:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V6DzeF98\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713385539;\n\tbh=MK3bb+i/eSNZkNSUMZB/MaoDLQWTi++01Kb3VYRKZ6Q=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=V6DzeF98I3QByqXssLiZ5E7lBzfPhqnnRShWyCa/LY0k858DOy3zzv0Xs3wLqf3Eb\n\tREDMZBIXGEgWV3/QVUv0GS9VJxmFxBUJDN2mX5uBmQX8bpSnz26JWONFJYhYo/wZvX\n\t/rC0ek43qUn943kA9gmtJPuf6IcK8/fm5EQccAmA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<171329127567.749723.17933607914936082659@ping.linuxembedded.co.uk>\n\t<20240417154156.GO12561@pendragon.ideasonboard.com>\n\t","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","Cc":"libcamera-devel ,\n\tWim Taymans ","To":"Laurent Pinchart ,\n\tNeal Gompa ","Date":"Wed, 17 Apr 2024 21:26:24 +0100","Message-ID":"<171338558433.3165863.3795210368053380951@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29246,"web_url":"https://patchwork.libcamera.org/comment/29246/","msgid":"<171338604317.3165863.12155352492089570201@ping.linuxembedded.co.uk>","date":"2024-04-17T20:34:03","subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2024-04-17 21:26:24)\n> Quoting Neal Gompa (2024-04-17 20:58:16)\n> > On Wed, Apr 17, 2024 at 11:42 AM Laurent Pinchart\n> > wrote:\n> > >\n> > > On Tue, Apr 16, 2024 at 07:14:35PM +0100, Kieran Bingham wrote:\n> > > > Quoting Neal Gompa via libcamera-devel (2024-01-21 22:39:53)\n> > > > > Open source Qt 5 has been effectively end of life since the release\n> > > > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > > >\n> > > > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > > > to Qt 5 that is no longer applicable.\n> > > >\n> > > > With Ubuntu 24.04 release 'imminent' (as well as the next libcamera-0.3\n> > > > after I can merge the softISP) I believe it's time to merge this patch.\n> > >\n> > > Unless I'm mistaken, Ubuntu will still ship Qt5, so there's no urgency.\n> > > I'm not opposed to this patch though (once fixed), as Qt6 seems to be\n> > > available everywhere.\n> > >\n> > \n> > This patch isn't broken. I just was able to build it on Ubuntu 24.04\n> > just fine: https://download.opensuse.org/repositories/home:/Pharaoh_Atem:/libcamera/xUbuntu_24.04/amd64/\n> \n> I don't think the patch is broken, Just that there must be some\n> additional dependency required which may have been implicitly installed\n> in your case, but seems not to have been in my case. \n> \n> I'm not going to merge a patch that will prevent me from using qcam\n> until I know how to correctly build it again.\n\n\"\"\"\nfor qcam: [optional]\n libtiff-dev qt6-base-dev qt6-tools-dev-tools\n\"\"\"\nkbingham@Monstersaurus:~/iob/libcamera/libcamera$ sudo apt install libtiff-dev qt6-base-dev qt6-tools-dev-tools\n[sudo] password for kbingham:\nReading package lists... Done\nBuilding dependency tree... Done\nReading state information... Done\nqt6-tools-dev-tools is already the newest version (6.2.4-1).\nlibtiff-dev is already the newest version (4.3.0-6ubuntu0.8).\nlibtiff-dev set to manually installed.\nqt6-base-dev is already the newest version (6.2.4+dfsg-2ubuntu1.1).\n\n\nThen:\n\n================================================================================\nkbingham@Monstersaurus:~/iob/libcamera/libcamera$ meson setup qt6-test -Dqcam=enabled\nThe Meson build system\nVersion: 1.4.0\nSource dir: /home/kbingham/iob/libcamera/libcamera\nBuild dir: /home/kbingham/iob/libcamera/libcamera/qt6-test\nBuild type: native build\nWARNING: failed to process netrc file: ~/.netrc access too permissive: access permissions must restrict access to only the owner (/home/kbingham/.netrc, line 3).\nProject name: libcamera\nProject version: 0.2.0\nC compiler for the host machine: ccache cc (gcc 11.4.0 \"cc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0\")\nC linker for the host machine: cc ld.bfd 2.38\nC++ compiler for the host machine: ccache c++ (gcc 11.4.0 \"c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0\")\nC++ linker for the host machine: c++ ld.bfd 2.38\nHost machine cpu family: x86_64\nHost machine cpu: x86_64\nHeader \"unistd.h\" has symbol \"issetugid\" : NO\nHeader \"locale.h\" has symbol \"locale_t\" : YES\nHeader \"stdlib.h\" has symbol \"secure_getenv\" : YES\nCompiler for C supports arguments -Wno-c99-designator: NO\nFound pkg-config: YES (/usr/bin/pkg-config) 0.29.2\nRun-time dependency lttng-ust found: YES 2.13.1\nProgram ./parser.py found: YES (/home/kbingham/iob/libcamera/libcamera/utils/ipc/./parser.py)\nProgram ./generate.py found: YES (/home/kbingham/iob/libcamera/libcamera/utils/ipc/./generate.py)\nProgram ./extract-docs.py found: YES (/home/kbingham/iob/libcamera/libcamera/utils/ipc/./extract-docs.py)\nProgram ./gen-tp-header.py found: YES (/home/kbingham/iob/libcamera/libcamera/utils/tracepoints/./gen-tp-header.py)\nConfiguring version.h using configuration\nProgram openssl found: YES (/usr/bin/openssl)\nLibrary atomic found: YES\nRun-time dependency threads found: YES\nRun-time dependency libdw found: YES 0.186\nRun-time dependency libunwind found: YES 1.3.2\nHeader \"execinfo.h\" has symbol \"backtrace\" : YES\nChecking for function \"dlopen\" : YES\nRun-time dependency libudev found: YES 249\nRun-time dependency yaml-0.1 found: YES 0.2.2\nRun-time dependency gnutls found: YES 3.7.3\nDependency libexif skipped: feature android disabled\nDependency libjpeg skipped: feature android disabled\nRun-time dependency libevent_pthreads found: YES 2.1.12-stable\nRun-time dependency libtiff-4 found: YES 4.3.0\nRun-time dependency GTest found: YES 1.11.0\nRun-time dependency libdrm found: YES 2.4.113\nRun-time dependency libjpeg found: YES 2.1.2\nRun-time dependency sdl2 found: YES 2.0.20\nRun-time dependency qt6 (modules: Core, Gui, OpenGL, OpenGLWidgets, Widgets) found: NO (tried pkgconfig)\n\nsrc/apps/qcam/meson.build:4:10: ERROR: Dependency \"qt6\" not found, tried pkgconfig\n\nA full log can be found at /home/kbingham/iob/libcamera/libcamera/qt6-test/meson-logs/meson-log.txt\n================================================================================\n\nI wonder if the modules have been implicitly installed, or used before\nand now need to be explicitly listed as a dependency.\n\n\n---\nRegards\n\nKieran\n\n\n\n\n> --\n> Kieran\n> \n> \n> > \n> > The build dependencies I used were the ones in the readme.\n> > \n> > You can see for yourself in the \"debbuild\" conditional for\n> > buildrequires: https://build.opensuse.org/projects/home:Pharaoh_Atem:libcamera/packages/libcamera/files/libcamera.spec?expand=1\n> > \n> > \n> > \n> > -- \n> > 真実はいつも一つ！/ Always, there's only one truth!","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99793BE08B\n\tfor ;\n\tWed, 17 Apr 2024 20:34:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0C986335E;\n\tWed, 17 Apr 2024 22:34:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B2FD6333E\n\tfor ;\n\tWed, 17 Apr 2024 22:34:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3984827;\n\tWed, 17 Apr 2024 22:33:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M4BH1fkc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713385998;\n\tbh=qhh78rB1Fr6yYz5x32aams62LIn6KgktQpFP/Fr+uWA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=M4BH1fkcNx5G42VKZlseyvtBuTekT8cCkOWM+Q0QRUKkbqznOIqhF51RSe0yzcXqN\n\tiyTng8SGoquAtQws/3BEt8UyEaa1CGCH9amq8OG1JRAK3K2zvNpnX0aqyQ5wDB8LJ0\n\td9tLxeLgVZ7XzQW5+l55SVJ51dHeG9c72AlUMQpI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<171338558433.3165863.3795210368053380951@ping.linuxembedded.co.uk>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240121224052.1049989-2-neal@gompa.dev>\n\t<171329127567.749723.17933607914936082659@ping.linuxembedded.co.uk>\n\t<20240417154156.GO12561@pendragon.ideasonboard.com>\n\t\n\t<171338558433.3165863.3795210368053380951@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","Cc":"libcamera-devel ,\n\tWim Taymans ","To":"Laurent Pinchart ,\n\tNeal Gompa ","Date":"Wed, 17 Apr 2024 21:34:03 +0100","Message-ID":"<171338604317.3165863.12155352492089570201@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]