[{"id":28549,"web_url":"https://patchwork.libcamera.org/comment/28549/","msgid":"<875xzl8adi.fsf@redhat.com>","date":"2024-01-22T18:56:57","subject":"Re: [PATCH 02/12] libcamera: signal: Replace object.h inclusion\n\twith forward declatation","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> The signal.h header doesn't need to include object.h. Replace it with a\n> forward declaration, and instead include object.h in source files that\n> require it. To can speed up compilation a little bit, but more\n ^^^^^^\nIt can?\n\n\n> importantly avoids unintended dependencies from the Signal class to the\n> Object class to be added later as the compiler will catch them.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/base/signal.h | 3 ++-\n> src/libcamera/base/bound_method.cpp | 1 +\n> src/libcamera/base/signal.cpp | 1 +\n> src/libcamera/base/thread.cpp | 1 +\n> test/event-thread.cpp | 1 +\n> test/ipa/ipa_interface_test.cpp | 1 +\n> test/message.cpp | 1 +\n> test/signal-threads.cpp | 1 +\n> test/timer-thread.cpp | 1 +\n> .../ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl | 1 +\n> 10 files changed, 11 insertions(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> index 841e4b4ca15c..444997b4525d 100644\n> --- a/include/libcamera/base/signal.h\n> +++ b/include/libcamera/base/signal.h\n> @@ -13,10 +13,11 @@\n> #include \n> \n> #include \n> -#include \n> \n> namespace libcamera {\n> \n> +class Object;\n> +\n> class SignalBase\n> {\n> public:\n> diff --git a/src/libcamera/base/bound_method.cpp b/src/libcamera/base/bound_method.cpp\n> index 3ecec51c4b75..c83d623f107d 100644\n> --- a/src/libcamera/base/bound_method.cpp\n> +++ b/src/libcamera/base/bound_method.cpp\n> @@ -7,6 +7,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp\n> index a46386a05abf..de51d060c21a 100644\n> --- a/src/libcamera/base/signal.cpp\n> +++ b/src/libcamera/base/signal.cpp\n> @@ -8,6 +8,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> /**\n> * \\file base/signal.h\n> diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\n> index b96951ac19ba..75693c92a0b1 100644\n> --- a/src/libcamera/base/thread.cpp\n> +++ b/src/libcamera/base/thread.cpp\n> @@ -18,6 +18,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> /**\n> * \\page thread Thread Support\n> diff --git a/test/event-thread.cpp b/test/event-thread.cpp\n> index ef8a52c3de55..88a8c07ef9f0 100644\n> --- a/test/event-thread.cpp\n> +++ b/test/event-thread.cpp\n> @@ -11,6 +11,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> index 051ef96e7ed2..56f3cd6d57ba 100644\n> --- a/test/ipa/ipa_interface_test.cpp\n> +++ b/test/ipa/ipa_interface_test.cpp\n> @@ -16,6 +16,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/test/message.cpp b/test/message.cpp\n> index d148a13d6c7a..0e76f323e3b9 100644\n> --- a/test/message.cpp\n> +++ b/test/message.cpp\n> @@ -11,6 +11,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> \n> #include \"test.h\"\n> diff --git a/test/signal-threads.cpp b/test/signal-threads.cpp\n> index d5e2eb662df2..8c550eb014d8 100644\n> --- a/test/signal-threads.cpp\n> +++ b/test/signal-threads.cpp\n> @@ -10,6 +10,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\n> index 618217538779..0bcd0d8ce194 100644\n> --- a/test/timer-thread.cpp\n> +++ b/test/timer-thread.cpp\n> @@ -9,6 +9,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> index ed270f5cd49c..6e823598930e 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> @@ -18,6 +18,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> \n> #include \"libcamera/internal/control_serializer.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F27FDBDB1C\n\tfor ;\n\tMon, 22 Jan 2024 18:57:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14CAC6291F;\n\tMon, 22 Jan 2024 19:57:04 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C585F61D30\n\tfor ;\n\tMon, 22 Jan 2024 19:57:02 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-688-q4zR9emhPce85MljzICtGw-1; Mon, 22 Jan 2024 13:57:00 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-337d589ef4dso2355500f8f.0\n\tfor ;\n\tMon, 22 Jan 2024 10:57:00 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tcp9-20020a056000400900b003392ded41c7sm5078943wrb.39.2024.01.22.10.56.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Jan 2024 10:56:57 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"cN8sCZ1A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1705949821;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=GR4qwn06CxcrXhq0rqbOVe2irJed0ahm/yTFIGVhdSw=;\n\tb=cN8sCZ1AKG86n+mz+OCNdHJxMT9TMWGDbzBeS0ZdkV5vmrxG3C/6IHqoUvMtOxY3rv7gJi\n\tjhzE+X6aq+77iW1AyorIrj596kwLGxzzyk3nbvWw/t1nCvq4DIMEpw1op7kmQFGCbo/QdT\n\tFei/hzVWT3TlTZlpKOO6Z82Es3LgGfI=","X-MC-Unique":"q4zR9emhPce85MljzICtGw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705949818; x=1706554618;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=GR4qwn06CxcrXhq0rqbOVe2irJed0ahm/yTFIGVhdSw=;\n\tb=bvNLVxctv1ACwJnfjwgplql4MR3izUo5QGzkaAmQTSIsC712SVehoNVxs8Z1yEkwfh\n\tpQI6qFbCUyAa+9mbb3icGGK2gsUxG4PT8jAAPlnOp2xrDuNG3R2zcg3KvBu943BISBIa\n\t1KHYBiNYtNQePE/hrpuIl7mM3g98S9vzqmH+8XvjSodTvqZLX37hudbprnsVJo6B4IeZ\n\tLQ3860rvaorAw6Hbjs87huEshdyMBd1EayhN5/SDkznDBn1n/VI/5CzTw/ExEDUUeTNv\n\tgWygxyCw6Z+6pJcVr3AgT9AKLCyS9aJtg2p8rUDtDgYYBDC9XSp+ut8lzpGHLxdCvz87\n\tooqA==","X-Gm-Message-State":"AOJu0YyRMfsbJsaWRG+64FPgbuJpsEnqxiT1AniDiH2p7DFQI/nnooom\n\tfdO83LlokJ9WfBh93mvO3dBo+DmtVyf+7krtkg+hZhMgqpTU1XzhiVBHMNScv/vNr+nSLIyyVcR\n\t4EZHZJTWdXdlenj9F2e8sGmHHiTkw5ZKIQkB/WOtKn3EObpRY5z1i4ZQM2Ef8XDUmpUIXjkkAZR\n\tuGm1Fmy24mqfGjeXyd724jhzNhv3UYsVG3wTK3vTBGUHzyo5DUPdWXnuE=","X-Received":["by 2002:a5d:4105:0:b0:337:c063:1120 with SMTP id\n\tl5-20020a5d4105000000b00337c0631120mr2605380wrp.62.1705949818708; \n\tMon, 22 Jan 2024 10:56:58 -0800 (PST)","by 2002:a5d:4105:0:b0:337:c063:1120 with SMTP id\n\tl5-20020a5d4105000000b00337c0631120mr2605375wrp.62.1705949818344; \n\tMon, 22 Jan 2024 10:56:58 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IG4rF56rXfVBgC4rXbTRDfFUJxX2s3rJvPDu05vKLsCV6kr6GaaqpzswPrwOuinJ7gUgfoUPw==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Subject":"Re: [PATCH 02/12] libcamera: signal: Replace object.h inclusion\n\twith forward declatation","In-Reply-To":"<20240121035948.4226-3-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Sun, 21 Jan 2024 05:59:38 +0200\")","References":"<20240121035948.4226-1-laurent.pinchart@ideasonboard.com>\n\t<20240121035948.4226-3-laurent.pinchart@ideasonboard.com>","Date":"Mon, 22 Jan 2024 19:56:57 +0100","Message-ID":"<875xzl8adi.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28562,"web_url":"https://patchwork.libcamera.org/comment/28562/","msgid":"<20240122223853.GA3195@pendragon.ideasonboard.com>","date":"2024-01-22T22:38:53","subject":"Re: [PATCH 02/12] libcamera: signal: Replace object.h inclusion with\n\tforward declatation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 07:56:57PM +0100, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> \n> > The signal.h header doesn't need to include object.h. Replace it with a\n> > forward declaration, and instead include object.h in source files that\n> > require it. To can speed up compilation a little bit, but more\n> ^^^^^^\n> It can?\n\nIndeed, will fix.\n\n> > importantly avoids unintended dependencies from the Signal class to the\n> > Object class to be added later as the compiler will catch them.\n> >\n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Milan Zamazal \n> \n> > ---\n> > include/libcamera/base/signal.h | 3 ++-\n> > src/libcamera/base/bound_method.cpp | 1 +\n> > src/libcamera/base/signal.cpp | 1 +\n> > src/libcamera/base/thread.cpp | 1 +\n> > test/event-thread.cpp | 1 +\n> > test/ipa/ipa_interface_test.cpp | 1 +\n> > test/message.cpp | 1 +\n> > test/signal-threads.cpp | 1 +\n> > test/timer-thread.cpp | 1 +\n> > .../ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl | 1 +\n> > 10 files changed, 11 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> > index 841e4b4ca15c..444997b4525d 100644\n> > --- a/include/libcamera/base/signal.h\n> > +++ b/include/libcamera/base/signal.h\n> > @@ -13,10 +13,11 @@\n> > #include \n> > \n> > #include \n> > -#include \n> > \n> > namespace libcamera {\n> > \n> > +class Object;\n> > +\n> > class SignalBase\n> > {\n> > public:\n> > diff --git a/src/libcamera/base/bound_method.cpp b/src/libcamera/base/bound_method.cpp\n> > index 3ecec51c4b75..c83d623f107d 100644\n> > --- a/src/libcamera/base/bound_method.cpp\n> > +++ b/src/libcamera/base/bound_method.cpp\n> > @@ -7,6 +7,7 @@\n> > \n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> > diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp\n> > index a46386a05abf..de51d060c21a 100644\n> > --- a/src/libcamera/base/signal.cpp\n> > +++ b/src/libcamera/base/signal.cpp\n> > @@ -8,6 +8,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > \n> > /**\n> > * \\file base/signal.h\n> > diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\n> > index b96951ac19ba..75693c92a0b1 100644\n> > --- a/src/libcamera/base/thread.cpp\n> > +++ b/src/libcamera/base/thread.cpp\n> > @@ -18,6 +18,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > \n> > /**\n> > * \\page thread Thread Support\n> > diff --git a/test/event-thread.cpp b/test/event-thread.cpp\n> > index ef8a52c3de55..88a8c07ef9f0 100644\n> > --- a/test/event-thread.cpp\n> > +++ b/test/event-thread.cpp\n> > @@ -11,6 +11,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> > diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> > index 051ef96e7ed2..56f3cd6d57ba 100644\n> > --- a/test/ipa/ipa_interface_test.cpp\n> > +++ b/test/ipa/ipa_interface_test.cpp\n> > @@ -16,6 +16,7 @@\n> > \n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> > diff --git a/test/message.cpp b/test/message.cpp\n> > index d148a13d6c7a..0e76f323e3b9 100644\n> > --- a/test/message.cpp\n> > +++ b/test/message.cpp\n> > @@ -11,6 +11,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > #include \n> > \n> > #include \"test.h\"\n> > diff --git a/test/signal-threads.cpp b/test/signal-threads.cpp\n> > index d5e2eb662df2..8c550eb014d8 100644\n> > --- a/test/signal-threads.cpp\n> > +++ b/test/signal-threads.cpp\n> > @@ -10,6 +10,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> > diff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\n> > index 618217538779..0bcd0d8ce194 100644\n> > --- a/test/timer-thread.cpp\n> > +++ b/test/timer-thread.cpp\n> > @@ -9,6 +9,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> > diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> > index ed270f5cd49c..6e823598930e 100644\n> > --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> > +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> > @@ -18,6 +18,7 @@\n> > #include \n> > #include \n> > \n> > +#include \n> > #include \n> > \n> > #include \"libcamera/internal/control_serializer.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F8C6C323E\n\tfor ;\n\tMon, 22 Jan 2024 22:38:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E29462936;\n\tMon, 22 Jan 2024 23:38:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41F1461D30\n\tfor ;\n\tMon, 22 Jan 2024 23:38:50 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D85CD221;\n\tMon, 22 Jan 2024 23:37:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e6G0SA3r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705963057;\n\tbh=s6RlCxIH1zcpmbrGYLDe+VcFzUpjbnX907xDY9osMtQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e6G0SA3rVcmi1rmIrJdhOschq0m26lyRjveZ0SanR7BSrIe2TRmD+0zBQ7Hcu8Zoc\n\tWZ2UeLMXo4bpSmxRgrRltFdGjDT9/xBH48ln1SWe5yLUVqGFnVvkximLHBZuKzboj4\n\tOacnPnsLrakmCmKkutQ4VKppwuFV96w03Cz+2oyo=","Date":"Tue, 23 Jan 2024 00:38:53 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Subject":"Re: [PATCH 02/12] libcamera: signal: Replace object.h inclusion with\n\tforward declatation","Message-ID":"<20240122223853.GA3195@pendragon.ideasonboard.com>","References":"<20240121035948.4226-1-laurent.pinchart@ideasonboard.com>\n\t<20240121035948.4226-3-laurent.pinchart@ideasonboard.com>\n\t<875xzl8adi.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<875xzl8adi.fsf@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]