[{"id":28548,"web_url":"https://patchwork.libcamera.org/comment/28548/","msgid":"<87a5ox8c9a.fsf@redhat.com>","date":"2024-01-22T18:16:17","subject":"Re: [PATCH 01/12] libcamera: object: Fix thread-bound reference in\n\tdocumentation","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> The Object::message() function is documented as thread-bound without\n> using the correct \\threadbound reference. Fix it to ensure it gets\n> included in the thread safety context list.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/base/object.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/base/object.cpp b/src/libcamera/base/object.cpp\n> index 92cecd22fbe9..1fce5a2af9af 100644\n> --- a/src/libcamera/base/object.cpp\n> +++ b/src/libcamera/base/object.cpp\n> @@ -259,7 +259,7 @@ void Object::message(Message *msg)\n> * Moving an object that has a parent is not allowed, and causes undefined\n> * behaviour.\n> *\n> - * \\context This function is thread-bound.\n> + * \\context This function is \\threadbound.\n> */\n> void Object::moveToThread(Thread *thread)\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC750C323E\n\tfor ;\n\tMon, 22 Jan 2024 18:16:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8113D62944;\n\tMon, 22 Jan 2024 19:16:48 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97A2661D30\n\tfor ;\n\tMon, 22 Jan 2024 19:16:46 +0100 (CET)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-195-gp5l6FS_PD-00RGy6QRWDA-1; Mon, 22 Jan 2024 13:16:41 -0500","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-40e5317c7a5so26993975e9.0\n\tfor ;\n\tMon, 22 Jan 2024 10:16:41 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tbg23-20020a05600c3c9700b0040d91fa270fsm40182724wmb.36.2024.01.22.10.16.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Jan 2024 10:16:38 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"LDfVGD+X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1705947405;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=fWW4EqCVW9OVsYKEAtF3oDzc3Jib9Ct9lmpm8YNpECQ=;\n\tb=LDfVGD+Xjd/hbWAN7kpkGdfePqSB1NXDQDbm3Xng04e8s+IpZVPuEHlyeZTJnZFNnxWe4+\n\tqrZXr5DQi+ijsf/KzxEHYOb1taN9OilTTT5NDLEqGKSTVgp9YciyN3Qjurm6qtMOL7EKx0\n\tIzUHqP0Q0VsOF3/54WQK0Oqm0kQurC4=","X-MC-Unique":"gp5l6FS_PD-00RGy6QRWDA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705947399; x=1706552199;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=fWW4EqCVW9OVsYKEAtF3oDzc3Jib9Ct9lmpm8YNpECQ=;\n\tb=ED1OozNs5Lt1GqklYEgjp8Fgvc2N6QFMqrX3kU4uxfD1vOKi3ezLq49u454pK/aGw9\n\tVnbnzetJt1LHlpTBDjIpIfjojj8viFTeXM2K1cJWr88SvW4cwJutDbpj9bCTYjJAH5So\n\tmnqlBSqFKyu5EJwQL7et+Tl7I2ZLOqGRtWN9Cwcr/HljgyqcA8nE5C6MfUDOjQmCktJi\n\tuZyE7Jl6QFjWWFNjXp5a0OSTuNaVXyDon2BUmF+ZxM6dikaQ6m5zavCeMh2X+XaQx0jN\n\tv3bRei6vIs4YC8NZV+slBjknY9pIGsHWVWXC2SIBRDh2FNzTbHAvDsVZsKDXmUsz5pO+\n\thxGw==","X-Gm-Message-State":"AOJu0Yz9A9sj5ZDQY8sq6Xgc6fDmsi6NX+zQrsU4Any7Io6tOMUgnGz3\n\t3m60J+kbKJINbWAxeBe6PakD2/LfelZ0Kquj1zZ9XORNAXvH4VRNKMdX2J6BuyzBB5dySxatTYD\n\tIlk6wGjX0Ju5XXX2nTXeLVASebjyjWPI+vp89mxluZia45Wmd2KTl6CDsk0vdT/8br3ImrPFeDh\n\tB8+zdwQAfDqLiq2qaKAZAGbZJogKoSdTMvR7DznlyRGjY4GUwZoPUCGf4=","X-Received":["by 2002:a05:600c:b9a:b0:40e:a9c0:31fe with SMTP id\n\tfl26-20020a05600c0b9a00b0040ea9c031femr1960584wmb.68.1705947399405; \n\tMon, 22 Jan 2024 10:16:39 -0800 (PST)","by 2002:a05:600c:b9a:b0:40e:a9c0:31fe with SMTP id\n\tfl26-20020a05600c0b9a00b0040ea9c031femr1960574wmb.68.1705947398999; \n\tMon, 22 Jan 2024 10:16:38 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IF3noiVIIRddgdssNTRGVzmPPlLKkam6CUSWHZnK5FJkuo1w9sYi/oUv0oj6Ef9R/F5G4u6Sg==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Subject":"Re: [PATCH 01/12] libcamera: object: Fix thread-bound reference in\n\tdocumentation","In-Reply-To":"<20240121035948.4226-2-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Sun, 21 Jan 2024 05:59:37 +0200\")","References":"<20240121035948.4226-1-laurent.pinchart@ideasonboard.com>\n\t<20240121035948.4226-2-laurent.pinchart@ideasonboard.com>","Date":"Mon, 22 Jan 2024 19:16:17 +0100","Message-ID":"<87a5ox8c9a.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]